X-Git-Url: https://code.citadel.org/?a=blobdiff_plain;f=citadel%2Fldap.c;h=8e51087b9550d6c93168139361d35b276ac7ab30;hb=219bbe065f3a3e1117f3fadd3e28164098d4f625;hp=864ab4807230af05da9e63e6871f781defc19383;hpb=553ba6310be04656ee304f6ae64f15304bc3ff73;p=citadel.git diff --git a/citadel/ldap.c b/citadel/ldap.c index 864ab4807..8e51087b9 100644 --- a/citadel/ldap.c +++ b/citadel/ldap.c @@ -2,7 +2,7 @@ * These functions implement the portions of AUTHMODE_LDAP and AUTHMODE_LDAP_AD which * actually speak to the LDAP server. * - * Copyright (c) 2011 by Art Cancro and the citadel.org development team. + * Copyright (c) 2011-2017 by the citadel.org development team. * * This program is open source software; you can redistribute it and/or modify * it under the terms of the GNU General Public License, version 3. @@ -15,23 +15,48 @@ int ctdl_require_ldap_version = 3; +#define _GNU_SOURCE // Needed to suppress warning about vasprintf() when running on Linux/Linux #include #include - #include "citserver.h" #include "citadel_ldap.h" #include "ctdl_module.h" - #include "user_ops.h" +#include "internet_addressing.h" +#include "config.h" #ifdef HAVE_LDAP -#define LDAP_DEPRECATED 1 /* Suppress libldap's warning that we are using deprecated API calls */ +#define LDAP_DEPRECATED 1 // Suppress libldap's warning that we are using deprecated API calls #include + +/* + * Wrapper function for ldap_initialize() that consistently fills in the correct fields + */ +int ctdl_ldap_initialize(LDAP **ld) { + + char server_url[256]; + int ret; + + snprintf(server_url, sizeof server_url, "ldap://%s:%d", CtdlGetConfigStr("c_ldap_host"), CtdlGetConfigInt("c_ldap_port")); + ret = ldap_initialize(ld, server_url); + if (ret != LDAP_SUCCESS) { + syslog(LOG_ERR, "ldap: could not connect to %s : %m", server_url); + *ld = NULL; + return(errno); + } + + return(ret); +} + + +/* + * Look up a user in the directory to see if this is an account that can be authenticated + */ int CtdlTryUserLDAP(char *username, char *found_dn, int found_dn_size, char *fullname, int fullname_size, - uid_t *uid) + uid_t *uid, int lookup_based_on_username) { LDAP *ldserver = NULL; int i; @@ -42,72 +67,49 @@ int CtdlTryUserLDAP(char *username, char **values; char *user_dn = NULL; -#ifndef LDAP_INITIALIZE if (fullname) safestrncpy(fullname, username, fullname_size); - ldserver = ldap_init(config.c_ldap_host, config.c_ldap_port); - if (ldserver == NULL) { - syslog(LOG_ALERT, "LDAP: Could not connect to %s:%d : %s\n", - config.c_ldap_host, config.c_ldap_port, - strerror(errno) - ); + if (ctdl_ldap_initialize(&ldserver) != LDAP_SUCCESS) { return(errno); } ldap_set_option(ldserver, LDAP_OPT_PROTOCOL_VERSION, &ctdl_require_ldap_version); ldap_set_option(ldserver, LDAP_OPT_REFERRALS, (void *)LDAP_OPT_OFF); - striplt(config.c_ldap_bind_dn); - striplt(config.c_ldap_bind_pw); - syslog(LOG_DEBUG, "LDAP bind DN: %s\n", config.c_ldap_bind_dn); + striplt(CtdlGetConfigStr("c_ldap_bind_dn")); + striplt(CtdlGetConfigStr("c_ldap_bind_pw")); + syslog(LOG_DEBUG, "ldap: bind DN: %s", CtdlGetConfigStr("c_ldap_bind_dn")); i = ldap_simple_bind_s(ldserver, - (!IsEmptyStr(config.c_ldap_bind_dn) ? config.c_ldap_bind_dn : NULL), - (!IsEmptyStr(config.c_ldap_bind_pw) ? config.c_ldap_bind_pw : NULL) + (!IsEmptyStr(CtdlGetConfigStr("c_ldap_bind_dn")) ? CtdlGetConfigStr("c_ldap_bind_dn") : NULL), + (!IsEmptyStr(CtdlGetConfigStr("c_ldap_bind_pw")) ? CtdlGetConfigStr("c_ldap_bind_pw") : NULL) ); if (i != LDAP_SUCCESS) { - syslog(LOG_ALERT, "LDAP: Cannot bind: %s (%d)\n", ldap_err2string(i), i); + syslog(LOG_ERR, "ldap: Cannot bind: %s (%d)", ldap_err2string(i), i); return(i); } -#else - if (ldap_initialize(&ldserver, config.c_ldap_host)) - { - syslog(LOG_ALERT, "LDAP: Could not connect to %s:%d : %s\n", - config.c_ldap_host, config.c_ldap_port, - strerror(errno) - ); - return(errno); - } - - striplt(config.c_ldap_bind_dn); - striplt(config.c_ldap_bind_pw); - - syslog(LOG_DEBUG, "LDAP bind DN: %s\n", config.c_ldap_bind_dn); - i = ldap_simple_bind_s(ldserver, - (!IsEmptyStr(config.c_ldap_bind_dn) ? config.c_ldap_bind_dn : NULL), - (!IsEmptyStr(config.c_ldap_bind_pw) ? config.c_ldap_bind_pw : NULL) - ); - - if (i != LDAP_SUCCESS) { - syslog(LOG_ALERT, "LDAP: Cannot bind: %s (%d)\n", ldap_err2string(i), i); - return(i); - } -#endif - tv.tv_sec = 10; tv.tv_usec = 0; - if (config.c_auth_mode == AUTHMODE_LDAP_AD) { - sprintf(searchstring, "(sAMAccountName=%s)", username); + if (CtdlGetConfigInt("c_auth_mode") == AUTHMODE_LDAP_AD) { + if (lookup_based_on_username != 0) + snprintf(searchstring, sizeof(searchstring), "(displayName=%s)",username); + else + snprintf(searchstring, sizeof(searchstring), "(sAMAccountName=%s)", username); } else { - sprintf(searchstring, "(&(objectclass=posixAccount)(uid=%s))", username); + if (lookup_based_on_username != 0) { + snprintf(searchstring, sizeof(searchstring), "(cn=%s)",username); + } + else { + snprintf(searchstring, sizeof(searchstring), "(&(objectclass=posixAccount)(uid=%s))", username); + } } - syslog(LOG_DEBUG, "LDAP search: %s\n", searchstring); + syslog(LOG_DEBUG, "ldap: search: %s", searchstring); (void) ldap_search_ext_s( ldserver, /* ld */ - config.c_ldap_base_dn, /* base */ + CtdlGetConfigStr("c_ldap_base_dn"), /* base */ LDAP_SCOPE_SUBTREE, /* scope */ searchstring, /* filter */ NULL, /* attrs (all attributes) */ @@ -123,7 +125,7 @@ int CtdlTryUserLDAP(char *username, * the search succeeds. Instead, we check to see whether search_result is still NULL. */ if (search_result == NULL) { - syslog(LOG_DEBUG, "LDAP search: zero results were returned\n"); + syslog(LOG_DEBUG, "ldap: zero search results were returned"); ldap_unbind(ldserver); return(2); } @@ -136,15 +138,15 @@ int CtdlTryUserLDAP(char *username, user_dn = ldap_get_dn(ldserver, entry); if (user_dn) { - syslog(LOG_DEBUG, "dn = %s\n", user_dn); + syslog(LOG_DEBUG, "ldap: dn = %s", user_dn); } - if (config.c_auth_mode == AUTHMODE_LDAP_AD) { + if (CtdlGetConfigInt("c_auth_mode") == AUTHMODE_LDAP_AD) { values = ldap_get_values(ldserver, search_result, "displayName"); if (values) { if (values[0]) { if (fullname) safestrncpy(fullname, values[0], fullname_size); - syslog(LOG_DEBUG, "displayName = %s\n", values[0]); + syslog(LOG_DEBUG, "ldap: displayName = %s", values[0]); } ldap_value_free(values); } @@ -154,34 +156,36 @@ int CtdlTryUserLDAP(char *username, if (values) { if (values[0]) { if (fullname) safestrncpy(fullname, values[0], fullname_size); - syslog(LOG_DEBUG, "cn = %s\n", values[0]); + syslog(LOG_DEBUG, "ldap: cn = %s", values[0]); } ldap_value_free(values); } } - - if (config.c_auth_mode == AUTHMODE_LDAP_AD) { - values = ldap_get_values(ldserver, search_result, "objectGUID"); - if (values) { - if (values[0]) { - if (uid != NULL) { - *uid = abs(HashLittle(values[0], strlen(values[0]))); - syslog(LOG_DEBUG, "uid hashed from objectGUID = %d\n", *uid); + /* If we know the username is the CN/displayName, we already set the uid*/ + if (lookup_based_on_username==0) { + if (CtdlGetConfigInt("c_auth_mode") == AUTHMODE_LDAP_AD) { + values = ldap_get_values(ldserver, search_result, "objectGUID"); + if (values) { + if (values[0]) { + if (uid != NULL) { + *uid = abs(HashLittle(values[0], strlen(values[0]))); + syslog(LOG_DEBUG, "ldap: uid hashed from objectGUID = %d", *uid); + } } + ldap_value_free(values); } - ldap_value_free(values); } - } - else { - values = ldap_get_values(ldserver, search_result, "uidNumber"); - if (values) { - if (values[0]) { - syslog(LOG_DEBUG, "uidNumber = %s\n", values[0]); - if (uid != NULL) { - *uid = atoi(values[0]); + else { + values = ldap_get_values(ldserver, search_result, "uidNumber"); + if (values) { + if (values[0]) { + syslog(LOG_DEBUG, "ldap: uidNumber = %s", values[0]); + if (uid != NULL) { + *uid = atoi(values[0]); + } } + ldap_value_free(values); } - ldap_value_free(values); } } @@ -194,7 +198,7 @@ int CtdlTryUserLDAP(char *username, ldap_unbind(ldserver); if (!user_dn) { - syslog(LOG_DEBUG, "No such user was found.\n"); + syslog(LOG_DEBUG, "ldap: No such user was found."); return(4); } @@ -210,20 +214,20 @@ int CtdlTryPasswordLDAP(char *user_dn, const char *password) int i = (-1); if (IsEmptyStr(password)) { - syslog(LOG_DEBUG, "LDAP: empty passwords are not permitted\n"); + syslog(LOG_DEBUG, "ldap: empty passwords are not permitted"); return(1); } - syslog(LOG_DEBUG, "LDAP: trying to bind as %s\n", user_dn); - ldserver = ldap_init(config.c_ldap_host, config.c_ldap_port); - if (ldserver) { + syslog(LOG_DEBUG, "ldap: trying to bind as %s", user_dn); + i = ctdl_ldap_initialize(&ldserver); + if (i == LDAP_SUCCESS) { ldap_set_option(ldserver, LDAP_OPT_PROTOCOL_VERSION, &ctdl_require_ldap_version); i = ldap_simple_bind_s(ldserver, user_dn, password); if (i == LDAP_SUCCESS) { - syslog(LOG_DEBUG, "LDAP: bind succeeded\n"); + syslog(LOG_DEBUG, "ldap: bind succeeded"); } else { - syslog(LOG_DEBUG, "LDAP: Cannot bind: %s (%d)\n", ldap_err2string(i), i); + syslog(LOG_DEBUG, "ldap: Cannot bind: %s (%d)", ldap_err2string(i), i); } ldap_set_option(ldserver, LDAP_OPT_REFERRALS, (void *)LDAP_OPT_OFF); ldap_unbind(ldserver); @@ -237,6 +241,41 @@ int CtdlTryPasswordLDAP(char *user_dn, const char *password) } +//return !0 iff property changed. +int vcard_set_props_iff_different(struct vCard *v,char *propname,int numvals, char **vals) { + int i; + char *oldval = ""; + for(i=0;i 512) { + syslog(LOG_ERR, "ldap: can't fit all email addresses into user record"); + } + else { + if (!IsEmptyStr(emailaddrs)) { + strcat(emailaddrs, "|"); + } + strcat(emailaddrs, mail[q]); + } + } + } + } + } + + /* free the results */ + ldap_msgfree(search_result); + + /* unbind so we can go back in as the authenticating user */ + ldap_unbind(ldserver); + return(0); +} + #endif /* HAVE_LDAP */