X-Git-Url: https://code.citadel.org/?a=blobdiff_plain;f=citadel%2Fldap.c;h=f5461f29996a3918f8e77e7ebb3f56af12e72894;hb=2230772b04f3b7c58dd02a820d8983c63d6370ca;hp=cc88a7b4e202fdbfdfd5412ab1efc39ac1853e5f;hpb=168342e0ff3187e28faa4be0f17f5a3b7d043e95;p=citadel.git diff --git a/citadel/ldap.c b/citadel/ldap.c index cc88a7b4e..f5461f299 100644 --- a/citadel/ldap.c +++ b/citadel/ldap.c @@ -2,71 +2,26 @@ * These functions implement the portions of AUTHMODE_LDAP and AUTHMODE_LDAP_AD which * actually speak to the LDAP server. * - * Copyright (c) 2011 by Art Cancro and the citadel.org development team. + * Copyright (c) 2011-2014 by the citadel.org development team. * * This program is open source software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 3 of the License, or - * (at your option) any later version. + * it under the terms of the GNU General Public License, version 3. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */ int ctdl_require_ldap_version = 3; -#include "sysdep.h" -#include -#include -#include #include -#include -#include -#include -#include -#include -#include -#ifdef HAVE_SYS_STAT_H -#include -#endif - -#if TIME_WITH_SYS_TIME -# include -# include -#else -# if HAVE_SYS_TIME_H -# include -# else -# include -# endif -#endif - -#include -#include #include -#include "auth.h" -#include "citadel.h" -#include "server.h" -#include "database.h" -#include "sysdep_decls.h" -#include "support.h" -#include "room_ops.h" -#include "file_ops.h" -#include "control.h" -#include "msgbase.h" -#include "config.h" + #include "citserver.h" -#include "citadel_dirs.h" -#include "genstamp.h" -#include "threads.h" #include "citadel_ldap.h" #include "ctdl_module.h" + #include "user_ops.h" #ifdef HAVE_LDAP @@ -87,6 +42,7 @@ int CtdlTryUserLDAP(char *username, char **values; char *user_dn = NULL; +#ifndef LDAP_INITIALIZE if (fullname) safestrncpy(fullname, username, fullname_size); ldserver = ldap_init(config.c_ldap_host, config.c_ldap_port); @@ -112,6 +68,31 @@ int CtdlTryUserLDAP(char *username, syslog(LOG_ALERT, "LDAP: Cannot bind: %s (%d)\n", ldap_err2string(i), i); return(i); } +#else + if (ldap_initialize(&ldserver, config.c_ldap_host)) + { + syslog(LOG_ALERT, "LDAP: Could not connect to %s:%d : %s\n", + config.c_ldap_host, config.c_ldap_port, + strerror(errno) + ); + return(errno); + } + + striplt(config.c_ldap_bind_dn); + striplt(config.c_ldap_bind_pw); + + syslog(LOG_DEBUG, "LDAP bind DN: %s\n", config.c_ldap_bind_dn); + i = ldap_simple_bind_s(ldserver, + (!IsEmptyStr(config.c_ldap_bind_dn) ? config.c_ldap_bind_dn : NULL), + (!IsEmptyStr(config.c_ldap_bind_pw) ? config.c_ldap_bind_pw : NULL) + ); + + if (i != LDAP_SUCCESS) { + syslog(LOG_ALERT, "LDAP: Cannot bind: %s (%d)\n", ldap_err2string(i), i); + return(i); + } +#endif + tv.tv_sec = 10; tv.tv_usec = 0; @@ -124,7 +105,8 @@ int CtdlTryUserLDAP(char *username, } syslog(LOG_DEBUG, "LDAP search: %s\n", searchstring); - i = ldap_search_ext_s(ldserver, /* ld */ + (void) ldap_search_ext_s( + ldserver, /* ld */ config.c_ldap_base_dn, /* base */ LDAP_SCOPE_SUBTREE, /* scope */ searchstring, /* filter */ @@ -255,6 +237,39 @@ int CtdlTryPasswordLDAP(char *user_dn, const char *password) } +//return !0 iff property changed. +int vcard_set_props_iff_different(struct vCard *v,char *propname,int numvals, char **vals) { + int i; + char *oldval; + for(i=0;i