X-Git-Url: https://code.citadel.org/?a=blobdiff_plain;f=citadel%2Fmd5.c;h=92196d377212af15765611b9f46e203acdc0e891;hb=f781bc87eeff269e5d570e0d9ecf14efac980cf4;hp=218989038ab458aa0844b655fd3ba8b1c6293f3a;hpb=971a2a6395d1c5fb418f3e2b64ef5213089e6255;p=citadel.git

diff --git a/citadel/md5.c b/citadel/md5.c
index 218989038..92196d377 100644
--- a/citadel/md5.c
+++ b/citadel/md5.c
@@ -336,7 +336,7 @@ void MD5Transform(cit_uint32_t buf[4], cit_uint32_t const in[16])
  * md5 string
  */
 
-char *make_apop_string(char *realpass, char *nonce, char *buffer)
+char *make_apop_string(char *realpass, char *nonce, char *buffer, size_t n)
 {
    struct MD5Context ctx;
    u_char rawdigest[MD5_DIGEST_LEN];
@@ -350,7 +350,7 @@ char *make_apop_string(char *realpass, char *nonce, char *buffer)
    MD5Final(rawdigest, &ctx);
    for (i=0; i<MD5_DIGEST_LEN; i++)
    {
-      sprintf(&buffer[i*2], "%02X", (unsigned char) (rawdigest[i] & 0xff));
+      snprintf(&buffer[i*2], n - i*2, "%02X", (unsigned char) (rawdigest[i] & 0xff));
       buffer[i*2] = tolower(buffer[i*2]);
       buffer[(i*2)+1] = tolower(buffer[(i*2)+1]);
    }