X-Git-Url: https://code.citadel.org/?a=blobdiff_plain;f=citadel%2Fmodules%2Fnetwork%2Fserv_netspool.c;h=7ca9edcd8422f7936ae7d8ecfb321f9ad652e179;hb=dc56ca4c678006a3930caa42688b2f02a9535270;hp=eeb35ba71b8fd060254ca953c498ffcdfae5812c;hpb=9571de81331e169c042c630800bff1bde499c8a9;p=citadel.git diff --git a/citadel/modules/network/serv_netspool.c b/citadel/modules/network/serv_netspool.c index eeb35ba71..7ca9edcd8 100644 --- a/citadel/modules/network/serv_netspool.c +++ b/citadel/modules/network/serv_netspool.c @@ -2,7 +2,7 @@ * This module handles shared rooms, inter-Citadel mail, and outbound * mailing list processing. * - * Copyright (c) 2000-2015 by the citadel.org team + * Copyright (c) 2000-2017 by the citadel.org team * * This program is open source software; you can redistribute it and/or modify * it under the terms of the GNU General Public License, version 3. @@ -60,6 +60,7 @@ #include #include #include +#include #include #include "citadel.h" #include "server.h" @@ -98,7 +99,6 @@ */ void network_bounce(struct CtdlMessage **pMsg, char *reason) { - struct CitContext *CCC = CC; char buf[SIZ]; char bouncesource[SIZ]; char recipient[SIZ]; @@ -108,7 +108,7 @@ void network_bounce(struct CtdlMessage **pMsg, char *reason) long len; struct CtdlMessage *msg = *pMsg; *pMsg = NULL; - QNM_syslog(LOG_DEBUG, "entering network_bounce()\n"); + syslog(LOG_DEBUG, "netspool: entering network_bounce()"); if (msg == NULL) return; @@ -130,7 +130,9 @@ void network_bounce(struct CtdlMessage **pMsg, char *reason) * FIXME ... right now we're just sending a bounce; we really want to * include the text of the bounced message. */ - CM_SetField(msg, eMesageText, reason, strlen(reason)); + if (!IsEmptyStr(reason)) { + CM_SetField(msg, eMesageText, reason, strlen(reason)); + } msg->cm_format_type = 0; /* @@ -169,7 +171,7 @@ void network_bounce(struct CtdlMessage **pMsg, char *reason) /* Clean up */ if (valid != NULL) free_recipients(valid); CM_Free(msg); - QNM_syslog(LOG_DEBUG, "leaving network_bounce()\n"); + syslog(LOG_DEBUG, "netspool: leaving network_bounce()"); } @@ -262,14 +264,13 @@ void InspectQueuedRoom(SpoolControl **pSC, HashList *working_ignetcfg, HashList *the_netmap) { - struct CitContext *CCC = CC; SpoolControl *sc; int i = 0; + syslog(LOG_INFO, "netspool: InspectQueuedRoom(%s)", room_to_spool->name); + sc = (SpoolControl*)malloc(sizeof(SpoolControl)); memset(sc, 0, sizeof(SpoolControl)); - sc->RNCfg = room_to_spool->OneRNCfg; - sc->lastsent = room_to_spool->lastsent; sc->working_ignetcfg = working_ignetcfg; sc->the_netmap = the_netmap; @@ -279,72 +280,68 @@ void InspectQueuedRoom(SpoolControl **pSC, * queued for networking and then deleted before it can happen. */ if (CtdlGetRoom(&sc->room, room_to_spool->name) != 0) { - syslog(LOG_CRIT, "ERROR: cannot load <%s>\n", room_to_spool->name); - free(sc); - return; - } - if (sc->room.QRhighest <= sc->lastsent) - { - QN_syslog(LOG_DEBUG, "nothing to do for <%s>\n", room_to_spool->name); + syslog(LOG_INFO, "netspool: ERROR; cannot load <%s>", room_to_spool->name); free(sc); return; } - begin_critical_section(S_NETCONFIGS); - if (sc->RNCfg == NULL) - sc->RNCfg = CtdlGetNetCfgForRoom(sc->room.QRnumber); + assert(sc->RNCfg == NULL); // checking to make sure we cleared it from last time + + sc->RNCfg = CtdlGetNetCfgForRoom(sc->room.QRnumber); - if (!HaveSpoolConfig(sc->RNCfg)) + syslog(LOG_DEBUG, "netspool: room <%s> highest=%ld lastsent=%ld", room_to_spool->name, sc->room.QRhighest, sc->RNCfg->lastsent); + if ( (!HaveSpoolConfig(sc->RNCfg)) || (sc->room.QRhighest <= sc->RNCfg->lastsent) ) { - end_critical_section(S_NETCONFIGS); + // There is nothing to send from this room. + syslog(LOG_DEBUG, "netspool: nothing to do for <%s>", room_to_spool->name); + FreeRoomNetworkStruct(&sc->RNCfg); + sc->RNCfg = NULL; free(sc); - /* nothing to do for this room... */ return; } + sc->lastsent = sc->RNCfg->lastsent; + room_to_spool->lastsent = sc->lastsent; + /* Now lets remember whats needed for the actual work... */ for (i=0; i < 4; i++) { - aggregate_recipients(&sc->Users[SpoolCfgs[i]], - SpoolCfgs[i], - sc->RNCfg, - SpoolCfgsCopyN[i]); + aggregate_recipients(&sc->Users[SpoolCfgs[i]], SpoolCfgs[i], sc->RNCfg, SpoolCfgsCopyN[i]); } - if (StrLength(sc->RNCfg->Sender) > 0) + if (StrLength(sc->RNCfg->Sender) > 0) { sc->Users[roommailalias] = NewStrBufDup(sc->RNCfg->Sender); - end_critical_section(S_NETCONFIGS); + } sc->next = *pSC; *pSC = sc; + FreeRoomNetworkStruct(&sc->RNCfg); // done with this for now, we'll grab it again next time + sc->RNCfg = NULL; } + void CalcListID(SpoolControl *sc) { StrBuf *RoomName; - const char *err; - int fd; struct CitContext *CCC = CC; - char filename[PATH_MAX]; #define MAX_LISTIDLENGTH 150 - assoc_file_name(filename, sizeof filename, &sc->room, ctdl_info_dir); - fd = open(filename, 0); - - if (fd > 0) { - struct stat stbuf; - - if ((fstat(fd, &stbuf) == 0) && - (stbuf.st_size > 0)) - { - sc->RoomInfo = NewStrBufPlain(NULL, stbuf.st_size + 1); - StrBufReadBLOB(sc->RoomInfo, &fd, 0, stbuf.st_size, &err); - } - close(fd); + // Load the room banner as the list description + struct CtdlMessage *msg = CtdlFetchMessage(sc->room.msgnum_info, 1, 1); + if (msg != NULL) { + CC->redirect_buffer = NewStrBufPlain(NULL, SIZ); + CtdlOutputPreLoadedMsg(msg, MT_CITADEL, HEADERS_NONE, 0, 0, 0); + CM_Free(msg); + sc->RoomInfo = CC->redirect_buffer; + CC->redirect_buffer = NULL; + } + else { + sc->RoomInfo = NewStrBufPlain(NULL, SIZ); } + // Calculate the List ID sc->ListID = NewStrBufPlain(NULL, 1024); if (StrLength(sc->RoomInfo) > 0) { @@ -413,7 +410,6 @@ void CalcListID(SpoolControl *sc) FreeStrBuf(&RoomName); } -static time_t last_digest_delivery = 0; /* * Batch up and send all outbound traffic from the current room @@ -432,7 +428,7 @@ void network_spoolout_room(SpoolControl *sc) */ memcpy (&CCC->room, &sc->room, sizeof(ctdlroom)); - syslog(LOG_INFO, "Networking started for <%s>\n", CCC->room.QRname); + syslog(LOG_INFO, "netspool: network_spoolout_room(room=%s, lastsent=%ld)", CCC->room.QRname, sc->lastsent); CalcListID(sc); @@ -440,8 +436,7 @@ void network_spoolout_room(SpoolControl *sc) lastsent = sc->lastsent; /* Fetch the messages we ought to send & prepare them. */ - CtdlForEachMessage(MSGS_GT, sc->lastsent, NULL, NULL, NULL, - network_spool_msg, sc); + CtdlForEachMessage(MSGS_GT, sc->lastsent, NULL, NULL, NULL, network_spool_msg, sc); if (StrLength(sc->Users[roommailalias]) > 0) { @@ -454,8 +449,7 @@ void network_spoolout_room(SpoolControl *sc) } else { - snprintf(buf, sizeof buf, "room_%s@%s", - CCC->room.QRname, CtdlGetConfigStr("c_fqdn")); + snprintf(buf, sizeof buf, "room_%s@%s", CCC->room.QRname, CtdlGetConfigStr("c_fqdn")); } for (i=0; buf[i]; ++i) { @@ -465,51 +459,31 @@ void network_spoolout_room(SpoolControl *sc) /* If we wrote a digest, deliver it and then close it */ - if (sc->Users[digestrecp] != NULL) { - time_t now = time(NULL); - time_t secs_today = now % (24 * 60 * 60); - long delta = 0; - - if (last_digest_delivery != 0) { - delta = now - last_digest_delivery; - delta = (24 * 60 * 60) - delta; - } - - if ((secs_today < 300) && - (delta < 300)) - { - if (sc->digestfp == NULL) { - sc->digestfp = create_digest_file(&sc->room, 0); - } - if (sc->digestfp != NULL) { - last_digest_delivery = now; - fprintf(sc->digestfp, - " -----------------------------------" - "------------------------------------" - "-------\n" - "You are subscribed to the '%s' " - "list.\n" - "To post to the list: %s\n", - CCC->room.QRname, buf - ); - network_deliver_digest(sc); /* deliver */ - remove_digest_file(&sc->room); - } - } - } - if (sc->digestfp != NULL) { + if ( (sc->Users[digestrecp] != NULL) && (sc->digestfp != NULL) ) + { + fprintf(sc->digestfp, + " ------------------------------------------------------------------------------\n" + "You are subscribed to the '%s' list.\n" + "To post to the list: %s\n", + CCC->room.QRname, buf + ); + network_deliver_digest(sc); /* deliver */ fclose(sc->digestfp); sc->digestfp = NULL; + remove_digest_file(&sc->room); } - /* Now rewrite the config file */ + /* Now rewrite the netconfig */ + syslog(LOG_DEBUG, "netspool: lastsent was %ld , now it is %ld", lastsent, sc->lastsent); if (sc->lastsent != lastsent) { - begin_critical_section(S_NETCONFIGS); - sc->RNCfg = CtdlGetNetCfgForRoom(sc->room.QRnumber); + OneRoomNetCfg *r; - sc->RNCfg->lastsent = sc->lastsent; - sc->RNCfg->changed = 1; + begin_critical_section(S_NETCONFIGS); + r = CtdlGetNetCfgForRoom(sc->room.QRnumber); + r->lastsent = sc->lastsent; + SaveRoomNetConfigFile(r, sc->room.QRnumber); + FreeRoomNetworkStruct(&r); end_critical_section(S_NETCONFIGS); } } @@ -524,8 +498,6 @@ void network_spoolout_room(SpoolControl *sc) int network_usetable(struct CtdlMessage *msg) { StrBuf *msgid; - struct CitContext *CCC = CC; - time_t now; /* Bail out if we can't generate a message ID */ if ((msg == NULL) || CM_IsEmpty(msg, emessageId)) @@ -545,13 +517,7 @@ int network_usetable(struct CtdlMessage *msg) return(0); } } - now = time(NULL); - if (CheckIfAlreadySeen("Networker Import", - msgid, - now, 0, - eUpdate, - CCC->cs_pid, 0) != 0) - { + if (CheckIfAlreadySeen(msgid)) { FreeStrBuf(&msgid); return(1); } @@ -568,7 +534,6 @@ int network_usetable(struct CtdlMessage *msg) void network_process_buffer(char *buffer, long size, HashList *working_ignetcfg, HashList *the_netmap, int *netmap_changed) { long len; - struct CitContext *CCC = CC; StrBuf *Buf = NULL; struct CtdlMessage *msg = NULL; long pos; @@ -582,14 +547,13 @@ void network_process_buffer(char *buffer, long size, HashList *working_ignetcfg, unsigned char firstbyte; unsigned char lastbyte; - QN_syslog(LOG_DEBUG, "network_process_buffer() processing %ld bytes\n", size); + syslog(LOG_DEBUG, "netspool: network_process_buffer() processing %ld bytes", size); /* Validate just a little bit. First byte should be FF and * last byte should be 00. */ firstbyte = buffer[0]; lastbyte = buffer[size-1]; if ( (firstbyte != 255) || (lastbyte != 0) ) { - QN_syslog(LOG_ERR, "Corrupt message ignored. Length=%ld, firstbyte = %d, lastbyte = %d\n", - size, firstbyte, lastbyte); + syslog(LOG_ERR, "netspool: corrupt message ignored. Length=%ld, firstbyte = %d, lastbyte = %d", size, firstbyte, lastbyte); return; } @@ -639,14 +603,14 @@ void network_process_buffer(char *buffer, long size, HashList *working_ignetcfg, time(NULL), rand() ); - QN_syslog(LOG_DEBUG, "Appending to %s\n", filename); + syslog(LOG_DEBUG, "netspool: appending to %s", filename); fp = fopen(filename, "ab"); if (fp != NULL) { fwrite(sermsg.ser, sermsg.len, 1, fp); fclose(fp); } else { - QN_syslog(LOG_ERR, "%s: %s\n", filename, strerror(errno)); + syslog(LOG_ERR, "%s: %s", filename, strerror(errno)); } free(sermsg.ser); CM_Free(msg); @@ -700,7 +664,7 @@ void network_process_buffer(char *buffer, long size, HashList *working_ignetcfg, "A message you sent could not be delivered due to an invalid address.\n" "Please check the address and try sending the message again.\n"); free_recipients(recp); - QNM_syslog(LOG_DEBUG, "Bouncing message due to invalid recipient address.\n"); + syslog(LOG_DEBUG, "netspool: bouncing message due to invalid recipient address."); return; } strcpy(target_room, ""); /* no target room if mail */ @@ -768,7 +732,6 @@ void network_process_file(char *filename, HashList *the_netmap, int *netmap_changed) { - struct CitContext *CCC = CC; FILE *fp; long msgstart = (-1L); long msgend = (-1L); @@ -778,12 +741,12 @@ void network_process_file(char *filename, fp = fopen(filename, "rb"); if (fp == NULL) { - QN_syslog(LOG_CRIT, "Error opening %s: %s\n", filename, strerror(errno)); + syslog(LOG_ERR, "%s: %s", filename, strerror(errno)); return; } fseek(fp, 0L, SEEK_END); - QN_syslog(LOG_INFO, "network: processing %ld bytes from %s\n", ftell(fp), filename); + syslog(LOG_INFO, "netspool: processing %ld bytes from %s", ftell(fp), filename); rewind(fp); /* Look for messages in the data stream and break them out */ @@ -818,10 +781,7 @@ void network_process_file(char *filename, } if (nMessages > 0) - QN_syslog(LOG_INFO, - "network: processed %d messages in %s\n", - nMessages, - filename); + syslog(LOG_INFO, "netspool: processed %d messages in %s", nMessages, filename); fclose(fp); unlink(filename); @@ -833,7 +793,6 @@ void network_process_file(char *filename, */ void network_do_spoolin(HashList *working_ignetcfg, HashList *the_netmap, int *netmap_changed) { - struct CitContext *CCC = CC; DIR *dp; struct dirent *d; struct dirent *filedir_entry; @@ -849,11 +808,11 @@ void network_do_spoolin(HashList *working_ignetcfg, HashList *the_netmap, int *n */ if (stat(ctdl_netin_dir, &statbuf)) return; if (statbuf.st_mtime == last_spoolin_mtime) { - QNM_syslog(LOG_DEBUG, "network: nothing in inbound queue\n"); + syslog(LOG_DEBUG, "netspool: nothing in inbound queue"); return; } last_spoolin_mtime = statbuf.st_mtime; - QNM_syslog(LOG_DEBUG, "network: processing inbound queue\n"); + syslog(LOG_DEBUG, "netspool: processing inbound queue"); /* * Ok, there's something interesting in there, so scan it. @@ -938,7 +897,6 @@ void network_do_spoolin(HashList *working_ignetcfg, HashList *the_netmap, int *n */ void network_consolidate_spoolout(HashList *working_ignetcfg, HashList *the_netmap) { - struct CitContext *CCC = CC; IOBuffer IOB; FDIOBuffer FDIO; int d_namelen; @@ -955,7 +913,6 @@ void network_consolidate_spoolout(HashList *working_ignetcfg, HashList *the_netm int nFailed = 0; int d_type = 0; - /* Step 1: consolidate files in the outbound queue into one file per neighbor node */ d = (struct dirent *)malloc(offsetof(struct dirent, d_name) + PATH_MAX + 1); if (d == NULL) return; @@ -1021,13 +978,10 @@ void network_consolidate_spoolout(HashList *working_ignetcfg, HashList *the_netm ctdl_netout_dir, ChrPtr(NextHop)); - QN_syslog(LOG_DEBUG, "Consolidate %s to %s\n", filename, ChrPtr(NextHop)); + syslog(LOG_DEBUG, "netspool: consolidate %s to %s", filename, ChrPtr(NextHop)); if (CtdlNetworkTalkingTo(SKEY(NextHop), NTT_CHECK)) { nFailed++; - QN_syslog(LOG_DEBUG, - "Currently online with %s - skipping for now\n", - ChrPtr(NextHop) - ); + syslog(LOG_DEBUG, "netspool: currently online with %s - skipping for now", ChrPtr(NextHop)); } else { size_t dsize; @@ -1039,10 +993,7 @@ void network_consolidate_spoolout(HashList *working_ignetcfg, HashList *the_netm infd = open(filename, O_RDONLY); if (infd == -1) { nFailed++; - QN_syslog(LOG_ERR, - "failed to open %s for reading due to %s; skipping.\n", - filename, strerror(errno) - ); + syslog(LOG_ERR, "%s: %s", filename, strerror(errno)); CtdlNetworkTalkingTo(SKEY(NextHop), NTT_REMOVE); continue; } @@ -1058,10 +1009,7 @@ void network_consolidate_spoolout(HashList *working_ignetcfg, HashList *the_netm } if (outfd == -1) { nFailed++; - QN_syslog(LOG_ERR, - "failed to open %s for reading due to %s; skipping.\n", - spooloutfilename, strerror(errno) - ); + syslog(LOG_ERR, "%s: %s", spooloutfilename, strerror(errno)); close(infd); CtdlNetworkTalkingTo(SKEY(NextHop), NTT_REMOVE); continue; @@ -1072,9 +1020,6 @@ void network_consolidate_spoolout(HashList *working_ignetcfg, HashList *the_netm fstat(infd, &statbuf); fsize = statbuf.st_size; -/* - fsize = lseek(infd, 0, SEEK_END); -*/ IOB.fd = infd; FDIOBufferInit(&FDIO, &IOB, outfd, fsize + dsize); FDIO.ChunkSendRemain = fsize; @@ -1084,18 +1029,11 @@ void network_consolidate_spoolout(HashList *working_ignetcfg, HashList *the_netm do {} while ((FileMoveChunked(&FDIO, &err) > 0) && (err == NULL)); if (err == NULL) { unlink(filename); - QN_syslog(LOG_DEBUG, - "Spoolfile %s now "SIZE_T_FMT" k\n", - spooloutfilename, - (dsize + fsize)/1024 - ); + syslog(LOG_DEBUG, "netspool: spoolfile %s now "SIZE_T_FMT" KB", spooloutfilename, (dsize + fsize)/1024); } else { nFailed++; - QN_syslog(LOG_ERR, - "failed to append to %s [%s]; rolling back..\n", - spooloutfilename, strerror(errno) - ); + syslog(LOG_ERR, "netspool: failed to append to %s [%s]; rolling back..", spooloutfilename, strerror(errno)); /* whoops partial append?? truncate spooloutfilename again! */ ftruncate(outfd, dsize); } @@ -1109,10 +1047,7 @@ void network_consolidate_spoolout(HashList *working_ignetcfg, HashList *the_netm if (nFailed > 0) { FreeStrBuf(&NextHop); - QN_syslog(LOG_INFO, - "skipping Spoolcleanup because of %d files unprocessed.\n", - nFailed - ); + syslog(LOG_INFO, "netspool: skipping Spoolcleanup because of %d files unprocessed.", nFailed); return; } @@ -1199,27 +1134,26 @@ void free_spoolcontrol_struct_members(SpoolControl *sc) } - /* * It's ok if these directories already exist. Just fail silently. */ void create_spool_dirs(void) { if ((mkdir(ctdl_spool_dir, 0700) != 0) && (errno != EEXIST)) - syslog(LOG_EMERG, "unable to create directory [%s]: %s", ctdl_spool_dir, strerror(errno)); + syslog(LOG_EMERG, "netspool: unable to create directory [%s]: %s", ctdl_spool_dir, strerror(errno)); if (chown(ctdl_spool_dir, CTDLUID, (-1)) != 0) - syslog(LOG_EMERG, "unable to set the access rights for [%s]: %s", ctdl_spool_dir, strerror(errno)); + syslog(LOG_EMERG, "netspool: unable to set the access rights for [%s]: %s", ctdl_spool_dir, strerror(errno)); if ((mkdir(ctdl_netin_dir, 0700) != 0) && (errno != EEXIST)) - syslog(LOG_EMERG, "unable to create directory [%s]: %s", ctdl_netin_dir, strerror(errno)); + syslog(LOG_EMERG, "netspool: unable to create directory [%s]: %s", ctdl_netin_dir, strerror(errno)); if (chown(ctdl_netin_dir, CTDLUID, (-1)) != 0) - syslog(LOG_EMERG, "unable to set the access rights for [%s]: %s", ctdl_netin_dir, strerror(errno)); + syslog(LOG_EMERG, "netspool: unable to set the access rights for [%s]: %s", ctdl_netin_dir, strerror(errno)); if ((mkdir(ctdl_nettmp_dir, 0700) != 0) && (errno != EEXIST)) - syslog(LOG_EMERG, "unable to create directory [%s]: %s", ctdl_nettmp_dir, strerror(errno)); + syslog(LOG_EMERG, "netspool: unable to create directory [%s]: %s", ctdl_nettmp_dir, strerror(errno)); if (chown(ctdl_nettmp_dir, CTDLUID, (-1)) != 0) - syslog(LOG_EMERG, "unable to set the access rights for [%s]: %s", ctdl_nettmp_dir, strerror(errno)); + syslog(LOG_EMERG, "netspool: unable to set the access rights for [%s]: %s", ctdl_nettmp_dir, strerror(errno)); if ((mkdir(ctdl_netout_dir, 0700) != 0) && (errno != EEXIST)) - syslog(LOG_EMERG, "unable to create directory [%s]: %s", ctdl_netout_dir, strerror(errno)); + syslog(LOG_EMERG, "netspool: unable to create directory [%s]: %s", ctdl_netout_dir, strerror(errno)); if (chown(ctdl_netout_dir, CTDLUID, (-1)) != 0) - syslog(LOG_EMERG, "unable to set the access rights for [%s]: %s", ctdl_netout_dir, strerror(errno)); + syslog(LOG_EMERG, "netspool: unable to set the access rights for [%s]: %s", ctdl_netout_dir, strerror(errno)); } /*