X-Git-Url: https://code.citadel.org/?a=blobdiff_plain;f=citadel%2Fmodules%2Frssclient%2Fserv_rssclient.c;h=530bed03fe6f689b8bb96eb6af547744f980f33c;hb=c855d497545dad80942a194624c111a54cd1fdc7;hp=d6145f6ee982454c0cbc29c01cf3d174078103b2;hpb=6ddb4b397f4abddeb28128deb2bf5ff8d99a55a6;p=citadel.git
diff --git a/citadel/modules/rssclient/serv_rssclient.c b/citadel/modules/rssclient/serv_rssclient.c
index d6145f6ee..530bed03f 100644
--- a/citadel/modules/rssclient/serv_rssclient.c
+++ b/citadel/modules/rssclient/serv_rssclient.c
@@ -62,15 +62,21 @@
#define TMP_SHORTER_URL_OFFSET 0xFE
#define TMP_SHORTER_URLS 0xFD
-citthread_mutex_t RSSQueueMutex; /* locks the access to the following vars: */
-HashList *RSSQueueRooms = NULL; /* rss_room_counter */
-HashList *RSSFetchUrls = NULL; /* -> rss_aggregator; ->RefCount access to be locked too. */
+time_t last_run = 0L;
-eNextState RSSAggregatorTerminate(AsyncIO *IO);
+pthread_mutex_t RSSQueueMutex; /* locks the access to the following vars: */
+HashList *RSSQueueRooms = NULL; /* rss_room_counter */
+HashList *RSSFetchUrls = NULL; /*->rss_aggregator;->RefCount access locked*/
+eNextState RSSAggregator_Terminate(AsyncIO *IO);
+eNextState RSSAggregator_ShutdownAbort(AsyncIO *IO);
+struct CitContext rss_CC;
struct rssnetcfg *rnclist = NULL;
-void AppendLink(StrBuf *Message, StrBuf *link, StrBuf *LinkTitle, const char *Title)
+void AppendLink(StrBuf *Message,
+ StrBuf *link,
+ StrBuf *LinkTitle,
+ const char *Title)
{
if (StrLength(link) > 0)
{
@@ -86,15 +92,6 @@ void AppendLink(StrBuf *Message, StrBuf *link, StrBuf *LinkTitle, const char *Ti
StrBufAppendBufPlain(Message, HKEY("
\n"), 0);
}
}
-typedef struct __networker_save_message {
- AsyncIO IO;
- struct CtdlMessage *Msg;
- struct recptypes *recp;
- rss_aggregator *Cfg;
- StrBuf *MsgGUID;
- StrBuf *Message;
- struct UseTable ut;
-} networker_save_message;
void DeleteRoomReference(long QRnumber)
@@ -107,21 +104,22 @@ void DeleteRoomReference(long QRnumber)
At = GetNewHashPos(RSSQueueRooms, 0);
- GetHashPosFromKey(RSSQueueRooms, LKEY(QRnumber), At);
- GetHashPos(RSSQueueRooms, At, &HKLen, &HK, &vData);
- if (vData != NULL)
+ if (GetHashPosFromKey(RSSQueueRooms, LKEY(QRnumber), At))
{
- pRoomC = (rss_room_counter *) vData;
- pRoomC->count --;
- if (pRoomC->count == 0)
- DeleteEntryFromHash(RSSQueueRooms, At);
+ GetHashPos(RSSQueueRooms, At, &HKLen, &HK, &vData);
+ if (vData != NULL)
+ {
+ pRoomC = (rss_room_counter *) vData;
+ pRoomC->count --;
+ if (pRoomC->count == 0)
+ DeleteEntryFromHash(RSSQueueRooms, At);
+ }
}
DeleteHashPos(&At);
}
void UnlinkRooms(rss_aggregator *Cfg)
{
-
DeleteRoomReference(Cfg->QRnumber);
if (Cfg->OtherQRnumbers != NULL)
{
@@ -131,7 +129,11 @@ void UnlinkRooms(rss_aggregator *Cfg)
void *vData;
At = GetNewHashPos(Cfg->OtherQRnumbers, 0);
- while (GetNextHashPos(Cfg->OtherQRnumbers, At, &HKLen, &HK, &vData) &&
+ while (! server_shutting_down &&
+ GetNextHashPos(Cfg->OtherQRnumbers,
+ At,
+ &HKLen, &HK,
+ &vData) &&
(vData != NULL))
{
long *lData = (long*) vData;
@@ -140,7 +142,6 @@ void UnlinkRooms(rss_aggregator *Cfg)
DeleteHashPos(&At);
}
-
}
void UnlinkRSSAggregator(rss_aggregator *Cfg)
@@ -150,33 +151,22 @@ void UnlinkRSSAggregator(rss_aggregator *Cfg)
UnlinkRooms(Cfg);
At = GetNewHashPos(RSSFetchUrls, 0);
- if (GetHashPosFromKey(RSSFetchUrls, SKEY(Cfg->Url), At) == 0)
+ if (GetHashPosFromKey(RSSFetchUrls, SKEY(Cfg->Url), At))
{
DeleteEntryFromHash(RSSFetchUrls, At);
}
DeleteHashPos(&At);
+ last_run = time(NULL);
}
-eNextState FreeNetworkSaveMessage (AsyncIO *IO)
+void FreeNetworkSaveMessage (void *vMsg)
{
- networker_save_message *Ctx = (networker_save_message *) IO->Data;
-
- citthread_mutex_lock(&RSSQueueMutex);
- Ctx->Cfg->RefCount --;
+ networker_save_message *Msg = (networker_save_message *) vMsg;
- if (Ctx->Cfg->RefCount == 0)
- {
- UnlinkRSSAggregator(Ctx->Cfg);
-
- }
- citthread_mutex_unlock(&RSSQueueMutex);
-
- CtdlFreeMessage(Ctx->Msg);
- free_recipients(Ctx->recp);
- FreeStrBuf(&Ctx->Message);
- FreeStrBuf(&Ctx->MsgGUID);
- free(Ctx);
- return eAbort;
+ CtdlFreeMessageContents(&Msg->Msg);
+ FreeStrBuf(&Msg->Message);
+ FreeStrBuf(&Msg->MsgGUID);
+ free(Msg);
}
eNextState AbortNetworkSaveMessage (AsyncIO *IO)
@@ -186,41 +176,64 @@ eNextState AbortNetworkSaveMessage (AsyncIO *IO)
eNextState RSSSaveMessage(AsyncIO *IO)
{
- networker_save_message *Ctx = (networker_save_message *) IO->Data;
+ long len;
+ const char *Key;
+ rss_aggregator *Ctx = (rss_aggregator *) IO->Data;
- Ctx->Msg->cm_fields['M'] = SmashStrBuf(&Ctx->Message);
+ Ctx->ThisMsg->Msg.cm_fields['M'] = SmashStrBuf(&Ctx->ThisMsg->Message);
- CtdlSubmitMsg(Ctx->Msg, Ctx->recp, NULL, 0);
+ CtdlSubmitMsg(&Ctx->ThisMsg->Msg, &Ctx->recp, NULL, 0);
/* write the uidl to the use table so we don't store this item again */
- cdb_store(CDB_USETABLE, SKEY(Ctx->MsgGUID), &Ctx->ut, sizeof(struct UseTable) );
-
- return eTerminateConnection;
+ cdb_store(CDB_USETABLE,
+ SKEY(Ctx->ThisMsg->MsgGUID),
+ &Ctx->ThisMsg->ut,
+ sizeof(struct UseTable) );
+
+ if (GetNextHashPos(Ctx->Messages,
+ Ctx->Pos,
+ &len, &Key,
+ (void**) &Ctx->ThisMsg))
+ return NextDBOperation(IO, RSS_FetchNetworkUsetableEntry);
+ else
+ return eAbort;
}
-// TODO: relink me: ExpandShortUrls(ri->description);
-
-eNextState FetchNetworkUsetableEntry(AsyncIO *IO)
+eNextState RSS_FetchNetworkUsetableEntry(AsyncIO *IO)
{
+ const char *Key;
+ long len;
struct cdbdata *cdbut;
- networker_save_message *Ctx = (networker_save_message *) IO->Data;
+ rss_aggregator *Ctx = (rss_aggregator *) IO->Data;
/* Find out if we've already seen this item */
- strcpy(Ctx->ut.ut_msgid, ChrPtr(Ctx->MsgGUID)); /// TODO
- Ctx->ut.ut_timestamp = time(NULL);
+ strcpy(Ctx->ThisMsg->ut.ut_msgid,
+ ChrPtr(Ctx->ThisMsg->MsgGUID)); /// TODO
+ Ctx->ThisMsg->ut.ut_timestamp = time(NULL);
- cdbut = cdb_fetch(CDB_USETABLE, SKEY(Ctx->MsgGUID));
+ cdbut = cdb_fetch(CDB_USETABLE, SKEY(Ctx->ThisMsg->MsgGUID));
#ifndef DEBUG_RSS
if (cdbut != NULL) {
/* Item has already been seen */
- CtdlLogPrintf(CTDL_DEBUG, "%s has already been seen\n", ChrPtr(Ctx->MsgGUID));
+ EV_syslog(LOG_DEBUG,
+ "%s has already been seen\n",
+ ChrPtr(Ctx->ThisMsg->MsgGUID));
cdb_free(cdbut);
/* rewrite the record anyway, to update the timestamp */
- cdb_store(CDB_USETABLE,
- SKEY(Ctx->MsgGUID),
- &Ctx->ut, sizeof(struct UseTable) );
- return eAbort;
+ cdb_store(CDB_USETABLE,
+ SKEY(Ctx->ThisMsg->MsgGUID),
+ &Ctx->ThisMsg->ut, sizeof(struct UseTable) );
+
+ if (GetNextHashPos(Ctx->Messages,
+ Ctx->Pos,
+ &len, &Key,
+ (void**) &Ctx->ThisMsg))
+ return NextDBOperation(
+ IO,
+ RSS_FetchNetworkUsetableEntry);
+ else
+ return eAbort;
}
else
#endif
@@ -229,50 +242,26 @@ eNextState FetchNetworkUsetableEntry(AsyncIO *IO)
return eSendMore;
}
}
-void RSSQueueSaveMessage(struct CtdlMessage *Msg, struct recptypes *recp, StrBuf *MsgGUID, StrBuf *MessageBody, rss_aggregator *Cfg)
-{
- networker_save_message *Ctx;
-
- Ctx = (networker_save_message *) malloc(sizeof(networker_save_message));
- memset(Ctx, 0, sizeof(networker_save_message));
-
- Ctx->MsgGUID = MsgGUID;
- Ctx->Message = MessageBody;
- Ctx->Msg = Msg;
- Ctx->Cfg = Cfg;
- Ctx->recp = recp;
- Ctx->IO.Data = Ctx;
- Ctx->IO.CitContext = CloneContext(CC);
- Ctx->IO.Terminate = FreeNetworkSaveMessage;
- Ctx->IO.ShutdownAbort = AbortNetworkSaveMessage;
- QueueDBOperation(&Ctx->IO, FetchNetworkUsetableEntry);
-}
-
/*
* Commit a fetched and parsed RSS item to disk
*/
void rss_save_item(rss_item *ri, rss_aggregator *Cfg)
{
-
+ networker_save_message *SaveMsg;
struct MD5Context md5context;
u_char rawdigest[MD5_DIGEST_LEN];
- struct CtdlMessage *msg;
- struct recptypes *recp = NULL;
int msglen = 0;
StrBuf *Message;
StrBuf *guid;
- StrBuf *Buf;
-
- recp = (struct recptypes *) malloc(sizeof(struct recptypes));
- if (recp == NULL) return;
- memset(recp, 0, sizeof(struct recptypes));
- Buf = NewStrBufDup(Cfg->rooms);
- recp->recp_room = SmashStrBuf(&Buf);
- recp->num_room = Cfg->roomlist_parts;
- recp->recptypes_magic = RECPTYPES_MAGIC;
-
- Cfg->RefCount ++;
+ AsyncIO *IO = &Cfg->IO;
+ int n;
+
+
+ SaveMsg = (networker_save_message *) malloc(
+ sizeof(networker_save_message));
+ memset(SaveMsg, 0, sizeof(networker_save_message));
+
/* Construct a GUID to use in the S_USETABLE table.
* If one is not present in the item itself, make one up.
*/
@@ -285,38 +274,39 @@ void rss_save_item(rss_item *ri, rss_aggregator *Cfg)
else {
MD5Init(&md5context);
if (ri->title != NULL) {
- MD5Update(&md5context, (const unsigned char*)ChrPtr(ri->title), StrLength(ri->title));
+ MD5Update(&md5context,
+ (const unsigned char*)SKEY(ri->title));
}
if (ri->link != NULL) {
- MD5Update(&md5context, (const unsigned char*)ChrPtr(ri->link), StrLength(ri->link));
+ MD5Update(&md5context,
+ (const unsigned char*)SKEY(ri->link));
}
MD5Final(rawdigest, &md5context);
- guid = NewStrBufPlain(NULL, MD5_DIGEST_LEN * 2 + 12 /* _rss2ctdl*/);
+ guid = NewStrBufPlain(NULL,
+ MD5_DIGEST_LEN * 2 + 12 /* _rss2ctdl*/);
StrBufHexEscAppend(guid, NULL, rawdigest, MD5_DIGEST_LEN);
StrBufAppendBufPlain(guid, HKEY("_rss2ctdl"), 0);
}
/* translate Item into message. */
- CtdlLogPrintf(CTDL_DEBUG, "RSS: translating item...\n");
+ EVM_syslog(LOG_DEBUG, "RSS: translating item...\n");
if (ri->description == NULL) ri->description = NewStrBufPlain(HKEY(""));
StrBufSpaceToBlank(ri->description);
- msg = malloc(sizeof(struct CtdlMessage));
- memset(msg, 0, sizeof(struct CtdlMessage));
- msg->cm_magic = CTDLMESSAGE_MAGIC;
- msg->cm_anon_type = MES_NORMAL;
- msg->cm_format_type = FMT_RFC822;
+ SaveMsg->Msg.cm_magic = CTDLMESSAGE_MAGIC;
+ SaveMsg->Msg.cm_anon_type = MES_NORMAL;
+ SaveMsg->Msg.cm_format_type = FMT_RFC822;
if (ri->guid != NULL) {
- msg->cm_fields['E'] = strdup(ChrPtr(ri->guid));
+ SaveMsg->Msg.cm_fields['E'] = strdup(ChrPtr(ri->guid));
}
if (ri->author_or_creator != NULL) {
char *From;
StrBuf *Encoded = NULL;
int FromAt;
-
+
From = html_to_ascii(ChrPtr(ri->author_or_creator),
- StrLength(ri->author_or_creator),
+ StrLength(ri->author_or_creator),
512, 0);
StrBufPlain(ri->author_or_creator, From, -1);
StrBufTrim(ri->author_or_creator);
@@ -326,26 +316,39 @@ void rss_save_item(rss_item *ri, rss_aggregator *Cfg)
if (!FromAt && StrLength (ri->author_email) > 0)
{
StrBufRFC2047encode(&Encoded, ri->author_or_creator);
- msg->cm_fields['A'] = SmashStrBuf(&Encoded);
- msg->cm_fields['P'] = SmashStrBuf(&ri->author_email);
+ SaveMsg->Msg.cm_fields['A'] = SmashStrBuf(&Encoded);
+ SaveMsg->Msg.cm_fields['P'] =
+ SmashStrBuf(&ri->author_email);
}
else
{
if (FromAt)
- msg->cm_fields['P'] = SmashStrBuf(&ri->author_or_creator);
- else
{
- StrBufRFC2047encode(&Encoded, ri->author_or_creator);
- msg->cm_fields['A'] = SmashStrBuf(&Encoded);
- msg->cm_fields['P'] = strdup("rss@localhost");
+ SaveMsg->Msg.cm_fields['A'] =
+ SmashStrBuf(&ri->author_or_creator);
+ SaveMsg->Msg.cm_fields['P'] =
+ strdup(SaveMsg->Msg.cm_fields['A']);
+ }
+ else
+ {
+ StrBufRFC2047encode(&Encoded,
+ ri->author_or_creator);
+ SaveMsg->Msg.cm_fields['A'] =
+ SmashStrBuf(&Encoded);
+ SaveMsg->Msg.cm_fields['P'] =
+ strdup("rss@localhost");
+
+ }
+ if (ri->pubdate <= 0) {
+ ri->pubdate = time(NULL);
}
}
}
else {
- msg->cm_fields['A'] = strdup("rss");
+ SaveMsg->Msg.cm_fields['A'] = strdup("rss");
}
- msg->cm_fields['N'] = strdup(NODENAME);
+ SaveMsg->Msg.cm_fields['N'] = strdup(NODENAME);
if (ri->title != NULL) {
long len;
char *Sbj;
@@ -367,21 +370,23 @@ void rss_save_item(rss_item *ri, rss_aggregator *Cfg)
StrBufTrim(Encoded);
StrBufRFC2047encode(&QPEncoded, Encoded);
- msg->cm_fields['U'] = SmashStrBuf(&QPEncoded);
+ SaveMsg->Msg.cm_fields['U'] = SmashStrBuf(&QPEncoded);
FreeStrBuf(&Encoded);
}
- msg->cm_fields['T'] = malloc(64);
- snprintf(msg->cm_fields['T'], 64, "%ld", ri->pubdate);
+ SaveMsg->Msg.cm_fields['T'] = malloc(64);
+ snprintf(SaveMsg->Msg.cm_fields['T'], 64, "%ld", ri->pubdate);
if (ri->channel_title != NULL) {
if (StrLength(ri->channel_title) > 0) {
- msg->cm_fields['O'] = strdup(ChrPtr(ri->channel_title));
+ SaveMsg->Msg.cm_fields['O'] =
+ strdup(ChrPtr(ri->channel_title));
}
}
- if (ri->link == NULL)
+ if (ri->link == NULL)
ri->link = NewStrBufPlain(HKEY(""));
#if 0 /* temporarily disable shorter urls. */
- msg->cm_fields[TMP_SHORTER_URLS] = GetShorterUrls(ri->description);
+ SaveMsg->Msg.cm_fields[TMP_SHORTER_URLS] =
+ GetShorterUrls(ri->description);
#endif
msglen += 1024 + StrLength(ri->link) + StrLength(ri->description) ;
@@ -392,7 +397,7 @@ void rss_save_item(rss_item *ri, rss_aggregator *Cfg)
"Content-type: text/html; charset=\"UTF-8\"\r\n\r\n"
"