X-Git-Url: https://code.citadel.org/?a=blobdiff_plain;f=citadel%2Fmsgbase.c;h=7f337d3ab0c3b04e98aaa7f9e2d2fdf85edc9031;hb=2b07e5c6abcbeca7426f4ce054efa455374a74be;hp=8f13a44d9f8563c1b1f89eef9f2c0821e60fc21d;hpb=9d88f4e66830ad2c4291d523254dfc499031d85c;p=citadel.git diff --git a/citadel/msgbase.c b/citadel/msgbase.c index 8f13a44d9..7f337d3ab 100644 --- a/citadel/msgbase.c +++ b/citadel/msgbase.c @@ -1,11 +1,9 @@ /* - * $Id$ - * * Implements the message store. * - * Copyright (c) 1987-2010 by the citadel.org team + * Copyright (c) 1987-2011 by the citadel.org team * - * This program is free software; you can redistribute it and/or modify + * This program is open source software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 3 of the License, or * (at your option) any later version. @@ -17,7 +15,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */ #include "sysdep.h" @@ -200,7 +198,7 @@ int alias(char *name) } if (strcasecmp(original_name, name)) { - CtdlLogPrintf(CTDL_INFO, "%s is being forwarded to %s\n", original_name, name); + syslog(LOG_INFO, "%s is being forwarded to %s\n", original_name, name); } /* Change "user @ xxx" to "user" if xxx is an alias for this host */ @@ -208,7 +206,7 @@ int alias(char *name) if (name[a] == '@') { if (CtdlHostAlias(&name[a+1]) == hostalias_localhost) { name[a] = 0; - CtdlLogPrintf(CTDL_INFO, "Changed to <%s>\n", name); + syslog(LOG_INFO, "Changed to <%s>\n", name); } } } @@ -356,7 +354,7 @@ int CtdlMsgCmp(struct CtdlMessage *msg, struct CtdlMessage *template) { * Retrieve the "seen" message list for the current room. */ void CtdlGetSeen(char *buf, int which_set) { - struct visit vbuf; + visit vbuf; /* Learn about the user and room in question */ CtdlGetRelationship(&vbuf, &CC->user, &CC->room); @@ -381,7 +379,7 @@ void CtdlSetSeen(long *target_msgnums, int num_target_msgnums, int was_seen = 0; long lo = (-1L); long hi = (-1L); - struct visit vbuf; + visit vbuf; long *msglist; int num_msgs = 0; StrBuf *vset; @@ -406,7 +404,7 @@ void CtdlSetSeen(long *target_msgnums, int num_target_msgnums, which_user = &CC->user; } - CtdlLogPrintf(CTDL_DEBUG, "CtdlSetSeen(%d msgs starting with %ld, %s, %d) in <%s>\n", + syslog(LOG_DEBUG, "CtdlSetSeen(%d msgs starting with %ld, %s, %d) in <%s>\n", num_target_msgnums, target_msgnums[0], (target_setting ? "SET" : "CLEAR"), which_set, @@ -443,17 +441,17 @@ void CtdlSetSeen(long *target_msgnums, int num_target_msgnums, #if 0 /* This is a special diagnostic section. Do not allow it to run during normal operation. */ - CtdlLogPrintf(CTDL_DEBUG, "There are %d messages in the room.\n", num_msgs); + syslog(LOG_DEBUG, "There are %d messages in the room.\n", num_msgs); for (i=0; i 0) && (msglist[i] <= msglist[i-1])) abort(); } - CtdlLogPrintf(CTDL_DEBUG, "We are twiddling %d of them.\n", num_target_msgnums); + syslog(LOG_DEBUG, "We are twiddling %d of them.\n", num_target_msgnums); for (k=0; k 0) && (target_msgnums[k] <= target_msgnums[k-1])) abort(); } #endif - CtdlLogPrintf(CTDL_DEBUG, "before update: %s\n", ChrPtr(vset)); + syslog(LOG_DEBUG, "before update: %s\n", ChrPtr(vset)); /* Translate the existing sequence set into an array of booleans */ setstr = NewStrBuf(); @@ -576,7 +574,7 @@ void CtdlSetSeen(long *target_msgnums, int num_target_msgnums, vset = new_set; } - CtdlLogPrintf(CTDL_DEBUG, " after update: %s\n", ChrPtr(vset)); + syslog(LOG_DEBUG, " after update: %s\n", ChrPtr(vset)); /* Decide which message set we're manipulating */ switch (which_set) { @@ -607,7 +605,7 @@ int CtdlForEachMessage(int mode, long ref, char *search_string, { int a, i, j; - struct visit vbuf; + visit vbuf; struct cdbdata *cdbfr; long *msglist = NULL; int num_msgs = 0; @@ -635,14 +633,28 @@ int CtdlForEachMessage(int mode, long ref, char *search_string, /* Load the message list */ cdbfr = cdb_fetch(CDB_MSGLISTS, &CC->room.QRnumber, sizeof(long)); - if (cdbfr != NULL) { - msglist = (long *) cdbfr->ptr; - num_msgs = cdbfr->len / sizeof(long); - } else { + if (cdbfr == NULL) { if (need_to_free_re) regfree(&re); return 0; /* No messages at all? No further action. */ } + msglist = (long *) cdbfr->ptr; + num_msgs = cdbfr->len / sizeof(long); + + cdbfr->ptr = NULL; /* clear this so that cdb_free() doesn't free it */ + cdb_free(cdbfr); /* we own this memory now */ + + /* + * We cache the most recent msglist in order to do security checks later + */ + if (CC->client_socket > 0) { + if (CC->cached_msglist != NULL) { + free(CC->cached_msglist); + } + + CC->cached_msglist = msglist; + CC->cached_num_msgs = num_msgs; + } /* * Now begin the traversal. @@ -774,8 +786,8 @@ int CtdlForEachMessage(int mode, long ref, char *search_string, ++num_processed; } } - cdb_free(cdbfr); /* Clean up */ if (need_to_free_re) regfree(&re); + if (CC->client_socket <= 0) free(msglist); return num_processed; } @@ -799,6 +811,8 @@ void cmd_msgs(char *cmdbuf) char search_string[1024]; ForEachMsgCallback CallBack; + if (CtdlAccessCheck(ac_logged_in_or_guest)) return; + extract_token(which, cmdbuf, 0, '|', sizeof which); cm_ref = extract_int(cmdbuf, 1); extract_token(search_string, cmdbuf, 1, '|', sizeof search_string); @@ -835,11 +849,6 @@ void cmd_msgs(char *cmdbuf) else mode = MSGS_ALL; - if ((!(CC->logged_in)) && (!(CC->internal_pgm))) { - cprintf("%d not logged in\n", ERROR + NOT_LOGGED_IN); - return; - } - if ( (mode == MSGS_SEARCH) && (!config.c_enable_fulltext) ) { cprintf("%d Full text index is not enabled on this server.\n", ERROR + CMD_NOT_SUPPORTED); @@ -933,19 +942,27 @@ void memfmout( const char *nl /* string to terminate lines with */ ) { int column = 0; - char ch = 0; + unsigned char ch = 0; char outbuf[1024]; int len = 0; int nllen = 0; if (!mptr) return; nllen = strlen(nl); - while (ch=*(mptr++), ch > 0) { + while (ch=*(mptr++), ch != 0) { if (ch == '\n') { - client_write(outbuf, len); + if (client_write(outbuf, len) == -1) + { + syslog(LOG_ERR, "memfmout(): aborting due to write failure.\n"); + return; + } len = 0; - client_write(nl, nllen); + if (client_write(nl, nllen) == -1) + { + syslog(LOG_ERR, "memfmout(): aborting due to write failure.\n"); + return; + } column = 0; } else if (ch == '\r') { @@ -953,9 +970,17 @@ void memfmout( } else if (isspace(ch)) { if (column > 72) { /* Beyond 72 columns, break on the next space */ - client_write(outbuf, len); + if (client_write(outbuf, len) == -1) + { + syslog(LOG_ERR, "memfmout(): aborting due to write failure.\n"); + return; + } len = 0; - client_write(nl, nllen); + if (client_write(nl, nllen) == -1) + { + syslog(LOG_ERR, "memfmout(): aborting due to write failure.\n"); + return; + } column = 0; } else { @@ -967,15 +992,27 @@ void memfmout( outbuf[len++] = ch; ++column; if (column > 1000) { /* Beyond 1000 columns, break anywhere */ - client_write(outbuf, len); + if (client_write(outbuf, len) == -1) + { + syslog(LOG_ERR, "memfmout(): aborting due to write failure.\n"); + return; + } len = 0; - client_write(nl, nllen); + if (client_write(nl, nllen) == -1) + { + syslog(LOG_ERR, "memfmout(): aborting due to write failure.\n"); + return; + } column = 0; } } } if (len) { - client_write(outbuf, len); + if (client_write(outbuf, len) == -1) + { + syslog(LOG_ERR, "memfmout(): aborting due to write failure.\n"); + return; + } len = 0; client_write(nl, nllen); column = 0; @@ -1103,7 +1140,6 @@ void mime_spew_section(char *name, char *filename, char *partnum, char *disp, } - /* * Load a message from disk into memory. * This is used by CtdlOutputMsg() and other fetch functions. @@ -1120,8 +1156,7 @@ struct CtdlMessage *CtdlFetchMessage(long msgnum, int with_body) cit_uint8_t ch; cit_uint8_t field_header; - CtdlLogPrintf(CTDL_DEBUG, "CtdlFetchMessage(%ld, %d)\n", msgnum, with_body); - + syslog(LOG_DEBUG, "CtdlFetchMessage(%ld, %d)\n", msgnum, with_body); dmsgtext = cdb_fetch(CDB_MSGMAIN, &msgnum, sizeof(long)); if (dmsgtext == NULL) { return NULL; @@ -1136,7 +1171,7 @@ struct CtdlMessage *CtdlFetchMessage(long msgnum, int with_body) */ ch = *mptr++; if (ch != 255) { - CtdlLogPrintf(CTDL_ERR, "Message %ld appears to be corrupted.\n", msgnum); + syslog(LOG_ERR, "Message %ld appears to be corrupted.\n", msgnum); cdb_free(dmsgtext); return NULL; } @@ -1200,7 +1235,7 @@ int is_valid_message(struct CtdlMessage *msg) { if (msg == NULL) return 0; if ((msg->cm_magic) != CTDLMESSAGE_MAGIC) { - CtdlLogPrintf(CTDL_WARNING, "is_valid_message() -- self-check failed\n"); + syslog(LOG_WARNING, "is_valid_message() -- self-check failed\n"); return 0; } return 1; @@ -1247,7 +1282,7 @@ void fixed_output_pre(char *name, char *filename, char *partnum, char *disp, struct ma_info *ma; ma = (struct ma_info *)cbuserdata; - CtdlLogPrintf(CTDL_DEBUG, "fixed_output_pre() type=<%s>\n", cbtype); + syslog(LOG_DEBUG, "fixed_output_pre() type=<%s>\n", cbtype); if (!strcasecmp(cbtype, "multipart/alternative")) { ++ma->is_ma; ma->did_print = 0; @@ -1267,7 +1302,7 @@ void fixed_output_post(char *name, char *filename, char *partnum, char *disp, struct ma_info *ma; ma = (struct ma_info *)cbuserdata; - CtdlLogPrintf(CTDL_DEBUG, "fixed_output_post() type=<%s>\n", cbtype); + syslog(LOG_DEBUG, "fixed_output_post() type=<%s>\n", cbtype); if (!strcasecmp(cbtype, "multipart/alternative")) { --ma->is_ma; ma->did_print = 0; @@ -1291,7 +1326,7 @@ void fixed_output(char *name, char *filename, char *partnum, char *disp, ma = (struct ma_info *)cbuserdata; - CtdlLogPrintf(CTDL_DEBUG, + syslog(LOG_DEBUG, "fixed_output() part %s: %s (%s) (%ld bytes)\n", partnum, filename, cbtype, (long)length); @@ -1300,7 +1335,7 @@ void fixed_output(char *name, char *filename, char *partnum, char *disp, * we've already printed another section, skip this one. */ if ( (ma->is_ma) && (ma->did_print) ) { - CtdlLogPrintf(CTDL_DEBUG, "Skipping part %s (%s)\n", partnum, cbtype); + syslog(LOG_DEBUG, "Skipping part %s (%s)\n", partnum, cbtype); return; } ma->did_print = 1; @@ -1372,7 +1407,7 @@ void choose_preferred(char *name, char *filename, char *partnum, char *disp, extract_token(buf, CC->preferred_formats, i, '|', sizeof buf); if ( (!strcasecmp(buf, cbtype)) && (!ma->freeze) ) { if (i < ma->chosen_pref) { - CtdlLogPrintf(CTDL_DEBUG, "Setting chosen part: <%s>\n", partnum); + syslog(LOG_DEBUG, "Setting chosen part: <%s>\n", partnum); safestrncpy(ma->chosen_part, partnum, sizeof ma->chosen_part); ma->chosen_pref = i; } @@ -1383,16 +1418,27 @@ void choose_preferred(char *name, char *filename, char *partnum, char *disp, /* * Now that we've chosen our preferred part, output it. */ -void output_preferred(char *name, char *filename, char *partnum, char *disp, - void *content, char *cbtype, char *cbcharset, size_t length, - char *encoding, char *cbid, void *cbuserdata) +void output_preferred(char *name, + char *filename, + char *partnum, + char *disp, + void *content, + char *cbtype, + char *cbcharset, + size_t length, + char *encoding, + char *cbid, + void *cbuserdata) { int i; char buf[128]; int add_newline = 0; char *text_content; struct ma_info *ma; - + char *decoded = NULL; + size_t bytes_decoded; + int rc = 0; + ma = (struct ma_info *)cbuserdata; /* This is not the MIME part you're looking for... */ @@ -1405,8 +1451,21 @@ void output_preferred(char *name, char *filename, char *partnum, char *disp, extract_token(buf, CC->preferred_formats, i, '|', sizeof buf); if (!strcasecmp(buf, cbtype)) { /* Yeah! Go! W00t!! */ + if (ma->dont_decode == 0) + rc = mime_decode_now (content, + length, + encoding, + &decoded, + &bytes_decoded); + if (rc < 0) + break; /* Give us the chance, maybe theres another one. */ + + if (rc == 0) text_content = (char *)content; + else { + text_content = decoded; + length = bytes_decoded; + } - text_content = (char *)content; if (text_content[length-1] != '\n') { ++add_newline; } @@ -1424,16 +1483,38 @@ void output_preferred(char *name, char *filename, char *partnum, char *disp, } cprintf("X-Citadel-MSG4-Partnum: %s\n", partnum); cprintf("\n"); - client_write(content, length); + if (client_write(text_content, length) == -1) + { + syslog(LOG_ERR, "output_preferred(): aborting due to write failure.\n"); + return; + } if (add_newline) cprintf("\n"); + if (decoded != NULL) free(decoded); return; } } /* No translations required or possible: output as text/plain */ cprintf("Content-type: text/plain\n\n"); - fixed_output(name, filename, partnum, disp, content, cbtype, cbcharset, + rc = 0; + if (ma->dont_decode == 0) + rc = mime_decode_now (content, + length, + encoding, + &decoded, + &bytes_decoded); + if (rc < 0) + return; /* Give us the chance, maybe theres another one. */ + + if (rc == 0) text_content = (char *)content; + else { + text_content = decoded; + length = bytes_decoded; + } + + fixed_output(name, filename, partnum, disp, text_content, cbtype, cbcharset, length, encoding, cbid, cbuserdata); + if (decoded != NULL) free(decoded); } @@ -1462,16 +1543,52 @@ void extract_encapsulated_message(char *name, char *filename, char *partnum, cha memcpy(encap->msg, content, length); return; } - } +/* + * Determine whether the specified message exists in the cached_msglist + * (This is a security check) + */ +int check_cached_msglist(long msgnum) { + /* cases in which we skip the check */ + if (!CC) return om_ok; /* not a session */ + if (CC->client_socket <= 0) return om_ok; /* not a client session */ + if (CC->cached_msglist == NULL) return om_access_denied; /* no msglist fetched */ + if (CC->cached_num_msgs == 0) return om_access_denied; /* nothing to check */ + /* Do a binary search within the cached_msglist for the requested msgnum */ + int min = 0; + int max = (CC->cached_num_msgs - 1); + while (max >= min) { + int middle = min + (max-min) / 2 ; + if (msgnum == CC->cached_msglist[middle]) { + return om_ok; + } + if (msgnum > CC->cached_msglist[middle]) { + min = middle + 1; + } + else { + max = middle - 1; + } + } + + return om_access_denied; +} + + +/* + * Determine whether the currently logged in session has permission to read + * messages in the current room. + */ int CtdlDoIHavePermissionToReadMessagesInThisRoom(void) { - if ((!(CC->logged_in)) && (!(CC->internal_pgm))) { + if ( (!(CC->logged_in)) + && (!(CC->internal_pgm)) + && (!config.c_guest_logins) + ) { return(om_not_logged_in); } return(om_ok); @@ -1495,7 +1612,7 @@ int CtdlOutputMsg(long msg_num, /* message number (local) to fetch */ struct encapmsg encap; int r; - CtdlLogPrintf(CTDL_DEBUG, "CtdlOutputMsg(msgnum=%ld, mode=%d, section=%s)\n", + syslog(LOG_DEBUG, "CtdlOutputMsg(msgnum=%ld, mode=%d, section=%s)\n", msg_num, mode, (section ? section : "<>") ); @@ -1513,7 +1630,26 @@ int CtdlOutputMsg(long msg_num, /* message number (local) to fetch */ return(r); } - /* FIXME: check message id against msglist for this room */ + r = check_cached_msglist(msg_num); + if (r != om_ok) { + syslog(LOG_DEBUG, "\033[31m SECURITY CHECK FAIL \033[0m\n"); +/* + * FIXME enable this section when the security check yields no false positives + * + if (do_proto) { + if (r == om_access_denied) { + cprintf("%d Message %ld was not found in this room.\n", + ERROR + MESSAGE_NOT_FOUND, + msg_num + ); + } + else { + cprintf("%d An unknown error has occurred.\n", ERROR); + } + return(r); + } +*/ + } /* * Fetch the message from disk. If we're in HEADERS_FAST mode, @@ -1595,7 +1731,7 @@ char *qp_encode_email_addrs(char *source) if (source == NULL) return source; if (IsEmptyStr(source)) return source; cit_backtrace(); - CtdlLogPrintf(CTDL_DEBUG, "qp_encode_email_addrs: [%s]\n", source); + syslog(LOG_DEBUG, "qp_encode_email_addrs: [%s]\n", source); AddrPtr = malloc (sizeof (long) * nAddrPtrMax); AddrUtf8 = malloc (sizeof (long) * nAddrPtrMax); @@ -1891,6 +2027,9 @@ void OutputRFC822MsgHeaders( } } } + else if (i == 'K') { + cprintf("Reply-To: <%s>%s", mptr, nl); + } if (mptr != mpptr) free (mptr); } @@ -1915,6 +2054,7 @@ void Dump_RFC822HeadersBody( int outlen = 0; int nllen = strlen(nl); char *mptr; + int rc; mptr = TheMessage->cm_fields['M']; @@ -1965,12 +2105,16 @@ void Dump_RFC822HeadersBody( } ++mptr; if (outlen > 1000) { - client_write(outbuf, outlen); + if (client_write(outbuf, outlen) == -1) + { + syslog(LOG_ERR, "Dump_RFC822HeadersBody(): aborting due to write failure.\n"); + return; + } outlen = 0; } } if (outlen > 0) { - client_write(outbuf, outlen); + rc = client_write(outbuf, outlen); outlen = 0; } } @@ -2032,7 +2176,11 @@ void DumpFormatFixed( buflen += nllen; buf[buflen] = '\0'; - client_write(buf, buflen); + if (client_write(buf, buflen) == -1) + { + syslog(LOG_ERR, "DumpFormatFixed(): aborting due to write failure.\n"); + return; + } *buf = '\0'; buflen = 0; xlline = 0; @@ -2072,7 +2220,7 @@ int CtdlOutputPreLoadedMsg( char snode[100]; char mid[100]; - CtdlLogPrintf(CTDL_DEBUG, "CtdlOutputPreLoadedMsg(TheMessage=%s, %d, %d, %d, %d\n", + syslog(LOG_DEBUG, "CtdlOutputPreLoadedMsg(TheMessage=%s, %d, %d, %d, %d\n", ((TheMessage == NULL) ? "NULL" : "not null"), mode, headers_only, do_proto, crlf); @@ -2080,7 +2228,7 @@ int CtdlOutputPreLoadedMsg( nl = (crlf ? "\r\n" : "\n"); if (!is_valid_message(TheMessage)) { - CtdlLogPrintf(CTDL_ERR, + syslog(LOG_ERR, "ERROR: invalid preloaded message for output\n"); cit_backtrace (); return(om_no_such_msg); @@ -2236,7 +2384,7 @@ START_TEXT: (do_proto ? *list_this_part : NULL), (do_proto ? *list_this_pref : NULL), (do_proto ? *list_this_suff : NULL), - (void *)&ma, 0); + (void *)&ma, 1); } else if (mode == MT_RFC822) { /* unparsed RFC822 dump */ Dump_RFC822HeadersBody( @@ -2291,11 +2439,12 @@ START_TEXT: ma.use_fo_hooks = 0; strcpy(ma.chosen_part, "1"); ma.chosen_pref = 9999; + ma.dont_decode = CC->msg4_dont_decode; mime_parser(mptr, NULL, *choose_preferred, *fixed_output_pre, - *fixed_output_post, (void *)&ma, 0); + *fixed_output_post, (void *)&ma, 1); mime_parser(mptr, NULL, - *output_preferred, NULL, NULL, (void *)&ma, CC->msg4_dont_decode); + *output_preferred, NULL, NULL, (void *)&ma, 1); } else { ma.use_fo_hooks = 1; @@ -2473,7 +2622,7 @@ int CtdlSaveMsgPointersInRoom(char *roomname, long newmsgidlist[], int num_newms long *msgs_to_be_merged = NULL; int num_msgs_to_be_merged = 0; - CtdlLogPrintf(CTDL_DEBUG, + syslog(LOG_DEBUG, "CtdlSaveMsgPointersInRoom(room=%s, num_msgs=%d, repl=%d, suppress_rca=%d)\n", roomname, num_newmsgs, do_repl_check, suppress_refcount_adj ); @@ -2489,7 +2638,7 @@ int CtdlSaveMsgPointersInRoom(char *roomname, long newmsgidlist[], int num_newms if (CtdlGetRoomLock(&CC->room, ((roomname != NULL) ? roomname : CC->room.QRname) ) != 0) { - CtdlLogPrintf(CTDL_ERR, "No such room <%s>\n", roomname); + syslog(LOG_ERR, "No such room <%s>\n", roomname); return(ERROR + ROOM_NOT_FOUND); } @@ -2526,14 +2675,14 @@ int CtdlSaveMsgPointersInRoom(char *roomname, long newmsgidlist[], int num_newms } } - CtdlLogPrintf(9, "%d unique messages to be merged\n", num_msgs_to_be_merged); + syslog(LOG_DEBUG, "%d unique messages to be merged\n", num_msgs_to_be_merged); /* * Now merge the new messages */ msglist = realloc(msglist, (sizeof(long) * (num_msgs + num_msgs_to_be_merged)) ); if (msglist == NULL) { - CtdlLogPrintf(CTDL_ALERT, "ERROR: can't realloc message list!\n"); + syslog(LOG_ALERT, "ERROR: can't realloc message list!\n"); } memcpy(&msglist[num_msgs], msgs_to_be_merged, (sizeof(long) * num_msgs_to_be_merged) ); num_msgs += num_msgs_to_be_merged; @@ -2557,7 +2706,7 @@ int CtdlSaveMsgPointersInRoom(char *roomname, long newmsgidlist[], int num_newms /* Perform replication checks if necessary */ if ( (DoesThisRoomNeedEuidIndexing(&CC->room)) && (do_repl_check) ) { - CtdlLogPrintf(CTDL_DEBUG, "CtdlSaveMsgPointerInRoom() doing repl checks\n"); + syslog(LOG_DEBUG, "CtdlSaveMsgPointerInRoom() doing repl checks\n"); for (i=0; ilen = 0; ret->ser = NULL; return; @@ -2732,7 +2881,7 @@ void serialize_message(struct ser_ret *ret, /* return values */ ret->ser = malloc(ret->len); if (ret->ser == NULL) { - CtdlLogPrintf(CTDL_ERR, "serialize_message() malloc(%ld) failed: %s\n", + syslog(LOG_ERR, "serialize_message() malloc(%ld) failed: %s\n", (long)ret->len, strerror(errno)); ret->len = 0; ret->ser = NULL; @@ -2750,7 +2899,7 @@ void serialize_message(struct ser_ret *ret, /* return values */ safestrncpy((char *)&ret->ser[wlen], msg->cm_fields[(int)forder[i]], fieldlen+1); wlen = wlen + fieldlen + 1; } - if (ret->len != wlen) CtdlLogPrintf(CTDL_ERR, "ERROR: len=%ld wlen=%ld\n", + if (ret->len != wlen) syslog(LOG_ERR, "ERROR: len=%ld wlen=%ld\n", (long)ret->len, (long)wlen); return; @@ -2776,7 +2925,7 @@ void dump_message(struct CtdlMessage *msg, /* unserialized msg */ * Check for valid message format */ if (is_valid_message(msg) == 0) { - CtdlLogPrintf(CTDL_ERR, "dump_message() aborting due to invalid message\n"); + syslog(LOG_ERR, "dump_message() aborting due to invalid message\n"); return; } @@ -2787,7 +2936,11 @@ void dump_message(struct CtdlMessage *msg, /* unserialized msg */ for (i=0; i<26; ++i) if (msg->cm_fields[(int)forder[i]] != NULL) { snprintf (buf, Siz, " msg[%c] = %s ...\n", (char) forder[i], msg->cm_fields[(int)forder[i]]); - client_write (buf, strlen(buf)); + if (client_write (buf, strlen(buf)) == -1) + { + syslog(LOG_ERR, "dump_message(): aborting due to write failure.\n"); + return; + } } return; @@ -2804,19 +2957,19 @@ void ReplicationChecks(struct CtdlMessage *msg) { if (DoesThisRoomNeedEuidIndexing(&CC->room) == 0) return; - CtdlLogPrintf(CTDL_DEBUG, "Performing replication checks in <%s>\n", + syslog(LOG_DEBUG, "Performing replication checks in <%s>\n", CC->room.QRname); /* No exclusive id? Don't do anything. */ if (msg == NULL) return; if (msg->cm_fields['E'] == NULL) return; if (IsEmptyStr(msg->cm_fields['E'])) return; - /*CtdlLogPrintf(CTDL_DEBUG, "Exclusive ID: <%s> for room <%s>\n", + /*syslog(LOG_DEBUG, "Exclusive ID: <%s> for room <%s>\n", msg->cm_fields['E'], CC->room.QRname);*/ old_msgnum = CtdlLocateMessageByEuid(msg->cm_fields['E'], &CC->room); if (old_msgnum > 0L) { - CtdlLogPrintf(CTDL_DEBUG, "ReplicationChecks() replacing message %ld\n", old_msgnum); + syslog(LOG_DEBUG, "ReplicationChecks() replacing message %ld\n", old_msgnum); CtdlDeleteMessages(CC->room.QRname, &old_msgnum, 1, ""); } } @@ -2828,7 +2981,7 @@ void ReplicationChecks(struct CtdlMessage *msg) { */ long CtdlSubmitMsg(struct CtdlMessage *msg, /* message to save */ struct recptypes *recps, /* recipients (if mail) */ - char *force, /* force a particular room? */ + const char *force, /* force a particular room? */ int flags /* should the message be exported clean? */ ) { char submit_filename[128]; @@ -2854,12 +3007,12 @@ long CtdlSubmitMsg(struct CtdlMessage *msg, /* message to save */ struct addresses_to_be_filed *aptr = NULL; StrBuf *saved_rfc822_version = NULL; int qualified_for_journaling = 0; - CitContext *CCC = CC; /* CachedCitContext - performance boost */ + CitContext *CCC = MyContext(); char bounce_to[1024] = ""; size_t tmp = 0; int rv = 0; - CtdlLogPrintf(CTDL_DEBUG, "CtdlSubmitMsg() called\n"); + syslog(LOG_DEBUG, "CtdlSubmitMsg() called\n"); if (is_valid_message(msg) == 0) return(-1); /* self check */ /* If this message has no timestamp, we take the liberty of @@ -2895,7 +3048,7 @@ long CtdlSubmitMsg(struct CtdlMessage *msg, /* message to save */ /* Learn about what's inside, because it's what's inside that counts */ if (msg->cm_fields['M'] == NULL) { - CtdlLogPrintf(CTDL_ERR, "ERROR: attempt to save message with NULL body\n"); + syslog(LOG_ERR, "ERROR: attempt to save message with NULL body\n"); return(-2); } @@ -2927,7 +3080,7 @@ long CtdlSubmitMsg(struct CtdlMessage *msg, /* message to save */ } /* Goto the correct room */ - CtdlLogPrintf(CTDL_DEBUG, "Selected room %s\n", (recps) ? CCC->room.QRname : SENTITEMS); + syslog(LOG_DEBUG, "Selected room %s\n", (recps) ? CCC->room.QRname : SENTITEMS); strcpy(hold_rm, CCC->room.QRname); strcpy(actual_rm, CCC->room.QRname); if (recps != NULL) { @@ -2939,7 +3092,7 @@ long CtdlSubmitMsg(struct CtdlMessage *msg, /* message to save */ if (CCC->user.axlevel == AxProbU) { strcpy(hold_rm, actual_rm); strcpy(actual_rm, config.c_twitroom); - CtdlLogPrintf(CTDL_DEBUG, "Diverting to twit room\n"); + syslog(LOG_DEBUG, "Diverting to twit room\n"); } } @@ -2948,7 +3101,7 @@ long CtdlSubmitMsg(struct CtdlMessage *msg, /* message to save */ strcpy(actual_rm, force_room); } - CtdlLogPrintf(CTDL_DEBUG, "Final selection: %s\n", actual_rm); + syslog(LOG_DEBUG, "Final selection: %s\n", actual_rm); if (strcasecmp(actual_rm, CCC->room.QRname)) { /* CtdlGetRoom(&CCC->room, actual_rm); */ CtdlUserGoto(actual_rm, 0, 1, NULL, NULL); @@ -2962,7 +3115,7 @@ long CtdlSubmitMsg(struct CtdlMessage *msg, /* message to save */ } /* Perform "before save" hooks (aborting if any return nonzero) */ - CtdlLogPrintf(CTDL_DEBUG, "Performing before-save hooks\n"); + syslog(LOG_DEBUG, "Performing before-save hooks\n"); if (PerformMessageHooks(msg, EVT_BEFORESAVE) > 0) return(-3); /* @@ -2974,7 +3127,7 @@ long CtdlSubmitMsg(struct CtdlMessage *msg, /* message to save */ } /* Save it to disk */ - CtdlLogPrintf(CTDL_DEBUG, "Saving to disk\n"); + syslog(LOG_DEBUG, "Saving to disk\n"); newmsgid = send_message(msg); if (newmsgid <= 0L) return(-5); @@ -2982,7 +3135,7 @@ long CtdlSubmitMsg(struct CtdlMessage *msg, /* message to save */ * be a critical section because nobody else knows about this message * yet. */ - CtdlLogPrintf(CTDL_DEBUG, "Creating MetaData record\n"); + syslog(LOG_DEBUG, "Creating MetaData record\n"); memset(&smi, 0, sizeof(struct MetaData)); smi.meta_msgnum = newmsgid; smi.meta_refcount = 0; @@ -3000,7 +3153,7 @@ long CtdlSubmitMsg(struct CtdlMessage *msg, /* message to save */ * message to attach to the journalized copy. */ if (CCC->redirect_buffer != NULL) { - CtdlLogPrintf(CTDL_ALERT, "CCC->redirect_buffer is not NULL during message submission!\n"); + syslog(LOG_ALERT, "CCC->redirect_buffer is not NULL during message submission!\n"); abort(); } CCC->redirect_buffer = NewStrBufPlain(NULL, SIZ); @@ -3012,7 +3165,7 @@ long CtdlSubmitMsg(struct CtdlMessage *msg, /* message to save */ PutMetaData(&smi); /* Now figure out where to store the pointers */ - CtdlLogPrintf(CTDL_DEBUG, "Storing pointers\n"); + syslog(LOG_DEBUG, "Storing pointers\n"); /* If this is being done by the networker delivering a private * message, we want to BYPASS saving the sender's copy (because there @@ -3020,7 +3173,7 @@ long CtdlSubmitMsg(struct CtdlMessage *msg, /* message to save */ */ if ((!CCC->internal_pgm) || (recps == NULL)) { if (CtdlSaveMsgPointerInRoom(actual_rm, newmsgid, 1, msg) != 0) { - CtdlLogPrintf(CTDL_ERR, "ERROR saving message pointer!\n"); + syslog(LOG_ERR, "ERROR saving message pointer!\n"); CtdlSaveMsgPointerInRoom(config.c_aideroom, newmsgid, 0, msg); } } @@ -3035,12 +3188,12 @@ long CtdlSubmitMsg(struct CtdlMessage *msg, /* message to save */ for (i=0; irecp_room, '|'); ++i) { extract_token(recipient, recps->recp_room, i, '|', sizeof recipient); - CtdlLogPrintf(CTDL_DEBUG, "Delivering to room <%s>\n", recipient); + syslog(LOG_DEBUG, "Delivering to room <%s>\n", recipient); CtdlSaveMsgPointerInRoom(recipient, newmsgid, 0, msg); } /* Bump this user's messages posted counter. */ - CtdlLogPrintf(CTDL_DEBUG, "Updating user\n"); + syslog(LOG_DEBUG, "Updating user\n"); CtdlGetUserLock(&CCC->user, CCC->curr_user); CCC->user.posted = CCC->user.posted + 1; CtdlPutUserLock(&CCC->user); @@ -3063,7 +3216,7 @@ long CtdlSubmitMsg(struct CtdlMessage *msg, /* message to save */ for (i=0; irecp_local, '|'); ++i) { extract_token(recipient, recps->recp_local, i, '|', sizeof recipient); - CtdlLogPrintf(CTDL_DEBUG, "Delivering private local mail to <%s>\n", + syslog(LOG_DEBUG, "Delivering private local mail to <%s>\n", recipient); if (CtdlGetUser(&userbuf, recipient) == 0) { // Add a flag so the Funambol module knows its mail @@ -3098,14 +3251,14 @@ long CtdlSubmitMsg(struct CtdlMessage *msg, /* message to save */ } } else { - CtdlLogPrintf(CTDL_DEBUG, "No user <%s>\n", recipient); + syslog(LOG_DEBUG, "No user <%s>\n", recipient); CtdlSaveMsgPointerInRoom(config.c_aideroom, newmsgid, 0, msg); } } /* Perform "after save" hooks */ - CtdlLogPrintf(CTDL_DEBUG, "Performing after-save hooks\n"); + syslog(LOG_DEBUG, "Performing after-save hooks\n"); PerformMessageHooks(msg, EVT_AFTERSAVE); /* For IGnet mail, we have to save a new copy into the spooler for @@ -3149,7 +3302,7 @@ long CtdlSubmitMsg(struct CtdlMessage *msg, /* message to save */ } /* Go back to the room we started from */ - CtdlLogPrintf(CTDL_DEBUG, "Returning to original room %s\n", hold_rm); + syslog(LOG_DEBUG, "Returning to original room %s\n", hold_rm); if (strcasecmp(hold_rm, CCC->room.QRname)) CtdlUserGoto(hold_rm, 0, 1, NULL, NULL); @@ -3159,7 +3312,7 @@ long CtdlSubmitMsg(struct CtdlMessage *msg, /* message to save */ * contain a recipient. */ if ((recps != NULL) && (recps->num_internet > 0)) { - CtdlLogPrintf(CTDL_DEBUG, "Generating delivery instructions\n"); + syslog(LOG_DEBUG, "Generating delivery instructions\n"); instr_alloc = 1024; instr = malloc(instr_alloc); snprintf(instr, instr_alloc, @@ -3342,7 +3495,7 @@ StrBuf *CtdlReadMessageBodyBuf(char *terminator, /* token signalling EOT */ /* read in the lines of message text one by one */ do { if (sock != NULL) { - if ((CtdlSockGetLine(sock, LineBuf) < 0) || + if ((CtdlSockGetLine(sock, LineBuf, 5) < 0) || (*sock == -1)) finished = 1; } @@ -3380,6 +3533,170 @@ StrBuf *CtdlReadMessageBodyBuf(char *terminator, /* token signalling EOT */ return Message; } +void DeleteAsyncMsg(ReadAsyncMsg **Msg) +{ + if (*Msg == NULL) + return; + FreeStrBuf(&(*Msg)->MsgBuf); + + free(*Msg); + *Msg = NULL; +} + +ReadAsyncMsg *NewAsyncMsg(const char *terminator, /* token signalling EOT */ + long tlen, + size_t maxlen, /* maximum message length */ + size_t expectlen, /* if we expect a message, how long should it be? */ + char *exist, /* if non-null, append to it; + exist is ALWAYS freed */ + long eLen, /* length of exist */ + int crlf /* CRLF newlines instead of LF */ + ) +{ + ReadAsyncMsg *NewMsg; + + NewMsg = (ReadAsyncMsg *)malloc(sizeof(ReadAsyncMsg)); + memset(NewMsg, 0, sizeof(ReadAsyncMsg)); + + if (exist == NULL) { + long len; + + if (expectlen == 0) { + len = 4 * SIZ; + } + else { + len = expectlen + 10; + } + NewMsg->MsgBuf = NewStrBufPlain(NULL, len); + } + else { + NewMsg->MsgBuf = NewStrBufPlain(exist, eLen); + free(exist); + } + /* Do we need to change leading ".." to "." for SMTP escaping? */ + if ((tlen == 1) && (*terminator == '.')) { + NewMsg->dodot = 1; + } + + NewMsg->terminator = terminator; + NewMsg->tlen = tlen; + + NewMsg->maxlen = maxlen; + + NewMsg->crlf = crlf; + + return NewMsg; +} + +/* + * Back end function used by CtdlMakeMessage() and similar functions + */ +eReadState CtdlReadMessageBodyAsync(AsyncIO *IO) +{ + ReadAsyncMsg *ReadMsg; + int MsgFinished = 0; + eReadState Finished = eMustReadMore; + +#ifdef BIGBAD_IODBG + char fn [SIZ]; + FILE *fd; + const char *pch = ChrPtr(IO->SendBuf.Buf); + const char *pchh = IO->SendBuf.ReadWritePointer; + long nbytes; + + if (pchh == NULL) + pchh = pch; + + nbytes = StrLength(IO->SendBuf.Buf) - (pchh - pch); + snprintf(fn, SIZ, "/tmp/foolog_ev_%s.%d", + ((CitContext*)(IO->CitContext))->ServiceName, + IO->SendBuf.fd); + + fd = fopen(fn, "a+"); +#endif + + ReadMsg = IO->ReadMsg; + + /* read in the lines of message text one by one */ + do { + Finished = StrBufChunkSipLine(IO->IOBuf, &IO->RecvBuf); + + switch (Finished) { + case eMustReadMore: /// read new from socket... +#ifdef BIGBAD_IODBG + if (IO->RecvBuf.ReadWritePointer != NULL) { + nbytes = StrLength(IO->RecvBuf.Buf) - (IO->RecvBuf.ReadWritePointer - ChrPtr(IO->RecvBuf.Buf)); + fprintf(fd, "Read; Line unfinished: %ld Bytes still in buffer [", nbytes); + + fwrite(IO->RecvBuf.ReadWritePointer, nbytes, 1, fd); + + fprintf(fd, "]\n"); + } else { + fprintf(fd, "BufferEmpty! \n"); + } + fclose(fd); +#endif + return Finished; + break; + case eBufferNotEmpty: /* shouldn't happen... */ + case eReadSuccess: /// done for now... + break; + case eReadFail: /// WHUT? + ///todo: shut down! + break; + } + + + if ((StrLength(IO->IOBuf) == ReadMsg->tlen) && + (!strcmp(ChrPtr(IO->IOBuf), ReadMsg->terminator))) { + MsgFinished = 1; +#ifdef BIGBAD_IODBG + fprintf(fd, "found Terminator; Message Size: %d\n", StrLength(ReadMsg->MsgBuf)); +#endif + } + else if (!ReadMsg->flushing) { + +#ifdef BIGBAD_IODBG + fprintf(fd, "Read Line: [%d][%s]\n", StrLength(IO->IOBuf), ChrPtr(IO->IOBuf)); +#endif + + /* Unescape SMTP-style input of two dots at the beginning of the line */ + if ((ReadMsg->dodot) && + (StrLength(IO->IOBuf) == 2) && /* TODO: do we just unescape lines with two dots or any line? */ + (!strcmp(ChrPtr(IO->IOBuf), ".."))) + { +#ifdef BIGBAD_IODBG + fprintf(fd, "UnEscaped!\n"); +#endif + StrBufCutLeft(IO->IOBuf, 1); + } + + if (ReadMsg->crlf) { + StrBufAppendBufPlain(IO->IOBuf, HKEY("\r\n"), 0); + } + else { + StrBufAppendBufPlain(IO->IOBuf, HKEY("\n"), 0); + } + + StrBufAppendBuf(ReadMsg->MsgBuf, IO->IOBuf, 0); + } + + /* if we've hit the max msg length, flush the rest */ + if (StrLength(ReadMsg->MsgBuf) >= ReadMsg->maxlen) ReadMsg->flushing = 1; + + } while (!MsgFinished); + +#ifdef BIGBAD_IODBG + fprintf(fd, "Done with reading; %s.\n, ", + (MsgFinished)?"Message Finished": "FAILED"); + fclose(fd); +#endif + if (MsgFinished) + return eReadSuccess; + else + return eAbort; +} + /* * Back end function used by CtdlMakeMessage() and similar functions @@ -3433,6 +3750,8 @@ struct CtdlMessage *CtdlMakeMessage( char dest_node[256]; char buf[1024]; struct CtdlMessage *msg; + StrBuf *FakeAuthor; + StrBuf *FakeEncAuthor = NULL; msg = malloc(sizeof(struct CtdlMessage)); memset(msg, 0, sizeof(struct CtdlMessage)); @@ -3462,11 +3781,14 @@ struct CtdlMessage *CtdlMakeMessage( msg->cm_fields['T'] = strdup(buf); if ((fake_name != NULL) && (fake_name[0])) { /* author */ - msg->cm_fields['A'] = strdup(fake_name); + FakeAuthor = NewStrBufPlain (fake_name, -1); } else { - msg->cm_fields['A'] = strdup(author->fullname); + FakeAuthor = NewStrBufPlain (author->fullname, -1); } + StrBufRFC2047encode(&FakeEncAuthor, FakeAuthor); + msg->cm_fields['A'] = SmashStrBuf(&FakeEncAuthor); + FreeStrBuf(&FakeAuthor); if (CC->room.QRflags & QR_MAILBOX) { /* room */ msg->cm_fields['O'] = strdup(&CC->room.QRname[11]); @@ -3543,10 +3865,13 @@ struct CtdlMessage *CtdlMakeMessage( * room. Returns a *CITADEL ERROR CODE* and puts a message in errmsgbuf, or * returns 0 on success. */ -int CtdlDoIHavePermissionToPostInThisRoom(char *errmsgbuf, - size_t n, - const char* RemoteIdentifier, - int PostPublic) { +int CtdlDoIHavePermissionToPostInThisRoom( + char *errmsgbuf, + size_t n, + const char* RemoteIdentifier, + int PostPublic, + int is_reply +) { int ra; if (!(CC->logged_in) && @@ -3611,7 +3936,18 @@ int CtdlDoIHavePermissionToPostInThisRoom(char *errmsgbuf, } CtdlRoomAccess(&CC->room, &CC->user, &ra, NULL); - if (!(ra & UA_POSTALLOWED)) { + + if ( (!(ra & UA_POSTALLOWED)) && (ra & UA_REPLYALLOWED) && (!is_reply) ) { + /* + * To be thorough, we ought to check to see if the message they are + * replying to is actually a valid one in this room, but unless this + * actually becomes a problem we'll go with high performance instead. + */ + snprintf(errmsgbuf, n, "You may only reply to existing messages here."); + return (ERROR + HIGHER_ACCESS_REQUIRED); + } + + else if (!(ra & UA_POSTALLOWED)) { snprintf(errmsgbuf, n, "Higher access is required to post in this room."); return (ERROR + HIGHER_ACCESS_REQUIRED); } @@ -3736,7 +4072,7 @@ struct recptypes *validate_recipients(const char *supplied_recipients, striplt(this_recp); if (IsEmptyStr(this_recp)) break; - CtdlLogPrintf(CTDL_DEBUG, "Evaluating recipient #%d: %s\n", num_recps, this_recp); + syslog(LOG_DEBUG, "Evaluating recipient #%d: %s\n", num_recps, this_recp); ++num_recps; mailtype = alias(this_recp); mailtype = alias(this_recp); @@ -3771,10 +4107,12 @@ struct recptypes *validate_recipients(const char *supplied_recipients, CC->room = tempQR; /* Check permissions to send mail to this room */ - err = CtdlDoIHavePermissionToPostInThisRoom(errmsg, - sizeof errmsg, - RemoteIdentifier, - Flags + err = CtdlDoIHavePermissionToPostInThisRoom( + errmsg, + sizeof errmsg, + RemoteIdentifier, + Flags, + 0 /* 0 = not a reply */ ); if (err) { @@ -3878,12 +4216,12 @@ struct recptypes *validate_recipients(const char *supplied_recipients, strcpy(ret->errormsg, "No recipients specified."); } - CtdlLogPrintf(CTDL_DEBUG, "validate_recipients()\n"); - CtdlLogPrintf(CTDL_DEBUG, " local: %d <%s>\n", ret->num_local, ret->recp_local); - CtdlLogPrintf(CTDL_DEBUG, " room: %d <%s>\n", ret->num_room, ret->recp_room); - CtdlLogPrintf(CTDL_DEBUG, " inet: %d <%s>\n", ret->num_internet, ret->recp_internet); - CtdlLogPrintf(CTDL_DEBUG, " ignet: %d <%s>\n", ret->num_ignet, ret->recp_ignet); - CtdlLogPrintf(CTDL_DEBUG, " error: %d <%s>\n", ret->num_error, ret->errormsg); + syslog(LOG_DEBUG, "validate_recipients()\n"); + syslog(LOG_DEBUG, " local: %d <%s>\n", ret->num_local, ret->recp_local); + syslog(LOG_DEBUG, " room: %d <%s>\n", ret->num_room, ret->recp_room); + syslog(LOG_DEBUG, " inet: %d <%s>\n", ret->num_internet, ret->recp_internet); + syslog(LOG_DEBUG, " ignet: %d <%s>\n", ret->num_ignet, ret->recp_ignet); + syslog(LOG_DEBUG, " error: %d <%s>\n", ret->num_error, ret->errormsg); free(recipients); return(ret); @@ -3900,7 +4238,7 @@ void free_recipients(struct recptypes *valid) { } if (valid->recptypes_magic != RECPTYPES_MAGIC) { - CtdlLogPrintf(CTDL_EMERG, "Attempt to call free_recipients() on some other data type!\n"); + syslog(LOG_EMERG, "Attempt to call free_recipients() on some other data type!\n"); abort(); } @@ -3977,7 +4315,13 @@ void cmd_ent0(char *entargs) /* first check to make sure the request is valid. */ - err = CtdlDoIHavePermissionToPostInThisRoom(errmsg, sizeof errmsg, NULL, POST_LOGGED_IN); + err = CtdlDoIHavePermissionToPostInThisRoom( + errmsg, + sizeof errmsg, + NULL, + POST_LOGGED_IN, + (!IsEmptyStr(references)) /* is this a reply? or a top-level post? */ + ); if (err) { cprintf("%d %s\n", err, errmsg); @@ -4033,12 +4377,13 @@ void cmd_ent0(char *entargs) /* In mailbox rooms we have to behave a little differently -- * make sure the user has specified at least one recipient. Then * validate the recipient(s). We do this for the Mail> room, as - * well as any room which has the "Mailbox" view set. + * well as any room which has the "Mailbox" view set - unless it + * is the DRAFTS room which does not require recipients */ - if ( ( (CC->room.QRflags & QR_MAILBOX) && (!strcasecmp(&CC->room.QRname[11], MAILROOM)) ) - || ( (CC->room.QRflags & QR_MAILBOX) && (CC->curr_view == VIEW_MAILBOX) ) - ) { + if ( ( ( (CC->room.QRflags & QR_MAILBOX) && (!strcasecmp(&CC->room.QRname[11], MAILROOM)) ) + || ( (CC->room.QRflags & QR_MAILBOX) && (CC->curr_view == VIEW_MAILBOX) ) + ) && (strcasecmp(&CC->room.QRname[11], USERDRAFTROOM)) !=0 ) { if (CC->user.axlevel < AxProbU) { strcpy(recp, "sysop"); strcpy(cc, ""); @@ -4250,12 +4595,12 @@ int CtdlDeleteMessages(char *room_name, /* which room */ regcomp(&re, content_type, 0); need_to_free_re = 1; } - CtdlLogPrintf(CTDL_DEBUG, "CtdlDeleteMessages(%s, %d msgs, %s)\n", + syslog(LOG_DEBUG, "CtdlDeleteMessages(%s, %d msgs, %s)\n", room_name, num_dmsgnums, content_type); /* get room record, obtaining a lock... */ if (CtdlGetRoomLock(&qrbuf, room_name) != 0) { - CtdlLogPrintf(CTDL_ERR, "CtdlDeleteMessages(): Room <%s> not found\n", + syslog(LOG_ERR, "CtdlDeleteMessages(): Room <%s> not found\n", room_name); if (need_to_free_re) regfree(&re); return (0); /* room not found */ @@ -4332,7 +4677,7 @@ int CtdlDeleteMessages(char *room_name, /* which room */ /* Now free the memory we used, and go away. */ if (msglist != NULL) free(msglist); if (dellist != NULL) free(dellist); - CtdlLogPrintf(CTDL_DEBUG, "%d message(s) deleted.\n", num_deleted); + syslog(LOG_DEBUG, "%d message(s) deleted.\n", num_deleted); if (need_to_free_re) regfree(&re); return (num_deleted); } @@ -4566,7 +4911,7 @@ void AdjRefCount(long msgnum, int incr) struct arcq new_arcq; int rv = 0; - CtdlLogPrintf(CTDL_DEBUG, "AdjRefCount() msg %ld ref count delta %+d\n", + syslog(LOG_DEBUG, "AdjRefCount() msg %ld ref count delta %+d\n", msgnum, incr ); @@ -4578,7 +4923,7 @@ void AdjRefCount(long msgnum, int incr) /* msgnum < 0 means that we're trying to close the file */ if (msgnum < 0) { - CtdlLogPrintf(CTDL_DEBUG, "Closing the AdjRefCount queue file\n"); + syslog(LOG_DEBUG, "Closing the AdjRefCount queue file\n"); begin_critical_section(S_SUPPMSGMAIN); if (arcfp != NULL) { fclose(arcfp); @@ -4630,7 +4975,7 @@ int TDAP_ProcessAdjRefCountQueue(void) r = link(file_arcq, file_arcq_temp); if (r != 0) { - CtdlLogPrintf(CTDL_CRIT, "%s: %s\n", file_arcq_temp, strerror(errno)); + syslog(LOG_CRIT, "%s: %s\n", file_arcq_temp, strerror(errno)); end_critical_section(S_SUPPMSGMAIN); return(num_records_processed); } @@ -4640,7 +4985,7 @@ int TDAP_ProcessAdjRefCountQueue(void) fp = fopen(file_arcq_temp, "rb"); if (fp == NULL) { - CtdlLogPrintf(CTDL_CRIT, "%s: %s\n", file_arcq_temp, strerror(errno)); + syslog(LOG_CRIT, "%s: %s\n", file_arcq_temp, strerror(errno)); return(num_records_processed); } @@ -4652,7 +4997,7 @@ int TDAP_ProcessAdjRefCountQueue(void) fclose(fp); r = unlink(file_arcq_temp); if (r != 0) { - CtdlLogPrintf(CTDL_CRIT, "%s: %s\n", file_arcq_temp, strerror(errno)); + syslog(LOG_CRIT, "%s: %s\n", file_arcq_temp, strerror(errno)); } return(num_records_processed); @@ -4683,7 +5028,7 @@ void TDAP_AdjRefCount(long msgnum, int incr) smi.meta_refcount += incr; PutMetaData(&smi); end_critical_section(S_SUPPMSGMAIN); - CtdlLogPrintf(CTDL_DEBUG, "TDAP_AdjRefCount() msg %ld ref count delta %+d, is now %d\n", + syslog(LOG_DEBUG, "TDAP_AdjRefCount() msg %ld ref count delta %+d, is now %d\n", msgnum, incr, smi.meta_refcount ); @@ -4691,7 +5036,7 @@ void TDAP_AdjRefCount(long msgnum, int incr) * (and its supplementary record as well). */ if (smi.meta_refcount == 0) { - CtdlLogPrintf(CTDL_DEBUG, "Deleting message <%ld>\n", msgnum); + syslog(LOG_DEBUG, "Deleting message <%ld>\n", msgnum); /* Call delete hooks with NULL room to show it has gone altogether */ PerformDeleteHooks(NULL, msgnum); @@ -4737,7 +5082,7 @@ void CtdlWriteObject(char *req_room, /* Room to stuff it in */ safestrncpy(roomname, req_room, sizeof(roomname)); } - CtdlLogPrintf(CTDL_DEBUG, "Raw length is %ld\n", (long)raw_length); + syslog(LOG_DEBUG, "Raw length is %ld\n", (long)raw_length); if (is_binary) { encoded_message = malloc((size_t) (((raw_length * 134) / 100) + 4096 ) ); @@ -4775,7 +5120,7 @@ void CtdlWriteObject(char *req_room, /* Room to stuff it in */ ); } - CtdlLogPrintf(CTDL_DEBUG, "Allocating\n"); + syslog(LOG_DEBUG, "Allocating\n"); msg = malloc(sizeof(struct CtdlMessage)); memset(msg, 0, sizeof(struct CtdlMessage)); msg->cm_magic = CTDLMESSAGE_MAGIC; @@ -4799,7 +5144,7 @@ void CtdlWriteObject(char *req_room, /* Room to stuff it in */ * other objects of this type that are currently in the room. */ if (is_unique) { - CtdlLogPrintf(CTDL_DEBUG, "Deleted %d other msgs of this type\n", + syslog(LOG_DEBUG, "Deleted %d other msgs of this type\n", CtdlDeleteMessages(roomname, NULL, 0, content_type) ); } @@ -4940,5 +5285,5 @@ CTDL_MODULE_INIT(msgbase) } /* return our Subversion id for the Log */ - return "$Id$"; + return "msgbase"; }