X-Git-Url: https://code.citadel.org/?a=blobdiff_plain;f=citadel%2Fserver_main.c;h=592ea7708bbc620f518e10eb21af59406b86642d;hb=a793d2fbf5e0aa9151490b76defd22f6db7ef7ed;hp=cc45704669cc60f80dafb8300bb0c5e57b007ff6;hpb=7716f155f4145d83b6acfe6157599e6a9ee04608;p=citadel.git

diff --git a/citadel/server_main.c b/citadel/server_main.c
index cc4570466..592ea7708 100644
--- a/citadel/server_main.c
+++ b/citadel/server_main.c
@@ -1,21 +1,15 @@
 /*
  * citserver's main() function lives here.
  * 
- * Copyright (c) 1987-2011 by the citadel.org team
+ * Copyright (c) 1987-2012 by the citadel.org team
  *
  * This program is open source software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 3 of the License, or
- * (at your option) any later version.
+ * it under the terms of the GNU General Public License version 3.
  *
  * This program is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
  */
 
 #include "sysdep.h"
@@ -100,11 +94,9 @@ int main(int argc, char **argv)
 	struct passwd pw, *pwp = NULL;
 	char pwbuf[SIZ];
 	int drop_root_perms = 1;
-	size_t size;
 	int relh=0;
 	int home=0;
 	int dbg=0;
-	int have_log=0;
 	char relhome[PATH_MAX]="";
 	char ctdldir[PATH_MAX]=CTDLDIR;
 	int syslog_facility = LOG_DAEMON;
@@ -116,13 +108,9 @@ int main(int argc, char **argv)
 //	eCrashSymbolTable symbol_table;
 #endif
 
-	/* initialise semaphores here. Patch by Matt and davew
-	 * its called here as they are needed by syslog for thread safety
-	 */
-	InitialiseSemaphores();
-	
 	/* initialize the master context */
 	InitializeMasterCC();
+	InitializeMasterTSD();
 
 	/* parse command-line arguments */
 	for (a=1; a<argc; ++a) {
@@ -139,11 +127,12 @@ int main(int argc, char **argv)
 
 		else if (!strncmp(argv[a], "-h", 2)) {
 			relh=argv[a][2]!='/';
-			if (!relh) safestrncpy(ctdl_home_directory, &argv[a][2],
-								   sizeof ctdl_home_directory);
-			else
-				safestrncpy(relhome, &argv[a][2],
-							sizeof relhome);
+			if (!relh) {
+				safestrncpy(ctdl_home_directory, &argv[a][2], sizeof ctdl_home_directory);
+			}
+			else {
+				safestrncpy(relhome, &argv[a][2], sizeof relhome);
+			}
 			home=1;
 		}
 
@@ -152,15 +141,7 @@ int main(int argc, char **argv)
 		}
 
 		else if (!strncmp(argv[a], "-t", 2)) {
-			if (freopen(&argv[a][2], "w", stderr) != stderr)
-			{
-				syslog(LOG_EMERG, 
-					      "unable to open your trace log [%s]: %s", 
-					      &argv[a][2], 
-					      strerror(errno));
-				exit(1);
-			}
-			have_log = 1;
+			/* deprecated */
 		}
 
 		else if (!strncmp(argv[a], "-D", 2)) {
@@ -170,8 +151,9 @@ int main(int argc, char **argv)
 		/* -r tells the server not to drop root permissions. don't use
 		 * this unless you know what you're doing. this should be
 		 * removed in the next release if it proves unnecessary. */
-		else if (!strcmp(argv[a], "-r"))
+		else if (!strcmp(argv[a], "-r")) {
 			drop_root_perms = 0;
+		}
 
 		/* any other parameter makes it crash and burn */
 		else {
@@ -179,7 +161,6 @@ int main(int argc, char **argv)
 					"citserver "
 					"[-lLogFacility] "
 					"[-d] [-D] [-s] "
-					"[-tTraceFile] "
 					"[-hHomeDir]\n"
 			);
 			exit(1);
@@ -216,25 +197,25 @@ int main(int argc, char **argv)
 #endif
 
 	/* Tell 'em who's in da house */
-	syslog(LOG_NOTICE, "\n");
-	syslog(LOG_NOTICE, "\n");
+	syslog(LOG_NOTICE, " ");
+	syslog(LOG_NOTICE, " ");
 	syslog(LOG_NOTICE,
-		"*** Citadel server engine v%d.%02d (build %s) ***\n",
+		"*** Citadel server engine v%d.%02d (build %s) ***",
 		(REV_LEVEL/100), (REV_LEVEL%100), svn_revision());
-	syslog(LOG_NOTICE, "Copyright (C) 1987-2010 by the Citadel development team.\n");
+	syslog(LOG_NOTICE, "Copyright (C) 1987-2012 by the Citadel development team.");
 	syslog(LOG_NOTICE, "This program is distributed under the terms of the GNU "
-					"General Public License.\n");
-	syslog(LOG_NOTICE, "\n");
-	syslog(LOG_DEBUG, "Called as: %s\n", argv[0]);
-	syslog(LOG_INFO, "%s\n", libcitadel_version_string());
+					"General Public License.");
+	syslog(LOG_NOTICE, " ");
+	syslog(LOG_DEBUG, "Called as: %s", argv[0]);
+	syslog(LOG_INFO, "%s", libcitadel_version_string());
 
 	/* Load site-specific parameters, and set the ipgm secret */
-	syslog(LOG_INFO, "Loading citadel.config\n");
+	syslog(LOG_INFO, "Loading citadel.config");
 	get_config();
 	config.c_ipgm_secret = rand();
 
 	/* get_control() MUST MUST MUST be called BEFORE the databases are opened!! */
-	syslog(LOG_INFO, "Acquiring control record\n");
+	syslog(LOG_INFO, "Acquiring control record");
 	get_control();
 
 	put_config();
@@ -283,18 +264,18 @@ int main(int argc, char **argv)
 	/*
 	 * Run any upgrade entry points
 	 */
-	syslog(LOG_INFO, "Upgrading modules.\n");
+	syslog(LOG_INFO, "Upgrading modules.");
 	upgrade_modules();
 	
-/**
+/*
  * Load the user for the masterCC or create them if they don't exist
  */
 	if (CtdlGetUser(&masterCC.user, "SYS_Citadel"))
 	{
-		/** User doesn't exist. We can't use create user here as the user number needs to be 0 */
+		/* User doesn't exist. We can't use create user here as the user number needs to be 0 */
 		strcpy (masterCC.user.fullname, "SYS_Citadel") ;
 		CtdlPutUser(&masterCC.user);
-		CtdlGetUser(&masterCC.user, "SYS_Citadel"); /** Just to be safe */
+		CtdlGetUser(&masterCC.user, "SYS_Citadel"); /* Just to be safe */
 	}
 	
 	/*
@@ -323,12 +304,9 @@ int main(int argc, char **argv)
 	/*
 	 * Load any server-side extensions available here.
 	 */
-	syslog(LOG_INFO, "Initializing server extensions\n");
-	size = strlen(ctdl_home_directory) + 9;
+	syslog(LOG_INFO, "Initializing server extensions");
 	
 	initialise_modules(0);
-	
-	
 
 	/*
 	 * If we need host auth, start our chkpwd daemon.
@@ -363,18 +341,18 @@ int main(int argc, char **argv)
 #endif // HAVE_GETPWUID_R
 
 		if (pwp == NULL)
-			syslog(LOG_CRIT, "WARNING: getpwuid(%ld): %s\n"
+			syslog(LOG_CRIT, "WARNING: getpwuid(%ld): %s"
 				   "Group IDs will be incorrect.\n", (long)CTDLUID,
 				strerror(errno));
 		else {
 			initgroups(pw.pw_name, pw.pw_gid);
 			if (setgid(pw.pw_gid))
-				syslog(LOG_CRIT, "setgid(%ld): %s\n", (long)pw.pw_gid,
+				syslog(LOG_CRIT, "setgid(%ld): %s", (long)pw.pw_gid,
 					strerror(errno));
 		}
-		syslog(LOG_INFO, "Changing uid to %ld\n", (long)CTDLUID);
+		syslog(LOG_INFO, "Changing uid to %ld", (long)CTDLUID);
 		if (setuid(CTDLUID) != 0) {
-			syslog(LOG_CRIT, "setuid() failed: %s\n", strerror(errno));
+			syslog(LOG_CRIT, "setuid() failed: %s", strerror(errno));
 		}
 #if defined (HAVE_SYS_PRCTL_H) && defined (PR_SET_DUMPABLE)
 		prctl(PR_SET_DUMPABLE, 1);