X-Git-Url: https://code.citadel.org/?a=blobdiff_plain;f=webcit%2Fbbsview_renderer.c;h=8bed3af37ddae02e57728da12e16119607de7b82;hb=4b4dc864ede7c5d8d956febe4a0afb422b78e7c4;hp=7ed776e01472a69ddaf2f0e3a34703d372465878;hpb=17ce76a935cdbd2e2fda4a6ee1680e603413eb0c;p=citadel.git

diff --git a/webcit/bbsview_renderer.c b/webcit/bbsview_renderer.c
index 7ed776e01..8bed3af37 100644
--- a/webcit/bbsview_renderer.c
+++ b/webcit/bbsview_renderer.c
@@ -6,7 +6,7 @@
  * with it, go get commit dcf99fe61379b78436c387ea3f89ebfd4ffaf635 of
  * bbsview_renderer.c and have fun.
  *
- * Copyright (c) 1996-2010 by the citadel.org team
+ * Copyright (c) 1996-2011 by the citadel.org team
  *
  * This program is open source software.  You can redistribute it and/or
  * modify it under the terms of the GNU General Public License as
@@ -27,7 +27,7 @@
 
 #include "webcit.h"
 #include "webserver.h"
-#include "groupdav.h"
+#include "dav.h"
 
 /*
  * Data which gets passed around between the various functions in this module
@@ -55,13 +55,15 @@ long bbsview_get_last_seen(void)
 	serv_puts("GTSN");
 	serv_getln(buf, sizeof buf);
 	if (buf[0] == '2') {
+		char *colon_pos;
+		char *comma_pos;
 
-		char *comma_pos = strchr(buf, ',');	/* kill first comma and everything to its right */
+		comma_pos = strchr(buf, ',');	/* kill first comma and everything to its right */
 		if (comma_pos) {
 			*comma_pos = 0;
 		}
 
-		char *colon_pos = strchr(buf, ':');	/* kill first colon and everything to its left */
+		colon_pos = strchr(buf, ':');	/* kill first colon and everything to its left */
 		if (colon_pos) {
 			strcpy(buf, ++colon_pos);
 		}
@@ -79,7 +81,9 @@ int bbsview_GetParamsGetServerCall(SharedMessageStatus *Stat,
 				   void **ViewSpecific, 
 				   long oper, 
 				   char *cmd, 
-				   long len)
+				   long len,
+				   char *filter,
+				   long flen)
 {
 	struct bbsview *BBS = malloc(sizeof(struct bbsview));
 	memset(BBS, 0, sizeof(struct bbsview));
@@ -179,9 +183,10 @@ int bbsview_RenderView_or_Tail(SharedMessageStatus *Stat,
 	const StrBuf *Mime;
 	int start_index = 0;
 	int end_index = 0;
+	int go_to_the_very_end = 0;
 
 	if (Stat->nummsgs > 0) {
-		lprintf(9, "sorting %d messages\n", BBS->num_msgs);
+		syslog(9, "sorting %d messages\n", BBS->num_msgs);
 		qsort(BBS->msgs, (size_t)(BBS->num_msgs), sizeof(long), bbsview_sortfunc);
 	}
 
@@ -218,9 +223,26 @@ int bbsview_RenderView_or_Tail(SharedMessageStatus *Stat,
 	 */
 	if (BBS->requested_page == (-3)) {
 		if (BBS->num_msgs == 0) {
+			/*
+			 * The room is empty; just start at the top and leave it there.
+			 */
 			BBS->requested_page = 0;
 		}
+		else if (
+			(BBS->num_msgs > 0) 
+			&& (BBS->lastseen <= BBS->msgs[0])
+		) {
+			/*
+			 * All messages are new; this is probably the user's first visit to the room,
+			 * so start at the last page instead of showing ancient history.
+			 */
+			BBS->requested_page = BBS->num_pages - 1;
+			go_to_the_very_end = 1;
+		}
 		else {
+			/*
+			 * Some messages are old and some are new.  Go to the start of new messages.
+			 */
 			for (i=0; i<BBS->num_msgs; ++i) {
 				if (
 					(BBS->msgs[i] > BBS->lastseen)
@@ -263,8 +285,10 @@ int bbsview_RenderView_or_Tail(SharedMessageStatus *Stat,
 					&& ( (i == 0) || (BBS->msgs[i-1] <= BBS->lastseen) )
 				) {
 					/* new messages start here */
-					do_template("start_of_new_msgs", NULL);
-					StrBufAppendPrintf(WC->trailing_javascript, "location.href=\"#newmsgs\";\n");
+					do_template("start_of_new_msgs");
+					if (!go_to_the_very_end) {
+						StrBufAppendPrintf(WC->trailing_javascript, "location.href=\"#newmsgs\";\n");
+					}
 				}
 				if (BBS->msgs[i] > 0L) {
 					read_message(WC->WBuf, HKEY("view_message"), BBS->msgs[i], NULL, &Mime);
@@ -274,20 +298,30 @@ int bbsview_RenderView_or_Tail(SharedMessageStatus *Stat,
 					&& (BBS->msgs[i] <= BBS->lastseen)
 				) {
 					/* no new messages */
-					do_template("no_new_msgs", NULL);
-					StrBufAppendPrintf(WC->trailing_javascript, "location.href=\"#nonewmsgs\";\n");
+					do_template("no_new_msgs");
+					if (!go_to_the_very_end) {
+						StrBufAppendPrintf(WC->trailing_javascript, "location.href=\"#nonewmsgs\";\n");
+					}
 				}
 			}
 		}
 
 		else if ( (seq == 0) || (seq == 2) ) {
+			int first;
+			int last;
 			/* Display the selecto-bar with the page numbers */
 
 			wc_printf("<div class=\"moreprompt\">");
+			if (seq == 2) {
+				wc_printf("<a name=\"end_of_msgs\">");
+			}
 			wc_printf(_("Go to page: "));
+			if (seq == 2) {
+				wc_printf("</a>");
+			}
 
-			int first = 0;
-			int last = BBS->num_pages - 1;
+			first = 0;
+			last = BBS->num_pages - 1;
 
 			for (i=0; i<=last; ++i) {
 
@@ -311,7 +345,12 @@ int bbsview_RenderView_or_Tail(SharedMessageStatus *Stat,
 						wc_printf("[");
 					}
 					else {
-						wc_printf("<a href=\"readfwd?page=%d\">", i);
+						wc_printf("<a href=\"readfwd?go=");
+						urlescputs(ChrPtr(WC->CurRoom.name));
+						wc_printf("?start_reading_at=%ld\">",
+							BBS->msgs[i*Stat->maxmsgs]
+						);
+						/* wc_printf("?page=%d\">", i); */
 						wc_printf("<span class=\"moreprompt_link\">");
 					}
 					if (
@@ -327,7 +366,7 @@ int bbsview_RenderView_or_Tail(SharedMessageStatus *Stat,
 						wc_printf(_("Last"));
 					}
 					else {
-						wc_printf("%d", i + 1);	// change to one-based for display
+						wc_printf("%d", i + 1);	/* change to one-based for display */
 					}
 					if (i == BBS->requested_page) {
 						wc_printf("]");
@@ -351,6 +390,9 @@ int bbsview_RenderView_or_Tail(SharedMessageStatus *Stat,
 		}
 	}
 
+	if (go_to_the_very_end) {
+		StrBufAppendPrintf(WC->trailing_javascript, "location.href=\"#end_of_msgs\";\n");
+	}
 	return(0);
 }
 
@@ -377,6 +419,7 @@ InitModule_BBSVIEWRENDERERS
 		VIEW_BBS,
 		bbsview_GetParamsGetServerCall,
 		NULL,
+		NULL,
 		NULL, 
 		bbsview_LoadMsgFromServer,
 		bbsview_RenderView_or_Tail,