From: Wilfried Göesgens <willi@citadel.org>
Date: Tue, 14 Aug 2007 16:17:40 +0000 (+0000)
Subject: * don't copy / lowercase more of the string than we need to.
X-Git-Tag: v7.86~3149
X-Git-Url: https://code.citadel.org/?a=commitdiff_plain;ds=sidebyside;h=5fa1c020b9096a490f97a0ff6df787ad84ed5c53;p=citadel.git

* don't copy / lowercase more of the string than we need to.
* go with direct pointers
---

diff --git a/citadel/room_ops.c b/citadel/room_ops.c
index fb3229a34..3cfd2af32 100644
--- a/citadel/room_ops.c
+++ b/citadel/room_ops.c
@@ -225,12 +225,16 @@ int getroom(struct ctdlroom *qrbuf, char *room_name)
 	struct cdbdata *cdbqr;
 	char lowercase_name[ROOMNAMELEN];
 	char personal_lowercase_name[ROOMNAMELEN];
-	int a;
+	char *dptr, *sptr, *eptr;
 
-	for (a = 0; room_name[a] && a < sizeof lowercase_name - 1; ++a) {
-		lowercase_name[a] = tolower(room_name[a]);
+	dptr = lowercase_name;
+	sptr = room_name;
+	eptr = (dptr + (sizeof lowercase_name - 1));
+	while (!IsEmptyStr(sptr) && (dptr < eptr)){
+		*dptr = tolower(*sptr);
+		sptr++; dptr++;
 	}
-	lowercase_name[a] = 0;
+	*dptr = '\0';
 
 	memset(qrbuf, 0, sizeof(struct ctdlroom));