From: Wilfried Goesgens <willi@arangodb.com>
Date: Sun, 11 Oct 2015 21:26:26 +0000 (+0200)
Subject: fix buffer overrun
X-Git-Tag: Release_902~153
X-Git-Url: https://code.citadel.org/?a=commitdiff_plain;h=06c40d5e06abb1b587c5062ed0b0b8ea5203c5b9;hp=d574d7121215c86414c12503d22bf9df286816db;p=citadel.git

fix buffer overrun
---

diff --git a/webcit/msg_renderers.c b/webcit/msg_renderers.c
index ec0ebd1b7..5bfc364e5 100644
--- a/webcit/msg_renderers.c
+++ b/webcit/msg_renderers.c
@@ -623,8 +623,9 @@ void render_MIME_VCard(StrBuf *Target, WCTemplputParams *TP, StrBuf *FoundCharse
 		Buf = NewStrBuf();
 		/** If it's my vCard I can edit it */
 		if (	(!strcasecmp(ChrPtr(WCC->CurRoom.name), USERCONFIGROOM))
-			|| (!strcasecmp(&(ChrPtr(WCC->CurRoom.name)[11]), USERCONFIGROOM))
-			|| (WC->CurRoom.view == VIEW_ADDRESSBOOK)
+			|| ((StrLength(WCC->CurRoom.name) > 11) &&
+			    (!strcasecmp(&(ChrPtr(WCC->CurRoom.name)[11]), USERCONFIGROOM)))
+			|| (WCC->CurRoom.view == VIEW_ADDRESSBOOK)
 			) {
 			StrBufAppendPrintf(Buf, "<a href=\"edit_vcard?msgnum=%ld?partnum=%s\">",
 				Mime->msgnum, ChrPtr(Mime->PartNum));