From: Wilfried Göesgens <willi@citadel.org>
Date: Sat, 22 May 2010 10:10:11 +0000 (+0000)
Subject: * NeedNewBuf() as CLANG indicates, this parameter should have a name
X-Git-Tag: v7.86~187
X-Git-Url: https://code.citadel.org/?a=commitdiff_plain;h=12ff276e33d5664b889233798dc35c0f04b895a7;hp=ac963d1b137cef5ca20d2afa01a20d5114ba33d5;p=citadel.git

* NeedNewBuf() as CLANG indicates, this parameter should have a name
* several more corrections advised by CLANG
---

diff --git a/webcit/decode.c b/webcit/decode.c
index 9ab67465e..13659d88f 100644
--- a/webcit/decode.c
+++ b/webcit/decode.c
@@ -27,7 +27,7 @@ iconv_t ctdl_iconv_open(const char *tocode, const char *fromcode)
 */
 
 
-inline char *FindNextEnd (char *bptr)
+static inline char *FindNextEnd (char *bptr)
 {
 	char * end;
 	/* Find the next ?Q? */
diff --git a/webcit/messages.c b/webcit/messages.c
index 28c1431ef..32df5afe5 100644
--- a/webcit/messages.c
+++ b/webcit/messages.c
@@ -650,17 +650,6 @@ int load_msg_ptrs(const char *servcmd,
 }
 
 
-inline message_summary* GetMessagePtrAt(int n, HashList *Summ)
-{
-	const char *Key;
-	long HKLen;
-	void *vMsg;
-
-	if (Summ == NULL)
-		return NULL;
-	GetHashAt(Summ, n, &HKLen, &Key, &vMsg);
-	return (message_summary*) vMsg;
-}
 
 
 
diff --git a/webcit/messages.h b/webcit/messages.h
index 387cbccff..eac391a28 100644
--- a/webcit/messages.h
+++ b/webcit/messages.h
@@ -60,7 +60,20 @@ typedef struct _message_summary {
 	wc_mime_attachment *MsgBody;
 } message_summary;
 void DestroyMessageSummary(void *vMsg);
-inline message_summary* GetMessagePtrAt(int n, HashList *Summ);
+
+
+
+static inline message_summary* GetMessagePtrAt(int n, HashList *Summ)
+{
+	const char *Key;
+	long HKLen;
+	void *vMsg;
+
+	if (Summ == NULL)
+		return NULL;
+	GetHashAt(Summ, n, &HKLen, &Key, &vMsg);
+	return (message_summary*) vMsg;
+}
 
 typedef void (*ExamineMsgHeaderFunc)(message_summary *Msg, StrBuf *HdrLine, StrBuf *FoundCharset);
 
diff --git a/webcit/subst.c b/webcit/subst.c
index ccbbbdba2..c12b65908 100644
--- a/webcit/subst.c
+++ b/webcit/subst.c
@@ -448,7 +448,7 @@ void clear_local_substs(void) {
 	clear_substs (WC);
 }
 
-int NeedNewBuf(type)
+int NeedNewBuf(int type)
 {
 	switch(type) {
 	case WCS_STRING: