From: Harlow Solutions <citadel@harlowsolutions.com>
Date: Tue, 18 Jul 2023 20:05:04 +0000 (-0400)
Subject: Memory leak in SMTP Client string trim
X-Git-Tag: v984~3^2
X-Git-Url: https://code.citadel.org/?a=commitdiff_plain;h=402ee003177c1a52da60a40fc098b305f59f177f;p=citadel.git

Memory leak in SMTP Client string trim

serv_smtpclient.c: Removed unused variable 't' from trim_response() which was malloc'ing memory
---

diff --git a/citadel/server/modules/smtp/serv_smtpclient.c b/citadel/server/modules/smtp/serv_smtpclient.c
index 9a91dc164..5bbc77d17 100644
--- a/citadel/server/modules/smtp/serv_smtpclient.c
+++ b/citadel/server/modules/smtp/serv_smtpclient.c
@@ -167,12 +167,6 @@ void trim_response(long response_code, char *response) {
 		return;
 	}
 
-	char *t = malloc(strlen(response));
-	if (!t) {
-		return;
-	}
-	t[0] = 0;
-
 	char *p;
 	for (p = response; *p != 0; ++p) {
 		if ( (*p != '\n') && (!isprint(*p)) ) {		// expunge any nonprintables except for newlines