From: Art Cancro <ajc@citadel.org>
Date: Fri, 21 Jul 2023 22:10:57 +0000 (+0000)
Subject: Merge branch 'Memory_Leak_SmtpClient' into 'master'
X-Git-Tag: v984~3
X-Git-Url: https://code.citadel.org/?a=commitdiff_plain;h=bb9560813e47a15af98f21b21b195da9e5858c67;hp=ded3f00af34320834a33f4e49528b040dc886b13;p=citadel.git

Merge branch 'Memory_Leak_SmtpClient' into 'master'

Memory leak in SMTP Client string trim

See merge request citadel/citadel!4
---

diff --git a/citadel/server/modules/smtp/serv_smtpclient.c b/citadel/server/modules/smtp/serv_smtpclient.c
index 9a91dc164..5bbc77d17 100644
--- a/citadel/server/modules/smtp/serv_smtpclient.c
+++ b/citadel/server/modules/smtp/serv_smtpclient.c
@@ -167,12 +167,6 @@ void trim_response(long response_code, char *response) {
 		return;
 	}
 
-	char *t = malloc(strlen(response));
-	if (!t) {
-		return;
-	}
-	t[0] = 0;
-
 	char *p;
 	for (p = response; *p != 0; ++p) {
 		if ( (*p != '\n') && (!isprint(*p)) ) {		// expunge any nonprintables except for newlines