From: Wilfried Göesgens <willi@citadel.org>
Date: Tue, 16 Mar 2010 23:37:38 +0000 (+0000)
Subject: * CtdlFetchMessage(): don't use strdup on a buffer we also can steal; this saves... 
X-Git-Tag: v7.86~309
X-Git-Url: https://code.citadel.org/?a=commitdiff_plain;h=db4f79c62298f74edbdc6437b7f408340e4a9031;p=citadel.git

* CtdlFetchMessage(): don't use strdup on a buffer we also can steal; this saves us one strlen, one malloc, and one memcpy.
---

diff --git a/citadel/msgbase.c b/citadel/msgbase.c
index 1d411f4c9..1b99b9216 100644
--- a/citadel/msgbase.c
+++ b/citadel/msgbase.c
@@ -1170,7 +1170,8 @@ struct CtdlMessage *CtdlFetchMessage(long msgnum, int with_body)
 	if ( (ret->cm_fields['M'] == NULL) && (with_body) ) {
 		dmsgtext = cdb_fetch(CDB_BIGMSGS, &msgnum, sizeof(long));
 		if (dmsgtext != NULL) {
-			ret->cm_fields['M'] = strdup(dmsgtext->ptr);
+			ret->cm_fields['M'] = dmsgtext->ptr;
+			dmsgtext->ptr = NULL;
 			cdb_free(dmsgtext);
 		}
 	}