From db4f79c62298f74edbdc6437b7f408340e4a9031 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Wilfried=20G=C3=B6esgens?= Date: Tue, 16 Mar 2010 23:37:38 +0000 Subject: [PATCH] * CtdlFetchMessage(): don't use strdup on a buffer we also can steal; this saves us one strlen, one malloc, and one memcpy. --- citadel/msgbase.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/citadel/msgbase.c b/citadel/msgbase.c index 1d411f4c9..1b99b9216 100644 --- a/citadel/msgbase.c +++ b/citadel/msgbase.c @@ -1170,7 +1170,8 @@ struct CtdlMessage *CtdlFetchMessage(long msgnum, int with_body) if ( (ret->cm_fields['M'] == NULL) && (with_body) ) { dmsgtext = cdb_fetch(CDB_BIGMSGS, &msgnum, sizeof(long)); if (dmsgtext != NULL) { - ret->cm_fields['M'] = strdup(dmsgtext->ptr); + ret->cm_fields['M'] = dmsgtext->ptr; + dmsgtext->ptr = NULL; cdb_free(dmsgtext); } } -- 2.39.2