From: Wilfried Goesgens <dothebart@citadel.org>
Date: Sat, 20 Aug 2011 17:37:45 +0000 (+0000)
Subject: protect access to the counter by mutex, else we might get race conditions.
X-Git-Tag: v8.11~1008
X-Git-Url: https://code.citadel.org/?p=citadel.git;a=commitdiff_plain;h=15c3b8a86f46e8c73fe2c90c3994f61f5221e8df

protect access to the counter by mutex, else we might get race conditions.
---

diff --git a/citadel/modules/smtp/serv_smtpqueue.c b/citadel/modules/smtp/serv_smtpqueue.c
index 6b46164c6..6ce560072 100644
--- a/citadel/modules/smtp/serv_smtpqueue.c
+++ b/citadel/modules/smtp/serv_smtpqueue.c
@@ -117,8 +117,10 @@ int DecreaseQReference(OneQueItem *MyQItem)
 {
 	int IDestructQueItem;
 
+	citthread_mutex_lock(&ActiveQItemsLock);
 	MyQItem->ActiveDeliveries--;
 	IDestructQueItem = MyQItem->ActiveDeliveries == 0;
+	citthread_mutex_unlock(&ActiveQItemsLock);
 	return IDestructQueItem;
 }