From: Art Cancro <ajc@citadel.org>
Date: Mon, 2 Jun 2008 14:24:40 +0000 (+0000)
Subject: Fixed a double free error in serv_openid_rp.c
X-Git-Tag: v7.86~2178
X-Git-Url: https://code.citadel.org/?p=citadel.git;a=commitdiff_plain;h=586bcf60773ae50e0700c82b9b1f1807d4211657

Fixed a double free error in serv_openid_rp.c
---

diff --git a/citadel/modules/openid/serv_openid_rp.c b/citadel/modules/openid/serv_openid_rp.c
index 4a87abc88..bd883bf31 100644
--- a/citadel/modules/openid/serv_openid_rp.c
+++ b/citadel/modules/openid/serv_openid_rp.c
@@ -501,7 +501,6 @@ void cmd_oidf(char *argbuf) {
 	char thiskey[1024];
 	char thisdata[1024];
 	HashList *keys = NULL;
-	HashPos *HashPos;
 	struct ctdl_openid *oiddata = (struct ctdl_openid *) CC->openid_data;
 
 	keys = NewHash(1, NULL);
@@ -662,18 +661,21 @@ void cmd_oidf(char *argbuf) {
 	}
 	cprintf("000\n");
 
-	/* Free the hash list */
+	/*
+	 * We will eventually do something with the data in the hash list.
+	 *
 	long len;
 	void *Value;
 	char *Key;
-
+	HashPos *HashPos;
 	HashPos = GetNewHashPos();
 	while (GetNextHashPos(keys, HashPos, &len, &Key, &Value)!=0)
 	{
-		free(Value);
 	}
 	DeleteHashPos(&HashPos);
-	DeleteHash(&keys);
+	 */
+
+	DeleteHash(&keys);		/* This will free() all the key data for us */
 }