From: Wilfried Goesgens <dothebart@citadel.org>
Date: Fri, 25 May 2012 10:03:40 +0000 (+0200)
Subject: as the clang static analyser points out, the | is useless here.
X-Git-Tag: v8.12~86
X-Git-Url: https://code.citadel.org/?p=citadel.git;a=commitdiff_plain;h=59b2f220e65fc35ebf26253ea716f4be623b9065

as the clang static analyser points out, the | is useless here.
---

diff --git a/citadel/auth.c b/citadel/auth.c
index 501008633..89218b60d 100644
--- a/citadel/auth.c
+++ b/citadel/auth.c
@@ -110,13 +110,14 @@ int validate_password(uid_t uid, const char *pass)
 #endif
 	struct passwd *pw;
 	int retval = 0;
-	int flags = 0;
-
-	flags = 0;	/* silences compiler warning */
+	int flags;
 
 #ifdef PAM_DATA_SILENT
-	flags = ( flags | PAM_DATA_SILENT ) ;
+	flags = PAM_DATA_SILENT;
+#else
+	flags = 0;
 #endif /* PAM_DATA_SILENT */
+
 	if ((pw = getpwuid(uid)) == NULL) {
 		return retval;
 	}