From: Wilfried Goesgens <dothebart@citadel.org>
Date: Wed, 31 Dec 2014 11:48:25 +0000 (+0100)
Subject: As clang told us: we have to check for empty buffer here - not null pointer.
X-Git-Tag: v9.01~62
X-Git-Url: https://code.citadel.org/?p=citadel.git;a=commitdiff_plain;h=b44d1c2f1e0ae68a1c274bd98799471426ae620f

As clang told us: we have to check for empty buffer here - not null pointer.
---

diff --git a/citadel/modules/imap/imap_misc.c b/citadel/modules/imap/imap_misc.c
index 5b501e4e7..f4d501c9d 100644
--- a/citadel/modules/imap/imap_misc.c
+++ b/citadel/modules/imap/imap_misc.c
@@ -306,7 +306,7 @@ void imap_append(int num_parms, ConstStr *Params) {
 		return;
 	}
 
-	strcpy(new_message_flags, "");
+	*new_message_flags = '\0';
 	if (num_parms >= 5) {
 		for (i=3; i<num_parms; ++i) {
 			strcat(new_message_flags, Params[i].Key);
@@ -430,7 +430,7 @@ void imap_append(int num_parms, ConstStr *Params) {
 	/* We don't need this buffer anymore */
 	CM_Free(msg);
 
-	if (new_message_flags != NULL) {
+	if (IsEmptyStr(new_message_flags)) {
 		imap_do_append_flags(new_msgnum, new_message_flags);
 	}
 }