From: the_mgt <themgt@ueberserver.de>
Date: Wed, 6 Jul 2011 22:55:17 +0000 (+0200)
Subject: Fixed the alignment before and after sorting the mailbox view!! Thanks to matt (Matth... 
X-Git-Tag: v8.11~602
X-Git-Url: https://code.citadel.org/?p=citadel.git;a=commitdiff_plain;h=bc30fe7f3bd68b28285513f1155f5d9cf649e026

Fixed the alignment before and after sorting the mailbox view!! Thanks to matt (Matthwe McBride)!
Also tried to fix the spacing in the table itself, so that long topics don't leak into the sender name...
Found out that FF3's js engine counts differently from operas and is off by a few pixels.
This is unbelievably frustrating and the current workaround is to leave 1em space, which is far too much.
---

diff --git a/webcit/static/styles/webcit.css b/webcit/static/styles/webcit.css
index 2e2ccc4c7..f5957e76c 100644
--- a/webcit/static/styles/webcit.css
+++ b/webcit/static/styles/webcit.css
@@ -446,19 +446,22 @@ body {
 /* Please avoid setting heights for any of the mailbox view elements (except summary_view
  * and resize). In particular, do NOT set any for message_list_hdr as its not good feng shui
  */
+#message_listview th {
+	border: 1px solid green;
+	border-right: 0.2em solid #fff;
+}
+#message_listview td {
+	padding-left: 1em;
+}
 
 #message_list_hdr {
 	display: block;
-	top: 0;
-	left: 0;
-	width: 100%;
 	padding-bottom: 0;
 	margin-bottom: 0;
 	background-color: #CCCCCC;
 }
 
 #summary_view {
-	height: 100px;
 	overflow-y: scroll;
 	overflow-x: hidden;
 	cursor: pointer;
@@ -466,7 +469,6 @@ body {
 
 #summary_headers {
 	background-color: white;
-	width: 100%;
 	table-layout: fixed;
 }
 
@@ -475,11 +477,11 @@ body {
 	overflow-x: hidden; /* stop long subjects overflowing */
 }
 
-.col1 { width: 50% }
+#message_listview .col1 { width: 66% }
 
-.col2 { width: 30% }
+#message_listview .col2 { width: 22% }
 
-.col3 { width: 20% }
+#message_listview .col3 { width: 12% }
 
 .col1, .col2, .col3 {
 	cursor: pointer;
@@ -724,17 +726,8 @@ div.auto_complete ul strong.highlight {
 
 #message_list_hdr > table { border-collapse: collapse }
 
-#message_list_hdr > table > tbody > tr > th {
-	border-left: 2px solid white;
-	border-right: 2px solid white;
-}
-
 #summary_view > table { border-collapse: collapse }
 
-th.col1 { border-left: none !important }
-
-th.col3 { border-right: none !important }
-
 /* System Administration Menu */
 
 ul.adminitems {
diff --git a/webcit/static/summaryview.js b/webcit/static/summaryview.js
index edcb3e2b8..a37776019 100644
--- a/webcit/static/summaryview.js
+++ b/webcit/static/summaryview.js
@@ -483,7 +483,7 @@ function sizePreviewPane() {
 	var heightOfViewPort = document.viewport.getHeight() // prototypejs method
 		var bannerHeight = banner.offsetHeight;
 	var contentViewPortHeight = heightOfViewPort-banner.offsetHeight-message_list_hdr.offsetHeight;
-	contentViewPortHeight = 0.98 * contentViewPortHeight; // leave some error
+	contentViewPortHeight = 0.95 * contentViewPortHeight; // leave some error (especially for FF3!!)
 	// Set summary_view to 20%;
 	var summary_height = ctdlLocalPrefs.readPref("svheight");
 	if (summary_height == null) {
diff --git a/webcit/static/t/msg_listview.html b/webcit/static/t/msg_listview.html
index 223d25ea1..3d8f0545c 100644
--- a/webcit/static/t/msg_listview.html
+++ b/webcit/static/t/msg_listview.html
@@ -1,33 +1,31 @@
 <script src="static/summaryview.js" type="text/javascript"></script>
 <script type="text/javascript">
-var is_safe_mode = <?%("COND:PREF", 1, :"mailbox", "client-nosort",
-"true", "false")>;
-var sortmode = ""; /*"<?PREF:ROOM:VALUE("sort")>";*/
+	var is_safe_mode = <?%("COND:PREF", 1, :"mailbox", "client-nosort", "true", "false")>;
+	var sortmode = ""; /*"<?PREF:ROOM:VALUE("sort")>";*/
 </script>
-<div id="message_list_hdr">
-<table>
-      <tr>
-	<th class="col1" id="mlh_subject"><?_("Subject")></th>
-	<th class="col2" id="mlh_from"><?_("Sender")></th>
-	<th class="col3" id="mlh_date"><?_("Date")></th>
-      </tr>
-	</table>
-</div>
-<div id="summary_view">
-  <table id="message_list_body" class="mailbox_summary"><tr style="display: none;"><td colspan="4"></td></tr></table>
-    <div id="loading">
-      <p><img src="static/webcit_icons/throbber.gif" alt=""></p>
-      <p><?_("Loading messages from server, please wait")></p>
-    </div>
-</div>
-<div id="resize_msglist"></div>
-<div id="preview_pane">
-</div>
-<div class="ctdlTemplate" id="listViewContextMenu">
-<?_("Open in new window")><br>
-<?_("Move")><br>
-<?_("Copy")><br>
-<?_("Delete")><br>
-<?_("Print")><br>
+<div id="message_listview">
+	<div id="message_list_hdr">      
+		<table><tr>
+			<th class="col1" id="mlh_subject"><?_("Subject")></th>
+			<th class="col2" id="mlh_from"><?_("Sender")></th>
+			<th class="col3" id="mlh_date"><?_("Date")></th>
+		</tr></table>
+	</div>
+	<div id="summary_view">
+		<table id="message_list_body" class="mailbox_summary"><tr style="display: none;"><td colspan="4"></td></tr></table>
+		<div id="loading">
+			<p><img src="static/webcit_icons/throbber.gif" alt=""></p>
+			<p><?_("Loading messages from server, please wait")></p>
+		</div>
+	</div>
+	<div id="resize_msglist"></div>
+	<div id="preview_pane"></div>
+	<div class="ctdlTemplate" id="listViewContextMenu">
+		<?_("Open in new window")><br>
+		<?_("Move")><br>
+		<?_("Copy")><br>
+		<?_("Delete")><br>
+		<?_("Print")><br>
+	</div>
 </div>
 </div>