From: Art Cancro <ajc@citadel.org>
Date: Mon, 10 Jan 2022 22:42:26 +0000 (-0500)
Subject: ssl ciphers had to be set to its old value of
X-Git-Tag: v948~1
X-Git-Url: https://code.citadel.org/?p=citadel.git;a=commitdiff_plain;h=e7fa57d8628023a97451ff690a5906b70412f4a5

ssl ciphers had to be set to its old value of
"ALL:RC4+RSA:+SSLv2:+TLSv1:!MD5:@STRENGTH"
instead of
"DEFAULT"
even though the latter works just fine in WebCit, works just fine
in all protocols on the development host, but causes all sorts of
chaos on Uncensored.  I don't know why.
---

diff --git a/citadel/modules/crypto/serv_crypto.c b/citadel/modules/crypto/serv_crypto.c
index 56bd7cc48..a899be7c6 100644
--- a/citadel/modules/crypto/serv_crypto.c
+++ b/citadel/modules/crypto/serv_crypto.c
@@ -207,7 +207,7 @@ void generate_certificate(char *keyfilename, char *certfilename) {
 
 	X509_free(certificate);
 	EVP_PKEY_free(public_key);
-	// RSA_free(private_key);				// private_key is freed by EVP_PKEY_free() above
+	// do not RSA_free(private_key); because it was freed by EVP_PKEY_free() above
 }