From: Wilfried Goesgens <dothebart@citadel.org>
Date: Sun, 10 Jun 2012 14:08:46 +0000 (+0200)
Subject: NETP: extract password string when we need it. else it might be overwritten meanwhile.
X-Git-Tag: v8.12~21
X-Git-Url: https://code.citadel.org/?p=citadel.git;a=commitdiff_plain;h=fbc579d772a0ba71d9adb0981e4427f169cd802a

NETP: extract password string when we need it. else it might be overwritten meanwhile.
---

diff --git a/citadel/modules/network/serv_netconfig.c b/citadel/modules/network/serv_netconfig.c
index 8f1018a4a..c5c457adc 100644
--- a/citadel/modules/network/serv_netconfig.c
+++ b/citadel/modules/network/serv_netconfig.c
@@ -480,7 +480,6 @@ void cmd_netp(char *cmdbuf)
 	/* Authenticate */
 	node = CCC->curr_user;
 	nodelen = extract_token(CCC->curr_user, cmdbuf, 0, '|', sizeof CCC->curr_user);
-	extract_token(CCC->user.password, cmdbuf, 1, '|', sizeof CCC->user.password);
 	NodeStr = NewStrBufPlain(node, nodelen);
 	/* load the IGnet Configuration to check node validity */
 	working_ignetcfg = load_ignetcfg();
@@ -498,6 +497,7 @@ void cmd_netp(char *cmdbuf)
 		return;
 	}
 
+	extract_token(CCC->user.password, cmdbuf, 1, '|', sizeof CCC->user.password);
 	if (strcasecmp(CCC->user.password, ChrPtr(secret))) {
 		snprintf(err_buf, sizeof err_buf,
 			"A Citadel server at %s [%s] failed to authenticate as network node \"%s\".\n",