From 9d62c756b928de642387c07f6ce71483175aeaba Mon Sep 17 00:00:00 2001 From: Art Cancro Date: Tue, 25 Oct 2005 21:31:08 +0000 Subject: [PATCH] * msgbase.c: when a summary mode message list is requested, and the room contains a pointer to a message which does not exist (this normally should not happen), return an empty message summary line instead of crashing. * removed the remaining vestiges of the libtool stuff in .c and .y files --- citadel/ChangeLog | 6 ++++++ citadel/config.c | 4 ---- citadel/control.c | 4 ---- citadel/database_sleepycat.c | 4 ---- citadel/file_ops.c | 4 ---- citadel/genstamp.c | 4 ---- citadel/getutline.c | 4 ---- citadel/housekeeping.c | 4 ---- citadel/html.c | 6 +----- citadel/internet_addressing.c | 4 ---- citadel/msgbase.c | 6 +----- citadel/parsedate.y | 4 ---- citadel/policy.c | 4 ---- citadel/room_ops.c | 4 ---- citadel/serv_autocompletion.c | 4 ---- citadel/snprintf.c | 4 ---- citadel/support.c | 4 ---- citadel/sysdep.c | 4 ---- citadel/tools.c | 4 ---- citadel/user_ops.c | 4 ---- 20 files changed, 8 insertions(+), 78 deletions(-) diff --git a/citadel/ChangeLog b/citadel/ChangeLog index 00d2ba4f3..e71800221 100644 --- a/citadel/ChangeLog +++ b/citadel/ChangeLog @@ -1,5 +1,11 @@ $Id$ +Tue Oct 25 17:29:12 EDT 2005 ajc +* msgbase.c: when a summary mode message list is requested, and the room + contains a pointer to a message which does not exist (this normally should + not happen), return an empty message summary line instead of crashing. +* removed the remaining vestiges of the libtool stuff in .c and .y files + Mon Oct 24 22:52:33 EDT 2005 ajc * Every user gets a Trash folder. Clients can also use _TRASH_ diff --git a/citadel/config.c b/citadel/config.c index 996118816..f5d4750e5 100644 --- a/citadel/config.c +++ b/citadel/config.c @@ -6,10 +6,6 @@ * */ -#ifdef DLL_EXPORT -#define IN_LIBCIT -#endif - #include "sysdep.h" #include #include diff --git a/citadel/control.c b/citadel/control.c index bbf3bf6ef..83a6c576d 100644 --- a/citadel/control.c +++ b/citadel/control.c @@ -5,10 +5,6 @@ * */ -#ifdef DLL_EXPORT -#define IN_LIBCIT -#endif - #include "sysdep.h" #include #include diff --git a/citadel/database_sleepycat.c b/citadel/database_sleepycat.c index 088ce5412..30e1e0b77 100644 --- a/citadel/database_sleepycat.c +++ b/citadel/database_sleepycat.c @@ -18,10 +18,6 @@ /*****************************************************************************/ -#ifdef DLL_EXPORT -#define IN_LIBCIT -#endif - #include "sysdep.h" #include #include diff --git a/citadel/file_ops.c b/citadel/file_ops.c index 1ee6ef3b2..97aa235b4 100644 --- a/citadel/file_ops.c +++ b/citadel/file_ops.c @@ -5,10 +5,6 @@ * */ -#ifdef DLL_EXPORT -#define IN_LIBCIT -#endif - #include "sysdep.h" #include #include diff --git a/citadel/genstamp.c b/citadel/genstamp.c index e97fb9796..cbf89d448 100644 --- a/citadel/genstamp.c +++ b/citadel/genstamp.c @@ -5,10 +5,6 @@ * */ -#ifdef DLL_EXPORT -#define IN_LIBCIT -#endif - #include "sysdep.h" #include #include diff --git a/citadel/getutline.c b/citadel/getutline.c index f64559abc..5eae2a760 100644 --- a/citadel/getutline.c +++ b/citadel/getutline.c @@ -6,10 +6,6 @@ * */ -#ifdef DLL_EXPORT -#define IN_LIBCIT -#endif - #include "sysdep.h" #ifdef HAVE_UTMP_H #include diff --git a/citadel/housekeeping.c b/citadel/housekeeping.c index 9bb4624bb..7eee008ae 100644 --- a/citadel/housekeeping.c +++ b/citadel/housekeeping.c @@ -5,10 +5,6 @@ * */ -#ifdef DLL_EXPORT -#define IN_LIBCIT -#endif - #include "sysdep.h" #include #include diff --git a/citadel/html.c b/citadel/html.c index c820d1c96..8ff0bbc93 100644 --- a/citadel/html.c +++ b/citadel/html.c @@ -2,14 +2,10 @@ * $Id$ * * Functions which handle translation between HTML and plain text - * Copyright (c) 2000-2001 by Art Cancro and others. This program is + * Copyright (c) 2000-2005 by Art Cancro and others. This program is * released under the terms of the GNU General Public License. */ -#ifdef DLL_EXPORT -#define IN_LIBCIT -#endif - #include "sysdep.h" #include #include diff --git a/citadel/internet_addressing.c b/citadel/internet_addressing.c index 0ec59ce34..a8487d38a 100644 --- a/citadel/internet_addressing.c +++ b/citadel/internet_addressing.c @@ -5,10 +5,6 @@ * to users on the Citadel system. */ -#ifdef DLL_EXPORT -#define IN_LIBCIT -#endif - #include "sysdep.h" #include #include diff --git a/citadel/msgbase.c b/citadel/msgbase.c index 09d057f0f..f09afc41d 100644 --- a/citadel/msgbase.c +++ b/citadel/msgbase.c @@ -5,10 +5,6 @@ * */ -#ifdef DLL_EXPORT -#define IN_LIBCIT -#endif - #include "sysdep.h" #include #include @@ -281,7 +277,7 @@ void headers_listing(long msgnum, void *userdata) struct CtdlMessage *msg; msg = CtdlFetchMessage(msgnum, 0); - if (msg < 0L) { + if (msg == NULL) { cprintf("%ld|0|||||\n", msgnum); return; } diff --git a/citadel/parsedate.y b/citadel/parsedate.y index bf69da311..cf87f0e27 100644 --- a/citadel/parsedate.y +++ b/citadel/parsedate.y @@ -19,10 +19,6 @@ /* SUPPRESS 593 on yynewstate *//* Label was not used */ /* SUPPRESS 595 on yypvt *//* Automatic variable may be used before set */ -#ifdef DLL_EXPORT -#define IN_LIBCIT -#endif - #include "sysdep.h" #include diff --git a/citadel/policy.c b/citadel/policy.c index b2c489e51..079c3cda0 100644 --- a/citadel/policy.c +++ b/citadel/policy.c @@ -4,10 +4,6 @@ * Functions which manage policy for rooms (such as message expiry) */ -#ifdef DLL_EXPORT -#define IN_LIBCIT -#endif - #include "sysdep.h" #include #include diff --git a/citadel/room_ops.c b/citadel/room_ops.c index 3d90b405c..9d0f82b06 100644 --- a/citadel/room_ops.c +++ b/citadel/room_ops.c @@ -5,10 +5,6 @@ * */ -#ifdef DLL_EXPORT -#define IN_LIBCIT -#endif - #include "sysdep.h" #include #include diff --git a/citadel/serv_autocompletion.c b/citadel/serv_autocompletion.c index cb1aed5c5..71aa0a035 100644 --- a/citadel/serv_autocompletion.c +++ b/citadel/serv_autocompletion.c @@ -4,10 +4,6 @@ * Autocompletion of email recipients, etc. */ -#ifdef DLL_EXPORT -#define IN_LIBCIT -#endif - #include "sysdep.h" #include #include diff --git a/citadel/snprintf.c b/citadel/snprintf.c index ab014de69..dcc9cd81c 100644 --- a/citadel/snprintf.c +++ b/citadel/snprintf.c @@ -20,10 +20,6 @@ * Written July 1997 by Sten Gunterberg (gunterberg@ergon.ch) */ -#ifdef DLL_EXPORT -#define IN_LIBCIT -#endif - #include #include #include diff --git a/citadel/support.c b/citadel/support.c index 970a215fd..bb27760cf 100644 --- a/citadel/support.c +++ b/citadel/support.c @@ -5,10 +5,6 @@ * */ -#ifdef DLL_EXPORT -#define IN_LIBCIT -#endif - #include "sysdep.h" #include #include diff --git a/citadel/sysdep.c b/citadel/sysdep.c index f9c4e1653..5eac30ef3 100644 --- a/citadel/sysdep.c +++ b/citadel/sysdep.c @@ -12,10 +12,6 @@ * */ -#ifdef DLL_EXPORT -#define IN_LIBCIT -#endif - #include "sysdep.h" #include #include diff --git a/citadel/tools.c b/citadel/tools.c index b1c495532..982d1ae1b 100644 --- a/citadel/tools.c +++ b/citadel/tools.c @@ -5,10 +5,6 @@ * */ -#ifdef DLL_EXPORT -#define IN_LIBCIT -#endif - #include "sysdep.h" #include #include diff --git a/citadel/user_ops.c b/citadel/user_ops.c index 1fb0936e6..2d64dab9a 100644 --- a/citadel/user_ops.c +++ b/citadel/user_ops.c @@ -5,10 +5,6 @@ * */ -#ifdef DLL_EXPORT -#define IN_LIBCIT -#endif - #include "sysdep.h" #include #include -- 2.30.2