From 2269e24e7f0b621a00c484206bac1888d40976d9 Mon Sep 17 00:00:00 2001 From: Art Cancro Date: Fri, 7 Apr 2017 08:35:58 -0400 Subject: [PATCH] fix double-free when there are multiple mxes --- citadel/modules/smtp/serv_smtpclient.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/citadel/modules/smtp/serv_smtpclient.c b/citadel/modules/smtp/serv_smtpclient.c index a7fb3052e..bfe665984 100644 --- a/citadel/modules/smtp/serv_smtpclient.c +++ b/citadel/modules/smtp/serv_smtpclient.c @@ -261,10 +261,10 @@ int smtp_attempt_delivery(long msgid, char *recp, char *envelope_from) response_code = 421; } - if (recipients != NULL) { curl_slist_free_all(recipients); - } - curl_easy_cleanup(curl); + recipients = NULL; // this gets reused; avoid double-free + curl_easy_cleanup(curl); + curl = NULL; // this gets reused; avoid double-free } } -- 2.30.2