From 8b205c8685728911def335ced64f35b5be86e7f5 Mon Sep 17 00:00:00 2001 From: Art Cancro Date: Fri, 6 Apr 2012 13:03:58 -0400 Subject: [PATCH] feed generator: strip out nonprintable characters so XML parsers do not choke on them --- webcit/feed_generator.c | 21 ++++++++++++++------- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/webcit/feed_generator.c b/webcit/feed_generator.c index 2be5e1f74..f6cb345a0 100644 --- a/webcit/feed_generator.c +++ b/webcit/feed_generator.c @@ -5,23 +5,16 @@ * * This program is open source software. You can redistribute it and/or * modify it under the terms of the GNU General Public License, version 3. - * - * * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * - * - * */ #include "webcit.h" #include "webserver.h" - /* * RSS feed generator -- do one message */ @@ -86,6 +79,19 @@ void feed_rss_one_message(long msgnum) { in_messagetext = 0; while (StrBufSipLine(Line, ServerResponse, &BufPtr), ((BufPtr!=StrBufNOTNULL)&&(BufPtr!=NULL)) ) { safestrncpy(buf, ChrPtr(Line), sizeof buf); + + /* XML parsers can be picky; strip out nonprintable header characters */ + if ((strlen(buf)>=6) && (buf[4]=='=')) { + char *p = &buf[5]; + while (*p) { + if (!isprint(*p)) { + *p = 0; + } + ++p; + } + } + + /* Now output fields */ if (in_body) { if (in_messagetext) { StrBufAppendBufPlain(messagetext, buf, -1, 0); @@ -141,6 +147,7 @@ void feed_rss_one_message(long msgnum) { return; } + /* * RSS feed generator -- go through the message list */ -- 2.39.2