From 98c6d07ff027ddc7c2bd74987b4f70642b159c7c Mon Sep 17 00:00:00 2001 From: Art Cancro Date: Mon, 23 May 2011 17:50:53 -0400 Subject: [PATCH] Revert "Change to blog euid storage; note new definition in libcitadel.h" This reverts commit 6d51b9ea0e3670d8ac52cc183e5ac0bcd3f3f2d6. --- citadel/modules/blog/serv_blog.c | 9 +-------- libcitadel/lib/libcitadel.h | 1 - webcit/blogview_renderer.c | 13 +++++++------ 3 files changed, 8 insertions(+), 15 deletions(-) diff --git a/citadel/modules/blog/serv_blog.c b/citadel/modules/blog/serv_blog.c index fb95d613b..5459898f7 100644 --- a/citadel/modules/blog/serv_blog.c +++ b/citadel/modules/blog/serv_blog.c @@ -74,18 +74,11 @@ int blog_upload_beforesave(struct CtdlMessage *msg) { */ if (msg->cm_fields['E'] == NULL) { - char uuid[BLOG_EUIDBUF_SIZE]; + char uuid[37]; generate_uuid(uuid); msg->cm_fields['E'] = strdup(uuid); } - /* - * We also want to define a maximum length, whether we generated it or not. - */ - else if (strlen(msg->cm_fields['E']) >= BLOG_EUIDBUF_SIZE) { - msg->cm_fields['E'][BLOG_EUIDBUF_SIZE-1] = 0; - } - /* Now allow the save to complete. */ return(0); } diff --git a/libcitadel/lib/libcitadel.h b/libcitadel/lib/libcitadel.h index 13737c39c..f47c4a241 100644 --- a/libcitadel/lib/libcitadel.h +++ b/libcitadel/lib/libcitadel.h @@ -89,7 +89,6 @@ typedef enum _room_views { VIEW_MAX } ROOM_VIEWS; -#define BLOG_EUIDBUF_SIZE 40 #ifndef IsEmptyStr #define IsEmptyStr(a) ((a)[0] == '\0') diff --git a/webcit/blogview_renderer.c b/webcit/blogview_renderer.c index 25af87053..8190cb8c8 100644 --- a/webcit/blogview_renderer.c +++ b/webcit/blogview_renderer.c @@ -1,7 +1,7 @@ /* * Blog view renderer module for WebCit * - * Copyright (c) 1996-2011 by the citadel.org team + * Copyright (c) 1996-2010 by the citadel.org team * * This program is open source software. You can redistribute it and/or * modify it under the terms of the GNU General Public License as @@ -87,7 +87,7 @@ void blogpost_render_and_destroy(struct blogpost *bp) { struct bltr { int id; int refs; - char euid[BLOG_EUIDBUF_SIZE]; /* please do not change this to a StrBuf */ + StrBuf *euid; }; @@ -124,7 +124,7 @@ struct bltr blogview_learn_thread_references(long msgnum) StrBuf *Buf; StrBuf *r; int len; - struct bltr bltr = { 0, 0, "" } ; + struct bltr bltr = { 0, 0, NULL }; Buf = NewStrBuf(); r = NewStrBuf(); serv_printf("MSG0 %ld|1", msgnum); /* top level citadel headers only */ @@ -145,7 +145,7 @@ struct bltr blogview_learn_thread_references(long msgnum) } else if (!strncasecmp(ChrPtr(Buf), "exti=", 5)) { StrBufCutLeft(Buf, 5); /* trim the field name */ - safestrncpy(bltr.euid, ChrPtr(Buf), sizeof(bltr.euid)); + bltr.euid = NewStrBufDup(Buf); } } } @@ -170,8 +170,9 @@ int blogview_LoadMsgFromServer(SharedMessageStatus *Stat, b = blogview_learn_thread_references(Msg->msgnum); - if (!IsEmptyStr(b.euid)) { - syslog(LOG_DEBUG, "\033[7m%s\033[0m", b.euid); + if (b.euid != NULL) { + syslog(LOG_DEBUG, "\033[7m%s\033[0m", ChrPtr(b.euid)); + FreeStrBuf(&b.euid); } /* FIXME an optimization here -- one we ought to perform -- is to exit this -- 2.30.2