From 9ef6e7b788b37e831d5d5fe1ba332084ecee0064 Mon Sep 17 00:00:00 2001
From: Wilfried Goesgens <dothebart@citadel.org>
Date: Sun, 1 Jul 2012 11:03:07 +0200
Subject: [PATCH] Roomedit - Sharing: remove lines unneeded

  - add portable function to find & remove a section
  - call that function instead of doing it in place.
  - there is no input=input, its input=text
---
 webcit/static/t/room/edit/shared_room_add.html     |  3 +--
 webcit/static/t/room/edit/shared_room_removal.html |  5 +++--
 webcit/static/wclib.js                             | 12 ++++++++++++
 3 files changed, 16 insertions(+), 4 deletions(-)

diff --git a/webcit/static/t/room/edit/shared_room_add.html b/webcit/static/t/room/edit/shared_room_add.html
index 1d5a6d6ba..c0905947e 100644
--- a/webcit/static/t/room/edit/shared_room_add.html
+++ b/webcit/static/t/room/edit/shared_room_add.html
@@ -2,7 +2,7 @@
 	<input type="hidden" name="nonce" value="<?NONCE>" />
 	<tr id="ignet_share_node_add__<?CFG:IGNET:NODE("U")>">
 		<td><?CFG:IGNET:NODE("X")></td>
-		<td><input type="input" name="suffix" maxlength="128" /></td>
+		<td><input type="text" name="suffix" maxlength="128" /></td>
 		<td>
 			<input type="hidden" name="line" value="ignet_push_share|<?CFG:IGNET:NODE("U")>|" /> 
 			<input type="hidden" name="tab" value="sharing" />
@@ -11,4 +11,3 @@
 		</td>
 	</tr>
 </form>
-
diff --git a/webcit/static/t/room/edit/shared_room_removal.html b/webcit/static/t/room/edit/shared_room_removal.html
index 2be39295b..4b6602635 100644
--- a/webcit/static/t/room/edit/shared_room_removal.html
+++ b/webcit/static/t/room/edit/shared_room_removal.html
@@ -1,6 +1,8 @@
 <script type="text/javascript">
-document.getElementById("ignet_share_node_add__<?CONTEXTSTRARR(#"GNET_IGNET_NODE", "U")>").style.display  = "none";
+<?#("if we already have this room, you can't add it anymore.")>
+remove_something('ignet_share_node_add__<?CONTEXTSTRARR(#"GNET_IGNET_NODE", "U")>', "hidden");
 </script>
+
 <form method="post" action="netedit">
 	<input type="hidden" name="nonce" value="<?NONCE>" />
 	<tr>
@@ -17,4 +19,3 @@ document.getElementById("ignet_share_node_add__<?CONTEXTSTRARR(#"GNET_IGNET_NODE
 		</td>
 	</tr>
 </form>
-
diff --git a/webcit/static/wclib.js b/webcit/static/wclib.js
index 956dd67b5..1594632f0 100644
--- a/webcit/static/wclib.js
+++ b/webcit/static/wclib.js
@@ -188,6 +188,18 @@ function hide_imsg_popup() {
 
 	document.poppedLayer.style.visibility = "hidden";
 }
+function remove_something(what_to_search, new_visibility) {
+	if (browserType == "gecko") {
+		document.poppedLayer = eval('document.getElementById(\'' + what_to_search + '\')');
+	}
+	else if (browserType == "ie") {
+		document.poppedLayer = eval('document.all[\'' + what_to_search + '\']');
+	}
+	else {
+		document.poppedLayer = eval('document.layers[\'`' + what_to_search + '\']');
+	}
+    document.poppedLayer.innerHTML = "";
+}
 
 function unhide_imsg_popup() {
 	if (browserType == "gecko") {
-- 
2.30.2