From fc08ae6465b6da1d9008ce4b20b3cc2c2a5781af Mon Sep 17 00:00:00 2001 From: Art Cancro Date: Tue, 20 Sep 2011 15:42:11 -0400 Subject: [PATCH] Room links in iconbar roomlist now properly escaped with encodeURIcomponent() --- webcit/iconbar.c | 2 +- webcit/static/wclib.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/webcit/iconbar.c b/webcit/iconbar.c index bdcadfb1c..7a6e39d1a 100644 --- a/webcit/iconbar.c +++ b/webcit/iconbar.c @@ -133,7 +133,7 @@ void LoadIconSettings(StrBuf *iconbar, long lvalue) { WCC->IBSettingsVec = (long*) malloc (nIBV * sizeof(long)); } - /** + /* * The initialized values of these variables also happen to * specify the default values for users who haven't customized * their iconbars. These should probably be set in a master diff --git a/webcit/static/wclib.js b/webcit/static/wclib.js index 31a0d7b4a..e8c0c4ee7 100644 --- a/webcit/static/wclib.js +++ b/webcit/static/wclib.js @@ -270,7 +270,7 @@ function addRoomToList(floorUL,room, roomToEmphasize) { var hasNewMsgs = ((raflags & UA_HASNEWMSGS) == UA_HASNEWMSGS); var roomLI = document.createElement("li"); var roomA = document.createElement("a"); - roomA.setAttribute("href","dotgoto?room="+roomName); + roomA.setAttribute("href","dotgoto?room="+encodeURIComponent(roomName)); roomA.appendChild(document.createTextNode(roomName)); roomLI.appendChild(roomA); floorUL.appendChild(roomLI); -- 2.30.2