X-Git-Url: https://code.citadel.org/?a=blobdiff_plain;f=citadel%2Fmodules%2Fimap%2Fserv_imap.c;h=3d5d2ac7bb8c685ae36235295c0dccf4b4fb15dc;hb=8c47559cb5ae97ec0fa35660ee16fd61a9451c72;hp=4f63c04e39c6d53e53c1defa5948444dace97559;hpb=4e2738804fe568c3d53291ed0be5a47fc9e81ae5;p=citadel.git diff --git a/citadel/modules/imap/serv_imap.c b/citadel/modules/imap/serv_imap.c index 4f63c04e3..3d5d2ac7b 100644 --- a/citadel/modules/imap/serv_imap.c +++ b/citadel/modules/imap/serv_imap.c @@ -2,12 +2,26 @@ * $Id$ * * IMAP server for the Citadel system - * Copyright (C) 2000-2007 by Art Cancro and others. + * Copyright (C) 2000-2009 by Art Cancro and others. * This code is released under the terms of the GNU General Public License. * * WARNING: the IMAP protocol is badly designed. No implementation of it * is perfect. Indeed, with so much gratuitous complexity, *all* IMAP * implementations have bugs. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */ #include "sysdep.h" @@ -227,7 +241,7 @@ void imap_load_msgids(void) struct cdbdata *cdbfr; if (IMAP->selected == 0) { - lprintf(CTDL_ERR, + CtdlLogPrintf(CTDL_ERR, "imap_load_msgids() can't run; no room selected\n"); return; } @@ -269,7 +283,7 @@ void imap_rescan_msgids(void) int num_recent = 0; if (IMAP->selected == 0) { - lprintf(CTDL_ERR, + CtdlLogPrintf(CTDL_ERR, "imap_load_msgids() can't run; no room selected\n"); return; } @@ -290,7 +304,7 @@ void imap_rescan_msgids(void) if (cdbfr != NULL) { msglist = malloc(cdbfr->len); if (msglist == NULL) { - lprintf(CTDL_CRIT, "malloc() failed\n"); + CtdlLogPrintf(CTDL_CRIT, "malloc() failed\n"); abort(); } memcpy(msglist, cdbfr->ptr, (size_t)cdbfr->len); @@ -407,7 +421,7 @@ void imap_cleanup_function(void) imap_do_expunge(); } - lprintf(CTDL_DEBUG, "Performing IMAP cleanup hook\n"); + CtdlLogPrintf(CTDL_DEBUG, "Performing IMAP cleanup hook\n"); imap_free_msgids(); imap_free_transmitted_message(); @@ -426,7 +440,7 @@ void imap_cleanup_function(void) } free(IMAP); - lprintf(CTDL_DEBUG, "Finished IMAP cleanup hook\n"); + CtdlLogPrintf(CTDL_DEBUG, "Finished IMAP cleanup hook\n"); } @@ -447,11 +461,20 @@ void imap_output_capability_string(void) { /* We are building a partial implementation of METADATA for the sole purpose * of interoperating with the ical/vcard version of the Bynari Insight Connector. - * If you were expecting something else, comment out one or both of these - * extension advertisements. + * It is not a full RFC5464 implementation, but it should refuse non-Bynari + * metadata in a compatible and graceful way. */ cprintf(" METADATA"); - /* cprintf(" LIST-EXTENDED"); */ + + /* + * LIST-EXTENDED was originally going to be required by the METADATA extension. + * It was mercifully removed prior to the finalization of RFC5464. We started + * implementing this but stopped when we learned that it would not be needed. + * If you uncomment this declaration you are responsible for writing a lot of new + * code. + * + * cprintf(" LIST-EXTENDED") + */ } /* @@ -498,6 +521,12 @@ void imap_greeting(void) IMAP->cached_rfc822_msgnum = (-1); IMAP->cached_rfc822_withbody = 0; + if (CC->nologin) + { + cprintf("* BYE; Server busy, try later\r\n"); + CC->kill_me = 1; + return; + } cprintf("* OK ["); imap_output_capability_string(); cprintf("] %s IMAP4rev1 %s ready\r\n", config.c_fqdn, CITADEL); @@ -587,6 +616,7 @@ void imap_auth_plain(char *cmd) char pass[256]; int result; + memset(pass, 0, sizeof(pass)); CtdlDecodeBase64(decoded_authstring, cmd, strlen(cmd)); safestrncpy(ident, decoded_authstring, sizeof ident); safestrncpy(user, &decoded_authstring[strlen(ident) + 1], sizeof user); @@ -626,6 +656,7 @@ void imap_auth_login_pass(char *cmd) { char buf[SIZ]; + memset(buf, 0, sizeof(buf)); CtdlDecodeBase64(buf, cmd, SIZ); if (CtdlTryPassword(buf) == pass_ok) { cprintf("%s OK authentication succeeded\r\n", IMAP->authseq); @@ -741,13 +772,17 @@ void imap_select(int num_parms, char *parms[]) cprintf("* OK [UIDVALIDITY %ld] UID validity status\r\n", GLOBAL_UIDVALIDITY_VALUE); cprintf("* OK [UIDNEXT %ld] Predicted next UID\r\n", CitControl.MMhighest + 1); - /* Note that \Deleted is a valid flag, but not a permanent flag, + /* Technically, \Deleted is a valid flag, but not a permanent flag, * because we don't maintain its state across sessions. Citadel * automatically expunges mailboxes when they are de-selected. + * + * Unfortunately, omitting \Deleted as a PERMANENTFLAGS flag causes + * some clients (particularly Thunderbird) to misbehave -- they simply + * elect not to transmit the flag at all. So we have to advertise + * \Deleted as a PERMANENTFLAGS flag, even though it technically isn't. */ cprintf("* FLAGS (\\Deleted \\Seen \\Answered)\r\n"); - cprintf("* OK [PERMANENTFLAGS (\\Deleted \\Seen \\Answered)] " - "permanent flags\r\n"); + cprintf("* OK [PERMANENTFLAGS (\\Deleted \\Seen \\Answered)] permanent flags\r\n"); cprintf("%s OK [%s] %s completed\r\n", parms[0], @@ -766,7 +801,7 @@ int imap_do_expunge(void) long *delmsgs = NULL; int num_delmsgs = 0; - lprintf(CTDL_DEBUG, "imap_do_expunge() called\n"); + CtdlLogPrintf(CTDL_DEBUG, "imap_do_expunge() called\n"); if (IMAP->selected == 0) { return (0); } @@ -789,7 +824,7 @@ int imap_do_expunge(void) imap_rescan_msgids(); } - lprintf(CTDL_DEBUG, "Expunged %d messages from <%s>\n", + CtdlLogPrintf(CTDL_DEBUG, "Expunged %d messages from <%s>\n", num_expunged, CC->room.QRname); return (num_expunged); } @@ -877,11 +912,16 @@ void imap_create(int num_parms, char *parms[]) int flags; int newroomtype = 0; int newroomview = 0; + char *notification_message = NULL; + + if (num_parms < 3) { + cprintf("%s NO A foder name must be specified\r\n", parms[0]); + return; + } if (strchr(parms[2], '\\') != NULL) { - cprintf("%s NO Invalid character in folder name\r\n", - parms[0]); - lprintf(CTDL_DEBUG, "invalid character in folder name\n"); + cprintf("%s NO Invalid character in folder name\r\n", parms[0]); + CtdlLogPrintf(CTDL_DEBUG, "invalid character in folder name\n"); return; } @@ -889,7 +929,7 @@ void imap_create(int num_parms, char *parms[]) if (ret < 0) { cprintf("%s NO Invalid mailbox name or location\r\n", parms[0]); - lprintf(CTDL_DEBUG, "invalid mailbox name or location\n"); + CtdlLogPrintf(CTDL_DEBUG, "invalid mailbox name or location\n"); return; } floornum = (ret & 0x00ff); /* lower 8 bits = floor number */ @@ -898,7 +938,7 @@ void imap_create(int num_parms, char *parms[]) if (flags & IR_MAILBOX) { if (strncasecmp(parms[2], "INBOX/", 6)) { cprintf("%s NO Personal folders must be created under INBOX\r\n", parms[0]); - lprintf(CTDL_DEBUG, "not subordinate to inbox\n"); + CtdlLogPrintf(CTDL_DEBUG, "not subordinate to inbox\n"); return; } } @@ -911,7 +951,7 @@ void imap_create(int num_parms, char *parms[]) newroomview = VIEW_BBS; } - lprintf(CTDL_INFO, "Create new room <%s> on floor <%d> with type <%d>\n", + CtdlLogPrintf(CTDL_INFO, "Create new room <%s> on floor <%d> with type <%d>\n", roomname, floornum, newroomtype); ret = create_room(roomname, newroomtype, "", floornum, 1, 0, newroomview); @@ -920,8 +960,20 @@ void imap_create(int num_parms, char *parms[]) cprintf("%s NO Mailbox already exists, or create failed\r\n", parms[0]); } else { cprintf("%s OK CREATE completed\r\n", parms[0]); + /* post a message in Aide> describing the new room */ + notification_message = malloc(1024); + snprintf(notification_message, 1024, + "A new room called \"%s\" has been created by %s%s%s%s\n", + roomname, + CC->user.fullname, + ((ret & QR_MAILBOX) ? " [personal]" : ""), + ((ret & QR_PRIVATE) ? " [private]" : ""), + ((ret & QR_GUESSNAME) ? " [hidden]" : "") + ); + aide_message(notification_message, "Room Creation Message"); + free(notification_message); } - lprintf(CTDL_DEBUG, "imap_create() completed\n"); + CtdlLogPrintf(CTDL_DEBUG, "imap_create() completed\n"); } @@ -993,7 +1045,7 @@ void imap_status(int num_parms, char *parms[]) char savedroom[ROOMNAMELEN]; int msgs, new; - ret = imap_grabroom(roomname, parms[2], 0); + ret = imap_grabroom(roomname, parms[2], 1); if (ret != 0) { cprintf ("%s NO Invalid mailbox name or location, or access denied\r\n", @@ -1095,7 +1147,7 @@ void imap_unsubscribe(int num_parms, char *parms[]) char savedroom[ROOMNAMELEN]; int msgs, new; - ret = imap_grabroom(roomname, parms[2], 0); + ret = imap_grabroom(roomname, parms[2], 1); if (ret != 0) { cprintf ("%s NO Invalid mailbox name or location, or access denied\r\n", @@ -1234,6 +1286,7 @@ void imap_rename(int num_parms, char *parms[]) struct irl *irl = NULL; /* the list */ struct irl *irlp = NULL; /* scratch pointer */ struct irlparms irlparms; + char buf[1024]; if (strchr(parms[3], '\\') != NULL) { cprintf("%s NO Invalid character in folder name\r\n", @@ -1275,7 +1328,6 @@ void imap_rename(int num_parms, char *parms[]) return; } - /* If this is the INBOX, then RFC2060 says we have to just move the * contents. In a Citadel environment it's easier to rename the room * (already did that) and create a new inbox. @@ -1298,7 +1350,7 @@ void imap_rename(int num_parms, char *parms[]) irl->irl_newfloor); if (r != crr_ok) { /* FIXME handle error returns better */ - lprintf(CTDL_ERR, "CtdlRenameRoom() error %d\n", r); + CtdlLogPrintf(CTDL_ERR, "CtdlRenameRoom() error %d\n", r); } irlp = irl; irl = irl->next; @@ -1306,6 +1358,13 @@ void imap_rename(int num_parms, char *parms[]) } } + snprintf(buf, sizeof buf, "IMAP folder \"%s\" renamed to \"%s\" by %s\n", + parms[2], + parms[3], + CC->curr_user + ); + aide_message(buf, "IMAP folder rename"); + cprintf("%s OK RENAME completed\r\n", parms[0]); } @@ -1322,28 +1381,29 @@ void imap_command_loop(void) int num_parms; struct timeval tv1, tv2; suseconds_t total_time = 0; + int untagged_ok = 1; gettimeofday(&tv1, NULL); CC->lastcmd = time(NULL); memset(cmdbuf, 0, sizeof cmdbuf); /* Clear it, just in case */ flush_output(); if (client_getln(cmdbuf, sizeof cmdbuf) < 1) { - lprintf(CTDL_ERR, "Client disconnected: ending session.\r\n"); + CtdlLogPrintf(CTDL_ERR, "Client disconnected: ending session.\r\n"); CC->kill_me = 1; return; } if (IMAP->authstate == imap_as_expecting_password) { - lprintf(CTDL_INFO, "IMAP: \n"); + CtdlLogPrintf(CTDL_INFO, "IMAP: \n"); } else if (IMAP->authstate == imap_as_expecting_plainauth) { - lprintf(CTDL_INFO, "IMAP: \n"); + CtdlLogPrintf(CTDL_INFO, "IMAP: \n"); } else if (bmstrcasestr(cmdbuf, " LOGIN ")) { - lprintf(CTDL_INFO, "IMAP: LOGIN...\n"); + CtdlLogPrintf(CTDL_INFO, "IMAP: LOGIN...\n"); } else { - lprintf(CTDL_INFO, "IMAP: %s\n", cmdbuf); + CtdlLogPrintf(CTDL_INFO, "IMAP: %s\n", cmdbuf); } while (strlen(cmdbuf) < 5) @@ -1375,15 +1435,32 @@ void imap_command_loop(void) * If the command just submitted does not contain a literal, we * might think about delivering some untagged stuff... */ - if (cmdbuf[strlen(cmdbuf)-1] != '}') { + if (cmdbuf[strlen(cmdbuf)-1] == '}') { + untagged_ok = 0; + } - imap_print_instant_messages(); + /* Grab the tag, command, and parameters. */ + num_parms = imap_parameterize(parms, cmdbuf); + + /* RFC3501 says that we cannot output untagged data during these commands */ + if (num_parms >= 2) { + if ( (!strcasecmp(parms[1], "FETCH")) + || (!strcasecmp(parms[1], "STORE")) + || (!strcasecmp(parms[1], "SEARCH")) + ) { + untagged_ok = 0; + } + } + if (untagged_ok) { + + /* we can put any additional untagged stuff right here in the future */ + /* * Before processing the command that was just entered... if we happen * to have a folder selected, we'd like to rescan that folder for new * messages, and for deletions/changes of existing messages. This - * could probably be optimized somehow, but IMAP sucks... + * could probably be optimized better with some deep thought... */ if (IMAP->selected) { imap_rescan_msgids(); @@ -1392,8 +1469,6 @@ void imap_command_loop(void) /* Now for the command set. */ - /* Grab the tag, command, and parameters. Check syntax. */ - num_parms = imap_parameterize(parms, cmdbuf); if (num_parms < 2) { cprintf("BAD syntax error\r\n"); } @@ -1413,7 +1488,7 @@ void imap_command_loop(void) else if (!strcasecmp(parms[1], "LOGOUT")) { if (IMAP->selected) { - imap_do_expunge(); /* yes, we auto-expunge */ + imap_do_expunge(); /* yes, we auto-expunge at logout */ } cprintf("* BYE %s logging out\r\n", config.c_fqdn); cprintf("%s OK Citadel IMAP session ended.\r\n", @@ -1586,7 +1661,8 @@ void imap_command_loop(void) gettimeofday(&tv2, NULL); total_time = (tv2.tv_usec + (tv2.tv_sec * 1000000)) - (tv1.tv_usec + (tv1.tv_sec * 1000000)); - lprintf(CTDL_DEBUG, "IMAP command completed in %ld.%ld seconds\n", + CtdlLogPrintf(CTDL_INFO, "IMAP: %s\n", cmdbuf); // FIXME FIXME FIXME REMOVE THIS NOW + CtdlLogPrintf(CTDL_DEBUG, "IMAP command completed in %ld.%ld seconds\n", (total_time / 1000000), (total_time % 1000000) );