X-Git-Url: https://code.citadel.org/?a=blobdiff_plain;f=citadel%2Fmodules%2Fxmpp%2Fserv_xmpp.c;h=6eb0fb6d1ba04a9e5804c8b1d3f06249e7669ab4;hb=7f1677e8798d3cb77fa9860b3bd1b8e3cbd332ab;hp=3248a11cb39bbbf98b1281ec78082c10d3da3774;hpb=7e8e24791e16e0a94ed346c6a11595a40d3a31b1;p=citadel.git diff --git a/citadel/modules/xmpp/serv_xmpp.c b/citadel/modules/xmpp/serv_xmpp.c index 3248a11cb..6eb0fb6d1 100644 --- a/citadel/modules/xmpp/serv_xmpp.c +++ b/citadel/modules/xmpp/serv_xmpp.c @@ -1,6 +1,6 @@ /* * XMPP (Jabber) service for the Citadel system - * Copyright (c) 2007-2017 by Art Cancro and citadel.org + * Copyright (c) 2007-2019 by Art Cancro and citadel.org * * This program is open source software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -57,6 +57,9 @@ #include "ctdl_module.h" #include "serv_xmpp.h" +/* uncomment for more verbosity - it will log all received XML tags */ +// #define XMPP_XML_DEBUG + /* XML_StopParser is present in expat 2.x */ #if XML_MAJOR_VERSION > 1 #define HAVE_XML_STOPPARSER @@ -64,9 +67,6 @@ struct xmpp_event *xmpp_queue = NULL; - - - #ifdef HAVE_XML_STOPPARSER /* Stop the parser if an entity declaration is hit. */ static void xmpp_entity_declaration(void *userData, const XML_Char *entityName, @@ -81,31 +81,34 @@ static void xmpp_entity_declaration(void *userData, const XML_Char *entityName, #endif - /* - * Given a source string and a target buffer, returns the string - * properly escaped for insertion into an XML stream. Returns a - * pointer to the target buffer for convenience. + * support function for xmlesc() which helps with UTF-8 strings */ static inline int Ctdl_GetUtf8SequenceLength(const char *CharS, const char *CharE) { int n = 0; unsigned char test = (1<<7); - if ((*CharS & 0xC0) != 0xC0) + if ((*CharS & 0xC0) != 0xC0) { return 1; + } - while ((n < 8) && - ((test & ((unsigned char)*CharS)) != 0)) - { + while ((n < 8) && ((test & ((unsigned char)*CharS)) != 0)) { test = test >> 1; n ++; } - if ((n > 6) || ((CharE - CharS) < n)) + if ((n > 6) || ((CharE - CharS) < n)) { n = 0; + } return n; } + +/* + * Given a source string and a target buffer, returns the string + * properly escaped for insertion into an XML stream. Returns a + * pointer to the target buffer for convenience. + */ char *xmlesc(char *buf, char *str, int bufsiz) { int IsUtf8Sequence; @@ -142,8 +145,7 @@ char *xmlesc(char *buf, char *str, int bufsiz) buf[len] = 0; } else if (ch < 0x20) { - /* we probably shouldn't be doing this */ - buf[len++] = '_'; + buf[len++] = '_'; // we probably shouldn't be doing this buf[len] = 0; } else { @@ -189,7 +191,6 @@ void xmpp_stream_start(void *data, const char *supplied_el, const char **attr) } cprintf(""); - cprintf("server_name, sizeof xmlbuf)); cprintf("id=\"%08x\" ", CC->cs_pid); @@ -220,7 +221,6 @@ void xmpp_stream_start(void *data, const char *supplied_el, const char **attr) /* Offer binding and sessions as part of our feature set */ cprintf(""); cprintf(""); - cprintf(""); CC->is_async = 1; /* XMPP sessions are inherently async-capable */ @@ -232,18 +232,20 @@ void xmpp_xml_start(void *data, const char *supplied_el, const char **attr) { char *sep = NULL; int i; - /* Axe the namespace, we don't care about it */ + /* Create a version of the element with the namespace removed. + * Now we can access "el" or "supplied_el" depending on whether we want to see the whole namespace. + */ safestrncpy(el, supplied_el, sizeof el); while (sep = strchr(el, ':'), sep) { strcpy(el, ++sep); } - /* +#ifdef XMPP_XML_DEBUG syslog(LOG_DEBUG, "xmpp: ELEMENT START: <%s>", el); for (i=0; attr[i] != NULL; i+=2) { syslog(LOG_DEBUG, "xmpp: Attribute '%s' = '%s'", attr[i], attr[i+1]); } - uncomment for more verbosity */ +#endif if (!strcasecmp(el, "stream")) { xmpp_stream_start(data, supplied_el, attr); @@ -298,45 +300,43 @@ void xmpp_xml_start(void *data, const char *supplied_el, const char **attr) { } - void xmpp_xml_end(void *data, const char *supplied_el) { char el[256]; char *sep = NULL; char xmlbuf[256]; - /* Axe the namespace, we don't care about it */ + /* Create a version of the element with the namespace removed. + * Now we can access "el" or "supplied_el" depending on whether we want to see the whole namespace. + */ safestrncpy(el, supplied_el, sizeof el); while (sep = strchr(el, ':'), sep) { strcpy(el, ++sep); } - /* +#ifdef XMPP_XML_DEBUG syslog(LOG_DEBUG, "xmpp: ELEMENT END : <%s>", el); if (XMPP->chardata_len > 0) { syslog(LOG_DEBUG, "xmpp: chardata: %s", XMPP->chardata); } - uncomment for more verbosity */ +#endif if (!strcasecmp(el, "resource")) { if (XMPP->chardata_len > 0) { - safestrncpy(XMPP->iq_client_resource, XMPP->chardata, - sizeof XMPP->iq_client_resource); + safestrncpy(XMPP->iq_client_resource, XMPP->chardata, sizeof XMPP->iq_client_resource); striplt(XMPP->iq_client_resource); } } else if (!strcasecmp(el, "username")) { /* NON SASL ONLY */ if (XMPP->chardata_len > 0) { - safestrncpy(XMPP->iq_client_username, XMPP->chardata, - sizeof XMPP->iq_client_username); + safestrncpy(XMPP->iq_client_username, XMPP->chardata, sizeof XMPP->iq_client_username); striplt(XMPP->iq_client_username); } } else if (!strcasecmp(el, "password")) { /* NON SASL ONLY */ if (XMPP->chardata_len > 0) { - safestrncpy(XMPP->iq_client_password, XMPP->chardata, - sizeof XMPP->iq_client_password); + safestrncpy(XMPP->iq_client_password, XMPP->chardata, sizeof XMPP->iq_client_password); striplt(XMPP->iq_client_password); } } @@ -352,8 +352,7 @@ void xmpp_xml_end(void *data, const char *supplied_el) { * Query on a namespace */ if (!IsEmptyStr(XMPP->iq_query_xmlns)) { - xmpp_query_namespace(XMPP->iq_id, XMPP->iq_from, - XMPP->iq_to, XMPP->iq_query_xmlns); + xmpp_query_namespace(XMPP->iq_id, XMPP->iq_from, XMPP->iq_to, XMPP->iq_query_xmlns); } /* @@ -370,6 +369,20 @@ void xmpp_xml_end(void *data, const char *supplied_el) { cprintf("id=\"%s\"/>", xmlesc(xmlbuf, XMPP->iq_id, sizeof xmlbuf)); } + /* + * Client is requesting its own vCard + * (If we make this more elaborate, move it to a separate function) + */ + else if (XMPP->iq_vcard) { + cprintf("iq_id, sizeof xmlbuf)); + cprintf("to=\"%s\">", xmlesc(xmlbuf, XMPP->iq_from, sizeof xmlbuf)); + cprintf(""); + cprintf("%s", xmlesc(xmlbuf, CC->user.fullname, sizeof xmlbuf)); + cprintf("%s", xmlesc(xmlbuf, CC->user.fullname, sizeof xmlbuf)); + cprintf(""); + cprintf(""); + } + /* * Unknown query ... return the XML equivalent of a blank stare */ @@ -390,14 +403,8 @@ void xmpp_xml_end(void *data, const char *supplied_el) { else if ( (!strcasecmp(XMPP->iq_type, "set")) && (!strcasecmp(XMPP->iq_query_xmlns, "jabber:iq:auth:query")) - ) { - - xmpp_non_sasl_authenticate( - XMPP->iq_id, - XMPP->iq_client_username, - XMPP->iq_client_password, - XMPP->iq_client_resource - ); + ) { + xmpp_non_sasl_authenticate(XMPP->iq_id, XMPP->iq_client_username, XMPP->iq_client_password); } /* @@ -406,20 +413,17 @@ void xmpp_xml_end(void *data, const char *supplied_el) { else if ( (XMPP->bind_requested) && (!IsEmptyStr(XMPP->iq_id)) - && (!IsEmptyStr(XMPP->iq_client_resource)) && (CC->logged_in) - ) { - - /* Generate the "full JID" of the client resource */ + ) { + /* If the client has not specified a client resource, generate one */ + if (IsEmptyStr(XMPP->iq_client_resource)) { + snprintf(XMPP->iq_client_resource, sizeof XMPP->iq_client_resource, "%d", CC->cs_pid); + } - snprintf(XMPP->client_jid, sizeof XMPP->client_jid, - "%s/%s", - CC->cs_inet_email, - XMPP->iq_client_resource - ); + /* Generate the "full JID" of the client (user@host/resource) */ + snprintf(XMPP->client_jid, sizeof XMPP->client_jid, "%s/%s", CC->cs_inet_email, XMPP->iq_client_resource); /* Tell the client what its JID is */ - cprintf("", xmlesc(xmlbuf, XMPP->iq_id, sizeof xmlbuf)); cprintf(""); cprintf("%s", xmlesc(xmlbuf, XMPP->client_jid, sizeof xmlbuf)); @@ -434,8 +438,9 @@ void xmpp_xml_end(void *data, const char *supplied_el) { else { cprintf("", xmlesc(xmlbuf, XMPP->iq_id, sizeof xmlbuf)); - cprintf("Don't know howto do '%s'!", xmlesc(xmlbuf, XMPP->iq_type, sizeof xmlbuf)); + cprintf("Don't know how to do '%s'!", xmlesc(xmlbuf, XMPP->iq_type, sizeof xmlbuf)); cprintf(""); + syslog(LOG_DEBUG, "XMPP: don't know how to do iq_type='%s' with iq_query_xmlns='%s'", XMPP->iq_type, XMPP->iq_query_xmlns); } /* Now clear these fields out so they don't get used by a future stanza */ @@ -445,13 +450,13 @@ void xmpp_xml_end(void *data, const char *supplied_el) { XMPP->iq_type[0] = 0; XMPP->iq_client_resource[0] = 0; XMPP->iq_session = 0; + XMPP->iq_vcard = 0; XMPP->iq_query_xmlns[0] = 0; XMPP->bind_requested = 0; XMPP->ping_requested = 0; } else if (!strcasecmp(el, "auth")) { - /* Try to authenticate (this function is responsible for the output stanza) */ xmpp_sasl_auth(XMPP->sasl_auth_mech, (XMPP->chardata != NULL ? XMPP->chardata : "") ); @@ -463,8 +468,11 @@ void xmpp_xml_end(void *data, const char *supplied_el) { XMPP->iq_session = 1; } - else if (!strcasecmp(el, "presence")) { + else if (!strcasecmp(supplied_el, "vcard-temp:vCard")) { + XMPP->iq_vcard = 1; + } + else if (!strcasecmp(el, "presence")) { /* Respond to a update by firing back with presence information * on the entire wholist. Check this assumption, it's probably wrong. */ @@ -571,7 +579,6 @@ void xmpp_cleanup_function(void) { } - /* * Here's where our XMPP session begins its happy day. */