From: Art Cancro <ajc@citadel.org>
Date: Fri, 7 Jul 2023 20:52:30 +0000 (-0900)
Subject: view_mail.js: set variables to local scope
X-Git-Tag: v981~43
X-Git-Url: https://code.citadel.org/?a=commitdiff_plain;h=37518e7711961f6d02452ec5e88fd96a3a4f586c;p=citadel.git

view_mail.js: set variables to local scope
---

diff --git a/webcit-ng/static/js/view_mail.js b/webcit-ng/static/js/view_mail.js
index 33beeec36..edf6c7963 100644
--- a/webcit-ng/static/js/view_mail.js
+++ b/webcit-ng/static/js/view_mail.js
@@ -49,8 +49,8 @@ mail_delete_func = async(table, row) => {
 
 // Delete the selected messages (can be activated by mouse click or keypress)
 function mail_delete_selected() {
-	var table = document.getElementById("ctdl-onscreen-mailbox");
-	var i, row;
+	let table = document.getElementById("ctdl-onscreen-mailbox");
+	let i, row;
 	for (i=0; row=table.rows[i]; ++i) {
 		if (row.classList.contains("ctdl-mail-selected")) {
 			mail_delete_func(table, row);
@@ -82,28 +82,26 @@ function mail_keypress(event) {
 
 // Handler function for dragging email messages to other folders
 function mail_dragstart(event) {
-	var i;
-	var count = 0;
-	var table = document.getElementById("ctdl-onscreen-mailbox");
-	var messages_being_dragged = [] ;
+	let i;
+	let count = 0;
+	let table = document.getElementById("ctdl-onscreen-mailbox");
+	let messages_being_dragged = [] ;
 
 	if (event.target.classList.contains("ctdl-mail-selected")) {
 		// The row being dragged IS selected.  See if any OTHER rows are selected, and they will come along for the ride.
 		for (i=1; row=table.rows[i]; ++i) {
 			if (row.classList.contains("ctdl-mail-selected")) {
 				count = count + 1;
-				messages_being_dragged.push(row.id);
+				messages_being_dragged.push(row.id);	// Tell the clipboard what's being moved.
 			}
 		}
 	}
 	else {
 		// The row being dragged is NOT selected.  It will be dragged on its own, ignoring the selected rows.
 		count = 1;
-		messages_being_dragged.push(event.target.id);
+		messages_being_dragged.push(event.target.id);		// Tell the clipboard what's being moved.
 	}
 
-	// FIXME tell the clipboard what's being moved.
-
 	// Set the custom drag image to an envelope + number of messages being dragged
 	d = document.getElementById("ctdl_draggo");
 	d.innerHTML = "<font size='+2'><i class='fa fa-envelope' style='color: red'></i> " + count + "</font>"
@@ -287,7 +285,7 @@ function click_message(event, msgnum) {
 
 // render one row in the mailbox table (this could be called from one of several places)
 function mail_render_row(msg, is_selected) {
-	row	= "<tr "
+	let row	= "<tr "
 		+ "id=\"ctdl-msgsum-" + msg["msgnum"] + "\" "
 		+ (is_selected ? "class=\"ctdl-mail-selected\" " : "")
 		+ "onClick=\"click_message(event," + msg["msgnum"] + ");\""