X-Git-Url: https://code.citadel.org/?p=citadel.git;a=blobdiff_plain;f=citadel%2Fdomain.c;h=18764725e093ae357795411e0915d35364a88107;hp=fda55e86e2f98d0dd0066d63412e96460b97cb7d;hb=51b18018ff923284d76a36cbd421d62abf6afcf4;hpb=de88010bd8faccb2f3249370f6306ac27e88af9d

diff --git a/citadel/domain.c b/citadel/domain.c
index fda55e86e..18764725e 100644
--- a/citadel/domain.c
+++ b/citadel/domain.c
@@ -1,17 +1,20 @@
 /*
- * $Id$
- *
  * DNS lookup for SMTP sender
  *
+ * Copyright (c) 1987-2021 by the citadel.org team
+ *
+ * This program is open source software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License, version 3.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
  */
 
 #include "sysdep.h"
-#include <stdlib.h>
-#include <unistd.h>
-#include <string.h>
-#include <netinet/in.h>
 #include <stdio.h>
-
+#include <syslog.h>
 #ifdef HAVE_RESOLV_H
 #include <arpa/nameser.h>
 #ifdef HAVE_ARPA_NAMESER_COMPAT_H
@@ -23,7 +26,6 @@
 #include "sysdep_decls.h"
 #include "citadel.h"
 #include "domain.h"
-#include "server.h"
 #include "internet_addressing.h"
 
 
@@ -110,56 +112,44 @@ int getmx(char *mxbuf, char *dest) {
 	unsigned short pref, type;
 	int n = 0;
 	int qdcount;
+	Array *mxrecords = NULL;
+	struct mx mx;
 
-	struct mx *mxrecs = NULL;
-	int num_mxrecs = 0;
-	
-	/* If we're configured to send all mail to a smart-host, then our
-	 * job here is really easy.
-	 */
+	// If we're configured to send all mail to a smart-host, then our job here is really easy -- just return those.
 	n = get_hosts(mxbuf, "smarthost");
-	if (n > 0) return(n);
+	if (n > 0) {
+		return(n);
+	}
 
-	/*
-	 * No smart-host?  Look up the best MX for a site.
-	 * Make a call to the resolver library.
-	 */
+	mxrecords = array_new(sizeof(struct mx));
 
-	ret = res_query(
-		dest,
-		C_IN, T_MX, (unsigned char *)answer.bytes, sizeof(answer)  );
+	// No smart-host?  Look up the best MX for a site.  Make a call to the resolver library.
+	ret = res_query(dest, C_IN, T_MX, (unsigned char *)answer.bytes, sizeof(answer));
 
 	if (ret < 0) {
-		mxrecs = malloc(sizeof(struct mx));
-		mxrecs[0].pref = 0;
-		strcpy(mxrecs[0].host, dest);
-		num_mxrecs = 1;
+		mx.pref = 0;
+		strcpy(mx.host, dest);
+		array_append(mxrecords, &mx);
 	}
 	else {
-
-		/* If we had to truncate, shrink the number to avoid fireworks */
-		if (ret > sizeof(answer))
+		if (ret > sizeof(answer)) {		// If we had to truncate, shrink the number to avoid fireworks
 			ret = sizeof(answer);
-	
-		startptr = &answer.bytes[0];		/* start and end of buffer */
+		}
+
+		startptr = &answer.bytes[0];		// start and end of buffer
 		endptr = &answer.bytes[ret];
-		ptr = startptr + HFIXEDSZ;	/* advance past header */
+		ptr = startptr + HFIXEDSZ;		// advance past header
 	
 		for (qdcount = ntohs(answer.header.qdcount); qdcount--; ptr += ret + QFIXEDSZ) {
 			if ((ret = dn_skipname(ptr, endptr)) < 0) {
-				lprintf(CTDL_DEBUG, "dn_skipname error\n");
+				syslog(LOG_DEBUG, "domain: dn_skipname error");
 				return(0);
 			}
 		}
 	
 		while(1) {
 			memset(expanded_buf, 0, sizeof(expanded_buf));
-			ret = dn_expand(startptr,
-					endptr,
-					ptr,
-					expanded_buf,
-					sizeof(expanded_buf)
-					);
+			ret = dn_expand(startptr, endptr, ptr, expanded_buf, sizeof(expanded_buf));
 			if (ret < 0) break;
 			ptr += ret;
 	
@@ -173,40 +163,30 @@ int getmx(char *mxbuf, char *dest) {
 	
 			else {
 				GETSHORT(pref, ptr);
-				ret = dn_expand(startptr,
-						endptr,
-						ptr,
-						expanded_buf,
-						sizeof(expanded_buf)
-						);
+				ret = dn_expand(startptr, endptr, ptr, expanded_buf, sizeof(expanded_buf));
 				ptr += ret;
 	
-				++num_mxrecs;
-				if (mxrecs == NULL) {
-					mxrecs = malloc(sizeof(struct mx));
-				}
-				else {
-					mxrecs = realloc(mxrecs,
-					    (sizeof(struct mx) * num_mxrecs) );
-				}
-	
-				mxrecs[num_mxrecs - 1].pref = pref;
-				strcpy(mxrecs[num_mxrecs - 1].host,
-				       expanded_buf);
+				mx.pref = pref;
+				strcpy(mx.host, expanded_buf);
+				array_append(mxrecords, &mx);
 			}
 		}
 	}
 
-	/* Sort the MX records by preference */
-	if (num_mxrecs > 1) {
-		qsort(mxrecs, num_mxrecs, sizeof(struct mx), mx_compare_pref);
+	// Sort the MX records by preference
+	if (array_len(mxrecords) > 1) {
+		array_sort(mxrecords, mx_compare_pref);
 	}
 
+	int num_mxrecs = array_len(mxrecords);
 	strcpy(mxbuf, "");
 	for (n=0; n<num_mxrecs; ++n) {
-		strcat(mxbuf, mxrecs[n].host);
+		strcat(mxbuf, ((struct mx *)array_get_element_at(mxrecords, n))->host);
 		strcat(mxbuf, "|");
 	}
-	free(mxrecs);
+	array_free(mxrecords);
+
+	// Append any fallback smart hosts we have configured.
+	num_mxrecs += get_hosts(&mxbuf[strlen(mxbuf)], "fallbackhost");
 	return(num_mxrecs);
 }