From: Art Cancro <ajc@uncensored.citadel.org>
Date: Thu, 28 Jul 2011 16:45:04 +0000 (-0400)
Subject: Removed the Base64 encoding in RSS feed links.  There was a bug in the other implemen... 
X-Git-Tag: v8.01~95
X-Git-Url: https://code.citadel.org/?p=citadel.git;a=commitdiff_plain;h=feb684dfef5f3b343263d2344406816b3eb1c76f

Removed the Base64 encoding in RSS feed links.  There was a bug in the other implementation and it was easier to just do it this way.  It's all StrBuf now, which Willi will like :)
---

diff --git a/webcit/feed_generator.c b/webcit/feed_generator.c
index c94013fc5..1c2d44daa 100644
--- a/webcit/feed_generator.c
+++ b/webcit/feed_generator.c
@@ -267,17 +267,17 @@ void tmplput_rssmeta(StrBuf *Target, WCTemplputParams *TP)
  */
 void tmplput_rssbutton(StrBuf *Target, WCTemplputParams *TP) 
 {
-	wcsession *WCC = WC;
-	char feed_link[1024];
-	char encoded_link[1024];
+	StrBuf *FeedLink = NULL;
 
-	strcpy(feed_link, "/feed_rss?go=");
-	urlesc(&feed_link[20], sizeof(feed_link) - 20, (char *)ChrPtr(WCC->CurRoom.name) );
-	CtdlEncodeBase64(encoded_link, feed_link, strlen(feed_link), 0);
+	FeedLink = NewStrBufPlain(HKEY("/feed_rss?go="));
+	StrBufUrlescAppend(FeedLink, WC->CurRoom.name, NULL);
 
-	StrBufAppendPrintf(Target, "<a type=\"application/rss+xml\" href=\"/B64%s\">", encoded_link);
-	StrBufAppendPrintf(Target, "<img src=\"static/webcit_icons/essen/16x16/rss.png\" alt=\"RSS\">");
+	StrBufAppendPrintf(Target, "<a type=\"application/rss+xml\" href=\"");
+	StrBufAppendBuf(Target, FeedLink, 0);
+	StrBufAppendPrintf(Target, "\"><img src=\"static/webcit_icons/essen/16x16/rss.png\" alt=\"RSS\">");
 	StrBufAppendPrintf(Target, "</a>");
+
+	FreeStrBuf(&FeedLink);
 }