citadel.git
12 years agoInternal version number to 8.01 for imminent release v8.01
Art Cancro [Wed, 12 Oct 2011 20:52:55 +0000 (16:52 -0400)]
Internal version number to 8.01 for imminent release

12 years agoKILL THE ENTIRE IE9 DEVELOPMENT TEAM NOW
Art Cancro [Tue, 11 Oct 2011 21:48:19 +0000 (17:48 -0400)]
KILL THE ENTIRE IE9 DEVELOPMENT TEAM NOW

12 years agoDIE MICROSOFT DIE IE9 STILL EATING SHIFT AND CTRL
Art Cancro [Tue, 11 Oct 2011 21:31:51 +0000 (17:31 -0400)]
DIE MICROSOFT DIE IE9 STILL EATING SHIFT AND CTRL

12 years agoChanged the way shift/ctrl are observed by the message view and it STILL doesn't...
Art Cancro [Tue, 11 Oct 2011 21:18:59 +0000 (17:18 -0400)]
Changed the way shift/ctrl are observed by the message view and it STILL doesn't work with IE9.

12 years agoChanged the way shift/ctrl are observed by the message view and it STILL doesn't...
Art Cancro [Tue, 11 Oct 2011 20:47:49 +0000 (16:47 -0400)]
Changed the way shift/ctrl are observed by the message view and it STILL doesn't work with IE9.

12 years agounfucked the delete key in IE9
Art Cancro [Tue, 11 Oct 2011 20:32:43 +0000 (16:32 -0400)]
unfucked the delete key in IE9

12 years agoImplemented and documented a '-g' option for WebCit to enable a default landing page...
Art Cancro [Tue, 11 Oct 2011 02:17:24 +0000 (22:17 -0400)]
Implemented and documented a '-g' option for WebCit to enable a default landing page for guests.

12 years agoRemoved the arbitrary redirectors file.
Art Cancro [Tue, 11 Oct 2011 02:04:09 +0000 (22:04 -0400)]
Removed the arbitrary redirectors file.
This was a half-baked feature and I don't want it anymore.

12 years agoFix editing of ignet node configs; needed to specify the proper post action.
Wilfried Goesgens [Sat, 8 Oct 2011 18:28:31 +0000 (18:28 +0000)]
Fix editing of ignet node configs; needed to specify the proper post action.

12 years agoRemoved PIE.htc in places where it makes IE fuck up even more than it usually does...
Art Cancro [Wed, 5 Oct 2011 21:00:25 +0000 (17:00 -0400)]
Removed PIE.htc in places where it makes IE fuck up even more than it usually does.  Die, Microsoft, Die.

12 years agofixed the link to the summary page too
Art Cancro [Thu, 29 Sep 2011 17:50:00 +0000 (13:50 -0400)]
fixed the link to the summary page too

12 years agoRepaired the user list command
Art Cancro [Thu, 29 Sep 2011 17:48:15 +0000 (13:48 -0400)]
Repaired the user list command

12 years agoctdlsh now has two working commands, 'date' and 'passwd'
Art Cancro [Tue, 27 Sep 2011 02:48:05 +0000 (22:48 -0400)]
ctdlsh now has two working commands, 'date' and 'passwd'

12 years agomore fiddling around with ctdlsh
Art Cancro [Mon, 26 Sep 2011 22:00:18 +0000 (18:00 -0400)]
more fiddling around with ctdlsh

12 years agoAdded verbose and non-verbose runtime options to ctdlsalearn
Art Cancro [Mon, 26 Sep 2011 16:57:51 +0000 (12:57 -0400)]
Added verbose and non-verbose runtime options to ctdlsalearn

12 years agopoking around in the ctdlsh source because citadel proper is in deep freeze :)
Art Cancro [Mon, 26 Sep 2011 14:55:35 +0000 (10:55 -0400)]
poking around in the ctdlsh source because citadel proper is in deep freeze :)

12 years agoUsername needs to be url encoded too.
Wilfried Goesgens [Sat, 24 Sep 2011 12:35:43 +0000 (12:35 +0000)]
Username needs to be url encoded too.

12 years agocorrect error message hint
Wilfried Goesgens [Tue, 20 Sep 2011 20:55:28 +0000 (20:55 +0000)]
correct error message hint

12 years agoMerge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel
Wilfried Goesgens [Tue, 20 Sep 2011 20:51:51 +0000 (20:51 +0000)]
Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel

12 years agoremove unneeded line
Wilfried Goesgens [Tue, 20 Sep 2011 20:50:40 +0000 (20:50 +0000)]
remove unneeded line

12 years agodocumentation
Art Cancro [Tue, 20 Sep 2011 20:35:28 +0000 (16:35 -0400)]
documentation

12 years agodocumentation
Art Cancro [Tue, 20 Sep 2011 20:31:36 +0000 (16:31 -0400)]
documentation

12 years agoRoom links in iconbar roomlist now properly escaped with encodeURIcomponent()
Art Cancro [Tue, 20 Sep 2011 19:42:11 +0000 (15:42 -0400)]
Room links in iconbar roomlist now properly escaped with encodeURIcomponent()

12 years agoChanged the naming convention of the setup wizard filename
Art Cancro [Tue, 20 Sep 2011 19:02:25 +0000 (15:02 -0400)]
Changed the naming convention of the setup wizard filename

12 years agoThe definition of ThreadIdHash() has been moved from webcit.h to libcitadel.h
Art Cancro [Tue, 20 Sep 2011 18:37:54 +0000 (14:37 -0400)]
The definition of ThreadIdHash() has been moved from webcit.h to libcitadel.h

12 years agoUse base64 encoding for permalinks in bbs rooms, otherwise google+ mangles them
Art Cancro [Tue, 20 Sep 2011 16:31:48 +0000 (12:31 -0400)]
Use base64 encoding for permalinks in bbs rooms, otherwise google+ mangles them

12 years agoDisable RSS-shorter link expander.
Wilfried Goesgens [Tue, 20 Sep 2011 14:38:46 +0000 (14:38 +0000)]
Disable RSS-shorter link expander.

12 years agoremove notes about 'W' double use again.
Wilfried Goesgens [Tue, 20 Sep 2011 14:31:53 +0000 (14:31 +0000)]
remove notes about 'W' double use again.

12 years agoserv_extnotify now uses field '2' instead of field 'W' within the server; resolve...
Art Cancro [Tue, 20 Sep 2011 13:47:56 +0000 (09:47 -0400)]
serv_extnotify now uses field '2' instead of field 'W' within the server; resolve conflict with the use of 'W' for references

12 years agoFix indention; its broken in some places which seems to hide memleaks.
Wilfried Goesgens [Mon, 19 Sep 2011 18:47:52 +0000 (18:47 +0000)]
Fix indention; its broken in some places which seems to hide memleaks.

12 years agofix possible leaks around 'W'; the funambol code abuses it.
Wilfried Goesgens [Mon, 19 Sep 2011 21:19:12 +0000 (21:19 +0000)]
fix possible leaks around 'W'; the funambol code abuses it.

12 years agoFix memory leaks in the networker
Wilfried Goesgens [Mon, 19 Sep 2011 21:18:24 +0000 (21:18 +0000)]
Fix memory leaks in the networker

12 years ago'W' is double used for the user when doing extnotify spool messages; add this to...
Wilfried Goesgens [Mon, 19 Sep 2011 18:50:47 +0000 (18:50 +0000)]
'W' is double used for the user when doing extnotify spool messages; add this to our column description.

12 years agoFix indention; its broken in some places which seems to hide memleaks.
Wilfried Goesgens [Mon, 19 Sep 2011 18:47:52 +0000 (18:47 +0000)]
Fix indention; its broken in some places which seems to hide memleaks.

12 years ago.debs: citserver depends on patch now.
Wilfried Goesgens [Fri, 16 Sep 2011 18:53:13 +0000 (18:53 +0000)]
.debs: citserver depends on patch now.

12 years agoUpgrade TinyMCE to v3.4.5
Art Cancro [Thu, 15 Sep 2011 16:35:49 +0000 (12:35 -0400)]
Upgrade TinyMCE to v3.4.5

12 years agoConditional_USER_HAS_PIC() was leaving the download file open, causing the actual...
Art Cancro [Wed, 14 Sep 2011 21:49:51 +0000 (17:49 -0400)]
Conditional_USER_HAS_PIC() was leaving the download file open, causing the actual download to fail.  Fixed.

12 years agoWrite out a log message when an unparented blog comment is encountered
Art Cancro [Wed, 14 Sep 2011 20:28:46 +0000 (16:28 -0400)]
Write out a log message when an unparented blog comment is encountered

12 years agobbsview_renderer 'go to page' links now use start_reading_at= instead of page= in...
Art Cancro [Wed, 14 Sep 2011 16:24:53 +0000 (12:24 -0400)]
bbsview_renderer 'go to page' links now use start_reading_at= instead of page= in order to make them more persistent when archived or indexed.

12 years agobbsview_renderer readfwd links now include a go= parameter to include the room name
Art Cancro [Wed, 14 Sep 2011 16:03:30 +0000 (12:03 -0400)]
bbsview_renderer readfwd links now include a go= parameter to include the room name

12 years agoRemoving of static vars in the Networker
Wilfried Goesgens [Wed, 14 Sep 2011 13:34:35 +0000 (13:34 +0000)]
Removing of static vars in the Networker

  - we have to fiddle them through the SpoolControl structure into the ForeachMessage() loop.

12 years agooops ... there was no way to delete blog comments ... fixed that
Art Cancro [Tue, 13 Sep 2011 20:35:21 +0000 (16:35 -0400)]
oops ... there was no way to delete blog comments ... fixed that

12 years agoOnly show the Search box in the mailbox view because that's the only view that it...
Art Cancro [Tue, 13 Sep 2011 19:04:10 +0000 (15:04 -0400)]
Only show the Search box in the mailbox view because that's the only view that it works in.

12 years agoUse autoconf to locate the diff and patch executables and pass those pathnames to...
Art Cancro [Mon, 12 Sep 2011 15:53:20 +0000 (11:53 -0400)]
Use autoconf to locate the diff and patch executables and pass those pathnames to serv_wiki.c

12 years agoAdded a couple more entity declarations
Art Cancro [Fri, 9 Sep 2011 17:04:25 +0000 (13:04 -0400)]
Added a couple more entity declarations

12 years agoRemove global variables; replace by stack passing.
Wilfried Goesgens [Thu, 8 Sep 2011 17:18:12 +0000 (17:18 +0000)]
Remove global variables; replace by stack passing.

12 years agoCC -> CCC in do_login
Wilfried Goesgens [Thu, 8 Sep 2011 13:45:29 +0000 (13:45 +0000)]
CC -> CCC in do_login

12 years agoNetworker reordering; remove / change dependencies
Wilfried Goesgens [Thu, 8 Sep 2011 12:35:51 +0000 (12:35 +0000)]
Networker reordering; remove / change dependencies

  - move serv_network.h into modules/network where it belongs...
  - move structs out of serv_network.h into their respective headers
  - serv_expire doesn't need serv_network.h anymore, it seems to get the usetable struct from elsewhere
  - the netfilter module was moved to the network directory, it seems to be closely dangled to networking
  - move all code about the netfilter (config reading) into serv_netfilter.c
  - move the code networker related from msgbase.c:CtdlDoIHavePermissionToPostInThisRoom() into serv_netconfig.c:netconfig_check_roomaccess()
  - move the filterlist instance into serv_netfilter.c

lesson learned the hard way today: if you move a header, flush the dependencies, else the make process will abort with no usefull message at all.
 -> Gentlemen please flush the dependencies and rebootstrap your workingcopy.

12 years agoRemove unused AUTH variable from the buildsystem
Wilfried Goesgens [Thu, 8 Sep 2011 12:07:55 +0000 (12:07 +0000)]
Remove unused AUTH variable from the buildsystem

12 years agoChop networker into handy bits; related functions now live in their own file.
Wilfried Goesgens [Thu, 8 Sep 2011 09:35:01 +0000 (09:35 +0000)]
Chop networker into handy bits; related functions now live in their own file.

  - master has some different vars; adjusted.

12 years agoremove unused code for locking
Wilfried Goesgens [Wed, 7 Sep 2011 21:07:09 +0000 (21:07 +0000)]
remove unused code for locking

12 years agooops, I had SERV_TRACE enabled and committed that. fixed
Art Cancro [Wed, 7 Sep 2011 19:44:18 +0000 (15:44 -0400)]
oops, I had SERV_TRACE enabled and committed that.  fixed

12 years agoNegated a strcmp in netconf.c that caused the function to hang every single time...
Art Cancro [Wed, 7 Sep 2011 19:43:37 +0000 (15:43 -0400)]
Negated a strcmp in netconf.c that caused the function to hang every single time, how did this get this way?

12 years agoHandle return values in Setup; catch errors & remove unneeded code.
Wilfried Goesgens [Wed, 7 Sep 2011 14:56:31 +0000 (14:56 +0000)]
Handle return values in Setup; catch errors & remove unneeded code.

12 years agoCode shuffling fixes warning with inline function... weirdo.
Wilfried Goesgens [Wed, 7 Sep 2011 15:25:11 +0000 (15:25 +0000)]
Code shuffling fixes warning with inline function... weirdo.

12 years agoFix warnings all over citserver; handle function replies; remove unused code.
Wilfried Goesgens [Wed, 7 Sep 2011 14:59:21 +0000 (14:59 +0000)]
Fix warnings all over citserver; handle function replies; remove unused code.

12 years agoCleanup our toolies, remove unneeded code; handle reply values.
Wilfried Goesgens [Wed, 7 Sep 2011 14:57:14 +0000 (14:57 +0000)]
Cleanup our toolies, remove unneeded code; handle reply values.

12 years agoremove unused code; evaluate returnvalues.
Wilfried Goesgens [Wed, 7 Sep 2011 12:25:52 +0000 (12:25 +0000)]
remove unused code; evaluate returnvalues.

12 years agoremove unused code.
Wilfried Goesgens [Wed, 7 Sep 2011 12:25:26 +0000 (12:25 +0000)]
remove unused code.

12 years agoPrecisely report whats going wrong with the handling of the control file.
Wilfried Goesgens [Wed, 7 Sep 2011 12:24:48 +0000 (12:24 +0000)]
Precisely report whats going wrong with the handling of the control file.

12 years agoFix more warnings; output errors to the users.
Wilfried Goesgens [Wed, 7 Sep 2011 12:13:44 +0000 (12:13 +0000)]
Fix more warnings; output errors to the users.

12 years agoFix compiler warnings in the textclient by evaluating returnvalues and removing unuse...
Wilfried Goesgens [Wed, 7 Sep 2011 09:37:33 +0000 (09:37 +0000)]
Fix compiler warnings in the textclient by evaluating returnvalues and removing unused code.

12 years agouse StrBuf to create startup failure messages.
Wilfried Goesgens [Wed, 7 Sep 2011 12:13:00 +0000 (12:13 +0000)]
use StrBuf to create startup failure messages.

12 years agoMerge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel
Wilfried Goesgens [Wed, 7 Sep 2011 12:39:03 +0000 (12:39 +0000)]
Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel

12 years agoLimit length of Commands sent to citserver; do multible json requests if neccessary
Wilfried Goesgens [Tue, 6 Sep 2011 23:00:12 +0000 (23:00 +0000)]
Limit length of Commands sent to citserver; do multible json requests if neccessary

  - roomListDropHandler() when cut'n'paste moving split after the move vector reaches 800 chars
  - deleteAllSelectedMessages() when <del> moving to trash / purging split into chunks to limit the command lengths

12 years agoTest commit 2
Art Cancro [Tue, 6 Sep 2011 21:20:06 +0000 (17:20 -0400)]
Test commit 2

12 years agoTest commit
Art Cancro [Tue, 6 Sep 2011 21:17:34 +0000 (17:17 -0400)]
Test commit

12 years agoLibcitadel resync; forgot to add that one.
Wilfried Goesgens [Tue, 6 Sep 2011 18:52:59 +0000 (18:52 +0000)]
Libcitadel resync; forgot to add that one.

12 years agodeleteAllSelectedMessages(): don't send one request per message, citadel can handle...
Wilfried Goesgens [Tue, 6 Sep 2011 18:46:53 +0000 (18:46 +0000)]
deleteAllSelectedMessages(): don't send one request per message, citadel can handle a list of them already.

  - this dramaticaly increases the performance of pressing the <del> key when having several messages selected; less stress on the browser, webcit and citserver.

12 years agoSync libcitadel with the one from the libevent-branch
Wilfried Goesgens [Mon, 5 Sep 2011 08:56:58 +0000 (08:56 +0000)]
Sync libcitadel with the one from the libevent-branch

12 years agoAdjust %s es in the chinese translation; Note to self: format string translates are...
Wilfried Goesgens [Sun, 28 Aug 2011 08:31:30 +0000 (08:31 +0000)]
Adjust %s es in the chinese translation; Note to self: format string translates are bad.

12 years agoMerge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel
Wilfried Goesgens [Sun, 28 Aug 2011 07:49:19 +0000 (07:49 +0000)]
Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel

12 years agoAdd templatization for the Listsubscriber Interface; the old interface remains intact.
Wilfried Goesgens [Sun, 28 Aug 2011 07:48:34 +0000 (07:48 +0000)]
Add templatization for the Listsubscriber Interface; the old interface remains intact.

12 years agoAdd LPRM iterator for the public rooms.
Wilfried Goesgens [Sun, 28 Aug 2011 07:45:01 +0000 (07:45 +0000)]
Add LPRM iterator for the public rooms.

12 years agoremove unused copy to WCC
Wilfried Goesgens [Sun, 28 Aug 2011 07:44:23 +0000 (07:44 +0000)]
remove unused copy to WCC

12 years agoClear of non-default language setting moved to its proper place
Art Cancro [Sat, 27 Aug 2011 23:25:57 +0000 (19:25 -0400)]
Clear of non-default language setting moved to its proper place

12 years agoMake use of XML_StopParser() when XML_MAJOR_VERSION is >1, not >2. Thanks to Stefan...
Art Cancro [Fri, 26 Aug 2011 17:03:57 +0000 (13:03 -0400)]
Make use of XML_StopParser() when XML_MAJOR_VERSION is >1, not >2.  Thanks to Stefan for the bugfix.

12 years agoRemoved references to Subversion in the code
Art Cancro [Fri, 26 Aug 2011 14:17:03 +0000 (10:17 -0400)]
Removed references to Subversion in the code

12 years agoFixed the remaining bugs that kept Drafts from working properly
Art Cancro [Thu, 25 Aug 2011 21:28:18 +0000 (17:28 -0400)]
Fixed the remaining bugs that kept Drafts from working properly

12 years agoTest commit
Art Cancro [Thu, 25 Aug 2011 21:07:58 +0000 (17:07 -0400)]
Test commit

12 years agoCleanup of code path for handling message submit errors
Art Cancro [Thu, 25 Aug 2011 20:02:40 +0000 (16:02 -0400)]
Cleanup of code path for handling message submit errors

12 years agoSubmitting a message and getting back a 550 from the server now results in an error...
Art Cancro [Thu, 25 Aug 2011 19:51:13 +0000 (15:51 -0400)]
Submitting a message and getting back a 550 from the server now results in an error message instead of a blank page.

12 years agoChanged save_to_drafts to saving_to_drafts for clarity
Art Cancro [Thu, 25 Aug 2011 19:33:48 +0000 (15:33 -0400)]
Changed save_to_drafts to saving_to_drafts for clarity

12 years agoNoted with a comment where we need to handle ENT0 errors
Art Cancro [Wed, 24 Aug 2011 21:56:24 +0000 (17:56 -0400)]
Noted with a comment where we need to handle ENT0 errors

12 years agoOnly offer the 'Edit' option in mailbox rooms. Elsewhere it does not make sense.
Art Cancro [Wed, 24 Aug 2011 21:12:03 +0000 (17:12 -0400)]
Only offer the 'Edit' option in mailbox rooms.  Elsewhere it does not make sense.

12 years agoIf user clicks in the empty part of a mailbox view, display a blank pane instead...
Art Cancro [Wed, 24 Aug 2011 21:06:27 +0000 (17:06 -0400)]
If user clicks in the empty part of a mailbox view, display a blank pane instead of an error.

12 years agoMore 'greeking' the test mime data.
Art Cancro [Tue, 23 Aug 2011 21:13:09 +0000 (17:13 -0400)]
More 'greeking' the test mime data.

12 years agoBegan 'greeking' the test mime data.
Art Cancro [Tue, 23 Aug 2011 20:57:11 +0000 (16:57 -0400)]
Began 'greeking' the test mime data.

12 years agoSet all version numbers to 8.00 -- FEATURE FREEZE FOR 8.00
Art Cancro [Mon, 22 Aug 2011 18:18:37 +0000 (14:18 -0400)]
Set all version numbers to 8.00 -- FEATURE FREEZE FOR 8.00

12 years agoAdded a checked and disabled dummy option in the room access tab, indicating that...
Art Cancro [Mon, 22 Aug 2011 17:20:04 +0000 (13:20 -0400)]
Added a checked and disabled dummy option in the room access tab, indicating that blog creators automatically become room aides.
This advises administrators of a built-in behavior, and also exposes a string to the translators so that its localization will already exist if we add that option later.

12 years agoBlog owners automatically become room aides of their blogs.
Art Cancro [Mon, 22 Aug 2011 17:07:12 +0000 (13:07 -0400)]
Blog owners automatically become room aides of their blogs.
(In the future we will offer a site-wide configuration setting to suppress this behavior.)

12 years agoMerge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel
Wilfried Goesgens [Sat, 20 Aug 2011 11:58:57 +0000 (11:58 +0000)]
Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel

12 years agoQP-Encode questionmarks.
Wilfried Goesgens [Sat, 20 Aug 2011 11:58:14 +0000 (11:58 +0000)]
QP-Encode questionmarks.

12 years agoWhen QP encoding, we need to convert blanks to underscores
Wilfried Goesgens [Sat, 20 Aug 2011 09:50:26 +0000 (09:50 +0000)]
When QP encoding, we need to convert blanks to underscores

  - Spamassasin test 'BAD_ENC_HEADER' matches if a subject looks like that:
     Subject: =?UTF-8?Q?=5Btestml=5D l=C3=B6sch misch ey.?=
    it needs to look like that:
     Subject: =?UTF-8?Q?=5Btestml=5D_l=C3=B6sch_misch_ey.?=

12 years agoClear selected_language when marking a guest session as inuse=0.
Art Cancro [Fri, 19 Aug 2011 19:12:50 +0000 (15:12 -0400)]
Clear selected_language when marking a guest session as inuse=0.
This prevents new visitors from seeing their first page in Chinese after Baidu comes calling.

12 years agoadd missing var definition *ups*
Wilfried Goesgens [Fri, 19 Aug 2011 17:17:31 +0000 (17:17 +0000)]
add missing var definition *ups*

12 years agoFix detecting of UTF8 Sequences
Wilfried Goesgens [Fri, 19 Aug 2011 17:12:32 +0000 (17:12 +0000)]
Fix detecting of UTF8 Sequences

  - we need to exactly check for both highest bits to be set, not one of them.

12 years agofix counting of UTF8-charwidth
Wilfried Goesgens [Fri, 19 Aug 2011 16:43:30 +0000 (16:43 +0000)]
fix counting of UTF8-charwidth

  - Ctdl_GetUtf8SequenceLength(): testbyte needs to be unsigned char, else >> will shift us new bits in from the left
  - we need to shift 'test' to the right
  - start counting at 0

12 years agoAdd ability to hex encode binary strings
Wilfried Goesgens [Sun, 3 Jul 2011 13:47:55 +0000 (13:47 +0000)]
Add ability to hex encode binary strings

 - when encoding plain md5 binary buffers we have to pass the length into the hex encoder, add parameter
 - add wrapper providing old schematic
 - fix documentation of StrBufSipLine()

12 years agofix StrHtmlEcmaEscAppend, StrECMAEscAppend
Wilfried Goesgens [Thu, 18 Aug 2011 18:18:38 +0000 (18:18 +0000)]
fix StrHtmlEcmaEscAppend, StrECMAEscAppend

  - StrHtmlEcmaEscAppend(): reimplement 'nbsp' - handling
  - StrECMAEscAppend(): copy over required stuff from StrHtmlEcmaEscAppend()