citadel.git
11 years agoDB: query keys are not written by berkeley db. believe me. v8.11
Wilfried Goesgens [Mon, 21 May 2012 20:44:22 +0000 (22:44 +0200)]
DB: query keys are not written by berkeley db. believe me.

11 years agoCurl-Eventclient: in this errorcase we don't have the context.
Wilfried Goesgens [Mon, 21 May 2012 19:35:42 +0000 (21:35 +0200)]
Curl-Eventclient: in this errorcase we don't have the context.

11 years agoits staying libcitdale2
Wilfried Goesgens [Mon, 21 May 2012 19:26:54 +0000 (21:26 +0200)]
its staying libcitdale2

11 years agoDon't mess around with the so-name for no reason.
Wilfried Goesgens [Mon, 21 May 2012 19:24:42 +0000 (21:24 +0200)]
Don't mess around with the so-name for no reason.

11 years agoVersioning: make the lib 8.x; cleanup.
Wilfried Goesgens [Mon, 21 May 2012 19:00:56 +0000 (21:00 +0200)]
Versioning: make the lib 8.x; cleanup.

11 years agoPOP3Client: stop client / db watchers before switching the context.
Wilfried Goesgens [Mon, 21 May 2012 05:40:29 +0000 (07:40 +0200)]
POP3Client: stop client / db watchers before switching the context.

11 years agoRSSClient: fix possible buffer underrun
Wilfried Goesgens [Sun, 20 May 2012 18:13:19 +0000 (20:13 +0200)]
RSSClient: fix possible buffer underrun

11 years agoSMTP: free the queue item in the very last function, so we have a valid pointer to...
Wilfried Goesgens [Sun, 20 May 2012 18:03:44 +0000 (20:03 +0200)]
SMTP: free the queue item in the very last function, so we have a valid pointer to the QID for logging.

11 years agoEV: check the connectionstate on deferred connecting; else we can't detect connection...
Wilfried Goesgens [Sun, 20 May 2012 18:02:10 +0000 (20:02 +0200)]
EV: check the connectionstate on deferred connecting; else we can't detect connections failed by non-existing hosts.

11 years agoopenbsd compatibility: add NS_GET16 workaround.
Wilfried Goesgens [Thu, 17 May 2012 09:49:26 +0000 (11:49 +0200)]
openbsd compatibility: add NS_GET16 workaround.

11 years agocleaned up some spelling and grammar in serv_vcard.c
Art Cancro [Thu, 17 May 2012 03:06:54 +0000 (23:06 -0400)]
cleaned up some spelling and grammar in serv_vcard.c

11 years agoReverted most of e40ba85133cf6401bda3d6b81a1d144d73d25074 because it broke the protoc...
Art Cancro [Thu, 17 May 2012 02:58:16 +0000 (22:58 -0400)]
Reverted most of e40ba85133cf6401bda3d6b81a1d144d73d25074 because it broke the protocol semantics and only provided a function that the protocol was already capable of doing. 'verbose_reply' is now gone.  If the client wants a verbose reply, use the 'do_confirm' semantics, which invokes protocol mode 8 (send listing then receive listing) instead of mode 4 (send listing).

11 years agoBumped version numbers to 8.11 for upcoming release
Art Cancro [Wed, 16 May 2012 20:08:45 +0000 (16:08 -0400)]
Bumped version numbers to 8.11 for upcoming release

11 years agoBumped version numbers to 8.11 for upcoming release
Art Cancro [Wed, 16 May 2012 20:06:09 +0000 (16:06 -0400)]
Bumped version numbers to 8.11 for upcoming release

11 years agoWhen a username/password auth fails, restore the username/password dialog instead...
Art Cancro [Wed, 16 May 2012 18:38:34 +0000 (14:38 -0400)]
When a username/password auth fails, restore the username/password dialog instead of leaving the throbber on the screen.

11 years agoi guess you can remove the loaded var alltogether then.
Art Cancro [Wed, 16 May 2012 16:28:35 +0000 (12:28 -0400)]
i guess you can remove the loaded var alltogether then.

11 years agoCall LoadExpirePolicy() unconditionally, this fixes the apparent snap back to old...
Art Cancro [Wed, 16 May 2012 16:26:50 +0000 (12:26 -0400)]
Call LoadExpirePolicy() unconditionally, this fixes the apparent snap back to old config when room/floor policy is changed

11 years agoStill trying to figure out why expire policy settings aren't sticking
Art Cancro [Wed, 16 May 2012 03:03:53 +0000 (23:03 -0400)]
Still trying to figure out why expire policy settings aren't sticking

11 years agowtf?
Art Cancro [Tue, 15 May 2012 20:55:21 +0000 (16:55 -0400)]
wtf?

11 years agoAdded 'go' as hidden input fields to all of the forms in the room editor
Art Cancro [Tue, 15 May 2012 20:37:21 +0000 (16:37 -0400)]
Added 'go' as hidden input fields to all of the forms in the room editor

11 years agoRemoved er_flags and er_flags2 from editroom(). These were being set and then never...
Art Cancro [Tue, 15 May 2012 16:13:09 +0000 (12:13 -0400)]
Removed er_flags and er_flags2 from editroom().  These were being set and then never sent to the server.

11 years agoremoved a bunch of blank comment lines
Art Cancro [Tue, 15 May 2012 14:45:08 +0000 (10:45 -0400)]
removed a bunch of blank comment lines

11 years agoAdd a 'go' value to the 'edit room configuration' tab so it automatically selects...
Art Cancro [Tue, 15 May 2012 03:56:15 +0000 (23:56 -0400)]
Add a 'go' value to the 'edit room configuration' tab so it automatically selects the correct room upon submit

11 years agolocate_host: add missing defines for openbsd
Wilfried Goesgens [Mon, 14 May 2012 22:03:21 +0000 (00:03 +0200)]
locate_host: add missing defines for openbsd

defines found over at dnssec: https://www.dnssec-tools.org/svn/dnssec-tools/tags/dnsval-1.8/include/validator/resolver.h

11 years agoRemove duplicate include with wrong #ifs
Wilfried Goesgens [Thu, 10 May 2012 20:34:49 +0000 (22:34 +0200)]
Remove duplicate include with wrong #ifs

11 years agoPOP3Client: use URL-Encoder that also encades the '@'
Wilfried Goesgens [Thu, 10 May 2012 20:34:21 +0000 (22:34 +0200)]
POP3Client: use URL-Encoder that also encades the '@'

11 years agoStringBuf: add URL-encoder that also encodes the @ character.
Wilfried Goesgens [Thu, 10 May 2012 20:32:59 +0000 (22:32 +0200)]
StringBuf: add URL-encoder that also encodes the @ character.

11 years agoPOP3Client: escape URL parts
Wilfried Goesgens [Thu, 10 May 2012 20:04:13 +0000 (22:04 +0200)]
POP3Client: escape URL parts

11 years agoSMTP-Client: shut down in one chunk
Wilfried Goesgens [Mon, 7 May 2012 21:28:01 +0000 (23:28 +0200)]
SMTP-Client: shut down in one chunk

  - splicing up the shutdown sequence into several db-request chunks doesn't work out. do it in one apraoch again.

11 years agoSMTP-Client: on success strip reply too.
Wilfried Goesgens [Mon, 7 May 2012 21:25:17 +0000 (23:25 +0200)]
SMTP-Client: on success strip reply too.

11 years agoEVENT-Client: set context on attach.
Wilfried Goesgens [Mon, 7 May 2012 21:24:34 +0000 (23:24 +0200)]
EVENT-Client: set context on attach.

11 years agoEvent-client: add waiting for the server greeting to our error status (preventive..)
Wilfried Goesgens [Sun, 6 May 2012 20:19:40 +0000 (22:19 +0200)]
Event-client: add waiting for the server greeting to our error status (preventive..)

11 years agoEventhandling: fix shutdownhandlers
Wilfried Goesgens [Sun, 6 May 2012 20:15:30 +0000 (22:15 +0200)]
Eventhandling: fix shutdownhandlers

  - add a mutex for securely accessing the eventqueues from outside via ev_async_send() (s.b. might want to shut down meanwhile)
  - remove unused add-pipes we used for signaling before switching to libev4
  - start the shutdown handlers only from within the eventqueue

11 years agoHTML Styleguide fixing.
Wilfried Goesgens [Sat, 5 May 2012 19:05:37 +0000 (21:05 +0200)]
HTML Styleguide fixing.

11 years agoEVENT-Client: add debug log when we connected to the remote side after E_AGAIN. this...
Wilfried Goesgens [Sat, 5 May 2012 15:45:21 +0000 (17:45 +0200)]
EVENT-Client: add debug log when we connected to the remote side after E_AGAIN. this way we now can see when the server isn't sending a greeting.

11 years agoSMTP-Client: don't set 5 as default connection status; this is fail and its dangerous.
Wilfried Goesgens [Sat, 5 May 2012 15:17:52 +0000 (17:17 +0200)]
SMTP-Client: don't set 5 as default connection status; this is fail and its dangerous.

11 years agoSMTP-Client: alocate the Statusmessage big enough so we don't reallocate them later on.
Wilfried Goesgens [Sat, 5 May 2012 15:17:12 +0000 (17:17 +0200)]
SMTP-Client: alocate the Statusmessage big enough so we don't reallocate them later on.

11 years agoSMTP-Client: strip newlines from smtp replies when setting them as Statusmessage.
Wilfried Goesgens [Sat, 5 May 2012 15:16:13 +0000 (17:16 +0200)]
SMTP-Client: strip newlines from smtp replies when setting them as Statusmessage.

11 years agoC-ARES: make debug logging completely runtime configurable.
Wilfried Goesgens [Sat, 5 May 2012 15:15:24 +0000 (17:15 +0200)]
C-ARES: make debug logging completely runtime configurable.

11 years agoCURL-Client: try to log after we actualy have an IO struct.
Wilfried Goesgens [Sat, 5 May 2012 15:14:45 +0000 (17:14 +0200)]
CURL-Client: try to log after we actualy have an IO struct.

11 years agoadjust loglevel in case of failing to get/set the FD Flags
Wilfried Goesgens [Sat, 5 May 2012 15:13:46 +0000 (17:13 +0200)]
adjust loglevel in case of failing to get/set the FD Flags

11 years agoLOGGING: add tiny webcit interface to manage log configs
Wilfried Goesgens [Sat, 5 May 2012 12:08:49 +0000 (14:08 +0200)]
LOGGING: add tiny webcit interface to manage log configs

11 years agoLOGP: use pipe as separator as we do it in all other places.
Wilfried Goesgens [Sat, 5 May 2012 11:31:21 +0000 (13:31 +0200)]
LOGP: use pipe as separator as we do it in all other places.

11 years agoCLEANUP: don't declare vars before code.
Wilfried Goesgens [Sat, 5 May 2012 11:11:28 +0000 (13:11 +0200)]
CLEANUP: don't declare vars before code.

11 years agoLogging: log the number of messages in room with the message-syslog domain
Wilfried Goesgens [Sat, 5 May 2012 10:40:34 +0000 (12:40 +0200)]
Logging: log the number of messages in room with the message-syslog domain

11 years agoIMAP: make debug logging configurable.
Wilfried Goesgens [Thu, 3 May 2012 21:55:30 +0000 (23:55 +0200)]
IMAP: make debug logging configurable.

11 years agoNTTList: move into networking module
Wilfried Goesgens [Thu, 3 May 2012 20:44:33 +0000 (22:44 +0200)]
NTTList: move into networking module

  - use session logout hook to free the NTTList entry instead of adding a dependency to user_ops.c
  - make logging of NTT configurable
  - move ntt locking code into serv_network.c

11 years agoMerge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel
Wilfried Goesgens [Thu, 3 May 2012 20:06:02 +0000 (22:06 +0200)]
Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel

11 years agoBSD compatibility: add missing include for AF_INET
Wilfried Goesgens [Thu, 3 May 2012 20:04:41 +0000 (22:04 +0200)]
BSD compatibility: add missing include for AF_INET

11 years agoRemoved duplicate typedef of CtdlDbgFunction
Art Cancro [Tue, 1 May 2012 03:29:22 +0000 (23:29 -0400)]
Removed duplicate typedef of CtdlDbgFunction

11 years agoLogging: configure message logging
Wilfried Goesgens [Sun, 29 Apr 2012 20:16:07 +0000 (22:16 +0200)]
Logging: configure message logging

11 years agoSMTPClient: more log silencing
Wilfried Goesgens [Sun, 29 Apr 2012 16:31:01 +0000 (18:31 +0200)]
SMTPClient: more log silencing

11 years agoLOGGING: make context logging configurabel. (joining user & context)
Wilfried Goesgens [Sun, 29 Apr 2012 15:51:51 +0000 (17:51 +0200)]
LOGGING: make context logging configurabel. (joining user & context)

11 years agoLOGGING: make module infrastructure logging configurable
Wilfried Goesgens [Sun, 29 Apr 2012 15:13:32 +0000 (17:13 +0200)]
LOGGING: make module infrastructure logging configurable

   - degrade lots of outputs from INFO to DEBUG. this is way to noisy.

11 years agoLOGGING: more debug messages to hide in eventqueue
Wilfried Goesgens [Sun, 29 Apr 2012 14:09:14 +0000 (16:09 +0200)]
LOGGING: more debug messages to hide in eventqueue

11 years agoXMPP: make logging configurable.
Wilfried Goesgens [Sun, 29 Apr 2012 13:48:48 +0000 (15:48 +0200)]
XMPP: make logging configurable.

11 years agoSieve: make logging configurable.
Wilfried Goesgens [Sun, 29 Apr 2012 13:38:35 +0000 (15:38 +0200)]
Sieve: make logging configurable.

11 years agoLogging: add commands to runtime view/enable/disable logging
Wilfried Goesgens [Sun, 29 Apr 2012 13:19:10 +0000 (15:19 +0200)]
Logging: add commands to runtime view/enable/disable logging

  - LOGP: print log config
  - LOGS: set one logging facility

11 years agoMerge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel
Wilfried Goesgens [Sun, 29 Apr 2012 10:14:09 +0000 (12:14 +0200)]
Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel

11 years agoSMTP-Client: streamline logging; make look more uniq
Wilfried Goesgens [Sun, 29 Apr 2012 10:13:34 +0000 (12:13 +0200)]
SMTP-Client: streamline logging; make look more uniq

11 years agoEVENT-Backtrace enableable on its own by now.
Wilfried Goesgens [Sun, 29 Apr 2012 10:13:00 +0000 (12:13 +0200)]
EVENT-Backtrace enableable on its own by now.

11 years agoCURL: make log output configurable.
Wilfried Goesgens [Sat, 28 Apr 2012 18:07:47 +0000 (20:07 +0200)]
CURL: make log output configurable.

11 years agoBacktrace: check for NULL pointer argument.
Wilfried Goesgens [Sat, 28 Apr 2012 18:07:23 +0000 (20:07 +0200)]
Backtrace: check for NULL pointer argument.

11 years agoMake logging configurable
Wilfried Goesgens [Sat, 28 Apr 2012 16:04:07 +0000 (18:04 +0200)]
Make logging configurable
  - event loop
  - c-ares

11 years agoPOP3Client: mute debug log if not enable
Wilfried Goesgens [Sat, 28 Apr 2012 16:03:29 +0000 (18:03 +0200)]
POP3Client: mute debug log if not enable

11 years agoRSSClient: make debug log runtime configurable
Wilfried Goesgens [Sat, 28 Apr 2012 16:03:05 +0000 (18:03 +0200)]
RSSClient: make debug log runtime configurable

11 years agochanged the default path to citadel in ctdlsh
Art Cancro [Fri, 27 Apr 2012 14:45:54 +0000 (10:45 -0400)]
changed the default path to citadel in ctdlsh

11 years agoRSS-Client: add missing locks
root [Thu, 26 Apr 2012 20:27:50 +0000 (22:27 +0200)]
RSS-Client: add missing locks

11 years agoMore logging for rssclient and pop3client holdoff and concurrency checks
Art Cancro [Wed, 25 Apr 2012 21:24:37 +0000 (17:24 -0400)]
More logging for rssclient and pop3client holdoff and concurrency checks

11 years agoMerge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel
Wilfried Goesgens [Tue, 24 Apr 2012 18:27:06 +0000 (20:27 +0200)]
Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel

11 years agoCitadel Networker: add per facility debug logging 'networkclient'
Wilfried Goesgens [Tue, 24 Apr 2012 18:26:16 +0000 (20:26 +0200)]
Citadel Networker: add per facility debug logging 'networkclient'

11 years agoSMTP-Client: add per facility debug logging 'smtpeventclient'
Wilfried Goesgens [Tue, 24 Apr 2012 18:25:27 +0000 (20:25 +0200)]
SMTP-Client: add per facility debug logging 'smtpeventclient'

11 years agoAdd framework for enabling (debug) logging per module
Wilfried Goesgens [Tue, 24 Apr 2012 18:23:31 +0000 (20:23 +0200)]
Add framework for enabling (debug) logging per module

  - -x <list of coma separated values> / 'all'
  - export CITADEL_LOGDEBUG=<list of coma separated values> / 'all'

11 years agoAdded more 'go=' parameters to links in the wiki view, thereby making those links...
Art Cancro [Tue, 24 Apr 2012 15:43:52 +0000 (11:43 -0400)]
Added more 'go=' parameters to links in the wiki view, thereby making those links more perma.

11 years agoThe 'wiki home' link now contains a go= parameter
Art Cancro [Tue, 24 Apr 2012 15:28:55 +0000 (11:28 -0400)]
The 'wiki home' link now contains a go= parameter

11 years agoCleanup: use typedef for structs; make those structs private which aren't used in...
Wilfried Goesgens [Tue, 24 Apr 2012 15:25:08 +0000 (17:25 +0200)]
Cleanup: use typedef for structs; make those structs private which aren't used in the rest of the code.

11 years agomore 'go=' links in wiki
Art Cancro [Tue, 24 Apr 2012 15:24:55 +0000 (11:24 -0400)]
more 'go=' links in wiki

11 years agoLogging: add timestamps for eventdriven IO
Wilfried Goesgens [Tue, 24 Apr 2012 10:32:51 +0000 (12:32 +0200)]
Logging: add timestamps for eventdriven IO

  - add the ev_now() timestamp to the contexts (just for measuring that precision should be ok...)
  - output the time the DNS requests take
  - output the time the whole SMTP delivery aproach took

11 years agoDeleting rooms: Invalid pointers; safeguarrds
Wilfried Goesgens [Tue, 24 Apr 2012 09:51:05 +0000 (11:51 +0200)]
Deleting rooms: Invalid pointers; safeguarrds

  - Server return buffer wasn't allocated -> crash
  - add mandatory parameter 'go' to delete_room, so we're realy shure which room to delete.

11 years agorename token CURRENT_ROOM to THISROOM; since all other tokens concerning the currentl...
Wilfried Goesgens [Tue, 24 Apr 2012 09:50:08 +0000 (11:50 +0200)]
rename token CURRENT_ROOM to THISROOM; since all other tokens concerning the currently selected room are named THISROOM:**

11 years agoMerge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel
Wilfried Goesgens [Tue, 24 Apr 2012 09:45:28 +0000 (11:45 +0200)]
Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel

11 years agoFirst of several required additions of 'go=' to wiki links
Art Cancro [Mon, 23 Apr 2012 22:41:53 +0000 (18:41 -0400)]
First of several required additions of 'go=' to wiki links

11 years agoFixed a problem with wiki history display being broken because carriage returns are...
Art Cancro [Mon, 23 Apr 2012 22:34:34 +0000 (18:34 -0400)]
Fixed a problem with wiki history display being broken because carriage returns are sneaking into the rev names

11 years agomore str_wiki_index() use
Art Cancro [Mon, 23 Apr 2012 22:20:03 +0000 (18:20 -0400)]
more str_wiki_index() use

11 years agoRemoved the 'room=' parameter from the wiki view. This functionality is provided...
Art Cancro [Mon, 23 Apr 2012 22:06:11 +0000 (18:06 -0400)]
Removed the 'room=' parameter from the wiki view.  This functionality is provided globally by the 'go=' parameter.

11 years agoBegan fixing http://uncensored.citadel.org/wiki?page=stefan2012mar07?go=exterminate
Art Cancro [Mon, 23 Apr 2012 18:06:34 +0000 (14:06 -0400)]
Began fixing uncensored.citadel.org/wiki?page=stefan2012mar07?go=exterminate

11 years agoWhen changes are made via the admin socket, post Aide messages indicating that the...
Art Cancro [Mon, 23 Apr 2012 14:42:35 +0000 (10:42 -0400)]
When changes are made via the admin socket, post Aide messages indicating that the changes were made 'by an administrator' instead of 'by (not logged in)'.

11 years agoSMTP-Client: summary log success / fail of delivery attempts.
Wilfried Goesgens [Mon, 23 Apr 2012 11:04:36 +0000 (13:04 +0200)]
SMTP-Client: summary log success / fail of delivery attempts.

12 years agoMerge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel
Wilfried Goesgens [Sun, 22 Apr 2012 08:34:55 +0000 (10:34 +0200)]
Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel

12 years agoLogging: add details to failed password attempts to make it fail2ban more easy to...
Wilfried Goesgens [Sun, 22 Apr 2012 08:33:53 +0000 (10:33 +0200)]
Logging: add details to failed password attempts to make it fail2ban more easy to block ports for dictionary attacks.

12 years agotweaks to ctdlsalearn
Art Cancro [Sun, 22 Apr 2012 04:11:47 +0000 (00:11 -0400)]
tweaks to ctdlsalearn

12 years agoAdjusted qstart/qend defaults
Art Cancro [Thu, 19 Apr 2012 16:29:54 +0000 (12:29 -0400)]
Adjusted qstart/qend defaults

12 years agospiffy new strprompt() allows backspacing over the existing value
Art Cancro [Thu, 19 Apr 2012 16:20:06 +0000 (12:20 -0400)]
spiffy new strprompt() allows backspacing over the existing value

12 years agoReplacement ctdl_getline()
Art Cancro [Thu, 19 Apr 2012 16:09:10 +0000 (12:09 -0400)]
Replacement ctdl_getline()

12 years agoReplacement ctdl_getline()
Art Cancro [Thu, 19 Apr 2012 16:07:00 +0000 (12:07 -0400)]
Replacement ctdl_getline()

12 years agowtf is gl_string? unused variable, removed it
Art Cancro [Thu, 19 Apr 2012 15:53:36 +0000 (11:53 -0400)]
wtf is gl_string?  unused variable, removed it

12 years agoThe 'negative number for asterisk echo' functionality is no longer in ctdl_getline...
Art Cancro [Thu, 19 Apr 2012 15:43:47 +0000 (11:43 -0400)]
The 'negative number for asterisk echo' functionality is no longer in ctdl_getline(), it has been moved to newprompt() and strprompt()

12 years agoRemove unused variable
Art Cancro [Thu, 19 Apr 2012 15:39:59 +0000 (11:39 -0400)]
Remove unused variable

12 years agoOutside of commands.c, calls to ctdl_getline() have been replaced with more appropria...
Art Cancro [Thu, 19 Apr 2012 15:36:14 +0000 (11:36 -0400)]
Outside of commands.c, calls to ctdl_getline() have been replaced with more appropriate functions

12 years agoctdl_getline() is a mess. continued cleaning it up
Art Cancro [Thu, 19 Apr 2012 15:13:59 +0000 (11:13 -0400)]
ctdl_getline() is a mess.  continued cleaning it up