From ec0632c60fbcc1509eada758e6778afb4a52ea11 Mon Sep 17 00:00:00 2001
From: Art Cancro <ajc@citadel.org>
Date: Mon, 7 Jan 2019 19:39:09 -0500
Subject: [PATCH] Cleaned up some messy rendering in the bbs view.

---
 webcit-ng/static/js/views.js | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

diff --git a/webcit-ng/static/js/views.js b/webcit-ng/static/js/views.js
index 35fdbef5b..5804155f4 100644
--- a/webcit-ng/static/js/views.js
+++ b/webcit-ng/static/js/views.js
@@ -54,8 +54,8 @@ function forum_readmessages(target_div, gt_msg, lt_msg)
 {
 	original_text = document.getElementById(target_div).innerHTML;		// in case we need to replace it after an error
 	document.getElementById(target_div).innerHTML = 
-		"<i class=\"fas fa-spinner fa-spin\"></i>&nbsp;&nbsp;"
-		+ _("Loading messages from server, please wait") ;
+		"<div align=\"center\"><i class=\"fas fa-spinner fa-spin\"></i>&nbsp;&nbsp;"
+		+ _("Loading messages from server, please wait") + "</div>";
 
 	var request = new XMLHttpRequest();
 	if (lt_msg < 9999999999) {
@@ -96,12 +96,10 @@ function forum_readmessages(target_div, gt_msg, lt_msg)
 						_("Older posts") + "&nbsp;&nbsp;<i class=\"fa fa-arrow-circle-up\"></a></div></div></a></div></div>" ;
 				}
 
-				// Render the divs (we will fill them in later)
+				// Render an empty div for each message.  We will fill them in later.
 				for (var i in msgs) {
-					document.getElementById(target_div).innerHTML +=
-						"<div id=\"ctdl_msg_"
-						+ msgs[i] + "\">#" + msgs[i]
-						+ "</div>" ;
+					document.getElementById(target_div).innerHTML += "<div id=\"ctdl_msg_" + msgs[i] + "\"> </div>" ;
+					document.getElementById("ctdl_msg_"+msgs[i]).style.display = "none";
 				}
 				if (lt_msg == 9999999999) {
 					new_new_div_name = randomString(5);
@@ -152,7 +150,7 @@ function forum_readmessages(target_div, gt_msg, lt_msg)
 function forum_render_messages(msgs, prefix, scroll_to)
 {
 	for (i=0; i<msgs.length; ++i) {
-		forum_render_one(prefix+msgs[i], msgs[i], scroll_to)
+		forum_render_one(prefix+msgs[i], msgs[i], scroll_to);
 	}
 }
 
@@ -192,6 +190,7 @@ function forum_render_one(div, msgnum, scroll_to)
 			else {
 				document.getElementById(div).innerHTML = "ERROR";
 			}
+			document.getElementById(div).style.display  = "inline";
 			if (msgnum == scroll_to) {
 				window.location.hash = div;
 			}
-- 
2.30.2