citadel
10 years agopoking around in the ctdlsh source because citadel proper is in deep freeze :)
Art Cancro [Mon, 26 Sep 2011 14:55:35 +0000 (10:55 -0400)]
poking around in the ctdlsh source because citadel proper is in deep freeze :)

10 years agocorrect error message hint
Wilfried Goesgens [Tue, 20 Sep 2011 20:55:28 +0000 (20:55 +0000)]
correct error message hint

10 years agoremove unneeded line
Wilfried Goesgens [Tue, 20 Sep 2011 20:50:40 +0000 (20:50 +0000)]
remove unneeded line

10 years agodocumentation
Art Cancro [Tue, 20 Sep 2011 20:35:28 +0000 (16:35 -0400)]
documentation

10 years agodocumentation
Art Cancro [Tue, 20 Sep 2011 20:31:36 +0000 (16:31 -0400)]
documentation

10 years agoRoom links in iconbar roomlist now properly escaped with encodeURIcomponent()
Art Cancro [Tue, 20 Sep 2011 19:42:11 +0000 (15:42 -0400)]
Room links in iconbar roomlist now properly escaped with encodeURIcomponent()

10 years agoChanged the naming convention of the setup wizard filename
Art Cancro [Tue, 20 Sep 2011 19:02:25 +0000 (15:02 -0400)]
Changed the naming convention of the setup wizard filename

10 years agoThe definition of ThreadIdHash() has been moved from webcit.h to libcitadel.h
Art Cancro [Tue, 20 Sep 2011 18:37:54 +0000 (14:37 -0400)]
The definition of ThreadIdHash() has been moved from webcit.h to libcitadel.h

10 years agoUse base64 encoding for permalinks in bbs rooms, otherwise google+ mangles them
Art Cancro [Tue, 20 Sep 2011 16:31:48 +0000 (12:31 -0400)]
Use base64 encoding for permalinks in bbs rooms, otherwise google+ mangles them

10 years agofix some more memleaks.
Wilfried Goesgens [Mon, 17 Oct 2011 22:19:14 +0000 (00:19 +0200)]
fix some more memleaks.

10 years agorework the networking locking facility using the hashlist.
Wilfried Goesgens [Mon, 17 Oct 2011 22:18:43 +0000 (00:18 +0200)]
rework the networking locking facility using the hashlist.

10 years agoAdd function to free the file upload facilities.
Wilfried Goesgens [Mon, 17 Oct 2011 22:15:57 +0000 (00:15 +0200)]
Add function to free the file upload facilities.

10 years agoFinalize Networker; native modern linux.
Wilfried Goesgens [Sun, 16 Oct 2011 21:30:50 +0000 (23:30 +0200)]
Finalize Networker; native modern linux.

  - use sendfile to upload spool files from disk to the remote party
  - use splice() to download spoolfiles from the remote site.

10 years agowe need to run export for wheezy.
Wilfried Goesgens [Sun, 16 Oct 2011 21:30:28 +0000 (23:30 +0200)]
we need to run export for wheezy.

10 years agoImplement asynchroneous networking.
Wilfried Goesgens [Sat, 8 Oct 2011 21:59:49 +0000 (23:59 +0200)]
Implement asynchroneous networking.

10 years agoAdd support for sending / reading to files; so far we just implement the linux sendfi...
Wilfried Goesgens [Sat, 8 Oct 2011 21:59:09 +0000 (23:59 +0200)]
Add support for sending / reading to files; so far we just implement the linux sendfile facility

10 years agoUsername needs to be url encoded too.
Wilfried Goesgens [Sat, 24 Sep 2011 12:35:43 +0000 (12:35 +0000)]
Username needs to be url encoded too.

10 years agoserv_extnotify now uses field '2' instead of field 'W' within the server; resolve...
Art Cancro [Tue, 20 Sep 2011 13:47:56 +0000 (09:47 -0400)]
serv_extnotify now uses field '2' instead of field 'W' within the server; resolve conflict with the use of 'W' for references

10 years agofix possible leaks around 'W'; the funambol code abuses it.
Wilfried Goesgens [Mon, 19 Sep 2011 21:19:12 +0000 (21:19 +0000)]
fix possible leaks around 'W'; the funambol code abuses it.

10 years agoFix memory leaks in the networker
Wilfried Goesgens [Mon, 19 Sep 2011 21:18:24 +0000 (21:18 +0000)]
Fix memory leaks in the networker

10 years ago'W' is double used for the user when doing extnotify spool messages; add this to...
Wilfried Goesgens [Mon, 19 Sep 2011 18:50:47 +0000 (18:50 +0000)]
'W' is double used for the user when doing extnotify spool messages; add this to our column description.

10 years agoFix indention; its broken in some places which seems to hide memleaks.
Wilfried Goesgens [Mon, 19 Sep 2011 18:47:52 +0000 (18:47 +0000)]
Fix indention; its broken in some places which seems to hide memleaks.

10 years ago.debs: citserver depends on patch now.
Wilfried Goesgens [Fri, 16 Sep 2011 18:53:13 +0000 (18:53 +0000)]
.debs: citserver depends on patch now.

10 years agoUpgrade TinyMCE to v3.4.5
Art Cancro [Thu, 15 Sep 2011 16:35:49 +0000 (12:35 -0400)]
Upgrade TinyMCE to v3.4.5

10 years agoConditional_USER_HAS_PIC() was leaving the download file open, causing the actual...
Art Cancro [Wed, 14 Sep 2011 21:49:51 +0000 (17:49 -0400)]
Conditional_USER_HAS_PIC() was leaving the download file open, causing the actual download to fail.  Fixed.

10 years agoWrite out a log message when an unparented blog comment is encountered
Art Cancro [Wed, 14 Sep 2011 20:28:46 +0000 (16:28 -0400)]
Write out a log message when an unparented blog comment is encountered

10 years agobbsview_renderer 'go to page' links now use start_reading_at= instead of page= in...
Art Cancro [Wed, 14 Sep 2011 16:24:53 +0000 (12:24 -0400)]
bbsview_renderer 'go to page' links now use start_reading_at= instead of page= in order to make them more persistent when archived or indexed.

10 years agobbsview_renderer readfwd links now include a go= parameter to include the room name
Art Cancro [Wed, 14 Sep 2011 16:03:30 +0000 (12:03 -0400)]
bbsview_renderer readfwd links now include a go= parameter to include the room name

10 years agooops ... there was no way to delete blog comments ... fixed that
Art Cancro [Tue, 13 Sep 2011 20:35:21 +0000 (16:35 -0400)]
oops ... there was no way to delete blog comments ... fixed that

10 years agoOnly show the Search box in the mailbox view because that's the only view that it...
Art Cancro [Tue, 13 Sep 2011 19:04:10 +0000 (15:04 -0400)]
Only show the Search box in the mailbox view because that's the only view that it works in.

10 years agoUse autoconf to locate the diff and patch executables and pass those pathnames to...
Art Cancro [Mon, 12 Sep 2011 15:53:20 +0000 (11:53 -0400)]
Use autoconf to locate the diff and patch executables and pass those pathnames to serv_wiki.c

10 years agoAdded a couple more entity declarations
Art Cancro [Fri, 9 Sep 2011 17:04:25 +0000 (13:04 -0400)]
Added a couple more entity declarations

10 years agooops, I had SERV_TRACE enabled and committed that. fixed
Art Cancro [Wed, 7 Sep 2011 19:44:18 +0000 (15:44 -0400)]
oops, I had SERV_TRACE enabled and committed that.  fixed

10 years agoReceiving files via the networker functional now.
Wilfried Goesgens [Fri, 16 Sep 2011 18:42:15 +0000 (18:42 +0000)]
Receiving files via the networker functional now.

10 years agoAdd function to measure the length of the fifo buffer
Wilfried Goesgens [Fri, 16 Sep 2011 18:41:28 +0000 (18:41 +0000)]
Add function to measure the length of the fifo buffer

10 years agoAdd error handler for failing DNS requests; the Client should be able to take its...
Wilfried Goesgens [Fri, 16 Sep 2011 18:39:36 +0000 (18:39 +0000)]
Add error handler for failing DNS requests; the Client should be able to take its individual decision whats to be done on fail.

10 years agoRemoving of static vars in the Networker
Wilfried Goesgens [Wed, 14 Sep 2011 13:34:35 +0000 (13:34 +0000)]
Removing of static vars in the Networker

  - we have to fiddle them through the SpoolControl structure into the ForeachMessage() loop.

10 years agoNetworker AsyncIO Rewrite
Wilfried Goesgens [Wed, 14 Sep 2011 13:00:47 +0000 (13:00 +0000)]
Networker AsyncIO Rewrite

  - chopped commands into pieces
  - created the usual handlers
  - created dispatch table
  - We now can perform a connection without content successfully.

10 years agowe need to register the smtp queue runner...
Wilfried Goesgens [Wed, 14 Sep 2011 08:29:46 +0000 (08:29 +0000)]
we need to register the smtp queue runner...

10 years agoNegated a strcmp in netconf.c that caused the function to hang every single time...
Art Cancro [Wed, 7 Sep 2011 19:43:37 +0000 (15:43 -0400)]
Negated a strcmp in netconf.c that caused the function to hang every single time, how did this get this way?

10 years agoprepend pop3 to some more functions to work around name clashes.
Wilfried Goesgens [Tue, 13 Sep 2011 15:58:51 +0000 (15:58 +0000)]
prepend pop3 to some more functions to work around name clashes.

10 years agoMake parameters const, its not altered inside.
Wilfried Goesgens [Tue, 13 Sep 2011 15:58:04 +0000 (15:58 +0000)]
Make parameters const, its not altered inside.

10 years agoRemove global variables; replace by stack passing.
Wilfried Goesgens [Thu, 8 Sep 2011 17:18:12 +0000 (17:18 +0000)]
Remove global variables; replace by stack passing.

10 years agoMore places to remove the experimental #if
Wilfried Goesgens [Thu, 8 Sep 2011 17:17:47 +0000 (17:17 +0000)]
More places to remove the experimental #if

10 years agoremove classic smtp client. we're over this.
Wilfried Goesgens [Thu, 8 Sep 2011 16:36:27 +0000 (16:36 +0000)]
remove classic smtp client. we're over this.

10 years agoCC -> CCC in do_login
Wilfried Goesgens [Thu, 8 Sep 2011 13:45:29 +0000 (13:45 +0000)]
CC -> CCC in do_login

10 years agoNetworker reordering; remove / change dependencies
Wilfried Goesgens [Thu, 8 Sep 2011 12:35:51 +0000 (12:35 +0000)]
Networker reordering; remove / change dependencies

  - move serv_network.h into modules/network where it belongs...
  - move structs out of serv_network.h into their respective headers
  - serv_expire doesn't need serv_network.h anymore, it seems to get the usetable struct from elsewhere
  - the netfilter module was moved to the network directory, it seems to be closely dangled to networking
  - move all code about the netfilter (config reading) into serv_netfilter.c
  - move the code networker related from msgbase.c:CtdlDoIHavePermissionToPostInThisRoom() into serv_netconfig.c:netconfig_check_roomaccess()
  - move the filterlist instance into serv_netfilter.c

lesson learned the hard way today: if you move a header, flush the dependencies, else the make process will abort with no usefull message at all.
 -> Gentlemen please flush the dependencies and rebootstrap your workingcopy.

10 years agoRemove unused AUTH variable from the buildsystem
Wilfried Goesgens [Thu, 8 Sep 2011 12:07:55 +0000 (12:07 +0000)]
Remove unused AUTH variable from the buildsystem

10 years agoChop networker into handy bits; related functions now live in their own file.
Wilfried Goesgens [Thu, 8 Sep 2011 09:35:01 +0000 (09:35 +0000)]
Chop networker into handy bits; related functions now live in their own file.

10 years agoremove unused code for locking
Wilfried Goesgens [Wed, 7 Sep 2011 21:07:09 +0000 (21:07 +0000)]
remove unused code for locking

10 years agoCode shuffling fixes warning with inline function... weirdo.
Wilfried Goesgens [Wed, 7 Sep 2011 15:25:11 +0000 (15:25 +0000)]
Code shuffling fixes warning with inline function... weirdo.

10 years agoLimit length of Commands sent to citserver; do multible json requests if neccessary
Wilfried Goesgens [Tue, 6 Sep 2011 23:00:12 +0000 (23:00 +0000)]
Limit length of Commands sent to citserver; do multible json requests if neccessary

  - roomListDropHandler() when cut'n'paste moving split after the move vector reaches 800 chars
  - deleteAllSelectedMessages() when <del> moving to trash / purging split into chunks to limit the command lengths

10 years agodeleteAllSelectedMessages(): don't send one request per message, citadel can handle...
Wilfried Goesgens [Tue, 6 Sep 2011 18:46:53 +0000 (18:46 +0000)]
deleteAllSelectedMessages(): don't send one request per message, citadel can handle a list of them already.

  - this dramaticaly increases the performance of pressing the <del> key when having several messages selected; less stress on the browser, webcit and citserver.

10 years agoFix warnings all over citserver; handle function replies; remove unused code.
Wilfried Goesgens [Wed, 7 Sep 2011 14:59:21 +0000 (14:59 +0000)]
Fix warnings all over citserver; handle function replies; remove unused code.

10 years agofix warnings in libev related codebase
Wilfried Goesgens [Wed, 7 Sep 2011 14:58:31 +0000 (14:58 +0000)]
fix warnings in libev related codebase

10 years agoCleanup our toolies, remove unneeded code; handle reply values.
Wilfried Goesgens [Wed, 7 Sep 2011 14:57:14 +0000 (14:57 +0000)]
Cleanup our toolies, remove unneeded code; handle reply values.

10 years agoHandle return values in Setup; catch errors & remove unneeded code.
Wilfried Goesgens [Wed, 7 Sep 2011 14:56:31 +0000 (14:56 +0000)]
Handle return values in Setup; catch errors & remove unneeded code.

10 years agoremove unused code; evaluate returnvalues.
Wilfried Goesgens [Wed, 7 Sep 2011 12:25:52 +0000 (12:25 +0000)]
remove unused code; evaluate returnvalues.

10 years agoremove unused code.
Wilfried Goesgens [Wed, 7 Sep 2011 12:25:26 +0000 (12:25 +0000)]
remove unused code.

10 years agoPrecisely report whats going wrong with the handling of the control file.
Wilfried Goesgens [Wed, 7 Sep 2011 12:24:48 +0000 (12:24 +0000)]
Precisely report whats going wrong with the handling of the control file.

10 years agodisable warnings about strict aliasing; gcc does broken warnings here in conjunction...
Wilfried Goesgens [Wed, 7 Sep 2011 12:14:16 +0000 (12:14 +0000)]
disable warnings about strict aliasing; gcc does broken warnings here in conjunction with libev

10 years agoFix more warnings; output errors to the users.
Wilfried Goesgens [Wed, 7 Sep 2011 12:13:44 +0000 (12:13 +0000)]
Fix more warnings; output errors to the users.

10 years agouse StrBuf to create startup failure messages.
Wilfried Goesgens [Wed, 7 Sep 2011 12:13:00 +0000 (12:13 +0000)]
use StrBuf to create startup failure messages.

10 years agoRevoke refetching of already polled pop3 messages
Wilfried Goesgens [Wed, 7 Sep 2011 09:38:22 +0000 (09:38 +0000)]
Revoke refetching of already polled pop3 messages

10 years agoFix compiler warnings in the textclient by evaluating returnvalues and removing unuse...
Wilfried Goesgens [Wed, 7 Sep 2011 09:37:33 +0000 (09:37 +0000)]
Fix compiler warnings in the textclient by evaluating returnvalues and removing unused code.

10 years agofix more merge hickups
Wilfried Goesgens [Tue, 6 Sep 2011 15:24:58 +0000 (15:24 +0000)]
fix more merge hickups

10 years agosome more tiny bits that slipped through
Wilfried Goesgens [Mon, 5 Sep 2011 09:01:21 +0000 (09:01 +0000)]
some more tiny bits that slipped through

10 years agomore tiny merge misses
Wilfried Goesgens [Mon, 5 Sep 2011 08:50:40 +0000 (08:50 +0000)]
more tiny merge misses

10 years agosome things which were missed during the big merger.
Wilfried Goesgens [Mon, 5 Sep 2011 06:55:43 +0000 (06:55 +0000)]
some things which were missed during the big merger.

10 years agoAdjust %s es in the chinese translation; Note to self: format string translates are...
Wilfried Goesgens [Sun, 28 Aug 2011 08:31:30 +0000 (08:31 +0000)]
Adjust %s es in the chinese translation; Note to self: format string translates are bad.

10 years agoAdd templatization for the Listsubscriber Interface; the old interface remains intact.
Wilfried Goesgens [Sun, 28 Aug 2011 07:48:34 +0000 (07:48 +0000)]
Add templatization for the Listsubscriber Interface; the old interface remains intact.

10 years agoAdd LPRM iterator for the public rooms.
Wilfried Goesgens [Sun, 28 Aug 2011 07:45:01 +0000 (07:45 +0000)]
Add LPRM iterator for the public rooms.

10 years agoremove unused copy to WCC
Wilfried Goesgens [Sun, 28 Aug 2011 07:44:23 +0000 (07:44 +0000)]
remove unused copy to WCC

10 years agoClear of non-default language setting moved to its proper place
Art Cancro [Sat, 27 Aug 2011 23:25:57 +0000 (19:25 -0400)]
Clear of non-default language setting moved to its proper place

10 years agoMake use of XML_StopParser() when XML_MAJOR_VERSION is >1, not >2. Thanks to Stefan...
Art Cancro [Fri, 26 Aug 2011 17:03:57 +0000 (13:03 -0400)]
Make use of XML_StopParser() when XML_MAJOR_VERSION is >1, not >2.  Thanks to Stefan for the bugfix.

10 years agoRemoved references to Subversion in the code
Art Cancro [Fri, 26 Aug 2011 14:17:03 +0000 (10:17 -0400)]
Removed references to Subversion in the code

10 years agoFixed the remaining bugs that kept Drafts from working properly
Art Cancro [Thu, 25 Aug 2011 21:28:18 +0000 (17:28 -0400)]
Fixed the remaining bugs that kept Drafts from working properly

10 years agoTest commit
Art Cancro [Thu, 25 Aug 2011 21:07:58 +0000 (17:07 -0400)]
Test commit

10 years agoCleanup of code path for handling message submit errors
Art Cancro [Thu, 25 Aug 2011 20:02:40 +0000 (16:02 -0400)]
Cleanup of code path for handling message submit errors

10 years agoSubmitting a message and getting back a 550 from the server now results in an error...
Art Cancro [Thu, 25 Aug 2011 19:51:13 +0000 (15:51 -0400)]
Submitting a message and getting back a 550 from the server now results in an error message instead of a blank page.

10 years agoChanged save_to_drafts to saving_to_drafts for clarity
Art Cancro [Thu, 25 Aug 2011 19:33:48 +0000 (15:33 -0400)]
Changed save_to_drafts to saving_to_drafts for clarity

10 years agoNoted with a comment where we need to handle ENT0 errors
Art Cancro [Wed, 24 Aug 2011 21:56:24 +0000 (17:56 -0400)]
Noted with a comment where we need to handle ENT0 errors

10 years agoOnly offer the 'Edit' option in mailbox rooms. Elsewhere it does not make sense.
Art Cancro [Wed, 24 Aug 2011 21:12:03 +0000 (17:12 -0400)]
Only offer the 'Edit' option in mailbox rooms.  Elsewhere it does not make sense.

10 years agoIf user clicks in the empty part of a mailbox view, display a blank pane instead...
Art Cancro [Wed, 24 Aug 2011 21:06:27 +0000 (17:06 -0400)]
If user clicks in the empty part of a mailbox view, display a blank pane instead of an error.

10 years agoMore 'greeking' the test mime data.
Art Cancro [Tue, 23 Aug 2011 21:13:09 +0000 (17:13 -0400)]
More 'greeking' the test mime data.

10 years agoBegan 'greeking' the test mime data.
Art Cancro [Tue, 23 Aug 2011 20:57:11 +0000 (16:57 -0400)]
Began 'greeking' the test mime data.

10 years agoAdded a checked and disabled dummy option in the room access tab, indicating that...
Art Cancro [Mon, 22 Aug 2011 17:20:04 +0000 (13:20 -0400)]
Added a checked and disabled dummy option in the room access tab, indicating that blog creators automatically become room aides.
This advises administrators of a built-in behavior, and also exposes a string to the translators so that its localization will already exist if we add that option later.

10 years agoBlog owners automatically become room aides of their blogs.
Art Cancro [Mon, 22 Aug 2011 17:07:12 +0000 (13:07 -0400)]
Blog owners automatically become room aides of their blogs.
(In the future we will offer a site-wide configuration setting to suppress this behavior.)

10 years agoClear selected_language when marking a guest session as inuse=0.
Art Cancro [Fri, 19 Aug 2011 19:12:50 +0000 (15:12 -0400)]
Clear selected_language when marking a guest session as inuse=0.
This prevents new visitors from seeing their first page in Chinese after Baidu comes calling.

10 years agoDon't add brackets <> to the reply to; it should be ok without.
Wilfried Goesgens [Thu, 18 Aug 2011 10:30:35 +0000 (10:30 +0000)]
Don't add brackets <> to the reply to; it should be ok without.

10 years agoparse reply-to header into its permanent database field
Wilfried Goesgens [Thu, 18 Aug 2011 10:27:54 +0000 (10:27 +0000)]
parse reply-to header into its permanent database field

it seems as if some mailers (Open exchange for example) add Reply-To headers; if we don't parse it when receiving it,
our list service adds another header; thus parse it into the database of headers.

10 years agoFix envelope-to header.
Wilfried Goesgens [Wed, 17 Aug 2011 10:12:21 +0000 (10:12 +0000)]
Fix envelope-to header.

  - don't output leading whitespace
  - don't output it at all if there is just whitespace inside.

10 years agoFixed a bug in the 'only replies are allowed in this room' logic in ENT0 command.
Art Cancro [Tue, 16 Aug 2011 19:55:15 +0000 (15:55 -0400)]
Fixed a bug in the 'only replies are allowed in this room' logic in ENT0 command.

10 years agoBegan working on access control changes for blog rooms.
Art Cancro [Tue, 16 Aug 2011 04:03:58 +0000 (00:03 -0400)]
Began working on access control changes for blog rooms.

10 years agoImproved coding style of the complex conditionals in CtdlRoomAccess()
Art Cancro [Tue, 16 Aug 2011 03:49:35 +0000 (23:49 -0400)]
Improved coding style of the complex conditionals in CtdlRoomAccess()

10 years agonetwork_spool_msg() handle QP
Wilfried Goesgens [Fri, 12 Aug 2011 15:51:14 +0000 (15:51 +0000)]
network_spool_msg() handle QP

while appending the [roomname] to the mailsubject, we have to
  - de-qp the original subject
  - search for the roomname
  - possibly prepend '[roomame] '
  - and re-qp everything.
that way we solve...
  - multiple [roomname] additions in case of QP encoded subjects
  - non RFC-Conformant behaviour in case of roomnames with umlauts.

10 years agodisplay_enter(): handle QP encodings
Wilfried Goesgens [Fri, 12 Aug 2011 15:49:45 +0000 (15:49 +0000)]
display_enter(): handle QP encodings

 - while loading several headers from the server we need to de-QP, else we will find gibberish in our...
  - Subject
  - recipients

10 years agofix all the tiny conditional problems our new checker told us about.
Wilfried Goesgens [Thu, 4 Aug 2011 21:09:56 +0000 (21:09 +0000)]
fix all the tiny conditional problems our new checker told us about.

10 years agouse the regular template error logging for our new endconditional checker, so we...
Wilfried Goesgens [Thu, 4 Aug 2011 20:52:11 +0000 (20:52 +0000)]
use the regular template error logging for our new endconditional checker, so we get our clean regular and detailed error messages.

10 years agoafter reading a template sanity check conditionals whether they're paired
Wilfried Goesgens [Mon, 1 Aug 2011 23:10:00 +0000 (23:10 +0000)]
after reading a template sanity check conditionals whether they're paired