citadel
8 years agodon't rely on malloc to handle (0) parameter; abort before.
Wilfried Goesgens [Sun, 29 Sep 2013 18:11:50 +0000 (20:11 +0200)]
don't rely on malloc to handle (0) parameter; abort before.

8 years agoremove unneeded assignment
Wilfried Goesgens [Sun, 29 Sep 2013 18:11:20 +0000 (20:11 +0200)]
remove unneeded assignment

8 years agowhen we did the login and replied, we mustn't try again to process the inbound comman...
Wilfried Goesgens [Sun, 29 Sep 2013 18:08:52 +0000 (20:08 +0200)]
when we did the login and replied, we mustn't try again to process the inbound command again, which will result in a useless additional second error reply.

8 years agoif the StrBuf or its parts are NULL, we can't do any work.
Wilfried Goesgens [Sun, 29 Sep 2013 16:04:40 +0000 (18:04 +0200)]
if the StrBuf or its parts are NULL, we can't do any work.

8 years agowe need to free the array _after_ releasing the array entries
Wilfried Goesgens [Sun, 29 Sep 2013 15:35:14 +0000 (17:35 +0200)]
we need to free the array _after_ releasing the array entries

8 years agoNULL-Protect the Context-ID
Wilfried Goesgens [Sun, 29 Sep 2013 15:08:27 +0000 (17:08 +0200)]
NULL-Protect the Context-ID

8 years agosecure possible NULL-Pointer access in strlen
Wilfried Goesgens [Sat, 28 Sep 2013 16:51:59 +0000 (18:51 +0200)]
secure possible NULL-Pointer access in strlen

8 years agoMake realy shure we don't put a NULL into memcpy
Wilfried Goesgens [Sat, 28 Sep 2013 16:48:36 +0000 (18:48 +0200)]
Make realy shure we don't put a NULL into memcpy

8 years agoset the type of the pointer into sizeof, so its definitely the right
Wilfried Goesgens [Sat, 28 Sep 2013 16:42:48 +0000 (18:42 +0200)]
set the type of the pointer into sizeof, so its definitely the right

8 years agoConvert CtdlMessages to respect cm_lengths[]
Wilfried Goesgens [Tue, 24 Sep 2013 22:37:08 +0000 (00:37 +0200)]
Convert CtdlMessages to respect cm_lengths[]

  - move application specific code during message saving behind abstract handlers
    - IGNET spoorling
    - SMTP Spooling
    - ExtNotify Spooling
  - add new Message Hook: EVT_AFTERUSRMBOXSAVE
  - Put the volatile message ID to the message struct earlier

8 years agoadd strbuff wrapper for base64 encoding
Wilfried Goesgens [Tue, 24 Sep 2013 22:33:29 +0000 (00:33 +0200)]
add strbuff wrapper for base64 encoding

8 years agoanother place where the include was missing
Wilfried Goesgens [Sun, 22 Sep 2013 19:32:41 +0000 (21:32 +0200)]
another place where the include was missing

8 years agoheader rework: we need ecrash.h here.
Wilfried Goesgens [Sun, 22 Sep 2013 18:55:25 +0000 (20:55 +0200)]
header rework: we need ecrash.h here.

8 years agofix possible endless loop
Wilfried Goesgens [Sun, 22 Sep 2013 14:31:02 +0000 (16:31 +0200)]
fix possible endless loop

8 years agocleanup includes
Wilfried Goesgens [Sun, 15 Sep 2013 17:03:00 +0000 (19:03 +0200)]
cleanup includes

8 years agocleanup: remove unneeded includes.
Wilfried Goesgens [Sun, 15 Sep 2013 13:49:55 +0000 (15:49 +0200)]
cleanup: remove unneeded includes.

8 years agouser access level helper moved to the other accesslevel helpers: user_ops.c
Wilfried Goesgens [Sat, 14 Sep 2013 21:00:46 +0000 (23:00 +0200)]
user access level helper moved to the other accesslevel helpers: user_ops.c

8 years agode-apify GenerateRoomDisplay(), its only needed in serv_rwho.
Wilfried Goesgens [Sat, 14 Sep 2013 20:44:56 +0000 (22:44 +0200)]
de-apify GenerateRoomDisplay(), its only needed in serv_rwho.

8 years agomove cmd_isme to serv_user.c
Wilfried Goesgens [Sat, 14 Sep 2013 20:30:41 +0000 (22:30 +0200)]
move cmd_isme to serv_user.c

8 years agomove cull to serv_syscmds
Wilfried Goesgens [Sat, 14 Sep 2013 20:23:59 +0000 (22:23 +0200)]
move cull to serv_syscmds

8 years agomove log switcher funcs to serv_syscmds.c
Wilfried Goesgens [Sat, 14 Sep 2013 20:18:25 +0000 (22:18 +0200)]
move log switcher funcs to serv_syscmds.c

8 years agostart moving system commands into its own file
Wilfried Goesgens [Sat, 14 Sep 2013 19:44:55 +0000 (21:44 +0200)]
start moving system commands into its own file

8 years agomove Mesg commands to serv_files; they basicaly also handle files - just text files.
Wilfried Goesgens [Sat, 14 Sep 2013 19:35:51 +0000 (21:35 +0200)]
move Mesg commands to serv_files; they basicaly also handle files - just text files.

8 years agomove file_ops to modules/ctdlsrv/serv_file.c
Wilfried Goesgens [Sat, 14 Sep 2013 17:36:23 +0000 (19:36 +0200)]
move file_ops to modules/ctdlsrv/serv_file.c

  - resolve dependency in session termination via EVT_LOGOUT-hook-function.

8 years agoApiize CtdlIsPublicClient()
Wilfried Goesgens [Sat, 14 Sep 2013 17:33:19 +0000 (19:33 +0200)]
Apiize CtdlIsPublicClient()

8 years agooops, forgot to add the user commands
Wilfried Goesgens [Sat, 14 Sep 2013 09:36:21 +0000 (11:36 +0200)]
oops, forgot to add the user commands

8 years agomove session related functions to ctdlproto/serv_session.c
Wilfried Goesgens [Sat, 14 Sep 2013 09:35:29 +0000 (11:35 +0200)]
move session related functions to ctdlproto/serv_session.c

8 years agomove citadel protocol user functions to modules/ctdlproto/serv_user.c
Wilfried Goesgens [Sat, 14 Sep 2013 09:12:26 +0000 (11:12 +0200)]
move citadel protocol user functions to modules/ctdlproto/serv_user.c

8 years agomove citadel room functions into its own file.
Wilfried Goesgens [Sat, 14 Sep 2013 09:05:32 +0000 (11:05 +0200)]
move citadel room functions into its own file.

8 years agomove the citadel protocol message handlers ino modules/citadel
Wilfried Goesgens [Sat, 14 Sep 2013 08:54:06 +0000 (10:54 +0200)]
move the citadel protocol message handlers ino modules/citadel

8 years agoMesages: fix copying of fields; add flush function to cleanup a messages structs...
Wilfried Goesgens [Sat, 14 Sep 2013 08:53:06 +0000 (10:53 +0200)]
Mesages: fix copying of fields; add flush function to cleanup a messages structs members.

8 years agoMerge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel
Wilfried Goesgens [Thu, 12 Sep 2013 20:59:03 +0000 (22:59 +0200)]
Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel

Conflicts:
citadel/modules/network/serv_network.c
citadel/modules/smtp/serv_smtp.c
citadel/modules/smtp/smtp_util.c

8 years agoextnotify: free up resources on exit.
Wilfried Goesgens [Thu, 12 Sep 2013 20:47:45 +0000 (22:47 +0200)]
extnotify: free up resources on exit.

8 years agofix the offset of items in calendar day view broken in d8b779a9ff974444efe99a5d41b8d2...
Wilfried Goesgens [Mon, 9 Sep 2013 21:01:41 +0000 (23:01 +0200)]
fix the offset of items in calendar day view broken in d8b779a9ff974444efe99a5d41b8d2663e8a5919

8 years agosplit citadel protocol related functions from msgbase.c into ctdl_message.c; fix...
Wilfried Goesgens [Sun, 1 Sep 2013 20:09:55 +0000 (22:09 +0200)]
split citadel protocol related functions from msgbase.c into ctdl_message.c; fix missing header forward declarations.

8 years agoadd initialization in internet_addressing
Wilfried Goesgens [Sun, 1 Sep 2013 18:40:00 +0000 (20:40 +0200)]
add initialization in internet_addressing

8 years agomove config message loading from msgbase.c -> config.c
Wilfried Goesgens [Sun, 1 Sep 2013 18:13:44 +0000 (20:13 +0200)]
move config message loading from msgbase.c -> config.c

8 years agomove email address related functions oven to internet_addressing
Wilfried Goesgens [Sun, 1 Sep 2013 16:57:02 +0000 (18:57 +0200)]
move email address related functions oven to internet_addressing

8 years agooops, this also checks room access rights.
Wilfried Goesgens [Sun, 1 Sep 2013 16:27:04 +0000 (18:27 +0200)]
oops, this also checks room access rights.

8 years agoMove user privileges functions to user_ops.c, room access check functions to room_ops.c
Wilfried Goesgens [Sun, 1 Sep 2013 16:12:25 +0000 (18:12 +0200)]
Move user privileges functions to user_ops.c, room access check functions to room_ops.c

8 years agoMove simple subtstitution functions to the message functions
Wilfried Goesgens [Sun, 1 Sep 2013 13:11:29 +0000 (15:11 +0200)]
Move simple subtstitution functions to the message functions

8 years agorefactor naming of core message manipulation funcions
Wilfried Goesgens [Sun, 1 Sep 2013 12:58:06 +0000 (14:58 +0200)]
refactor naming of core message manipulation funcions

8 years agoMove Message struct manipulation functions into one place
Wilfried Goesgens [Sun, 1 Sep 2013 12:46:56 +0000 (14:46 +0200)]
Move Message struct manipulation functions into one place

8 years agoReplace all discrete checks for empty message fields by CM_IsEmpty()
Wilfried Goesgens [Sun, 1 Sep 2013 12:33:21 +0000 (14:33 +0200)]
Replace all discrete checks for empty message fields by CM_IsEmpty()

8 years agoRoute all access to cm_fields[] through api functions
Wilfried Goesgens [Sun, 1 Sep 2013 10:30:27 +0000 (12:30 +0200)]
Route all access to cm_fields[] through api functions

8 years agoFix generation of bounce messages; we would put the bounce body into the author field.
Wilfried Goesgens [Sun, 1 Sep 2013 09:39:20 +0000 (11:39 +0200)]
Fix generation of bounce messages; we would put the bounce body into the author field.

8 years agoFix possible double free during sending network error messages.
Wilfried Goesgens [Sat, 31 Aug 2013 18:57:16 +0000 (20:57 +0200)]
Fix possible double free during sending network error messages.

8 years agomake it const, baby!
Wilfried Goesgens [Sat, 31 Aug 2013 13:18:30 +0000 (15:18 +0200)]
make it const, baby!

8 years agoObserve the 'preferred sender email' and 'preferred sender name' preferences when...
Art Cancro [Sun, 25 Aug 2013 18:56:50 +0000 (14:56 -0400)]
Observe the 'preferred sender email' and 'preferred sender name' preferences when submitting email via SMTP.

9 years agouse an Enum for the cm_fields vector instead of nameless chars
Wilfried Goesgens [Sun, 18 Aug 2013 08:29:11 +0000 (10:29 +0200)]
use an Enum for the cm_fields vector instead of nameless chars

9 years agoUCLS: output networker files to syslog
Wilfried Goesgens [Sat, 17 Aug 2013 19:13:22 +0000 (21:13 +0200)]
UCLS: output networker files to syslog

9 years agoNetworker: more verbose INFO-logging about what we do / did with files.
Wilfried Goesgens [Sat, 17 Aug 2013 19:05:36 +0000 (21:05 +0200)]
Networker: more verbose INFO-logging about what we do / did with files.

9 years agoFDIO: don't set fd's to 0, -1 is better since its safe for abuse.
Wilfried Goesgens [Sat, 17 Aug 2013 10:14:57 +0000 (12:14 +0200)]
FDIO: don't set fd's to 0, -1 is better since its safe for abuse.

9 years agoFDIO: check for double freeing of an FDIO resource to fix possible double close ...
Wilfried Goesgens [Thu, 15 Aug 2013 21:25:32 +0000 (23:25 +0200)]
FDIO: check for double freeing of an FDIO resource to fix possible double close / 0 fd close

9 years agoAdjusted paramhandling to accept parameters with empty values (which is legal) v8.20
Art Cancro [Wed, 14 Aug 2013 14:43:11 +0000 (10:43 -0400)]
Adjusted paramhandling to accept parameters with empty values (which is legal)

9 years agocorrected some comment mistakes
Art Cancro [Sun, 11 Aug 2013 19:40:02 +0000 (15:40 -0400)]
corrected some comment mistakes

9 years agoOnly define CTDLDIR if not already defined
Art Cancro [Sun, 11 Aug 2013 19:37:06 +0000 (15:37 -0400)]
Only define CTDLDIR if not already defined

9 years agofixed some comment syntax
Art Cancro [Sun, 11 Aug 2013 19:35:41 +0000 (15:35 -0400)]
fixed some comment syntax

9 years agoRSS: if debug, remove variables too.
Wilfried Goesgens [Sat, 3 Aug 2013 16:49:15 +0000 (18:49 +0200)]
RSS: if debug, remove variables too.

9 years agoMerge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel
Wilfried Goesgens [Sat, 3 Aug 2013 14:20:51 +0000 (16:20 +0200)]
Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel

9 years agoMESSAGES: store 1 & 2 field to db - it has to be permanent.
Wilfried Goesgens [Sat, 3 Aug 2013 14:20:21 +0000 (16:20 +0200)]
MESSAGES: store 1 & 2 field to db - it has to be permanent.

9 years agoInstant expunge is now the only mode of operation. The expunge semantics have been...
Art Cancro [Sat, 3 Aug 2013 00:10:43 +0000 (20:10 -0400)]
Instant expunge is now the only mode of operation.  The expunge semantics have been stupid from the beginning and Mark Crispin should die in a car fire for forcing the entire world to deal with workarounds for his crappy data store.

9 years agoDisable ical rendering for now.
Wilfried Goesgens [Fri, 19 Jul 2013 12:38:00 +0000 (14:38 +0200)]
Disable ical rendering for now.

9 years agoUpdated all version numbers to 8.20 in preparation for release
Art Cancro [Tue, 16 Jul 2013 17:50:38 +0000 (13:50 -0400)]
Updated all version numbers to 8.20 in preparation for release

9 years agoStrBufStripAllBut() now returns the LEFTMOST qualifying substring. This allows mail...
Art Cancro [Thu, 11 Jul 2013 01:07:43 +0000 (21:07 -0400)]
StrBufStripAllBut() now returns the LEFTMOST qualifying substring. This allows mail to be received from brain-damaged Microsoft MTAs that place additional superfluous angle-bracketed strings on the MAIL FROM line.  Bill Gates is Hitler.

9 years agoAdditional logging to troubleshoot false positives on spoof check
Art Cancro [Mon, 8 Jul 2013 18:48:41 +0000 (14:48 -0400)]
Additional logging to troubleshoot false positives on spoof check

9 years agoVCARD: if we loaded the vcard mime from the server don't load it again.
Wilfried Goesgens [Sat, 6 Jul 2013 14:03:39 +0000 (16:03 +0200)]
VCARD: if we loaded the vcard mime from the server don't load it again.

Thanks to Stefan for reporting this (again)

9 years agoSendcommand: add missing break - so we don't fail to -w.
Wilfried Goesgens [Sat, 29 Jun 2013 22:21:53 +0000 (00:21 +0200)]
Sendcommand: add missing break - so we don't fail to -w.

Thanks to Harry Coin for pointing this out.

9 years agoGETTEXT: when re-using a session, make shure we re-detect the locales.
Wilfried Goesgens [Tue, 25 Jun 2013 21:13:40 +0000 (23:13 +0200)]
GETTEXT: when re-using a session, make shure we re-detect the locales.

9 years agoGETTEXT: Browser detection; if we don't know any of the users languages, rather defau...
Wilfried Goesgens [Tue, 25 Jun 2013 20:28:22 +0000 (22:28 +0200)]
GETTEXT: Browser detection; if we don't know any of the users languages, rather default to en_US then choosing the lexicographical closest match - the user may not understand this locale at all.

9 years agoGETTEXT: represent C as en_US to the user - no one speaks C that fluently after all ;-)
Wilfried Goesgens [Tue, 25 Jun 2013 18:47:08 +0000 (20:47 +0200)]
GETTEXT: represent C as en_US to the user - no one speaks C that fluently after all ;-)

9 years agoSUBST: bad bug in plain text substitution: need to specify -1 if strlen not provided.
Wilfried Goesgens [Tue, 25 Jun 2013 18:46:23 +0000 (20:46 +0200)]
SUBST: bad bug in plain text substitution: need to specify -1 if strlen not provided.

9 years agoSUBST: fix warnings.
Wilfried Goesgens [Sun, 23 Jun 2013 14:43:33 +0000 (16:43 +0200)]
SUBST: fix warnings.

9 years agoGETTEXT: optionaly allow to escape translated tokens.
Wilfried Goesgens [Sun, 23 Jun 2013 14:41:24 +0000 (16:41 +0200)]
GETTEXT: optionaly allow to escape translated tokens.

9 years agoDEB: also warn uninitialized access when doing debug compile
Wilfried Goesgens [Sun, 23 Jun 2013 14:35:34 +0000 (16:35 +0200)]
DEB: also warn uninitialized access when doing debug compile

9 years agocURL: put error description into the status message.
Wilfried Goesgens [Sat, 15 Jun 2013 13:00:14 +0000 (15:00 +0200)]
cURL: put error description into the status message.

9 years agoCURL: it seems as in case of timeout cURL closes the FD somewhere before - forget...
Wilfried Goesgens [Wed, 12 Jun 2013 22:27:56 +0000 (00:27 +0200)]
CURL: it seems as in case of timeout cURL closes the FD somewhere before - forget it so we don't close it again.

9 years agoMailinglists: possible room aliases have to be prepared to not contain blanks and...
Wilfried Goesgens [Wed, 12 Jun 2013 20:11:53 +0000 (22:11 +0200)]
Mailinglists: possible room aliases have to be prepared to not contain blanks and non-ascii-chars.

9 years agoML: don't free the roomname yet - we still need it.
Wilfried Goesgens [Wed, 12 Jun 2013 19:51:38 +0000 (21:51 +0200)]
ML: don't free the roomname yet - we still need it.

9 years agoMailinglist: properly sanitize the roomname if we have to use it as sender.
Wilfried Goesgens [Wed, 12 Jun 2013 19:14:41 +0000 (21:14 +0200)]
Mailinglist: properly sanitize the roomname if we have to use it as sender.

9 years agoSMTP: fix aggregation of fail stati for aide / bounce message.
Wilfried Goesgens [Mon, 10 Jun 2013 18:02:40 +0000 (20:02 +0200)]
SMTP: fix aggregation of fail stati for aide / bounce message.

9 years agoNETCFG: make shure files exist with proper permissions.
Wilfried Goesgens [Mon, 10 Jun 2013 17:43:39 +0000 (19:43 +0200)]
NETCFG: make shure files exist with proper permissions.

9 years agoRNCFG: protect deletion of configs
Wilfried Goesgens [Sat, 8 Jun 2013 15:10:06 +0000 (17:10 +0200)]
RNCFG: protect deletion of configs

9 years agoCitadel Networking: add configured remote room name, so its later on put into the...
Wilfried Goesgens [Sat, 8 Jun 2013 15:06:11 +0000 (17:06 +0200)]
Citadel Networking: add configured remote room name, so its later on put into the spool message.

9 years agoNETIN: one return is enough.
Wilfried Goesgens [Sat, 8 Jun 2013 15:05:01 +0000 (17:05 +0200)]
NETIN: one return is enough.

9 years agoNETIN: save strlens when deserializing network message buffers.
Wilfried Goesgens [Sat, 8 Jun 2013 15:03:50 +0000 (17:03 +0200)]
NETIN: save strlens when deserializing network message buffers.

9 years agoMessage Deletion: only use one memmove to remove leading empty message numbers
Wilfried Goesgens [Sat, 8 Jun 2013 15:02:49 +0000 (17:02 +0200)]
Message Deletion: only use one memmove to remove leading empty message numbers

9 years agoLOG: add separating blanks in debug messages.
Wilfried Goesgens [Sat, 8 Jun 2013 15:01:10 +0000 (17:01 +0200)]
LOG: add separating blanks in debug messages.

9 years agoEVCURL: debug log stopping
Wilfried Goesgens [Sat, 8 Jun 2013 14:59:48 +0000 (16:59 +0200)]
EVCURL: debug log stopping

9 years agoRSSClient: don't save empty messages.
Wilfried Goesgens [Thu, 6 Jun 2013 21:22:47 +0000 (23:22 +0200)]
RSSClient: don't save empty messages.

9 years agofix buffer overrun by 1
Wilfried Goesgens [Thu, 6 Jun 2013 19:02:28 +0000 (21:02 +0200)]
fix buffer overrun by 1

9 years agoAdd handler for recovery of bad file descriptors
Wilfried Goesgens [Wed, 5 Jun 2013 23:06:30 +0000 (01:06 +0200)]
Add handler for recovery of bad file descriptors

9 years agoUT: fix comparison for expired timestamps.
Wilfried Goesgens [Wed, 5 Jun 2013 07:46:20 +0000 (09:46 +0200)]
UT: fix comparison for expired timestamps.

9 years agoRSSClient: do not double delete the curl context; don't swap IOID and CCID for logging
Wilfried Goesgens [Tue, 4 Jun 2013 20:10:43 +0000 (22:10 +0200)]
RSSClient: do not double delete the curl context; don't swap IOID and CCID for logging

9 years agoTDAP: increase usetable flush time to 10 days
Wilfried Goesgens [Sun, 2 Jun 2013 12:12:52 +0000 (14:12 +0200)]
TDAP: increase usetable flush time to 10 days

9 years agoCURL: the cleanup has to be done before.
Wilfried Goesgens [Sun, 2 Jun 2013 12:10:43 +0000 (14:10 +0200)]
CURL: the cleanup has to be done before.

9 years agoRSSClient: refresh per message UT-Entries after one day
Wilfried Goesgens [Mon, 27 May 2013 22:47:15 +0000 (00:47 +0200)]
RSSClient: refresh per message UT-Entries after one day

9 years agoMerge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel
Wilfried Goesgens [Sun, 26 May 2013 13:47:04 +0000 (15:47 +0200)]
Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel

9 years agoEV: stop all watchers before going into other queues - so we can avoid race conditions.
Wilfried Goesgens [Sun, 26 May 2013 13:46:09 +0000 (15:46 +0200)]
EV: stop all watchers before going into other queues - so we can avoid race conditions.

9 years agominor doc change
Art Cancro [Mon, 20 May 2013 21:45:30 +0000 (17:45 -0400)]
minor doc change