citadel
9 years agoEV: fix possible nullpointer access in last commit.
Wilfried Goesgens [Sun, 12 May 2013 20:44:11 +0000 (22:44 +0200)]
EV: fix possible nullpointer access in last commit.

9 years agoEV: expose current event queue state to the RWHO command
Wilfried Goesgens [Sun, 12 May 2013 16:36:33 +0000 (18:36 +0200)]
EV: expose current event queue state to the RWHO command

9 years agoRSS: expose current state of action to RWHO command
Wilfried Goesgens [Sun, 12 May 2013 09:50:52 +0000 (11:50 +0200)]
RSS: expose current state of action to RWHO command

9 years agofix formating; use define for size_t arguments.
Wilfried Goesgens [Sun, 21 Apr 2013 08:11:48 +0000 (10:11 +0200)]
fix formating; use define for size_t arguments.

9 years agoUnix domain sockets don't work well in non-blocking.
Wilfried Goesgens [Sun, 21 Apr 2013 07:30:43 +0000 (09:30 +0200)]
Unix domain sockets don't work well in non-blocking.

9 years agoTHREADS: config setting min_workers _now_ also is that, plus its also max_spare_workers
Wilfried Goesgens [Sat, 20 Apr 2013 11:16:37 +0000 (13:16 +0200)]
THREADS: config setting min_workers _now_ also is that, plus its also max_spare_workers

9 years agoTHREADS: re-install the max workers & min spare workers configs; lock thread count...
Wilfried Goesgens [Sat, 20 Apr 2013 10:48:45 +0000 (12:48 +0200)]
THREADS: re-install the max workers & min spare workers configs; lock thread count operations.

9 years agofix compilation.
Wilfried Goesgens [Tue, 16 Apr 2013 21:04:12 +0000 (23:04 +0200)]
fix compilation.

9 years agofix closing of already closed files
Wilfried Goesgens [Tue, 16 Apr 2013 21:03:33 +0000 (23:03 +0200)]
fix closing of already closed files

9 years agoSockets: make clear we don't close a socket again.
Wilfried Goesgens [Tue, 16 Apr 2013 19:42:24 +0000 (21:42 +0200)]
Sockets: make clear we don't close a socket again.

9 years agoEVENT: we memset the context, remember & re-set the ID so we can find the earlier...
Wilfried Goesgens [Tue, 16 Apr 2013 19:27:10 +0000 (21:27 +0200)]
EVENT: we memset the context, remember & re-set the ID so we can find the earlier destroy better.

9 years agoRSS: some more debug logging.
Wilfried Goesgens [Tue, 16 Apr 2013 19:26:53 +0000 (21:26 +0200)]
RSS: some more debug logging.

9 years agoSMPQ: we collect stati of all failed attempts; put them into the bounce messages.
Wilfried Goesgens [Sat, 13 Apr 2013 10:45:21 +0000 (12:45 +0200)]
SMPQ: we collect stati of all failed attempts; put them into the bounce messages.

9 years agoNETCFG: increment loop counter.
Wilfried Goesgens [Sat, 13 Apr 2013 09:17:47 +0000 (11:17 +0200)]
NETCFG: increment loop counter.

9 years agoLogin: fix typo in token
Wilfried Goesgens [Fri, 12 Apr 2013 06:16:56 +0000 (08:16 +0200)]
Login: fix typo in token

9 years agoWildfire: fix memory leak.
Wilfried Goesgens [Sun, 31 Mar 2013 19:54:38 +0000 (21:54 +0200)]
Wildfire: fix memory leak.

9 years agoNETCFG: fix condition to check whether a filedescriptor is there or not.
Wilfried Goesgens [Sun, 31 Mar 2013 19:31:07 +0000 (21:31 +0200)]
NETCFG: fix condition to check whether a filedescriptor is there or not.

9 years agoNETCFG: oops, we need to add CCID to the CtdlAideFPMessage() here too.
Wilfried Goesgens [Sun, 31 Mar 2013 12:47:08 +0000 (14:47 +0200)]
NETCFG: oops, we need to add CCID to the CtdlAideFPMessage() here too.

9 years agoRework Login dialog to work with rekonq (and hopefully Safari)
Wilfried Goesgens [Sun, 31 Mar 2013 11:52:02 +0000 (13:52 +0200)]
Rework Login dialog to work with rekonq (and hopefully Safari)

  - modal.js: don't use a function pointer - simply name the function as the pointer.
  - head.html: if we're not logged in, we add the login dialog to the page; its hidden anyways.
  - login.html: since we get printed into existing pages, we don't need <html><body> - its wrong in first place to have them.
  - authmethods.js: GetLoggedInFirst(): we don't need to send an ajax request to retrieve the login mask; if its needed, head.html already contains it. Simply uncover it to the user.

9 years agoSEEN-Database: refactor database interface for remembering whether we already aggrega...
Wilfried Goesgens [Fri, 29 Mar 2013 10:53:03 +0000 (11:53 +0100)]
SEEN-Database: refactor database interface for remembering whether we already aggregated messages

  - concentrate all application interactions in database.c in CheckIfAlreadySeen
  - add debug log facility for seen access
  - reduce write access to the table by only refreshing records every 4 days (we need to do this, else they will expire after 7 days)

9 years agoInfrastructure: if we don't find the ical headers during boostrap, abort.
Wilfried Goesgens [Tue, 26 Mar 2013 19:13:26 +0000 (20:13 +0100)]
Infrastructure: if we don't find the ical headers during boostrap, abort.

9 years agoRSSC: remove old malloc not needed anymore.
Wilfried Goesgens [Mon, 25 Mar 2013 14:28:40 +0000 (15:28 +0100)]
RSSC: remove old malloc not needed anymore.

9 years agoNSYN: fix the NSYN command
Wilfried Goesgens [Mon, 25 Mar 2013 13:58:48 +0000 (14:58 +0100)]
NSYN: fix the NSYN command

  - construct the recipients the way the networking functions expect them
  - add debug log when combining the spoolfile to log the current outbound file size
  - check whether we are able to load the message from disk before calling the recipient handlers.

9 years agoNTT: add a debug facility to dump all currently locked peers
Wilfried Goesgens [Mon, 25 Mar 2013 13:56:49 +0000 (14:56 +0100)]
NTT: add a debug facility to dump all currently locked peers

9 years agoMSG: log if we don't find a requested message in the db
Wilfried Goesgens [Mon, 25 Mar 2013 13:54:44 +0000 (14:54 +0100)]
MSG: log if we don't find a requested message in the db

9 years agoWorkaround pop3 servers sending empty lines in message lists
Wilfried Goesgens [Fri, 22 Mar 2013 17:35:20 +0000 (18:35 +0100)]
Workaround pop3 servers sending empty lines in message lists

9 years agoRSSClient: fix loading of RSS Configs; Usetable handling
Wilfried Goesgens [Thu, 21 Mar 2013 00:25:08 +0000 (01:25 +0100)]
RSSClient: fix loading of RSS Configs; Usetable handling

  - Configs: forgot to iterate over the list
  - Configs: extract the bare URL
  - UseTable: now and then we need to parse the document, so we refresh the seen-table timestamps; else these entries will be removed by the TDAB.

9 years agothere is no ar_AR, we choose ar_AE.
Wilfried Goesgens [Tue, 19 Mar 2013 12:40:47 +0000 (13:40 +0100)]
there is no ar_AR, we choose ar_AE.

9 years agoGETTEXT: rather choose the language on the array of locales successfully loaded than...
Wilfried Goesgens [Mon, 18 Mar 2013 22:30:37 +0000 (23:30 +0100)]
GETTEXT: rather choose the language on the array of locales successfully loaded than those we originaly shipped.

9 years agooops, we chose to do this in alphabetic order.
Wilfried Goesgens [Wed, 6 Mar 2013 06:21:43 +0000 (07:21 +0100)]
oops, we chose to do this in alphabetic order.

9 years agoTranslation: add arabic
Wilfried Goesgens [Wed, 6 Mar 2013 06:17:30 +0000 (07:17 +0100)]
Translation: add arabic

9 years agoTinyMCE: enable browser based spellchecking. Tnx ax25 to dig out this option.
Wilfried Goesgens [Mon, 11 Mar 2013 19:07:52 +0000 (20:07 +0100)]
TinyMCE: enable browser based spellchecking. Tnx ax25 to dig out this option.

9 years agooops, we chose to do this in alphabetic order.
Wilfried Goesgens [Wed, 6 Mar 2013 06:21:43 +0000 (07:21 +0100)]
oops, we chose to do this in alphabetic order.

9 years agoTranslation: add arabic
Wilfried Goesgens [Wed, 6 Mar 2013 06:17:30 +0000 (07:17 +0100)]
Translation: add arabic

9 years agoEVENT_CLIENT: when handing over to the DB-Queue, don't re-start IO-Watchers.
Wilfried Goesgens [Sat, 2 Mar 2013 14:35:30 +0000 (15:35 +0100)]
EVENT_CLIENT: when handing over to the DB-Queue, don't re-start IO-Watchers.

9 years agoSMTPSrv: don't use memset() to forget - we have structured data in there now.
Wilfried Goesgens [Fri, 1 Mar 2013 19:19:41 +0000 (20:19 +0100)]
SMTPSrv: don't use memset() to forget - we have structured data in there now.

9 years agoFile-Handling: sanitize filenames.
Wilfried Goesgens [Mon, 25 Feb 2013 19:48:08 +0000 (20:48 +0100)]
File-Handling: sanitize filenames.

9 years agomime_download(): missed CC -> CCC in one place.
Wilfried Goesgens [Mon, 25 Feb 2013 19:32:52 +0000 (20:32 +0100)]
mime_download(): missed CC -> CCC in one place.

9 years agoSMTP-Client: Implement AUTH LOGIN
Wilfried Goesgens [Mon, 25 Feb 2013 18:59:47 +0000 (19:59 +0100)]
SMTP-Client: Implement AUTH LOGIN

9 years agoMerge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel
Wilfried Goesgens [Sun, 24 Feb 2013 11:44:45 +0000 (12:44 +0100)]
Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel

9 years agoLists: don't overwrite from: header. this only needs to be done for participates.
Wilfried Goesgens [Sun, 24 Feb 2013 11:38:12 +0000 (12:38 +0100)]
Lists: don't overwrite from: header. this only needs to be done for participates.

9 years agoCompleted a pair of functions to fetch the user preferences at the beginning of an...
Art Cancro [Fri, 22 Feb 2013 20:11:21 +0000 (15:11 -0500)]
Completed a pair of functions to fetch the user preferences at the beginning of an authenticated SMTP session.  (Actually doing something with this data will follow in an upcoming commit.)

9 years agoPOP3Clinet: add missing iteration to next in linked list.
Wilfried Goesgens [Fri, 22 Feb 2013 11:50:20 +0000 (12:50 +0100)]
POP3Clinet: add missing iteration to next in linked list.

9 years agoMerge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel
Wilfried Goesgens [Fri, 22 Feb 2013 11:41:15 +0000 (12:41 +0100)]
Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel

9 years agoPOP3Aggregator: check whether we already have a session or not before attempting...
Wilfried Goesgens [Fri, 22 Feb 2013 11:40:22 +0000 (12:40 +0100)]
POP3Aggregator: check whether we already have a session or not before attempting to flag it to be killed.

9 years agoBegan writing a routine to fetch the user's preferred display name for authenticated...
Art Cancro [Fri, 22 Feb 2013 04:00:24 +0000 (23:00 -0500)]
Began writing a routine to fetch the user's preferred display name for authenticated-smtp mails.  Couldn't test it because my citserver is crashing from another bug.

9 years agoOPENID: if self service account creation is disabled - ApenID is also.
Wilfried Goesgens [Wed, 20 Feb 2013 23:27:10 +0000 (00:27 +0100)]
OPENID: if self service account creation is disabled - ApenID is also.

9 years agomake the server connection to citserver nonblocking so we can react with timeouts.
Wilfried Goesgens [Mon, 18 Feb 2013 22:54:54 +0000 (23:54 +0100)]
make the server connection to citserver nonblocking so we can react with timeouts.

9 years agoNETCFG: add a UI interface to add participates.
Wilfried Goesgens [Mon, 18 Feb 2013 22:51:54 +0000 (23:51 +0100)]
NETCFG: add a UI interface to add participates.

9 years agoML: remove cludge to set the reply-to from the original mail recipiient; we may now...
Wilfried Goesgens [Sun, 17 Feb 2013 22:41:54 +0000 (23:41 +0100)]
ML: remove cludge to set the reply-to from the original mail recipiient; we may now use our new config value or the default room name.

9 years agoRNCFG: implement missing handler for room aliases.
Wilfried Goesgens [Sun, 17 Feb 2013 22:32:56 +0000 (23:32 +0100)]
RNCFG: implement missing handler for room aliases.

9 years agoread will return 0 if select wouldn't have been successfull.
Wilfried Goesgens [Sun, 17 Feb 2013 19:41:29 +0000 (20:41 +0100)]
read will return 0 if select wouldn't have been successfull.

9 years agoNETCFG: cleanup & memleaks fixed.
Wilfried Goesgens [Sun, 17 Feb 2013 19:40:38 +0000 (20:40 +0100)]
NETCFG: cleanup & memleaks fixed.

9 years agono, CalcListID is needed in both places :(
Wilfried Goesgens [Sun, 17 Feb 2013 17:48:34 +0000 (18:48 +0100)]
no, CalcListID is needed in both places :(

9 years agoCalcListID() was ran in the wrong place.
Wilfried Goesgens [Sun, 17 Feb 2013 17:45:33 +0000 (18:45 +0100)]
CalcListID() was ran in the wrong place.

9 years agoNETWORKER: add from addresses and new way of setting list headers.
Wilfried Goesgens [Sun, 17 Feb 2013 16:23:27 +0000 (17:23 +0100)]
NETWORKER: add from addresses and new way of setting list headers.

9 years agowrap around ; as the style guide police against nasty errors sugests.
Wilfried Goesgens [Sun, 17 Feb 2013 16:22:48 +0000 (17:22 +0100)]
wrap around ; as the style guide police against nasty errors sugests.

9 years agoadd utility function to set / replace cm_flield entries.
Wilfried Goesgens [Sun, 17 Feb 2013 16:22:05 +0000 (17:22 +0100)]
add utility function to set / replace cm_flield entries.

9 years agoAdd new function to remove non-ascii characters from strings.
Wilfried Goesgens [Sun, 17 Feb 2013 14:50:46 +0000 (15:50 +0100)]
Add new function to remove non-ascii characters from strings.

9 years agoWhen trying to bind default broadcast (ipv6) fails, retry with broadcast ipv4. -...
Wilfried Goesgens [Sat, 16 Feb 2013 13:09:01 +0000 (14:09 +0100)]
When trying to bind default broadcast (ipv6) fails, retry with broadcast ipv4. - set trigger.

9 years agoWhen trying to bind default broadcast (ipv6) fails, retry with broadcast ipv4.
Wilfried Goesgens [Sat, 16 Feb 2013 13:05:30 +0000 (14:05 +0100)]
When trying to bind default broadcast (ipv6) fails, retry with broadcast ipv4.

9 years agofree static stuff on shutdown.
Wilfried Goesgens [Tue, 12 Feb 2013 22:20:03 +0000 (23:20 +0100)]
free static stuff on shutdown.

9 years agoContext: void* is more appropriate for the module data pointer than char*
Wilfried Goesgens [Tue, 12 Feb 2013 21:48:58 +0000 (22:48 +0100)]
Context: void* is more appropriate for the module data pointer than char*

9 years agoFinalize simplification of module detection.
Wilfried Goesgens [Tue, 12 Feb 2013 21:48:19 +0000 (22:48 +0100)]
Finalize simplification of module detection.

9 years agoMODULES: simplify scan script; add missing entry point.
Wilfried Goesgens [Tue, 12 Feb 2013 21:00:27 +0000 (22:00 +0100)]
MODULES: simplify scan script; add missing entry point.

9 years agostyle: modules mustn't have braces in the line.
Wilfried Goesgens [Tue, 12 Feb 2013 20:33:08 +0000 (21:33 +0100)]
style: modules mustn't have braces in the line.

9 years agofix warning of scan-build; it doesn't see we would exit() before.
Wilfried Goesgens [Sun, 10 Feb 2013 19:08:18 +0000 (20:08 +0100)]
fix warning of scan-build; it doesn't see we would exit() before.

9 years agofix typo
Wilfried Goesgens [Sun, 10 Feb 2013 15:19:37 +0000 (16:19 +0100)]
fix typo

9 years agoMD5: fix wrong memset
Wilfried Goesgens [Sun, 10 Feb 2013 15:10:37 +0000 (16:10 +0100)]
MD5: fix wrong memset

9 years agoRNCFG: add forward declaration missing in last commit.
Wilfried Goesgens [Sun, 10 Feb 2013 15:10:00 +0000 (16:10 +0100)]
RNCFG: add forward declaration missing in last commit.

9 years agoRNCFG: if we are going to overwrite the contents of a pointer, free these contents.
Wilfried Goesgens [Sun, 10 Feb 2013 15:08:55 +0000 (16:08 +0100)]
RNCFG: if we are going to overwrite the contents of a pointer, free these contents.

9 years agoVCard: this bitflag is supposed to be used with & not &&; add CCC for speed.
Wilfried Goesgens [Sun, 10 Feb 2013 15:02:59 +0000 (16:02 +0100)]
VCard: this bitflag is supposed to be used with & not &&; add CCC for speed.

9 years agoAccording to clang -Wcast-align its not good to cast from char* to some structs;...
Wilfried Goesgens [Sun, 10 Feb 2013 14:46:00 +0000 (15:46 +0100)]
According to clang -Wcast-align its not good to cast from char* to some structs; Since the session is used a void pointer is a better choice here anyways.

9 years agoRNCFG: fix room access check function for posters; this was still using an old method.
Wilfried Goesgens [Sat, 9 Feb 2013 14:38:27 +0000 (15:38 +0100)]
RNCFG: fix room access check function for posters; this was still using an old method.

9 years agoSMTP-QUEUE: silence warning
Wilfried Goesgens [Sat, 9 Feb 2013 14:28:15 +0000 (15:28 +0100)]
SMTP-QUEUE: silence warning

9 years agoNETCFG: check for nullpointer. tnx bzed for the scan service.
Wilfried Goesgens [Sat, 9 Feb 2013 14:23:52 +0000 (15:23 +0100)]
NETCFG: check for nullpointer. tnx bzed for the scan service.

9 years agoNWC: fix format string for loff_t which is longlog on 32 bit
Wilfried Goesgens [Sat, 9 Feb 2013 13:05:45 +0000 (14:05 +0100)]
NWC: fix format string for loff_t which is longlog on 32 bit

9 years agoNETCFG: fix specifying the remote room to IGNET share.
Wilfried Goesgens [Sat, 9 Feb 2013 12:25:00 +0000 (13:25 +0100)]
NETCFG: fix specifying the remote room to IGNET share.

9 years agoDB: more backtraces in case of errors
Wilfried Goesgens [Sat, 9 Feb 2013 12:24:44 +0000 (13:24 +0100)]
DB: more backtraces in case of errors

9 years agoSYSLOG: more places to correct the loglevel parameters.
Wilfried Goesgens [Tue, 5 Feb 2013 23:48:58 +0000 (00:48 +0100)]
SYSLOG: more places to correct the loglevel parameters.

9 years agoSyslog: adjust loglevels to sane values.
Wilfried Goesgens [Tue, 5 Feb 2013 22:32:14 +0000 (23:32 +0100)]
Syslog: adjust loglevels to sane values.

 - by Benjamin Bochmann

9 years agoSession Cleanup: init timestamp properly.
Wilfried Goesgens [Tue, 5 Feb 2013 22:25:11 +0000 (23:25 +0100)]
Session Cleanup: init timestamp properly.

9 years agoRNCFG: reduce the work needed to be done during the active rncfg lock
Wilfried Goesgens [Tue, 5 Feb 2013 22:23:06 +0000 (23:23 +0100)]
RNCFG: reduce the work needed to be done during the active rncfg lock

9 years agoNETSPOOL: combine collecting of email recipients into one function; participates...
Wilfried Goesgens [Sat, 2 Feb 2013 12:33:01 +0000 (13:33 +0100)]
NETSPOOL: combine collecting of email recipients into one function; participates also.

9 years agoNETSPOOL: combine collecting of email recipients into one function.
Wilfried Goesgens [Sat, 2 Feb 2013 12:19:36 +0000 (13:19 +0100)]
NETSPOOL: combine collecting of email recipients into one function.

9 years agoMerge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel
Wilfried Goesgens [Tue, 29 Jan 2013 23:24:21 +0000 (00:24 +0100)]
Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel

9 years agoCONTEXT: add interlock with cleanup / attaching of sessions.
Wilfried Goesgens [Tue, 29 Jan 2013 23:23:29 +0000 (00:23 +0100)]
CONTEXT: add interlock with cleanup / attaching of sessions.

9 years agoICAL: add debug code to edit messages
Wilfried Goesgens [Tue, 29 Jan 2013 23:21:53 +0000 (00:21 +0100)]
ICAL: add debug code to edit messages

9 years agoNETSPOOL: enable sending to mailinglists
Wilfried Goesgens [Tue, 29 Jan 2013 23:19:37 +0000 (00:19 +0100)]
NETSPOOL: enable sending to mailinglists

9 years agoMSG: fix size to copy for message copying
Wilfried Goesgens [Tue, 29 Jan 2013 23:19:06 +0000 (00:19 +0100)]
MSG: fix size to copy for message copying

9 years agoNETCFG: finalize & verify listsubscription interface.
Wilfried Goesgens [Tue, 29 Jan 2013 22:16:12 +0000 (23:16 +0100)]
NETCFG: finalize & verify listsubscription interface.

9 years agoNETWORKER: fix memleak.
Wilfried Goesgens [Tue, 29 Jan 2013 22:15:53 +0000 (23:15 +0100)]
NETWORKER: fix memleak.

9 years agoNETCFG: fix leaks & oddities
Wilfried Goesgens [Sun, 27 Jan 2013 09:32:51 +0000 (10:32 +0100)]
NETCFG: fix leaks & oddities

9 years agoNETCFG: migrate list subscription to the new room facility
Wilfried Goesgens [Sat, 26 Jan 2013 19:02:27 +0000 (20:02 +0100)]
NETCFG: migrate list subscription to the new room facility

9 years agoNETCFG: set the right file permissions so its not world writeable.
Wilfried Goesgens [Sat, 26 Jan 2013 18:59:29 +0000 (19:59 +0100)]
NETCFG: set the right file permissions so its not world writeable.

9 years agomake it const, baby.
Wilfried Goesgens [Sat, 26 Jan 2013 18:06:05 +0000 (19:06 +0100)]
make it const, baby.

9 years agoRNCFG: fix destructing, implement reloading on SNET
Wilfried Goesgens [Tue, 22 Jan 2013 22:45:11 +0000 (23:45 +0100)]
RNCFG: fix destructing, implement reloading on SNET

9 years agoNETCFG: save messages if changed.
Wilfried Goesgens [Mon, 21 Jan 2013 23:51:01 +0000 (00:51 +0100)]
NETCFG: save messages if changed.

9 years agoMSG: fix duplication of messages.
Wilfried Goesgens [Sun, 20 Jan 2013 19:12:42 +0000 (20:12 +0100)]
MSG: fix duplication of messages.

9 years agoNETSPOOL: move spool types into their own function.
Wilfried Goesgens [Sun, 20 Jan 2013 16:11:22 +0000 (17:11 +0100)]
NETSPOOL: move spool types into their own function.