citadel
23 months agoIn the text client - fixed the logic for determining whether to display the email...
Art Cancro [Thu, 10 Dec 2020 04:22:21 +0000 (23:22 -0500)]
In the text client - fixed the logic for determining whether to display the email address of a message author next to their display name.  Since we ALWAYS include at least a UPN now, we were getting superfluous displays of them.  Must fix the same thing in webcit next.

23 months agoUgh. The sloppiness of the code in the text client really reflects how bad I was...
Art Cancro [Thu, 10 Dec 2020 03:59:46 +0000 (22:59 -0500)]
Ugh.  The sloppiness of the code in the text client really reflects how bad I was at this 30+ years ago.

23 months agoMerge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel
Art Cancro [Sun, 6 Dec 2020 20:27:01 +0000 (15:27 -0500)]
Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel

23 months agofix to auto generated messages from inbox handler
Art Cancro [Sun, 6 Dec 2020 20:26:58 +0000 (15:26 -0500)]
fix to auto generated messages from inbox handler

23 months agoRemoved extra references to thread keys that are not extern
Art Cancro [Sun, 6 Dec 2020 20:24:24 +0000 (15:24 -0500)]
Removed extra references to thread keys that are not extern

2 years agoinput type="date" here will allow datepicker.js to be eliminated
root [Wed, 2 Dec 2020 14:36:26 +0000 (09:36 -0500)]
input type="date" here will allow datepicker.js to be eliminated
and should fall back to type="text" in the few remaining browsers
that don't support it.

2 years agoWhen comparing the sender, compare both the name and address.
Art Cancro [Sun, 29 Nov 2020 00:24:28 +0000 (19:24 -0500)]
When comparing the sender, compare both the name and address.

2 years agoJust a little bit less debug logging
Art Cancro [Sat, 28 Nov 2020 22:58:10 +0000 (17:58 -0500)]
Just a little bit less debug logging

2 years agoSend a hash of an auto-response to the use table. This keeps us from spamming the...
Art Cancro [Sat, 28 Nov 2020 19:04:46 +0000 (14:04 -0500)]
Send a hash of an auto-response to the use table.  This keeps us from spamming the same correspondent with an auto-reply over and over.

2 years agoImplemented the 'vacation' action
Art Cancro [Sat, 28 Nov 2020 18:19:00 +0000 (13:19 -0500)]
Implemented the 'vacation' action

2 years agoRecord the 'last message processed' in the user record instead of in the inbox config...
Art Cancro [Sat, 28 Nov 2020 17:30:26 +0000 (12:30 -0500)]
Record the 'last message processed' in the user record instead of in the inbox config message.  This eliminates any need to rewrite the config

2 years agoNew field in user record "lastproc_inboxrules" which keeps track of the most recent...
Art Cancro [Sat, 28 Nov 2020 15:40:13 +0000 (10:40 -0500)]
New field in user record "lastproc_inboxrules" which keeps track of the most recent message processed by the inbox rules filter, since we're now going to make the ruleset something that is only written to when the user changes it.

2 years agoRemoved unused RSEN server command
Art Cancro [Sat, 28 Nov 2020 14:57:45 +0000 (09:57 -0500)]
Removed unused RSEN server command

2 years agoThis may be the completion of the rewrite bits. Need to test more.
Art Cancro [Fri, 27 Nov 2020 04:39:31 +0000 (23:39 -0500)]
This may be the completion of the rewrite bits.  Need to test more.

2 years agoinbox_do_reject() does not need to return a value, the message is always deleted
Art Cancro [Wed, 25 Nov 2020 22:01:08 +0000 (17:01 -0500)]
inbox_do_reject() does not need to return a value, the message is always deleted

2 years agocompleted the 'redirect' action
Art Cancro [Tue, 24 Nov 2020 16:13:26 +0000 (11:13 -0500)]
completed the 'redirect' action

2 years agoThere is no tabs vs. spaces debate. There are only tab users and communists.
Art Cancro [Mon, 23 Nov 2020 04:04:10 +0000 (23:04 -0500)]
There is no tabs vs. spaces debate.  There are only tab users and communists.

2 years agoCompleted the 'fileinto' action
Art Cancro [Mon, 23 Nov 2020 03:50:56 +0000 (22:50 -0500)]
Completed the 'fileinto' action

2 years agoAction functions will return a keep or delete instruction
Art Cancro [Sun, 22 Nov 2020 22:15:02 +0000 (17:15 -0500)]
Action functions will return a keep or delete instruction

2 years agoWhen appropriate, delete the message from the inbox after processing rules.
Art Cancro [Sun, 22 Nov 2020 21:59:52 +0000 (16:59 -0500)]
When appropriate, delete the message from the inbox after processing rules.

2 years agomeaningless shuffle of parentheses
Art Cancro [Sun, 22 Nov 2020 19:56:53 +0000 (14:56 -0500)]
meaningless shuffle of parentheses

2 years agoDecided not to attempt normalizing the parameters to action functions
Art Cancro [Sun, 22 Nov 2020 06:28:30 +0000 (01:28 -0500)]
Decided not to attempt normalizing the parameters to action functions

2 years agoCompleted the code for the 'reject' action
Art Cancro [Sun, 22 Nov 2020 05:32:02 +0000 (00:32 -0500)]
Completed the code for the 'reject' action

2 years agoImplemented keep_message flag to determine whether to keep or delete the copy of...
Art Cancro [Sat, 21 Nov 2020 20:14:04 +0000 (15:14 -0500)]
Implemented keep_message flag to determine whether to keep or delete the copy of a message that is still in the inbox after rules processing

2 years agofleshed out the actions in pseudocode
Art Cancro [Fri, 20 Nov 2020 05:32:25 +0000 (00:32 -0500)]
fleshed out the actions in pseudocode

2 years agoImplemented the 'stop' final action
Art Cancro [Fri, 20 Nov 2020 05:20:24 +0000 (00:20 -0500)]
Implemented the 'stop' final action

2 years agoField comparison code is functionally complete
Art Cancro [Thu, 19 Nov 2020 14:12:56 +0000 (09:12 -0500)]
Field comparison code is functionally complete

2 years agofilled out some of the field comparison code
Art Cancro [Mon, 16 Nov 2020 02:57:39 +0000 (21:57 -0500)]
filled out some of the field comparison code

2 years agoFixed an edge case that could crash the server from a malformed message
Art Cancro [Sun, 15 Nov 2020 23:58:54 +0000 (18:58 -0500)]
Fixed an edge case that could crash the server from a malformed message

2 years agomsgbase.c: some of the field conversion buffer fields were too small, increased them...
Art Cancro [Sun, 15 Nov 2020 21:32:56 +0000 (16:32 -0500)]
msgbase.c: some of the field conversion buffer fields were too small, increased them from 100 bytes to 1024 bytes to handle messages converted from RFC822 or RSS.

2 years agoserv_rssclient.c: RFC2047-encode fields where needed
Art Cancro [Sun, 15 Nov 2020 21:11:15 +0000 (16:11 -0500)]
serv_rssclient.c: RFC2047-encode fields where needed

2 years agoMake use of the functionality provided in the preceding commit
Art Cancro [Tue, 10 Nov 2020 05:45:47 +0000 (00:45 -0500)]
Make use of the functionality provided in the preceding commit

2 years agoCM_SetField() and CM_SetAsField() now accept -1 as a length to have the function...
Art Cancro [Tue, 10 Nov 2020 05:39:36 +0000 (00:39 -0500)]
CM_SetField() and CM_SetAsField() now accept -1 as a length to have the function measure the field for the caller.

2 years agowar on BSD style curly braces
Art Cancro [Tue, 27 Oct 2020 23:32:16 +0000 (19:32 -0400)]
war on BSD style curly braces

2 years agoRemoved BSD style curly braces from serv_expire.c and database.c ... Warren embarrass...
Art Cancro [Wed, 21 Oct 2020 02:17:26 +0000 (22:17 -0400)]
Removed BSD style curly braces from serv_expire.c and database.c ... Warren embarrassed me into doing it

2 years agomore inbox filter testing, and yes the build is still broken
Art Cancro [Wed, 21 Oct 2020 02:12:16 +0000 (22:12 -0400)]
more inbox filter testing, and yes the build is still broken

2 years agomore work on the inboxrules module. don't run this in production. it isn't finished.
Art Cancro [Sun, 4 Oct 2020 02:33:19 +0000 (22:33 -0400)]
more work on the inboxrules module.  don't run this in production.  it isn't finished.

2 years agoMore chiseling away at the replacement inbox filter.
Art Cancro [Sun, 23 Aug 2020 18:34:24 +0000 (14:34 -0400)]
More chiseling away at the replacement inbox filter.

2 years agoRemoved support for 'before read hooks' because there is no such thing.
Art Cancro [Sun, 9 Aug 2020 20:48:18 +0000 (16:48 -0400)]
Removed support for 'before read hooks' because there is no such thing.

2 years agominor formatting
Art Cancro [Sun, 9 Aug 2020 19:52:17 +0000 (15:52 -0400)]
minor formatting

2 years agoRichard Stallman is a pinko commie bastard.
Art Cancro [Mon, 27 Jul 2020 00:39:04 +0000 (20:39 -0400)]
Richard Stallman is a pinko commie bastard.

2 years agoNext step for inbox rules processing: retrieve each message in the room using a CtdlF...
Art Cancro [Sat, 25 Jul 2020 20:49:32 +0000 (16:49 -0400)]
Next step for inbox rules processing: retrieve each message in the room using a CtdlForEachMessage() callback with the MSGS_GT operator for maximum allowance of the API to do the hard part instead of writing the comparison code ourselves.  Really, that work was already done, so why do it again?  Duplication of effort is necessary.  For that matter, why does Google insist on maintaining their own email and forums software when they could just use Citadel?  Citadel is way better than anything Google or Microsoft have ever produced.  And don't get me started about Facebook.  Facebook is the absolute worst thing to ever happen to the universe and it should be shut down.

2 years agook, we're actually at the point now where we can fetch some inbox messages and proces...
Art Cancro [Thu, 23 Jul 2020 17:52:30 +0000 (13:52 -0400)]
ok, we're actually at the point now where we can fetch some inbox messages and process them.

2 years agoshift around the order of the functions because we're going to remove some duplicated...
Art Cancro [Thu, 23 Jul 2020 17:39:11 +0000 (13:39 -0400)]
shift around the order of the functions because we're going to remove some duplicated effort

2 years agowork on serialization schtuffs
Art Cancro [Wed, 22 Jul 2020 03:37:10 +0000 (23:37 -0400)]
work on serialization schtuffs

2 years agoPlease substitute this comment with whatever you feel like reading right now.
Art Cancro [Fri, 17 Jul 2020 21:06:54 +0000 (17:06 -0400)]
Please substitute this comment with whatever you feel like reading right now.

2 years agoHandling is now to the point where user accounts requiring potential inbox processing...
Art Cancro [Thu, 16 Jul 2020 22:03:49 +0000 (18:03 -0400)]
Handling is now to the point where user accounts requiring potential inbox processing are brought to the handler's attention.

2 years agomodule 'sieve' is renamed to 'inboxrules'
Art Cancro [Thu, 16 Jul 2020 21:12:17 +0000 (17:12 -0400)]
module 'sieve' is renamed to 'inboxrules'

2 years agoit now builds but does not do inbox filtering
Art Cancro [Thu, 16 Jul 2020 20:53:15 +0000 (16:53 -0400)]
it now builds but does not do inbox filtering

2 years agoMerge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel
Art Cancro [Sat, 11 Jul 2020 22:33:31 +0000 (18:33 -0400)]
Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel

2 years agoRemove managesieve framework because we are removing sieve
Art Cancro [Sat, 11 Jul 2020 22:33:22 +0000 (18:33 -0400)]
Remove managesieve framework because we are removing sieve

2 years agoRemoved all mail filtering options except the rules editor in WebCit
Art Cancro [Sat, 11 Jul 2020 21:55:49 +0000 (17:55 -0400)]
Removed all mail filtering options except the rules editor in WebCit

2 years agoZZMerge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel
Art Cancro [Mon, 6 Jul 2020 02:13:46 +0000 (22:13 -0400)]
ZZMerge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel

2 years agoWhen editing a vCard, suppress the email fields from being displayed when editing...
Art Cancro [Mon, 6 Jul 2020 02:13:28 +0000 (22:13 -0400)]
When editing a vCard, suppress the email fields from being displayed when editing an account's vCard

2 years agoCode cleanup. Added template conditional for suppressing email fields in a vcard...
Art Cancro [Sun, 5 Jul 2020 21:56:39 +0000 (17:56 -0400)]
Code cleanup.  Added template conditional for suppressing email fields in a vcard edit.

2 years agoRemoved some leftover dependencies on message fields which no longer exist
Art Cancro [Sun, 5 Jul 2020 15:52:51 +0000 (11:52 -0400)]
Removed some leftover dependencies on message fields which no longer exist

2 years agoFixed a bug in username key usage that was causing email aliases to disappear
Art Cancro [Wed, 8 Apr 2020 21:35:15 +0000 (17:35 -0400)]
Fixed a bug in username key usage that was causing email aliases to disappear

2 years ago'Network User' is now 'Normal User'
Art Cancro [Mon, 6 Apr 2020 17:10:57 +0000 (13:10 -0400)]
'Network User' is now 'Normal User'

2 years agocleaned up some spacing while admiring how clean this code is
Art Cancro [Tue, 7 Jan 2020 05:15:31 +0000 (00:15 -0500)]
cleaned up some spacing while admiring how clean this code is

2 years agoShamlessly slapped a 2020 copyright date on all startup banners.
Art Cancro [Wed, 1 Jan 2020 20:34:18 +0000 (15:34 -0500)]
Shamlessly slapped a 2020 copyright date on all startup banners.

2 years agoApplied patch sent by Vijay Kumar to correct SMTP dot de-stuffing
Art Cancro [Sat, 7 Dec 2019 06:08:04 +0000 (01:08 -0500)]
Applied patch sent by Vijay Kumar to correct SMTP dot de-stuffing

2 years agoSuppress output of inline HTML styles when converting to plain text
Art Cancro [Sat, 7 Dec 2019 03:10:31 +0000 (22:10 -0500)]
Suppress output of inline HTML styles when converting to plain text

3 years agoThe user principal identity is now used as the JID in all XMPP protocol stanzas.
Art Cancro [Mon, 25 Nov 2019 04:45:05 +0000 (23:45 -0500)]
The user principal identity is now used as the JID in all XMPP protocol stanzas.

3 years agoplaying around with readline
Art Cancro [Sat, 16 Nov 2019 22:44:03 +0000 (17:44 -0500)]
playing around with readline

3 years agodo nothing with blank lines, exit on EOF
Art Cancro [Wed, 30 Oct 2019 19:27:29 +0000 (15:27 -0400)]
do nothing with blank lines, exit on EOF

3 years agodo nothing with blank lines, exit on EOF
Art Cancro [Wed, 30 Oct 2019 19:26:05 +0000 (15:26 -0400)]
do nothing with blank lines, exit on EOF

3 years agomoving towards the new autocompleter
Art Cancro [Wed, 30 Oct 2019 16:25:10 +0000 (12:25 -0400)]
moving towards the new autocompleter

3 years agoReal zombies are undead, not the kind you see on TV.
Art Cancro [Wed, 30 Oct 2019 01:08:00 +0000 (21:08 -0400)]
Real zombies are undead, not the kind you see on TV.

3 years agoOn the first run of the server on an empty database, create a default administrator...
Art Cancro [Mon, 21 Oct 2019 18:38:13 +0000 (14:38 -0400)]
On the first run of the server on an empty database, create a default administrator account.  This should eliminate the need to run setup on most systems.

3 years agocosmetic cleanup to serv_virus.c
Art Cancro [Mon, 21 Oct 2019 18:17:07 +0000 (14:17 -0400)]
cosmetic cleanup to serv_virus.c

3 years agofix_other_mtas() is old news
Art Cancro [Mon, 21 Oct 2019 18:13:42 +0000 (14:13 -0400)]
fix_other_mtas() is old news

3 years agoRemoved the fixnss() step from setup. I don't think it's needed anymore. Moving...
Art Cancro [Mon, 21 Oct 2019 18:07:56 +0000 (14:07 -0400)]
Removed the fixnss() step from setup.  I don't think it's needed anymore.  Moving towards eliminating setup entirely.

3 years agoForEachUser() linked list , keep track of last item so we don't have to traverse...
Art Cancro [Sat, 28 Sep 2019 20:54:46 +0000 (16:54 -0400)]
ForEachUser() linked list , keep track of last item so we don't have to traverse backwards

3 years agoForEachUser() now uses a linked list
Art Cancro [Sat, 28 Sep 2019 20:03:37 +0000 (16:03 -0400)]
ForEachUser() now uses a linked list

3 years agoThe index key for user records now omits non-alphanumeric characters, in addition...
Art Cancro [Wed, 25 Sep 2019 13:49:27 +0000 (09:49 -0400)]
The index key for user records now omits non-alphanumeric characters, in addition to the previous behavior of converting to lower case.

3 years agoRemoved md5.c and md5.h because the APOP implementation which used it is no longer...
Art Cancro [Thu, 12 Sep 2019 17:45:36 +0000 (13:45 -0400)]
Removed md5.c and md5.h because the APOP implementation which used it is no longer part of Citadel Server

3 years agocleanup
Art Cancro [Thu, 22 Aug 2019 03:08:24 +0000 (23:08 -0400)]
cleanup

3 years agoRemoved all of the SYS_ user contexts, they aren't needed anymore
Art Cancro [Wed, 21 Aug 2019 21:42:00 +0000 (17:42 -0400)]
Removed all of the SYS_ user contexts, they aren't needed anymore

3 years agoRemoved a lot of legacy cruft out of the setup utility. Eventually I want to remove...
Art Cancro [Wed, 21 Aug 2019 20:38:07 +0000 (16:38 -0400)]
Removed a lot of legacy cruft out of the setup utility.  Eventually I want to remove this utility entirely.

3 years agothere it is ... found a stray endif
Art Cancro [Wed, 21 Aug 2019 18:18:23 +0000 (14:18 -0400)]
there it is ... found a stray endif

3 years agoMark Zuckerberg is the Hitler of our era
Art Cancro [Wed, 21 Aug 2019 18:01:49 +0000 (14:01 -0400)]
Mark Zuckerberg is the Hitler of our era

3 years agooops
Art Cancro [Wed, 21 Aug 2019 00:12:04 +0000 (20:12 -0400)]
oops

3 years agoMerge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel
Art Cancro [Tue, 20 Aug 2019 20:34:00 +0000 (16:34 -0400)]
Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel

3 years agominor changes
Art Cancro [Tue, 20 Aug 2019 20:33:48 +0000 (16:33 -0400)]
minor changes

3 years agoctdl_tcp_server and ctdl_uds_server improved handling of error
Art Cancro [Mon, 19 Aug 2019 19:12:50 +0000 (19:12 +0000)]
ctdl_tcp_server and ctdl_uds_server improved handling of error
conditions in places like getprotobyname() which normally never throw an
error, but in container universe it's a new game.

3 years agoreversed previous change
Art Cancro [Sun, 18 Aug 2019 23:14:32 +0000 (19:14 -0400)]
reversed previous change

3 years agotesting AC_SEARCH_LIBS(gettext, intl libintl)
Art Cancro [Sun, 18 Aug 2019 23:09:19 +0000 (19:09 -0400)]
testing AC_SEARCH_LIBS(gettext, intl libintl)

3 years agoServer restart via command no longer requires running as a daemon , uses execv()...
Art Cancro [Tue, 13 Aug 2019 20:27:13 +0000 (16:27 -0400)]
Server restart via command no longer requires running as a daemon , uses execv() to restart.

3 years agoServer restart via command no longer requires running as a daemon , uses execv()...
Art Cancro [Tue, 13 Aug 2019 20:16:17 +0000 (16:16 -0400)]
Server restart via command no longer requires running as a daemon , uses execv() to restart.

3 years agoInitialize TSD key earlier in the startup process. Newer Linux/Linux distributions...
Art Cancro [Tue, 13 Aug 2019 18:37:14 +0000 (14:37 -0400)]
Initialize TSD key earlier in the startup process.  Newer Linux/Linux distributions were beginning to crash on an uninitialized key.

3 years agoPeople who disagree with me are always wrong and need to die.
Art Cancro [Wed, 7 Aug 2019 15:12:40 +0000 (11:12 -0400)]
People who disagree with me are always wrong and need to die.

3 years agoModified the behavior of ForEachUser() to do the two phase load/perform cycle
Art Cancro [Mon, 5 Aug 2019 02:44:34 +0000 (22:44 -0400)]
Modified the behavior of ForEachUser() to do the two phase load/perform cycle
as part of the function, since so many callbacks were implementing this anyway.

3 years agoRenamed cutuserkey() to cutusername(). Function has nothing to do with keys.
Art Cancro [Tue, 30 Jul 2019 13:40:51 +0000 (09:40 -0400)]
Renamed cutuserkey() to cutusername().  Function has nothing to do with keys.

3 years agoAdded header to user_ops.h
Art Cancro [Mon, 29 Jul 2019 20:25:27 +0000 (16:25 -0400)]
Added header to user_ops.h

3 years agoMoved makeuserkey() and cutuserkey() from user_ops.h to user_ops.c
Art Cancro [Mon, 29 Jul 2019 20:16:55 +0000 (16:16 -0400)]
Moved makeuserkey() and cutuserkey() from user_ops.h to user_ops.c

3 years agoRemoving things that depend on sysvinit. It's a systemd world now.
Art Cancro [Thu, 18 Jul 2019 18:45:52 +0000 (14:45 -0400)]
Removing things that depend on sysvinit.  It's a systemd world now.

3 years ago<E>nter-message command in the text client now warns the user that this creates a...
Art Cancro [Thu, 4 Jul 2019 20:09:40 +0000 (16:09 -0400)]
<E>nter-message command in the text client now warns the user that this creates a top level blog post instead of a comment.

3 years agoAccept the origin host as indicated by the client, if the connection is from 127...
Art Cancro [Wed, 19 Jun 2019 18:38:13 +0000 (14:38 -0400)]
Accept the origin host as indicated by the client, if the connection is from 127.0.0.1 or ::1 (or on a local socket, as before)

3 years agoOrthodontic adjustments (moved some braces around)
Art Cancro [Wed, 19 Jun 2019 18:23:54 +0000 (14:23 -0400)]
Orthodontic adjustments (moved some braces around)

3 years agoungoto/skip/goto ui taking shape...
Art Cancro [Sun, 28 Apr 2019 22:12:16 +0000 (18:12 -0400)]
ungoto/skip/goto ui taking shape...