Art Cancro [Mon, 7 Apr 2008 04:01:04 +0000 (04:01 +0000)]
Removed the 'Gateway Domain' function from the entire Citadel system. This function has long since been superseded by the Global Address Book. Absolutely no one is using it. In fact, as far as I can tell, its implementation does not even exist anymore -- I couldn't find the back end code to remove. So instead of confusing site administrators with a superfluous configuration option, we are removing it.
Dave West [Sun, 6 Apr 2008 21:14:34 +0000 (21:14 +0000)]
Give the user contained within masterCC a name.
Its not a real user but it is stored in the DB and does contain info
like how many messages the system has created.
We call it Citadel.
This make "citadel" an illegal user name.
Now this user has a name we need to make sure the auto purger doesn't
purge it and make sure no one can login by that name.
Dave West [Sat, 5 Apr 2008 21:40:46 +0000 (21:40 +0000)]
Added some CtdlThreadCheckStop() calls to exit rbl checks and stop the
SMTP negotiation if we are shutting down.
Also added a bit of code to log the time it takes to do an RBL check. If
it takes a long time maybe we can cache the results in a hash with
something like a 30 second life span.
Dave West [Sat, 5 Apr 2008 19:51:53 +0000 (19:51 +0000)]
Quieten the user 0 message to the Aide room.
User 0 is created as a side effect of the system posting messages from
the masterCC. This side effect has the benefit of recording the number
of messages the system has generated.
Should we make use of this somewhere?
The actual code that creates the user 0 is in CtdlSubmitMsg() and reads
as
/* Bump this user's messages posted counter. */
CtdlLogPrintf(CTDL_DEBUG, "Updating user\n");
lgetuser(&CCC->user, CCC->curr_user);
CCC->user.posted = CCC->user.posted + 1;
lputuser(&CCC->user);
* we have now several bstrs:
* bstr: simply gives the string
* xbstr: gives string and its length
* lbstr: gives the long value of the item
* ibstr: gives the int value of the item
* havebstr: whether this bstr and if it wasn't set empty
* yesbstr: returns true if the value equals "yes"
there also is a CAPITAL version of each, for dynamicaly calculated keys.
* replaced all atol(bstr()), strcmp(bstr(), "yes") IsEmptyStr(bstr()) by the above.
* moved url argument list to hash.
* carry length of parameter value in the hash for later use
* added Bstr, BSTR and bstr. bstr mustn't be used for dynamic keys, use BSTR instead.
* use BSTR where apropriate.
* fixed crash condition with message posting Mrs. Foobar found out
Dave West [Sat, 29 Mar 2008 01:15:32 +0000 (01:15 +0000)]
Fix up ARTV import so that imports actually work.
Fixed various client_getln loops so that they don't go endless if the
client disappears.
ARTV import now makes use of the internal base64 decoder so it should be
quicker.
ARTV import now sends lots of dots to the client. This is to kick the
watchdog timer in sendcommand so that it doesn't expire while we process
a big message.
Changes in threads.* are in preperation for cancelling threads and using
signals to interrupt threads. They are #ifdef excluded.
Dave West [Fri, 28 Mar 2008 13:03:37 +0000 (13:03 +0000)]
Fix the artv import.
It couldn't handle the blank lines between sections and now it does.
Also added code to send dots during the room import to keep the user
informed that something is happening if we are importing a BIG room.
This has the added advantage of kicking the watchdog in sendcommand so
it doesn't time out unexpectedly.
Also added code to exit the artv early if we are shutting down.
Dave West [Fri, 28 Mar 2008 12:59:05 +0000 (12:59 +0000)]
On my slow system a watch dog time out of 5 seconds is not always
enough.
I added a command line arg to increase it if needed.
Watchdog defaults to 5 seconds but you can use -w to extend it if you
need to.
Dave West [Thu, 20 Mar 2008 15:39:58 +0000 (15:39 +0000)]
A test fix for the thread cancellation routine.
We only log situations where we would have cancelled a thread, we don't
actually cancel them.
With this code we should not see cancellation requests during normal
running.
Cancelation requests during normal running were due to threads being
asked to stop when load decreased but the idle thread detection aloud a
thread to be asked to stop just as select gave it a task and made it not
idle.
Now if select gives a thread a job to do and the thread was asked to
stop during the select the thread changes its state back to running and
refuses the stop request. This only happens if the system is NOT
shutting down.
Art Cancro [Wed, 19 Mar 2008 19:28:48 +0000 (19:28 +0000)]
EVT_LOGOUT hooks are now called with the thread's current
CitContext set to that of the session being logged out, even when
killing a session administratively. This allows the identity of the
user to be passed along to module hooks. This fixes the problem in
the Jabber server where buddy 'ghosts' whould remain visible to
clients if the user disconnected without logging off.
Dave West [Tue, 18 Mar 2008 23:28:55 +0000 (23:28 +0000)]
When doing shutdown we allow each thread up to 5 seconds to exit on its
own after asking it nicely to do so. After 5 seconds we will cancel()
the thread. Its possible that we may loose messages in this manner
since its similar to a SIGTERM. Because of this we write messages to the
log about this event. If we are seeing these entries in the log we need
to track down why the thread is strugling to exit and fix it.
Dave West [Tue, 18 Mar 2008 19:58:41 +0000 (19:58 +0000)]
Ignet now makes use of CtdlThreadCheckStop() to check if it should exit.
This should improve shutdown times.
Still need to be able to interrupt the syscalls for a full solution.
Art Cancro [Tue, 18 Mar 2008 19:15:08 +0000 (19:15 +0000)]
libical, expat, and libsieve are now *required*.
If any are missing, configure will abort, telling the user what is missing and
pointing them to the relevant page on our web site.
Dave West [Mon, 17 Mar 2008 23:35:42 +0000 (23:35 +0000)]
Re-ordered the sequence of checking email addresses against valid system
addresses. This allows us to have a GAB entry for rooms and allows
messages originating internally to be addressed to a room.
For the GAB lookup to work as expected the email address for the room
must be simply room_roomname without the @domain. If the domain part is
included the aliasing routines will translate it into the address of the
person who created the GAB entry.
This should fix bug #324.
Art Cancro [Mon, 17 Mar 2008 15:11:49 +0000 (15:11 +0000)]
When dumping or scanning the wholist in the Jabber
service, only pay attention to sessions that have users logged
in. Doing otherwise exposes empty JID's that cause clients to
malfunction.
* abstract #ifdef HAVE_ICONV around utf8ify_rfc822_string to one place as they started spreadding all over the place
* de-QP email-attachment filenames
* put icon/mime logic into the attachment list
* if we have an application/octet-stream, try to guess the mime for the icon by its extension
Art Cancro [Wed, 5 Mar 2008 04:14:14 +0000 (04:14 +0000)]
Backed out changes in r6088 of addressbook_popup.c
The list may have been nicely sorted, but selecting addresses from the list
causes the names to have escaped HTML characters in them.