From b01d557aca8d844a075d5047718cb610335d2e5d Mon Sep 17 00:00:00 2001
From: Art Cancro <ajc@citadel.org>
Date: Tue, 19 Sep 2023 16:02:38 -0400
Subject: [PATCH] view_mail.js: better display of attachment links; attachments
 are now working

Displaying each one as a link definitely makes it stand out from the message text.
Display the size of each attachment --   _(bytes) is already in the webcit-classic translations
Downloads are working, but the wrong file name is derived
---
 webcit-ng/server/webcit.h        | 1 +
 webcit-ng/static/js/view_mail.js | 7 ++++++-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/webcit-ng/server/webcit.h b/webcit-ng/server/webcit.h
index d06e3800c..1304100dd 100644
--- a/webcit-ng/server/webcit.h
+++ b/webcit-ng/server/webcit.h
@@ -23,6 +23,7 @@
 #include <sys/un.h>
 #include <sys/poll.h>
 #include <time.h>
+#include <sys/time.h>
 #include <string.h>
 #include <pwd.h>
 #include <errno.h>
diff --git a/webcit-ng/static/js/view_mail.js b/webcit-ng/static/js/view_mail.js
index a647ed0a3..0c7052cb7 100644
--- a/webcit-ng/static/js/view_mail.js
+++ b/webcit-ng/static/js/view_mail.js
@@ -216,7 +216,12 @@ function mail_render_one(msgnum, msg, target_div, include_controls) {
 						outmsg += "<ul>";
 					}
 					display_attachments += 1;
-					outmsg += "<li><i class=\"fa fa-paperclip\"></i>&nbsp;" + msg.part[r].partnum + ": " + msg.part[r].filename + "</li>";
+					outmsg += "<li>"
+						+ "<a href=\"/ctdl/r/" + escapeHTMLURI(current_room) + "/" + msgnum + "/" + msg.part[r].partnum + "\">"
+						+ "<i class=\"fa fa-paperclip\"></i>&nbsp;" + msg.part[r].partnum + ": " + msg.part[r].filename
+						+ " (" + msg.part[r].len + " " + _("bytes") + ")"
+						+ "</a>"
+						+ "</li>";
 				}
 			}
 			if (display_attachments > 0) {
-- 
2.39.2