]> code.citadel.org Git - citadel.git/blobdiff - citadel/citadel.c
*** empty log message ***
[citadel.git] / citadel / citadel.c
index 64649facedd77871228e5c44a89f31f0406a2509..a0457670ff7d9a2843353b8630fb416ed02a3eec 100644 (file)
@@ -30,8 +30,8 @@
 #include <sys/ioctl.h>
 #include <signal.h>
 #include <pwd.h>
-#include <setjmp.h>
 #include <stdarg.h>
+#include <errno.h>
 
 #include "citadel.h"
 #include "citadel_ipc.h"
 struct march *march = NULL;
 
 /* globals associated with the client program */
-char temp[PATH_MAX];           /* Name of general temp file */
-char temp2[PATH_MAX];          /* Name of general temp file */
-char tempdir[PATH_MAX];                /* Name of general temp dir */
-char editor_path[SIZ];         /* path to external editor */
+char temp[PATH_MAX];           /* Name of general-purpose temp file */
+char temp2[PATH_MAX];          /* Name of general-purpose temp file */
+char tempdir[PATH_MAX];                /* Name of general-purpose temp directory */
+char editor_paths[MAX_EDITORS][SIZ];   /* paths to external editors */
 char printcmd[SIZ];            /* print command */
 int editor_pid = (-1);
-char fullname[32];
-jmp_buf nextbuf;
+char fullname[USERNAME_SIZE];
 struct CtdlServInfo serv_info; /* Info on the server connected */
 int screenwidth;
 int screenheight;
@@ -90,7 +89,7 @@ long highest_msg_read;                /* used for <A>bandon room cmd */
 long maxmsgnum;                        /* used for <G>oto */
 char sigcaught = 0;
 char have_xterm = 0;           /* are we running on an xterm? */
-char rc_username[32];
+char rc_username[USERNAME_SIZE];
 char rc_password[32];
 char hostbuf[SIZ];
 char portbuf[SIZ];
@@ -113,25 +112,27 @@ CtdlIPC *ipc_for_signal_handlers; /* KLUDGE cover your eyes */
  */
 void logoff(CtdlIPC *ipc, int code)
 {
-    int lp;
+       int lp;
+
        if (editor_pid > 0) {   /* kill the editor if it's running */
                kill(editor_pid, SIGHUP);
        }
 
-    /* Free the ungoto list */
-    for (lp = 0; lp < uglistsize; lp++)
-      free (uglist[lp]);
+       /* Free the ungoto list */
+       for (lp = 0; lp < uglistsize; lp++) {
+               free(uglist[lp]);
+       }
 
-/* shut down the server... but not if the logoff code is 3, because
- * that means we're exiting because we already lost the server
+/* Shut down the server connection ... but not if the logoff code is 3,
+ * because that means we're exiting because we already lost the server.
  */
-       if (code != 3)
+       if (code != 3) {
                CtdlIPCQuit(ipc);
+       }
 
 /*
  * now clean up various things
  */
-
        screen_delete();
 
        unlink(temp);
@@ -174,8 +175,8 @@ void catch_sigcont(int signum)
 }
 
 
-
 /* general purpose routines */
+
 /* display a file */
 void formout(CtdlIPC *ipc, char *name)
 {
@@ -334,14 +335,14 @@ char *pop_march(int desired_floor)
  */
 void dotgoto(CtdlIPC *ipc, char *towhere, int display_name, int fromungoto)
 {
-       char aaa[SIZ], bbb[SIZ], psearch[SIZ];
+       char aaa[SIZ], bbb[SIZ];
        static long ls = 0L;
        int newmailcount = 0;
        int partial_match, best_match;
        char from_floor;
        int ugpos = uglistsize;
        int r;                          /* IPC result code */
-       struct ctdlipcroom *roomrec = NULL;
+       struct ctdlipcroom *room = NULL;
 
        /* store ungoto information */
        if (fromungoto == 0) {
@@ -354,8 +355,9 @@ void dotgoto(CtdlIPC *ipc, char *towhere, int display_name, int fromungoto)
                                uglistlsn[lp] = uglistlsn[lp+1];
                        }
                        ugpos--;
-               } else
+               } else {
                        uglistsize++;
+               }
         
                uglist[ugpos] = malloc(strlen(room_name)+1);
                strcpy(uglist[ugpos], room_name);
@@ -363,10 +365,10 @@ void dotgoto(CtdlIPC *ipc, char *towhere, int display_name, int fromungoto)
        }
       
        /* first try an exact match */
-       r = CtdlIPCGotoRoom(ipc, towhere, "", &roomrec, aaa);
+       r = CtdlIPCGotoRoom(ipc, towhere, "", &room, aaa);
        if (r / 10 == 54) {
                newprompt("Enter room password: ", bbb, 9);
-               r = CtdlIPCGotoRoom(ipc, towhere, bbb, &roomrec, aaa);
+               r = CtdlIPCGotoRoom(ipc, towhere, bbb, &room, aaa);
                if (r / 10 == 54) {
                        scr_printf("Wrong password.\n");
                        return;
@@ -380,45 +382,55 @@ void dotgoto(CtdlIPC *ipc, char *towhere, int display_name, int fromungoto)
         * has the highest-weighted match.
         */
        if (r / 100 != 2) {
+               struct march *march = NULL;
+
                best_match = 0;
                strcpy(bbb, "");
-               CtdlIPC_putline(ipc, "LKRA");
-               CtdlIPC_getline(ipc, aaa);
-               if (aaa[0] == '1')
-                       while (CtdlIPC_getline(ipc, aaa), strcmp(aaa, "000")) {
-                               extract(psearch, aaa, 0);
+
+               r = CtdlIPCKnownRooms(ipc, AllAccessibleRooms, AllFloors, &march, aaa);
+               if (r / 100 == 1) {
+                       /* Run the roomlist; free the data as we go */
+                       struct march *mp = march;       /* Current */
+
+                       while (mp) {
                                partial_match = 0;
-                               if (pattern(psearch, towhere) >= 0) {
+                               if (pattern(mp->march_name, towhere) >= 0) {
                                        partial_match = 1;
                                }
-                               if (!strncasecmp(towhere, psearch, strlen(towhere))) {
+                               if (!strncasecmp(mp->march_name, towhere, strlen(towhere))) {
                                        partial_match = 2;
                                }
                                if (partial_match > best_match) {
-                                       strcpy(bbb, psearch);
+                                       strcpy(bbb, mp->march_name);
                                        best_match = partial_match;
                                }
+                               /* Both pointers are NULL at end of list */
+                               march = mp->next;
+                               free(mp);
+                               mp = march;
                        }
+               }
+
                if (strlen(bbb) == 0) {
                        scr_printf("No room '%s'.\n", towhere);
                        return;
                }
-               roomrec = NULL;
-               r = CtdlIPCGotoRoom(ipc, bbb, "", &roomrec, aaa);
+               room = NULL;
+               r = CtdlIPCGotoRoom(ipc, bbb, "", &room, aaa);
        }
-       if (r / 100 != 2) {
+       if (r / 100 != 1 && r / 100 != 2) {
                scr_printf("%s\n", aaa);
                return;
        }
-       safestrncpy(room_name, roomrec->RRname, ROOMNAMELEN);
-       room_flags = roomrec->RRflags;
+       safestrncpy(room_name, room->RRname, ROOMNAMELEN);
+       room_flags = room->RRflags;
        from_floor = curr_floor;
-       curr_floor = roomrec->RRfloor;
+       curr_floor = room->RRfloor;
 
        remove_march(room_name, 0);
        if (!strcasecmp(towhere, "_BASEROOM_"))
                remove_march(towhere, 0);
-       if (!roomrec->RRunread)
+       if (!room->RRunread)
                next_lazy_cmd = 5;      /* Don't read new if no new msgs */
        if ((from_floor != curr_floor) && (display_name > 0) && (floor_mode == 1)) {
                if (floorlist[(int) curr_floor][0] == 0)
@@ -433,26 +445,26 @@ void dotgoto(CtdlIPC *ipc, char *towhere, int display_name, int fromungoto)
        }
        if (display_name != 2) {
                color(BRIGHT_YELLOW);
-               scr_printf("%d ", roomrec->RRunread);
+               scr_printf("%d ", room->RRunread);
                color(DIM_WHITE);
                scr_printf("new of ");
                color(BRIGHT_YELLOW);
-               scr_printf("%d ", roomrec->RRtotal);
+               scr_printf("%d ", room->RRtotal);
                color(DIM_WHITE);
                scr_printf("messages.\n");
        }
-       highest_msg_read = roomrec->RRlastread;
-       maxmsgnum = roomrec->RRhighest;
-       is_mail = roomrec->RRismailbox;
-       is_room_aide = roomrec->RRaide;
-       ls = roomrec->RRlastread;
+       highest_msg_read = room->RRlastread;
+       maxmsgnum = room->RRhighest;
+       is_mail = room->RRismailbox;
+       is_room_aide = room->RRaide;
+       ls = room->RRlastread;
 
        /* read info file if necessary */
-       if (roomrec->RRinfoupdated > 0)
+       if (room->RRinfoupdated > 0)
                readinfo(ipc);
 
        /* check for newly arrived mail if we can */
-       newmailcount = roomrec->RRnewmail;
+       newmailcount = room->RRnewmail;
        if (newmailcount > 0) {
                color(BRIGHT_RED);
                if (newmailcount == 1) {
@@ -487,7 +499,9 @@ void gotonext(CtdlIPC *ipc)
         * If it is, pop the first room off the list and go there.
         */
        if (march == NULL) {
-               r = CtdlIPCKnownRooms(ipc, 1, -1, &march, buf);
+               r = CtdlIPCKnownRooms(ipc, SubscribedRoomsWithNewMessages,
+                                       AllFloors, &march, buf);
+
 /* add _BASEROOM_ to the end of the march list, so the user will end up
  * in the system base room (usually the Lobby>) at the end of the loop
  */
@@ -524,27 +538,18 @@ void forget_all_rooms_on(CtdlIPC *ipc, int ffloor)
 {
        char buf[SIZ];
        struct march *flist, *fptr;
-       struct ctdlipcroom *roomrec;    /* Ignored */
+       struct ctdlipcroom *room;       /* Ignored */
        int r;                          /* IPC response code */
 
        scr_printf("Forgetting all rooms on %s...\r", &floorlist[ffloor][0]);
        scr_flush();
-       snprintf(buf, sizeof buf, "LKRA %d", ffloor);
-       CtdlIPC_putline(ipc, buf);
-       CtdlIPC_getline(ipc, buf);
-       if (buf[0] != '1') {
-               scr_printf("%-72s\n", &buf[4]);
+       r = CtdlIPCKnownRooms(ipc, AllAccessibleRooms, ffloor, &flist, buf);
+       if (r / 100 != 1) {
+               scr_printf("%-72s\n", buf);
                return;
        }
-       flist = NULL;
-       while (CtdlIPC_getline(ipc, buf), strcmp(buf, "000")) {
-               fptr = (struct march *) malloc(sizeof(struct march));
-               fptr->next = flist;
-               flist = fptr;
-               extract(fptr->march_name, buf, 0);
-       }
-       while (flist != NULL) {
-               r = CtdlIPCGotoRoom(ipc, flist->march_name, "", &roomrec, buf);
+       while (flist) {
+               r = CtdlIPCGotoRoom(ipc, flist->march_name, "", &room, buf);
                if (r / 100 == 2) {
                        r = CtdlIPCForgetRoom(ipc, buf);
                }
@@ -587,6 +592,7 @@ void gf_toroom(CtdlIPC *ipc, char *towhere, int mode)
 void gotofloor(CtdlIPC *ipc, char *towhere, int mode)
 {
        int a, tofloor;
+       int r;          /* IPC response code */
        struct march *mptr;
        char buf[SIZ], targ[SIZ];
 
@@ -620,14 +626,20 @@ void gotofloor(CtdlIPC *ipc, char *towhere, int mode)
        }
 
        strcpy(targ, "");
-       snprintf(buf, sizeof buf, "LKRA %d", tofloor);
-       CtdlIPC_putline(ipc, buf);
-       CtdlIPC_getline(ipc, buf);
-       if (buf[0] == '1')
-               while (CtdlIPC_getline(ipc, buf), strcmp(buf, "000")) {
-                       if ((extract_int(buf, 2) == tofloor) && (strlen(targ) == 0))
-                               extract(targ, buf, 0);
+       mptr = NULL;
+       r = CtdlIPCKnownRooms(ipc, AllAccessibleRooms, tofloor, &mptr, buf);
+       if (r / 100 == 1) {
+               struct march *tmp = mptr;
+
+               /* TODO: room order is being ignored? */
+               if (mptr)
+                       strncpy(targ, mptr->march_name, ROOMNAMELEN);
+               while (mptr) {
+                       tmp = mptr->next;
+                       free(mptr);
+                       mptr = tmp;
                }
+       }
        if (strlen(targ) > 0) {
                gf_toroom(ipc, targ, mode);
        } else {
@@ -727,7 +739,7 @@ int set_password(CtdlIPC *ipc)
        if (!strcasecmp(pass1, pass2)) {
                CtdlIPCChangePassword(ipc, pass1, buf);
                scr_printf("%s\n", buf);
-               offer_to_remember_password(hostbuf, portbuf, fullname, pass1);
+               offer_to_remember_password(ipc, hostbuf, portbuf, fullname, pass1);
                return (0);
        } else {
                scr_printf("*** They don't match... try again.\n");
@@ -749,8 +761,9 @@ void get_serv_info(CtdlIPC *ipc, char *supplied_hostname)
        /* be nice and identify ourself to the server */
        CtdlIPCIdentifySoftware(ipc, SERVER_TYPE, 0, REV_LEVEL,
                 (ipc->isLocal ? "local" : CITADEL),
-                (supplied_hostname) ? supplied_hostname : "", buf);
-                /* (locate_host(buf), buf)); */
+                (supplied_hostname) ? supplied_hostname : 
+                /* Look up the , in the bible if you're confused */
+                (locate_host(buf), buf), buf);
 
        /* Tell the server what our preferred content formats are */
        if ((CtdlIPCSpecifyPreferredFormats(ipc, buf, "text/html|text/plain") / 100 )== 2) {
@@ -760,6 +773,61 @@ void get_serv_info(CtdlIPC *ipc, char *supplied_hostname)
 
 
 
+/*
+ * Record compare function for SortOnlineUsers()
+ */
+int idlecmp(const void *rec1, const void *rec2) {
+       time_t i1, i2;
+
+       i1 = extract_long(rec1, 5);
+       i2 = extract_long(rec2, 5);
+
+       if (i1 < i2) return(1);
+       if (i1 > i2) return(-1);
+       return(0);
+}
+
+
+/*
+ * Sort the list of online users by idle time.
+ * This function frees the supplied buffer, and returns a new one
+ * to the caller.  The caller is responsible for freeing the returned buffer.
+ */
+char *SortOnlineUsers(char *listing) {
+       int rows;
+       char *sortbuf;
+       char *retbuf;
+       char buf[SIZ];
+       int i;
+
+       rows = num_tokens(listing, '\n');
+       sortbuf = malloc(rows * SIZ);
+       if (sortbuf == NULL) return(listing);
+       retbuf = malloc(rows * SIZ);
+       if (retbuf == NULL) {
+               free(sortbuf);
+               return(listing);
+       }
+
+       /* Copy the list into a fixed-record-size array for sorting */
+       for (i=0; i<rows; ++i) {
+               memset(buf, 0, SIZ);
+               extract_token(buf, listing, i, '\n');
+               memcpy(&sortbuf[i*SIZ], buf, SIZ);
+       }
+
+       /* Do the sort */
+       qsort(sortbuf, rows, SIZ, idlecmp);
+
+       /* Copy back to a \n delimited list */
+       strcpy(retbuf, "");
+       for (i=0; i<rows; ++i) {
+               strcat(retbuf, &sortbuf[i*SIZ]);
+               if (i<(rows-1)) strcat(retbuf, "\n");
+       }
+       return(retbuf);
+}
+
 
 
 /*
@@ -785,11 +853,12 @@ void who_is_online(CtdlIPC *ipc, int longlist)
 
        if (!longlist) {
                color(BRIGHT_WHITE);
-               pprintf("FLG ###        User Name                 Room                 From host\n");
+               pprintf("           User Name               Room           Idle        From host\n");
                color(DIM_WHITE);
-               pprintf("--- --- ------------------------- -------------------- ------------------------\n");
+               pprintf("   ------------------------- -------------------- ---- ------------------------\n");
        }
        r = CtdlIPCOnlineUsers(ipc, &listing, &timenow, buf);
+       listing = SortOnlineUsers(listing);
        if (r / 100 == 1) {
                while (strlen(listing) > 0) {
                        int isidle = 0;
@@ -810,10 +879,12 @@ void who_is_online(CtdlIPC *ipc, int longlist)
                        idlesecs = (idletime - (idlehours * 3600) - (idlemins * 60));
 
                        if (idletime > rc_idle_threshold) {
+                               /*
                                while (strlen(roomname) < 20) {
                                        strcat(roomname, " ");
                                }
                                strcpy(&roomname[14], "[idle]");
+                               */
                                if (skipidle)
                                        isidle = 1;
                        }
@@ -849,9 +920,7 @@ void who_is_online(CtdlIPC *ipc, int longlist)
                                        pprintf("        ");
                                } else {
                                        color(BRIGHT_MAGENTA);
-                                       pprintf("%-3s ", flags);
-                                       color(DIM_WHITE);
-                                       pprintf("%-3d ", extract_int(buf, 0));
+                                       pprintf("%-3s", flags);
                                }
                                last_session = extract_int(buf, 0);
                                color(BRIGHT_CYAN);
@@ -859,6 +928,29 @@ void who_is_online(CtdlIPC *ipc, int longlist)
                                color(BRIGHT_MAGENTA);
                                roomname[20] = 0;
                                pprintf("%-20s ", roomname);
+                               if (idletime > rc_idle_threshold) {
+                                       /* over 1000d, must be gone fishing */
+                                       if (idlehours > 23999) {
+                                               pprintf("fish");
+                                       /* over 10 days */
+                                       } else if (idlehours > 239) {
+                                               pprintf("%3ldd",
+                                                       idlehours / 24);
+                                       /* over 10 hours */
+                                       } else if (idlehours > 9) {
+                                               pprintf("%1ldd%02ld",
+                                                       idlehours / 24,
+                                                       idlehours % 24);
+                                       /* less than 10 hours */
+                                       } else {
+                                               pprintf("%1ld:%02ld",
+                                                       idlehours, idlemins);
+                                       }
+                               }
+                               else {
+                                       pprintf("    ");
+                               }
+                               pprintf(" ");
                                color(BRIGHT_CYAN);
                                fromhost[24] = '\0';
                                pprintf("%-24s\n", fromhost);
@@ -909,7 +1001,7 @@ int main(int argc, char **argv)
        int stored_password = 0;
        char password[SIZ];
        struct ctdlipcmisc chek;
-       struct usersupp *myself = NULL;
+       struct user *myself = NULL;
        CtdlIPC* ipc;                   /* Our server connection */
        int r;                          /* IPC result code */
 
@@ -939,7 +1031,7 @@ int main(int argc, char **argv)
 #ifdef HAVE_OPENSSL
        arg_encrypt = RC_DEFAULT;
 #endif
-#ifdef HAVE_CURSES_H
+#if defined(HAVE_CURSES_H) && !defined(DISABLE_CURSES)
        arg_screen = RC_DEFAULT;
 #endif
 
@@ -968,13 +1060,13 @@ int main(int argc, char **argv)
 #endif
                }
                if (!strcmp(argv[a], "-s")) {
-#ifdef HAVE_CURSES_H
+#if defined(HAVE_CURSES_H) && !defined(DISABLE_CURSES)
                        arg_screen = RC_NO;
 #endif
                        argc = shift(argc, argv, a, 1);
                }
                if (!strcmp(argv[a], "-S")) {
-#ifdef HAVE_CURSES_H
+#if defined(HAVE_CURSES_H) && !defined(DISABLE_CURSES)
                        arg_screen = RC_YES;
 #endif
                        argc = shift(argc, argv, a, 1);
@@ -1016,6 +1108,10 @@ int main(int argc, char **argv)
 
        screen_new();
 
+#ifdef __CYGWIN__
+       newprompt("Connect to (return for local server): ", hostbuf, 64);
+#endif
+
        sln_printf("Attaching to server... \r");
        sln_flush();
        ipc = CtdlIPC_new(argc, argv, hostbuf, portbuf);
@@ -1024,6 +1120,9 @@ int main(int argc, char **argv)
                error_printf("Can't connect: %s\n", strerror(errno));
                logoff(NULL, 3);
        }
+#if defined(HAVE_CURSES_H) && !defined(DISABLE_CURSES)
+       CtdlIPC_SetNetworkStatusCallback(ipc, wait_indicator);
+#endif
        ipc_for_signal_handlers = ipc;  /* KLUDGE cover your eyes */
 
        CtdlIPC_getline(ipc, aaa);
@@ -1054,6 +1153,7 @@ int main(int argc, char **argv)
                                }
                }
 
+#ifdef HAVE_OPENSSL
        /* Evaluate encryption preferences */
        if (arg_encrypt != RC_NO && rc_encrypt != RC_NO) {
                if (!ipc->isLocal || arg_encrypt == RC_YES || rc_encrypt == RC_YES) {
@@ -1062,6 +1162,7 @@ int main(int argc, char **argv)
                                error_printf("Can't encrypt: %s\n", aaa);
                }
        }
+#endif
 
        get_serv_info(ipc, telnet_client_host);
        scr_printf("%-24s\n%s\n%s\n", serv_info.serv_software, serv_info.serv_humannode,
@@ -1083,26 +1184,20 @@ int main(int argc, char **argv)
        if (rc_remember_passwords) {
                get_stored_password(hostbuf, portbuf, fullname, password);
                if (strlen(fullname) > 0) {
-                       snprintf(aaa, sizeof(aaa)-1, "USER %s", fullname);
-                       CtdlIPC_putline(ipc, aaa);
-                       CtdlIPC_getline(ipc, aaa);
-                       if (nonce[0])
-                               {
-                                       snprintf(aaa, sizeof aaa, "PAS2 %s", make_apop_string(password, nonce, hexstring, sizeof hexstring));
-                               }
-                       else    /* Else no APOP */
-                               {
-                                       snprintf(aaa, sizeof(aaa)-1, "PASS %s", password);
+                       r = CtdlIPCTryLogin(ipc, fullname, aaa);
+                       if (r / 100 == 3) {
+                               if (*nonce) {
+                                       r = CtdlIPCTryApopPassword(ipc, make_apop_string(password, nonce, hexstring, sizeof hexstring), aaa);
+                               } else {
+                                       r = CtdlIPCTryPassword(ipc, password, aaa);
                                }
-                       
-                       CtdlIPC_putline(ipc, aaa);
-                       CtdlIPC_getline(ipc, aaa);
-                       if (aaa[0] == '2') {
-                               load_user_info(&aaa[4]);
+                       }
+
+                       if (r / 100 == 2) {
+                               load_user_info(aaa);
                                stored_password = 1;
                                goto PWOK;
-                       }
-                       else {
+                       } else {
                                set_stored_password(hostbuf, portbuf, "", "");
                        }
                }
@@ -1142,43 +1237,37 @@ int main(int argc, char **argv)
        }
        strproc(password);
 
-       if (nonce[0])
-               {
-                       snprintf(aaa, sizeof aaa, "PAS2 %s", make_apop_string(password, nonce, hexstring, sizeof hexstring));
-               }
-       else    /* Else no APOP */
-               {
-                       snprintf(aaa, sizeof aaa, "PASS %s", password);
-               }
+       if (*nonce) {
+               r = CtdlIPCTryApopPassword(ipc, make_apop_string(password, nonce, hexstring, sizeof hexstring), aaa);
+       } else {
+               r = CtdlIPCTryPassword(ipc, password, aaa);
+       }
        
-       CtdlIPC_putline(ipc, aaa);
-       CtdlIPC_getline(ipc, aaa);
-       if (aaa[0] == '2') {
-               load_user_info(&aaa[4]);
-               offer_to_remember_password(hostbuf, portbuf,
+       if (r / 100 == 2) {
+               load_user_info(aaa);
+               offer_to_remember_password(ipc, hostbuf, portbuf,
                                           fullname, password);
                goto PWOK;
        }
        scr_printf("<< wrong password >>\n");
        if (strlen(rc_password) > 0)
-               logoff(ipc, 0);
+               logoff(ipc, 2);
        goto GSTA;
 
- NEWUSR:       if (strlen(rc_password) == 0) {
-        scr_printf("No record. Enter as new user? ");
-        if (yesno() == 0)
-                goto GSTA;
- }
-       snprintf(aaa, sizeof aaa, "NEWU %s", fullname);
-       CtdlIPC_putline(ipc, aaa);
-       CtdlIPC_getline(ipc, aaa);
-       if (aaa[0] != '2') {
+NEWUSR:        if (strlen(rc_password) == 0) {
+               scr_printf("No record. Enter as new user? ");
+               if (yesno() == 0)
+                       goto GSTA;
+       }
+
+       r = CtdlIPCCreateUser(ipc, fullname, 1, aaa);
+       if (r / 100 != 2) {
                scr_printf("%s\n", aaa);
                goto GSTA;
        }
-       load_user_info(&aaa[4]);
+       load_user_info(aaa);
 
-       while (set_password(ipc) != 0);;
+       while (set_password(ipc) != 0);
        newnow = 1;
 
        enter_config(ipc, 1);
@@ -1192,13 +1281,14 @@ int main(int argc, char **argv)
                        enable_color = 0;
        }
 
-       scr_printf("%s\nAccess level: %d (%s)\n"
+       color(BRIGHT_WHITE);
+       scr_printf("\n%s\nAccess level: %d (%s)\n"
                   "User #%ld / Login #%d",
                   fullname, axlevel, axdefs[(int) axlevel],
                   usernum, timescalled);
        if (lastcall > 0L) {
-               scr_printf(" / Last login: %s\n",
-                          asctime(localtime(&lastcall)) );
+               scr_printf(" / Last login: %s",
+                          asctime(localtime(&lastcall)));
        }
        scr_printf("\n");
 
@@ -1256,7 +1346,6 @@ int main(int argc, char **argv)
 
        set_floor_mode();
 
-
        /* Enter the lobby */
        dotgoto(ipc, "_BASEROOM_", 1, 0);
 
@@ -1264,9 +1353,9 @@ int main(int argc, char **argv)
        uglistsize = 0;
 
        if (newnow == 1)
-               readmsgs(ipc, 3, 1, 5);
+               readmsgs(ipc, LastMessages, ReadForward, 5);
        else
-               readmsgs(ipc, 1, 1, 0);
+               readmsgs(ipc, NewMessages, ReadForward, 0);
 
        /* MAIN COMMAND LOOP */
        do {
@@ -1300,50 +1389,60 @@ int main(int argc, char **argv)
                                else
                                        entmsg(ipc, 0, 0);
                                break;
-                       case 5:
+                       case 5:                         /* <G>oto */
                                updatels(ipc);
                                gotonext(ipc);
                                break;
-                       case 47:
-                               if (!rc_alt_semantics)
+                       case 47:                        /* <A>bandon */
+                               if (!rc_alt_semantics) {
                                        updatelsa(ipc);
+                               }
                                gotonext(ipc);
                                break;
-                       case 90:
+                       case 90:                        /* <.A>bandon */
                                if (!rc_alt_semantics)
                                        updatelsa(ipc);
                                dotgoto(ipc, argbuf, 0, 0);
                                break;
-                       case 58:
+                       case 58:                        /* <M>ail */
                                updatelsa(ipc);
                                dotgoto(ipc, "_MAIL_", 1, 0);
                                break;
                        case 20:
-                               updatels(ipc);
-                               dotgoto(ipc, argbuf, 0, 0);
+                               if (strlen(argbuf) > 0) {
+                                       updatels(ipc);
+                                       dotgoto(ipc, argbuf, 0, 0);
+                               }
                                break;
                        case 52:
-                               if (rc_alt_semantics)
-                                       updatelsa(ipc);
-                               dotgoto(ipc, argbuf, 0, 0);
+                               if (strlen(argbuf) > 0) {
+                                       if (rc_alt_semantics) {
+                                               updatelsa(ipc);
+                                       }
+                                       dotgoto(ipc, argbuf, 0, 0);
+                               }
+                               break;
+                       case 95: /* what exactly is the numbering scheme supposed to be anyway? */
+                               dotungoto(ipc, argbuf);
                                break;
                        case 10:
-                               readmsgs(ipc, 0, 1, 0);
+                               readmsgs(ipc, AllMessages, ReadForward, 0);
                                break;
                        case 9:
-                               readmsgs(ipc, 3, 1, 5);
+                               readmsgs(ipc, LastMessages, ReadForward, 5);
                                break;
                        case 13:
-                               readmsgs(ipc, 1, 1, 0);
+                               readmsgs(ipc, NewMessages, ReadForward, 0);
                                break;
                        case 11:
-                               readmsgs(ipc, 0, (-1), 0);
+                               readmsgs(ipc, AllMessages, ReadReverse, 0);
                                break;
                        case 12:
-                               readmsgs(ipc, 2, (-1), 0);
+                               readmsgs(ipc, OldMessages, ReadReverse, 0);
                                break;
                        case 71:
-                               readmsgs(ipc, 3, 1, atoi(argbuf));
+                               readmsgs(ipc, LastMessages, ReadForward,
+                                               atoi(argbuf));
                                break;
                        case 7:
                                forget(ipc);
@@ -1416,13 +1515,10 @@ int main(int argc, char **argv)
                                validate(ipc);
                                break;
                        case 29:
-                               if (!rc_alt_semantics)
-                                       updatels(ipc);
-                               termn8 = 1;
-                               break;
                        case 30:
-                               if (!rc_alt_semantics)
+                               if (!rc_alt_semantics) {
                                        updatels(ipc);
+                               }
                                termn8 = 1;
                                break;
                        case 48:
@@ -1480,7 +1576,8 @@ int main(int argc, char **argv)
                        case 15:
                                scr_printf("Are you sure (y/n)? ");
                                if (yesno() == 1) {
-                                       updatels(ipc);
+                                       if (!rc_alt_semantics)
+                                               updatels(ipc);
                                        a = 0;
                                        termn8 = 1;
                                }
@@ -1490,10 +1587,11 @@ int main(int argc, char **argv)
                                scr_printf("All users will be disconnected!  "
                                           "Really terminate the server? ");
                                if (yesno() == 1) {
+                                       if (!rc_alt_semantics)
+                                               updatels(ipc);
                                        r = CtdlIPCTerminateServerNow(ipc, aaa);
                                        scr_printf("%s\n", aaa);
                                        if (r / 100 == 2) {
-                                               updatels(ipc);
                                                a = 0;
                                                termn8 = 1;
                                        }
@@ -1543,8 +1641,9 @@ int main(int argc, char **argv)
                                break;
 
                        case 6:
-                               if (rc_alt_semantics)
+                               if (rc_alt_semantics) {
                                        updatelsa(ipc);
+                               }
                                gotonext(ipc);
                                break;
 
@@ -1664,7 +1763,7 @@ int main(int argc, char **argv)
                                break;
 
                        case 70:
-                               edit_system_message(argbuf);
+                               edit_system_message(ipc, argbuf);
                                break;
 
                        case 19:
@@ -1688,10 +1787,24 @@ int main(int argc, char **argv)
                                page_user(ipc);
                                break;
 
+                       default: /* allow some math on the command */
+                               /* commands 100... to 100+MAX_EDITORS-1 will
+                                  call the appropriate editor... in other
+                                  words, command numbers 100+ will match
+                                  the citadel.rc keys editor0, editor1, etc.*/
+                               if (mcmd >= 100 && mcmd < (100+MAX_EDITORS))
+                               {
+                                       /* entmsg mode >=2 select editor */
+                                       entmsg(ipc, 0, mcmd - 100 + 2);
+                                       break;
+                               }
                        }       /* end switch */
        } while (termn8 == 0);
 
- TERMN8:       scr_printf("%s logged out.\n", fullname);
+TERMN8:        scr_printf("%s logged out.", fullname);
+       termn8 = 0;
+       color(ORIGINAL_PAIR);
+       scr_printf("\n");
        while (march != NULL) {
                remove_march(march->march_name, 0);
        }