Added the OPNA command for downloading attachments

[citadel.git] / citadel / citserver.c

diff --git a/citadel/citserver.c b/citadel/citserver.c
index 8a967629826e288d5196a5ed6a2cb105365ae6df..70fa577fd06eca78357d95369ca57d9b491e77b9 100644 (file)
--- a/citadel/citserver.c
+++ b/citadel/citserver.c
@@ -90,7 +90,6 @@ void master_cleanup(void) {
  */
 void cleanup_stuff(void *arg)
 {
-       struct ExpressMessage *emptr;
 
        lprintf(9, "cleanup_stuff() called\n");
 
@@ -108,15 +107,11 @@ void cleanup_stuff(void *arg)
        
        /* Deallocate any unsent express messages */
        begin_critical_section(S_SESSION_TABLE);
-       while (CC->FirstExpressMessage != NULL) {
-               emptr = CC->FirstExpressMessage;
-               CC->FirstExpressMessage = CC->FirstExpressMessage->next;
-               free(emptr);
-               }
+       if (CC->ExpressMessages != NULL) phree(CC->ExpressMessages);
        end_critical_section(S_SESSION_TABLE);
 
        /* Deallocate any message list we might have in memory */
-       if (CC->msglist != NULL) free(CC->msglist);
+       if (CC->msglist != NULL) phree(CC->msglist);
 
        /* Now get rid of the session and context */
        lprintf(7, "cleanup_stuff() calling RemoveContext(%d)\n", CC->cs_pid);
@@ -176,14 +171,16 @@ void cmd_info(void) {
        cprintf("%d\n",SERVER_TYPE);
        cprintf("%s\n",config.c_moreprompt);
        cprintf("1\n"); /* 1 = yes, this system supports floors */
+       cprintf("1\n"); /* 1 = we support the extended paging options */
        cprintf("000\n");
        }
 
 void cmd_rchg(char *argbuf)
 {
-       char newroomname[ROOMNAMELEN];
+       char newroomname[256]; /* set to 256 to prevent buffer overruns <dme>*/
 
        extract(newroomname, argbuf, 0);
+       newroomname[ROOMNAMELEN] = 0;
        if (strlen(newroomname) > 0) {
                strncpy(CC->fake_roomname, newroomname, ROOMNAMELEN);
                CC->fake_roomname[ROOMNAMELEN - 1] = 0;
@@ -198,7 +195,7 @@ void cmd_hchg(char *newhostname)
 {
    if ((newhostname) && (newhostname[0]))
    {
-      bzero(CC->fake_hostname, 25);
+      memset(CC->fake_hostname, 0, 25);
       strncpy(CC->fake_hostname, newhostname, 24);
    }
    else
@@ -217,7 +214,7 @@ void cmd_uchg(char *newusername)
    if ((newusername) && (newusername[0]))
    {
       CC->cs_flags &= ~CS_STEALTH;
-      bzero(CC->fake_username, 32);
+      memset(CC->fake_username, 0, 32);
       if (strncasecmp(newusername, CC->curr_user, strlen(CC->curr_user)))
          strncpy(CC->fake_username, newusername, 31);
    }
@@ -234,7 +231,7 @@ void cmd_uchg(char *newusername)
  * space otherwise.
  */
 char check_express(void) {
-       if (CC->FirstExpressMessage == NULL) {
+       if (CC->ExpressMessages == NULL) {
                return(' ');
                }
        else {
@@ -377,13 +374,13 @@ void cmd_mesg(char *mname)
        extract(buf,mname,0);
 
 
-       dirs[0]=malloc(64);
-       dirs[1]=malloc(64);
+       dirs[0]=mallok(64);
+       dirs[1]=mallok(64);
        strcpy(dirs[0],"messages");
        strcpy(dirs[1],"help");
        mesg_locate(targ,buf,2,dirs);
-       free(dirs[0]);
-       free(dirs[1]);
+       phree(dirs[0]);
+       phree(dirs[1]);
 
 
        if (strlen(targ)==0) {
@@ -432,13 +429,13 @@ void cmd_emsg(char *mname)
                if (buf[a] == '/') buf[a] = '.';
                }
 
-       dirs[0]=malloc(64);
-       dirs[1]=malloc(64);
+       dirs[0]=mallok(64);
+       dirs[1]=mallok(64);
        strcpy(dirs[0],"messages");
        strcpy(dirs[1],"help");
        mesg_locate(targ,buf,2,dirs);
-       free(dirs[0]);
-       free(dirs[1]);
+       phree(dirs[0]);
+       phree(dirs[1]);
 
        if (strlen(targ)==0) {
                snprintf(targ, sizeof targ, "./help/%s", buf);
@@ -542,6 +539,7 @@ void cmd_term(char *cmdbuf)
 {
        int session_num;
        struct CitContext *ccptr;
+       int session_to_kill = 0;
 
        if (!CC->logged_in) {
                cprintf("%d Not logged in.\n",ERROR+NOT_LOGGED_IN);
@@ -560,15 +558,24 @@ void cmd_term(char *cmdbuf)
                return;
                }
 
+       lprintf(9, "Locating session to kill\n");
+       begin_critical_section(S_SESSION_TABLE);
        for (ccptr = ContextList; ccptr != NULL; ccptr = ccptr->next) {
                if (session_num == ccptr->cs_pid) {
-                       kill_session(ccptr->cs_pid);
-                       cprintf("%d Session terminated.\n", OK);
-                       return;
+                       session_to_kill = ccptr->cs_pid;
                        }
                }
+       end_critical_section(S_SESSION_TABLE);
+       lprintf(9, "session_to_kill == %d\n", session_to_kill);
 
-       cprintf("%d No such session.\n", ERROR);
+       if (session_to_kill > 0) {
+               lprintf(9, "calling kill_session()\n");
+               kill_session(session_to_kill);
+               cprintf("%d Session terminated.\n", OK);
+               }
+       else {
+               cprintf("%d No such session.\n", ERROR);
+               }
        }
 
 
@@ -663,7 +670,7 @@ void cmd_scdn(char *argbuf)
 void *context_loop(struct CitContext *con)
 {
        char cmdbuf[256];
-       int session_num;
+       int num_sessions;
 
        /*
         * Wedge our way into the context table.
@@ -678,7 +685,7 @@ void *context_loop(struct CitContext *con)
        CC->download_fp = NULL;
        CC->upload_fp = NULL;
        CC->cs_pid = con->client_socket;        /* not necessarily portable */
-       CC->FirstExpressMessage = NULL;
+       CC->ExpressMessages = NULL;
        CC->msglist = NULL;
        CC->num_msgs = 0;
        time(&CC->lastcmd);
@@ -696,9 +703,9 @@ void *context_loop(struct CitContext *con)
        CC->upload_type = UPL_FILE;
        CC->dl_is_net = 0;
 
-       session_num = session_count();
+       num_sessions = session_count();
        CC->nologin = 0;
-       if ((config.c_maxsessions > 0)&&(session_num > config.c_maxsessions))
+       if ((config.c_maxsessions > 0)&&(num_sessions > config.c_maxsessions))
                CC->nologin = 1;
 
        if (CC->nologin==1) {
@@ -719,7 +726,7 @@ void *context_loop(struct CitContext *con)
 
        do {
                time(&CC->lastcmd);
-               bzero(cmdbuf, sizeof cmdbuf); /* Clear it, just in case */
+               memset(cmdbuf, 0, sizeof cmdbuf); /* Clear it, just in case */
                if (client_gets(cmdbuf) < 1) cleanup(EXIT_NULL);
                lprintf(5, "citserver[%3d]: %s\n", CC->cs_pid, cmdbuf);
 
@@ -827,6 +834,14 @@ void *context_loop(struct CitContext *con)
                        cmd_msg3(&cmdbuf[5]);
                        }
 
+               else if (!strncasecmp(cmdbuf,"MSG4",4)) {
+                       cmd_msg4(&cmdbuf[5]);
+                       }
+
+               else if (!strncasecmp(cmdbuf,"OPNA",4)) {
+                       cmd_opna(&cmdbuf[5]);
+                       }
+
                else if (!strncasecmp(cmdbuf,"INFO",4)) {
                        cmd_info();
                        }
@@ -1091,6 +1106,12 @@ void *context_loop(struct CitContext *con)
                        cmd_conf(&cmdbuf[5]);
                        }
 
+#ifdef DEBUG_MEMORY_LEAKS
+               else if (!strncasecmp(cmdbuf, "LEAK", 4)) {
+                       dump_tracked();
+                       }
+#endif
+
                else if (!DLoader_Exec_Cmd(cmdbuf))
                        {
                           cprintf("%d Unrecognized or unsupported command.\n",