- pass -Wcast-qual to gcc

[citadel.git] / citadel / locate_host.c

diff --git a/citadel/locate_host.c b/citadel/locate_host.c
index b4f5cdbadcbb810385a4908cc26f82219f4b1a51..7e30b46f2aea6732dc06b88b44812ef6a38ce889 100644 (file)
--- a/citadel/locate_host.c
+++ b/citadel/locate_host.c
@@ -1,8 +1,14 @@
 /*
- * locate the originating host
  * $Id$
+ *
+ * locate the originating host
+ *
  */
 
+#ifdef DLL_EXPORT
+#define IN_LIBCIT
+#endif
+
 #include "sysdep.h"
 #include <stdlib.h>
 #include <unistd.h>
@@ -16,36 +22,41 @@
 #include <string.h>
 #include "citadel.h"
 #include "server.h"
+#include "dynloader.h"
 #include "locate_host.h"
+#include "sysdep_decls.h"
 #include "config.h"
 #include "tools.h"
 
-void locate_host(char *tbuf, const struct in_addr *addr)
+void locate_host(char *tbuf, size_t n, const struct in_addr *addr)
 {
        struct hostent *ch;
-       char *i;
+       const char *i;
+       char *j;
        int a1, a2, a3, a4;
 
+       lprintf(9, "locate_host() called\n");
+
 #ifdef HAVE_NONREENTRANT_NETDB
        begin_critical_section(S_NETDB);
 #endif
 
-       if ((ch = gethostbyaddr((char *) addr, sizeof(*addr), AF_INET)) ==
+       if ((ch = gethostbyaddr((const char *) addr, sizeof(*addr), AF_INET)) ==
            NULL) {
              bad_dns:
-               i = (char *) addr;
+               i = (const char *) addr;
                a1 = ((*i++) & 0xff);
                a2 = ((*i++) & 0xff);
                a3 = ((*i++) & 0xff);
                a4 = ((*i++) & 0xff);
-               sprintf(tbuf, "%d.%d.%d.%d", a1, a2, a3, a4);
+               snprintf(tbuf, n, "%d.%d.%d.%d", a1, a2, a3, a4);
                goto end;       /* because we might need to end the critical
                                   section */
        }
        /* check if the forward DNS agrees; if not, they're spoofing */
-       i = strdoop(ch->h_name);
-       ch = gethostbyname(i);
-       phree(i);
+       j = strdoop(ch->h_name);
+       ch = gethostbyname(j);
+       phree(j);
        if (ch == NULL)
                goto bad_dns;
 
@@ -53,7 +64,7 @@ void locate_host(char *tbuf, const struct in_addr *addr)
        for (; *ch->h_addr_list; ch->h_addr_list++)
                if (!memcmp(*ch->h_addr_list, addr,
                            sizeof *addr)) {
-                       safestrncpy(tbuf, ch->h_name, 25);
+                       safestrncpy(tbuf, ch->h_name, 63);
                        goto end;
                }
        goto bad_dns;           /* they were spoofing. report a numeric IP
@@ -65,5 +76,6 @@ void locate_host(char *tbuf, const struct in_addr *addr)
        end_critical_section(S_NETDB);
 #endif
 
-       tbuf[25] = 0;
+       tbuf[63] = 0;
+       lprintf(9, "locate_host() exiting\n");
 }