Fix memleaks

[citadel.git] / citadel / modules / eventclient / serv_eventclient.c

diff --git a/citadel/modules/eventclient/serv_eventclient.c b/citadel/modules/eventclient/serv_eventclient.c
index 153f1847ec1dcd79956bf67b03a8ce6a0d4a481c..53cbea4bd95e440734e2935fe84873ff8c438a3c 100644 (file)
--- a/citadel/modules/eventclient/serv_eventclient.c
+++ b/citadel/modules/eventclient/serv_eventclient.c
@@ -44,6 +44,7 @@
 #include <limits.h>
 #include <sys/socket.h>
 #include <netinet/in.h>
+#include <assert.h>
 #include <arpa/inet.h>
 #include <libcitadel.h>
 #include <curl/curl.h>
@@ -86,15 +87,13 @@ evcurl_global_data global;
 static void
 gotstatus(int nnrun) 
 {
-        CURLM *mhnd;
         CURLMsg *msg;
         int nmsg;
 
         global.nrun = nnrun;
-        mhnd = global.mhnd;
 
         syslog(LOG_DEBUG, "CURLEV: gotstatus(): about to call curl_multi_info_read\n");
-        while ((msg = curl_multi_info_read(mhnd, &nmsg))) {
+        while ((msg = curl_multi_info_read(global.mhnd, &nmsg))) {
                 syslog(LOG_ERR, "EVCURL: got curl multi_info message msg=%d\n", msg->msg);
                 if (CURLMSG_DONE == msg->msg) {
                         CURL *chnd;
@@ -126,17 +125,18 @@ gotstatus(int nnrun)
 
 
                         curl_slist_free_all(IO->HttpReq.headers);
-                        msta = curl_multi_remove_handle(mhnd, chnd);
+                        msta = curl_multi_remove_handle(global.mhnd, chnd);
                         if (msta)
                                 EV_syslog(LOG_ERR, "EVCURL: warning problem detaching completed handle from curl multi: %s\n", curl_multi_strerror(msta));
 
-                        curl_easy_cleanup(IO->HttpReq.chnd);
-                       IO->HttpReq.chnd = NULL;
+                       ev_cleanup_stop(event_base, &IO->abort_by_shutdown);
 
                         IO->HttpReq.attached = 0;
                         switch(IO->SendDone(IO))
                        {
                        case eDBQuery:
+                               curl_easy_cleanup(IO->HttpReq.chnd);
+                               IO->HttpReq.chnd = NULL;
                                break;
                        case eSendDNSQuery:
                        case eReadDNSReply:
@@ -148,9 +148,13 @@ gotstatus(int nnrun)
                        case eReadMore:
                        case eReadPayload:
                        case eReadFile:
+                               curl_easy_cleanup(IO->HttpReq.chnd);
+                               IO->HttpReq.chnd = NULL;
                                break;
                        case eTerminateConnection:
                        case eAbort:
+                               curl_easy_cleanup(IO->HttpReq.chnd);
+                               IO->HttpReq.chnd = NULL;
                                FreeStrBuf(&IO->HttpReq.ReplyData);
                                FreeURL(&IO->ConnectMe);
                                RemoveContext(IO->CitContext);
@@ -212,7 +216,7 @@ gotwatchtime(CURLM *multi, long tblock_ms, void *cglobal) {
                 tblock_ms = 14000;
         ev_timer_set(&global->timeev, 0.5e-3 + 1.0e-3 * tblock_ms, 14.0);
         ev_timer_start(EV_DEFAULT_UC, &global->timeev);
-        curl_multi_perform(global, CURL_POLL_NONE);
+        curl_multi_perform(global, &global->nrun);
         return 0;
 }
 
@@ -325,11 +329,12 @@ void curl_init_connectionpool(void)
 
 
 
-int evcurl_init(AsyncIO *IO, 
-                void *CustomData, 
+int evcurl_init(AsyncIO *IO,
+                void *CustomData,
                 const char* Desc,
-                IO_CallBack CallBack, 
-                IO_CallBack Terminate)
+                IO_CallBack CallBack,
+                IO_CallBack Terminate, 
+               IO_CallBack ShutdownAbort)
 {
         CURLcode sta;
         CURL *chnd;
@@ -338,6 +343,7 @@ int evcurl_init(AsyncIO *IO,
         IO->HttpReq.attached = 0;
         IO->SendDone = CallBack;
         IO->Terminate = Terminate;
+       IO->ShutdownAbort = ShutdownAbort;
         chnd = IO->HttpReq.chnd = curl_easy_init();
         if (!chnd)
         {
@@ -349,12 +355,12 @@ int evcurl_init(AsyncIO *IO,
 
         OPT(VERBOSE, (long)1);
                 /* unset in production */
-        OPT(NOPROGRESS, (long)1); 
-        OPT(NOSIGNAL, (long)1);
+        OPT(NOPROGRESS, 1L); 
+        OPT(NOSIGNAL, 1L);
         OPT(FAILONERROR, (long)1);
         OPT(ENCODING, "");
         OPT(FOLLOWLOCATION, (long)0);
-        OPT(MAXREDIRS, (long)7);
+        OPT(MAXREDIRS, (long)0);
         OPT(USERAGENT, CITADEL);
 
         OPT(TIMEOUT, (long)1800);
@@ -406,6 +412,26 @@ int evcurl_init(AsyncIO *IO,
        return 1;
 }
 
+
+static void IOcurl_abort_shutdown_callback(struct ev_loop *loop, ev_cleanup *watcher, int revents)
+{
+        CURLMcode msta;
+       AsyncIO *IO = watcher->data;
+       EV_syslog(LOG_DEBUG, "EVENT Curl: %s\n", __FUNCTION__);
+
+       curl_slist_free_all(IO->HttpReq.headers);
+       msta = curl_multi_remove_handle(global.mhnd, IO->HttpReq.chnd);
+       if (msta)
+               EV_syslog(LOG_ERR, "EVCURL: warning problem detaching completed handle from curl multi: %s\n", curl_multi_strerror(msta));
+       
+       curl_easy_cleanup(IO->HttpReq.chnd);
+       IO->HttpReq.chnd = NULL;
+       ev_cleanup_stop(event_base, &IO->abort_by_shutdown);
+       ev_io_stop(event_base, &IO->recv_event);
+       ev_io_stop(event_base, &IO->send_event);
+       assert(IO->ShutdownAbort);
+       IO->ShutdownAbort(IO);
+}
 eNextState
 evcurl_handle_start(AsyncIO *IO) 
 {
@@ -417,6 +443,9 @@ evcurl_handle_start(AsyncIO *IO)
                EV_syslog(LOG_ERR, "EVCURL: error attaching to curl multi handle: %s\n", curl_multi_strerror(msta));
        IO->HttpReq.attached = 1;
        ev_async_send (event_base, &WakeupCurl);
+       ev_cleanup_init(&IO->abort_by_shutdown, 
+                       IOcurl_abort_shutdown_callback);
+       ev_cleanup_start(event_base, &IO->abort_by_shutdown);
        return eReadMessage;
 }
 
@@ -429,7 +458,9 @@ static void WakeupCurlCallback(EV_P_ ev_async *w, int revents)
 
 static void evcurl_shutdown (void)
 {
+       curl_global_cleanup();
        curl_multi_cleanup(global.mhnd);
+       syslog(LOG_DEBUG, "client_event_thread() initializing\n");
 }
 /*****************************************************************************
  *                       libevent integration                                *
@@ -522,10 +553,9 @@ void *client_event_thread(void *arg)
 
        CtdlFillSystemContext(&libev_client_CC, "LibEv Thread");
 //     citthread_setspecific(MyConKey, (void *)&smtp_queue_CC);
-       syslog(LOG_DEBUG, "client_ev_thread() initializing\n");
+       syslog(LOG_DEBUG, "client_event_thread() initializing\n");
 
        event_base = ev_default_loop (EVFLAG_AUTO);
-
        ev_async_init(&AddJob, QueueEventAddCallback);
        ev_async_start(event_base, &AddJob);
        ev_async_init(&ExitEventLoop, EventExitCallback);
@@ -537,10 +567,10 @@ void *client_event_thread(void *arg)
 
        ev_run (event_base, 0);
 
+       syslog(LOG_DEBUG, "client_event_thread() exiting\n");
 
 ///what todo here?     CtdlClearSystemContext();
        ev_loop_destroy (EV_DEFAULT_UC);
-       
        DeleteHash(&QueueEvents);
        InboundEventQueue = NULL;
        DeleteHash(&InboundEventQueues[0]);
@@ -613,7 +643,7 @@ static void DBQueueEventAddCallback(EV_P_ ev_async *w, int revents)
 
 static void DBEventExitCallback(EV_P_ ev_async *w, int revents)
 {
-       syslog(LOG_DEBUG, "EVENT Q exiting.\n");
+       syslog(LOG_DEBUG, "DB EVENT Q exiting.\n");
        ev_break(event_db, EVBREAK_ALL);
 }
 
@@ -650,7 +680,7 @@ void *db_event_thread(void *arg)
 
        CtdlFillSystemContext(&libev_msg_CC, "LibEv DB IO Thread");
 //     citthread_setspecific(MyConKey, (void *)&smtp_queue_CC);
-       syslog(LOG_DEBUG, "client_msgev_thread() initializing\n");
+       syslog(LOG_DEBUG, "dbevent_thread() initializing\n");
 
        event_db = ev_loop_new (EVFLAG_AUTO);
 
@@ -661,6 +691,7 @@ void *db_event_thread(void *arg)
 
        ev_run (event_db, 0);
 
+       syslog(LOG_DEBUG, "dbevent_thread() exiting\n");
 
 //// what to do here?  CtdlClearSystemContext();
        ev_loop_destroy (event_db);
@@ -674,10 +705,24 @@ void *db_event_thread(void *arg)
        return(NULL);
 }
 
+void ShutDownEventQueues(void)
+{
+       syslog(LOG_DEBUG, "EVENT Qs triggering exits.\n");
+
+       pthread_mutex_lock(&DBEventQueueMutex);
+       ev_async_send (event_db, &DBExitEventLoop);
+       pthread_mutex_unlock(&DBEventQueueMutex);
+
+       pthread_mutex_lock(&EventQueueMutex);
+       ev_async_send (EV_DEFAULT_ &ExitEventLoop);
+       pthread_mutex_unlock(&EventQueueMutex);
+}
+
 CTDL_MODULE_INIT(event_client)
 {
        if (!threading)
        {
+               CtdlRegisterCleanupHook(ShutDownEventQueues);
                InitEventQueue();
                DBInitEventQueue();
                CtdlThreadCreate(/*"Client event", */ client_event_thread);