]> code.citadel.org Git - citadel.git/blobdiff - citadel/modules/rssclient/serv_rssclient.c
Memleak: fix the varous handler & config lists of the rss module on exit.
[citadel.git] / citadel / modules / rssclient / serv_rssclient.c
index 9a1a7688e1483dde839b25ff249c7f2f6e33896a..13156ba0df047eca2b55796bc577d30c4e166738 100644 (file)
@@ -56,6 +56,7 @@
 #include "md5.h"
 #include "context.h"
 
+
 typedef struct rssnetcfg rssnetcfg;
 struct rssnetcfg {
        rssnetcfg *next;
@@ -63,6 +64,7 @@ struct rssnetcfg {
        char *rooms;
        time_t last_error_when;
        int ItemType;
+       time_t next_poll;
 };
 
 #define RSS_UNSET       (1<<0)
@@ -111,9 +113,10 @@ typedef struct _rsscollection {
 } rsscollection;
 
 struct rssnetcfg *rnclist = NULL;
-HashList *StartHandlers;
-HashList *EndHandlers;
-HashList *KnownNameSpaces;
+HashList *StartHandlers = NULL;
+HashList *EndHandlers = NULL;
+HashList *KnownNameSpaces = NULL;
+HashList *UrlShorteners = NULL;
 void AddRSSStartHandler(rss_handler_func Handler, int Flags, const char *key, long len)
 {
        rss_xml_handler *h;
@@ -131,7 +134,7 @@ void AddRSSEndHandler(rss_handler_func Handler, int Flags, const char *key, long
        Put(EndHandlers, key, len, h, NULL);
 }
 
-///#if 0
+#if 0
 //#ifdef HAVE_ICONV
 #include <iconv.h>
 
@@ -169,10 +172,10 @@ fill_encoding_info (const char *charset, XML_Encoding * info)
     } 
  
   { 
-    unsigned short out; 
+    unsigned short out = 0
     unsigned char buf[4]; 
     unsigned int i0, i1, i2; 
-    int result; 
+    int result = 0
     flag = 0; 
     for (i0 = 0; i0 < 0x100; i0++) 
       { 
@@ -303,7 +306,212 @@ handle_unknown_xml_encoding (void *encodingHandleData,
 } 
 
 ///#endif
-//#endif
+#endif
+size_t GetLocationString( void *ptr, size_t size, size_t nmemb, void *userdata)
+{
+#define LOCATION "location"
+       if (strncasecmp((char*)ptr, LOCATION, sizeof(LOCATION) - 1) == 0)
+       {
+               StrBuf *pURL = (StrBuf*) userdata;
+               char *pch = (char*) ptr;
+               char *pche;
+               
+               pche = pch + (size * nmemb);
+               pch += sizeof(LOCATION);
+               
+               while (isspace(*pch) || (*pch == ':'))
+                       pch ++;
+
+               while (isspace(*pche) || (*pche == '\0'))
+                       pche--;
+               
+               FlushStrBuf(pURL);
+               StrBufPlain(pURL, pch, pche - pch + 1); 
+       }
+       return size * nmemb;
+}
+
+int LookupUrl(StrBuf *ShorterUrlStr)
+{
+       CURL *curl;
+       char errmsg[1024] = "";
+       StrBuf *Answer;
+       int rc = 0;
+
+       curl = curl_easy_init();
+       if (!curl) {
+               CtdlLogPrintf(CTDL_ALERT, "Unable to initialize libcurl.\n");
+               return 0;
+       }
+       Answer = NewStrBufPlain(NULL, SIZ);
+
+       curl_easy_setopt(curl, CURLOPT_URL, ChrPtr(ShorterUrlStr));
+       curl_easy_setopt(curl, CURLOPT_SSL_VERIFYPEER, 0);
+       curl_easy_setopt(curl, CURLOPT_SSL_VERIFYHOST, 0);
+       curl_easy_setopt(curl, CURLOPT_WRITEDATA, Answer);
+//     curl_easy_setopt(curl, CURLOPT_WRITEFUNCTION, rss_libcurl_callback);
+       curl_easy_setopt(curl, CURLOPT_WRITEFUNCTION, CurlFillStrBuf_callback);
+       curl_easy_setopt(curl, CURLOPT_ERRORBUFFER, errmsg);
+       curl_easy_setopt(curl, CURLOPT_FOLLOWLOCATION, 1);
+#ifdef CURLOPT_HTTP_CONTENT_DECODING
+       curl_easy_setopt(curl, CURLOPT_HTTP_CONTENT_DECODING, 1);
+       curl_easy_setopt(curl, CURLOPT_ENCODING, "");
+#endif
+       curl_easy_setopt(curl, CURLOPT_USERAGENT, CITADEL);
+       curl_easy_setopt(curl, CURLOPT_TIMEOUT, 180);           /* die after 180 seconds */
+       curl_easy_setopt(curl, CURLOPT_FOLLOWLOCATION, 0);
+
+       curl_easy_setopt(curl, CURLOPT_HEADERFUNCTION , GetLocationString);
+       curl_easy_setopt(curl, CURLOPT_WRITEHEADER, ShorterUrlStr);
+
+
+       if (
+               (!IsEmptyStr(config.c_ip_addr))
+               && (strcmp(config.c_ip_addr, "*"))
+               && (strcmp(config.c_ip_addr, "::"))
+               && (strcmp(config.c_ip_addr, "0.0.0.0"))
+       ) {
+               curl_easy_setopt(curl, CURLOPT_INTERFACE, config.c_ip_addr);
+       }
+
+       if (CtdlThreadCheckStop())
+               goto shutdown ;
+
+       rc = curl_easy_perform(curl);
+       if (rc) {
+               CtdlLogPrintf(CTDL_ALERT, "libcurl error %d: %s\n", rc, errmsg);
+               rc = 0;
+       }
+       else 
+               rc = 1;
+
+shutdown:
+       curl_easy_cleanup(curl);
+
+               return rc;
+
+}
+
+
+
+void CrawlMessageForShorterUrls(HashList *pUrls, StrBuf *Message)
+{
+       int nHits = 0;
+       void *pv;
+       int nShorter = 0;
+       const char *pch;
+       const char *pUrl;
+       ConstStr *pCUrl;
+
+       while (GetHash(UrlShorteners, IKEY(nShorter), &pv))
+       {
+               nShorter++;
+               pch = ChrPtr(Message);
+               pUrl = strstr(pch, ChrPtr((StrBuf*)pv));
+               while ((pUrl != NULL) && (nHits < 99))
+               {
+                       pCUrl = malloc(sizeof(ConstStr));
+
+                       pCUrl->Key = pUrl;
+                       pch = pUrl + StrLength((StrBuf*)pv);
+                       while (isalnum(*pch)||(*pch == '-')||(*pch == '/'))
+                               pch++;
+                       pCUrl->len = pch - pCUrl->Key;
+
+                       Put(pUrls, IKEY(nHits), pCUrl, NULL);
+                       nHits ++;
+                       pUrl = strstr(pch, ChrPtr((StrBuf*)pv));
+               }
+       }
+}
+
+int SortConstStrByPosition(const void *Item1, const void *Item2)
+{
+       const ConstStr *p1, *p2;
+       p1 = (const ConstStr*) Item1;
+       p2 = (const ConstStr*) Item2;
+       if (p1->Key == p2->Key)
+               return 0;
+       if (p1->Key > p2->Key)
+               return 1;
+       return -1;
+}
+
+void ExpandShortUrls(StrBuf *Message)
+{
+       StrBuf *Shadow;
+       HashList *pUrls;
+       ConstStr *pCUrl;
+       const char *pch;
+       const char *pche;
+
+       /* we just suspect URL shorteners to be inside of feeds from twitter
+        * or other short content messages, so don't crawl through real blogs.
+        */
+       if (StrLength(Message) > 500)
+               return;
+
+       pUrls = NewHash(1, Flathash);
+       CrawlMessageForShorterUrls(pUrls, Message);
+
+       if (GetCount(pUrls) > 0)
+       {
+               StrBuf *ShorterUrlStr;
+               HashPos *Pos;
+               const char *Key;
+               void *pv;
+               long len;
+
+               Shadow = NewStrBufPlain(NULL, StrLength(Message));
+               SortByPayload (pUrls, SortConstStrByPosition);
+
+               ShorterUrlStr = NewStrBufPlain(NULL, StrLength(Message));
+
+               pch = ChrPtr(Message);
+               pche = pch + StrLength(Message);
+               Pos = GetNewHashPos(pUrls, 1);
+               while (GetNextHashPos(pUrls, Pos, &len, &Key, &pv))
+               {
+                       pCUrl = (ConstStr*) pv;
+
+                       if (pch != pCUrl->Key)
+                               StrBufAppendBufPlain(Shadow, pch, pCUrl->Key - pch, 0);
+                       
+                       StrBufPlain(ShorterUrlStr, CKEY(*pCUrl));
+                       if (LookupUrl(ShorterUrlStr))
+                       {
+                               StrBufAppendBufPlain(Shadow, HKEY("<a href=\""), 0);
+                               StrBufAppendBuf(Shadow, ShorterUrlStr, 0);
+                               StrBufAppendBufPlain(Shadow, HKEY("\">"), 0);
+                               StrBufAppendBuf(Shadow, ShorterUrlStr, 0);
+                               StrBufAppendBufPlain(Shadow, HKEY("["), 0);
+                               StrBufAppendBufPlain(Shadow, pCUrl->Key, pCUrl->len, 0);
+                               StrBufAppendBufPlain(Shadow, HKEY("]</a>"), 0);
+                       }
+                       else
+                       {
+                               StrBufAppendBufPlain(Shadow, HKEY("<a href=\""), 0);
+                               StrBufAppendBufPlain(Shadow, pCUrl->Key, pCUrl->len, 0);
+                               StrBufAppendBufPlain(Shadow, HKEY("\">"), 0);
+                               StrBufAppendBufPlain(Shadow, pCUrl->Key, pCUrl->len, 0);
+                               StrBufAppendBufPlain(Shadow, HKEY("</a>"), 0);
+                       }
+                       pch = pCUrl->Key + pCUrl->len + 1;
+
+               }
+               if (pch < pche)
+                       StrBufAppendBufPlain(Shadow, pch, pche - pch, 0);
+               FlushStrBuf(Message);
+               StrBufAppendBuf(Message, Shadow, 0);
+
+               FreeStrBuf(&ShorterUrlStr);
+               FreeStrBuf(&Shadow);
+               DeleteHashPos(&Pos);
+       }
+
+       DeleteHash(&pUrls);
+}
+
 
 void AppendLink(StrBuf *Message, StrBuf *link, StrBuf *LinkTitle, const char *Title)
 {
@@ -385,7 +593,7 @@ void rss_save_item(rss_item *ri)
                ut.ut_timestamp = time(NULL);
                cdb_store(CDB_USETABLE, utmsgid, strlen(utmsgid), &ut, sizeof(struct UseTable) );
        }
-       else 
+       else
 #endif
 {
                /* Item has not been seen, so save it. */
@@ -404,67 +612,34 @@ void rss_save_item(rss_item *ri)
 
                if (ri->author_or_creator != NULL) {
                        char *From;
-                       StrBuf *Encoded, *QPEncoded;
-                       StrBuf *UserName;
-                       StrBuf *EmailAddress;
-                       StrBuf *EncBuf;
+                       StrBuf *Encoded = NULL;
                        int FromAt;
-                       int FromLen;
                        
-                       UserName = NewStrBuf();
-                       EmailAddress = NewStrBuf();
-                       EncBuf = NewStrBuf();
-////TODO!
-                       StrBufTrim(ri->author_or_creator);
                        From = html_to_ascii(ChrPtr(ri->author_or_creator),
                                             StrLength(ri->author_or_creator), 
                                             512, 0);
-                       FromLen = strlen(From);
-                       if (From[FromLen - 1] == '\n')
-                       {
-                               From[FromLen - 1] = '\0';
-                       }
-                       FromAt = strchr(From, '@') != NULL;
+                       StrBufPlain(ri->author_or_creator, From, -1);
+                       StrBufTrim(ri->author_or_creator);
+                       free(From);
+
+                       FromAt = strchr(ChrPtr(ri->author_or_creator), '@') != NULL;
                        if (!FromAt && StrLength (ri->author_email) > 0)
                        {
-                               Encoded = NewStrBuf();
-                               if (!IsEmptyStr(From))
-                               {
-                                       StrBufPrintf(Encoded,
-                                                    "\"%s\" <%s>", 
-                                                    From, 
-                                                    ChrPtr(ri->author_email));
-                               }
-                               else
-                               {
-                                       StrBufPrintf(Encoded,
-                                                    "<%s>", 
-                                                    ChrPtr(ri->author_email));
-                               }
+                               StrBufRFC2047encode(&Encoded, ri->author_or_creator);
+                               msg->cm_fields['A'] = SmashStrBuf(&Encoded);
+                               msg->cm_fields['P'] = SmashStrBuf(&ri->author_email);
                        }
                        else
                        {
                                if (FromAt)
-                                       Encoded = NewStrBufPlain(From, -1);
+                                       msg->cm_fields['P'] = SmashStrBuf(&ri->author_or_creator);
                                else 
                                {
-                                       Encoded = NewStrBuf();
-                                       StrBufPrintf(Encoded,
-                                                    "\"%s\" <%s>", 
-                                                    From, 
-                                                    "rss@localhost"); /// TODO: get hostname?
+                                       StrBufRFC2047encode(&Encoded, ri->author_or_creator);
+                                       msg->cm_fields['A'] = SmashStrBuf(&Encoded);
+                                       msg->cm_fields['P'] = strdup("rss@localhost");
                                }
                        }
-                       free(From);
-                       StrBufTrim(Encoded);
-                       QPEncoded = StrBufSanitizeEmailRecipientVector(Encoded, UserName, EmailAddress, EncBuf);
-                       msg->cm_fields['A'] = SmashStrBuf(&QPEncoded);
-
-                       FreeStrBuf(&Encoded);
-                       FreeStrBuf(&UserName);
-                       FreeStrBuf(&EmailAddress);
-                       FreeStrBuf(&EncBuf);
-
                }
                else {
                        msg->cm_fields['A'] = strdup("rss");
@@ -504,6 +679,7 @@ void rss_save_item(rss_item *ri)
                }
                if (ri->link == NULL) 
                        ri->link = NewStrBufPlain(HKEY(""));
+               ExpandShortUrls(ri->description);
                msglen += 1024 + StrLength(ri->link) + StrLength(ri->description) ;
 
                Message = NewStrBufPlain(NULL, StrLength(ri->description));
@@ -858,6 +1034,13 @@ void RSS_item_link_end (StrBuf *CData, rss_item *ri, rssnetcfg *Cfg, const char*
                StrBufTrim(ri->link);
        }
 }
+void RSS_item_relink_end(StrBuf *CData, rss_item *ri, rssnetcfg *Cfg, const char** Attr)
+{
+       if (StrLength(CData) > 0) {
+               NewStrBufDupAppendFlush(&ri->reLink, CData, NULL, 0);
+               StrBufTrim(ri->reLink);
+       }
+}
 
 void RSSATOM_item_title_end (StrBuf *CData, rss_item *ri, rssnetcfg *Cfg, const char** Attr)
 {
@@ -1060,7 +1243,7 @@ size_t rss_libcurl_callback(void *ptr, size_t size, size_t nmemb, void *stream)
 void rss_do_fetching(rssnetcfg *Cfg) {
        rsscollection rssc;
        rss_item ri;
-       XML_Parser xp;
+       XML_Parser xp = NULL;
        StrBuf *Answer;
 
        CURL *curl;
@@ -1070,6 +1253,12 @@ void rss_do_fetching(rssnetcfg *Cfg) {
        const char *at;
        long len;
 
+       time_t now;
+
+        now = time(NULL);
+
+       if ((Cfg->next_poll != 0) && (now < Cfg->next_poll))
+               return;
        memset(&ri, 0, sizeof(rss_item));
        rssc.Item = &ri;
        rssc.Cfg = Cfg;
@@ -1191,6 +1380,8 @@ shutdown:
        flush_rss_item(&ri);
        FreeStrBuf(&rssc.CData);
        FreeStrBuf(&rssc.Key);
+
+        Cfg->next_poll = time(NULL) + config.c_net_freq; 
 }
 
 
@@ -1242,6 +1433,7 @@ void rssclient_scan_room(struct ctdlroom *qrbuf, void *data)
                        /* Otherwise create a new client request */
                        if (use_this_rncptr == NULL) {
                                rncptr = (rssnetcfg *) malloc(sizeof(rssnetcfg));
+                               memset(rncptr, 0, sizeof(rssnetcfg));
                                rncptr->ItemType = RSS_UNSET;
                                if (rncptr != NULL) {
                                        rncptr->next = rnclist;
@@ -1278,15 +1470,10 @@ void rssclient_scan_room(struct ctdlroom *qrbuf, void *data)
 /*
  * Scan for rooms that have RSS client requests configured
  */
-void *rssclient_scan(void *args) {
+void rssclient_scan(void) {
        static time_t last_run = 0L;
        static int doing_rssclient = 0;
        rssnetcfg *rptr = NULL;
-       CitContext rssclientCC;
-
-       /* Give this thread its own private CitContext */
-       CtdlFillSystemContext(&rssclientCC, "rssclient");
-       citthread_setspecific(MyConKey, (void *)&rssclientCC );
 
        /*
         * This is a simple concurrency check to make sure only one rssclient run
@@ -1294,7 +1481,7 @@ void *rssclient_scan(void *args) {
         * don't really require extremely fine granularity here, we'll do it
         * with a static variable instead.
         */
-       if (doing_rssclient) return NULL;
+       if (doing_rssclient) return;
        doing_rssclient = 1;
 
        CtdlLogPrintf(CTDL_DEBUG, "rssclient started\n");
@@ -1311,98 +1498,149 @@ void *rssclient_scan(void *args) {
        CtdlLogPrintf(CTDL_DEBUG, "rssclient ended\n");
        last_run = time(NULL);
        doing_rssclient = 0;
-       if (!CtdlThreadCheckStop())
-               CtdlThreadSchedule ("RSS Client", CTDLTHREAD_BIGSTACK, rssclient_scan, NULL, last_run + config.c_net_freq);
-       else
-               CtdlLogPrintf(CTDL_DEBUG, "rssclient: Task STOPPED.\n");
-       CtdlClearSystemContext();
-       return NULL;
+       return;
 }
 
+void LoadUrlShorteners(void)
+{
+       int i = 0;
+       int fd;
+       const char *POS = NULL;
+       const char *Err = NULL;
+       StrBuf *Content, *Line;
+
+
+       UrlShorteners = NewHash(0, Flathash);
+
+       fd = open(file_citadel_urlshorteners, 0);
+
+       if (fd != 0)
+       {
+               Content = NewStrBufPlain(NULL, SIZ);
+               Line = NewStrBuf();
+               while (POS != StrBufNOTNULL)
+               {
+                       StrBufTCP_read_buffered_line_fast (Line, Content, &POS, &fd, 1, 1, &Err);
+                       StrBufTrim(Line);
+                       if ((*ChrPtr(Line) != '#') && (StrLength(Line) > 0))
+                       {
+                               Put(UrlShorteners, IKEY(i), Line, HFreeStrBuf);
+                               i++;
+                               Line = NewStrBuf();
+                       }
+                       else
+                               FlushStrBuf(Line);
+                       if (POS == NULL)
+                               POS = StrBufNOTNULL;
+               }
+               FreeStrBuf(&Line);
+               FreeStrBuf(&Content);
+       }
+       close(fd);
+}
+
+void rss_cleanup(void)
+{
+        DeleteHash(&StartHandlers);
+        DeleteHash(&EndHandlers);
+       DeleteHash(&UrlShorteners);
+       DeleteHash(&KnownNameSpaces);
+}
 
 CTDL_MODULE_INIT(rssclient)
 {
        if (threading)
        {
                CtdlLogPrintf(CTDL_INFO, "%s\n", curl_version());
-               CtdlThreadSchedule ("RSS Client", CTDLTHREAD_BIGSTACK, rssclient_scan, NULL, 0);
+               CtdlRegisterSessionHook(rssclient_scan, EVT_TIMER);
        }
-
-       StartHandlers = NewHash(1, NULL);
-       EndHandlers = NewHash(1, NULL);
-
-       AddRSSStartHandler(RSS_item_rss_start,     RSS_UNSET, HKEY("rss"));
-       AddRSSStartHandler(RSS_item_rdf_start,     RSS_UNSET, HKEY("rdf"));
-       AddRSSStartHandler(ATOM_item_feed_start,    RSS_UNSET, HKEY("feed"));
-       AddRSSStartHandler(RSS_item_item_start,    RSS_RSS, HKEY("item"));
-       AddRSSStartHandler(ATOM_item_entry_start,  RSS_ATOM, HKEY("entry"));
-       AddRSSStartHandler(ATOM_item_link_start,   RSS_ATOM, HKEY("link"));
-
-       AddRSSEndHandler(ATOMRSS_item_title_end,   RSS_ATOM|RSS_RSS|RSS_REQUIRE_BUF, HKEY("title"));
-       AddRSSEndHandler(RSS_item_guid_end,        RSS_RSS|RSS_REQUIRE_BUF, HKEY("guid"));
-       AddRSSEndHandler(ATOM_item_id_end,         RSS_ATOM|RSS_REQUIRE_BUF, HKEY("id"));
-       AddRSSEndHandler(RSS_item_link_end,        RSS_RSS|RSS_REQUIRE_BUF, HKEY("link"));
-       AddRSSEndHandler(RSSATOM_item_title_end,   RSS_ATOM|RSS_RSS|RSS_REQUIRE_BUF, HKEY("title"));
-       AddRSSEndHandler(ATOM_item_content_end,    RSS_ATOM|RSS_REQUIRE_BUF, HKEY("content"));
-       AddRSSEndHandler(RSS_item_description_end, RSS_RSS|RSS_ATOM|RSS_REQUIRE_BUF, HKEY("encoded"));
-       AddRSSEndHandler(ATOM_item_summary_end,    RSS_ATOM|RSS_REQUIRE_BUF, HKEY("summary"));
-       AddRSSEndHandler(RSS_item_description_end, RSS_RSS|RSS_REQUIRE_BUF, HKEY("description"));
-       AddRSSEndHandler(ATOM_item_published_end,  RSS_ATOM|RSS_REQUIRE_BUF, HKEY("published"));
-       AddRSSEndHandler(ATOM_item_updated_end,    RSS_ATOM|RSS_REQUIRE_BUF, HKEY("updated"));
-       AddRSSEndHandler(RSS_item_pubdate_end,     RSS_RSS|RSS_REQUIRE_BUF, HKEY("pubdate"));
-       AddRSSEndHandler(RSS_item_date_end,        RSS_RSS|RSS_REQUIRE_BUF, HKEY("date"));
-       AddRSSEndHandler(RSS_item_author_end,      RSS_RSS|RSS_REQUIRE_BUF, HKEY("author"));
-       AddRSSEndHandler(RSS_item_creator_end,     RSS_RSS|RSS_REQUIRE_BUF, HKEY("creator"));
+       else 
+       {
+               LoadUrlShorteners ();
+
+               StartHandlers = NewHash(1, NULL);
+               EndHandlers = NewHash(1, NULL);
+
+               AddRSSStartHandler(RSS_item_rss_start,     RSS_UNSET, HKEY("rss"));
+               AddRSSStartHandler(RSS_item_rdf_start,     RSS_UNSET, HKEY("rdf"));
+               AddRSSStartHandler(ATOM_item_feed_start,    RSS_UNSET, HKEY("feed"));
+               AddRSSStartHandler(RSS_item_item_start,    RSS_RSS, HKEY("item"));
+               AddRSSStartHandler(ATOM_item_entry_start,  RSS_ATOM, HKEY("entry"));
+               AddRSSStartHandler(ATOM_item_link_start,   RSS_ATOM, HKEY("link"));
+
+               AddRSSEndHandler(ATOMRSS_item_title_end,   RSS_ATOM|RSS_RSS|RSS_REQUIRE_BUF, HKEY("title"));
+               AddRSSEndHandler(RSS_item_guid_end,        RSS_RSS|RSS_REQUIRE_BUF, HKEY("guid"));
+               AddRSSEndHandler(ATOM_item_id_end,         RSS_ATOM|RSS_REQUIRE_BUF, HKEY("id"));
+               AddRSSEndHandler(RSS_item_link_end,        RSS_RSS|RSS_REQUIRE_BUF, HKEY("link"));
+#if 0 
+// hm, rss to the comments of that blog, might be interesting in future, but... 
+               AddRSSEndHandler(RSS_item_relink_end,      RSS_RSS|RSS_REQUIRE_BUF, HKEY("commentrss"));
+// comment count...
+               AddRSSEndHandler(RSS_item_relink_end,      RSS_RSS|RSS_REQUIRE_BUF, HKEY("comments"));
+#endif
+               AddRSSEndHandler(RSSATOM_item_title_end,   RSS_ATOM|RSS_RSS|RSS_REQUIRE_BUF, HKEY("title"));
+               AddRSSEndHandler(ATOM_item_content_end,    RSS_ATOM|RSS_REQUIRE_BUF, HKEY("content"));
+               AddRSSEndHandler(RSS_item_description_end, RSS_RSS|RSS_ATOM|RSS_REQUIRE_BUF, HKEY("encoded"));
+               AddRSSEndHandler(ATOM_item_summary_end,    RSS_ATOM|RSS_REQUIRE_BUF, HKEY("summary"));
+               AddRSSEndHandler(RSS_item_description_end, RSS_RSS|RSS_REQUIRE_BUF, HKEY("description"));
+               AddRSSEndHandler(ATOM_item_published_end,  RSS_ATOM|RSS_REQUIRE_BUF, HKEY("published"));
+               AddRSSEndHandler(ATOM_item_updated_end,    RSS_ATOM|RSS_REQUIRE_BUF, HKEY("updated"));
+               AddRSSEndHandler(RSS_item_pubdate_end,     RSS_RSS|RSS_REQUIRE_BUF, HKEY("pubdate"));
+               AddRSSEndHandler(RSS_item_date_end,        RSS_RSS|RSS_REQUIRE_BUF, HKEY("date"));
+               AddRSSEndHandler(RSS_item_author_end,      RSS_RSS|RSS_REQUIRE_BUF, HKEY("author"));
+               AddRSSEndHandler(RSS_item_creator_end,     RSS_RSS|RSS_REQUIRE_BUF, HKEY("creator"));
 /* <author> */
-       AddRSSEndHandler(ATOM_item_email_end,      RSS_ATOM|RSS_REQUIRE_BUF, HKEY("email"));
-       AddRSSEndHandler(ATOM_item_name_end,       RSS_ATOM|RSS_REQUIRE_BUF, HKEY("name"));
-       AddRSSEndHandler(ATOM_item_uri_end,        RSS_ATOM|RSS_REQUIRE_BUF, HKEY("uri"));
+               AddRSSEndHandler(ATOM_item_email_end,      RSS_ATOM|RSS_REQUIRE_BUF, HKEY("email"));
+               AddRSSEndHandler(ATOM_item_name_end,       RSS_ATOM|RSS_REQUIRE_BUF, HKEY("name"));
+               AddRSSEndHandler(ATOM_item_uri_end,        RSS_ATOM|RSS_REQUIRE_BUF, HKEY("uri"));
 /* </author> */
-       AddRSSEndHandler(RSS_item_item_end,        RSS_RSS, HKEY("item"));
-       AddRSSEndHandler(RSS_item_rss_end,         RSS_RSS, HKEY("rss"));
-       AddRSSEndHandler(RSS_item_rdf_end,         RSS_RSS, HKEY("rdf"));
-       AddRSSEndHandler(ATOM_item_entry_end,      RSS_ATOM, HKEY("entry"));
+               AddRSSEndHandler(RSS_item_item_end,        RSS_RSS, HKEY("item"));
+               AddRSSEndHandler(RSS_item_rss_end,         RSS_RSS, HKEY("rss"));
+               AddRSSEndHandler(RSS_item_rdf_end,         RSS_RSS, HKEY("rdf"));
+               AddRSSEndHandler(ATOM_item_entry_end,      RSS_ATOM, HKEY("entry"));
 
 
 /* at the start of atoms: <seq> <li>link to resource</li></seq> ignore them. */
-       AddRSSStartHandler(RSSATOM_item_ignore,      RSS_RSS|RSS_ATOM, HKEY("seq"));
-       AddRSSEndHandler  (RSSATOM_item_ignore,      RSS_RSS|RSS_ATOM, HKEY("seq"));
-       AddRSSStartHandler(RSSATOM_item_ignore,      RSS_RSS|RSS_ATOM, HKEY("li"));
-       AddRSSEndHandler  (RSSATOM_item_ignore,      RSS_RSS|RSS_ATOM, HKEY("li"));
+               AddRSSStartHandler(RSSATOM_item_ignore,      RSS_RSS|RSS_ATOM, HKEY("seq"));
+               AddRSSEndHandler  (RSSATOM_item_ignore,      RSS_RSS|RSS_ATOM, HKEY("seq"));
+               AddRSSStartHandler(RSSATOM_item_ignore,      RSS_RSS|RSS_ATOM, HKEY("li"));
+               AddRSSEndHandler  (RSSATOM_item_ignore,      RSS_RSS|RSS_ATOM, HKEY("li"));
 
 /* links to other feed generators... */
-       AddRSSStartHandler(RSSATOM_item_ignore,      RSS_RSS|RSS_ATOM, HKEY("feedflare"));
-       AddRSSEndHandler  (RSSATOM_item_ignore,      RSS_RSS|RSS_ATOM, HKEY("feedflare"));
-       AddRSSStartHandler(RSSATOM_item_ignore,      RSS_RSS|RSS_ATOM, HKEY("browserfriendly"));
-       AddRSSEndHandler  (RSSATOM_item_ignore,      RSS_RSS|RSS_ATOM, HKEY("browserfriendly"));
-
-       KnownNameSpaces = NewHash(1, NULL);
-       Put(KnownNameSpaces, HKEY("http://a9.com/-/spec/opensearch/1.1/"), NULL, reference_free_handler);
-       Put(KnownNameSpaces, HKEY("http://a9.com/-/spec/opensearchrss/1.0/"), NULL, reference_free_handler);
-       Put(KnownNameSpaces, HKEY("http://backend.userland.com/creativeCommonsRssModule"), NULL, reference_free_handler);
-       Put(KnownNameSpaces, HKEY("http://purl.org/atom/ns#"), NULL, reference_free_handler);
-       Put(KnownNameSpaces, HKEY("http://purl.org/dc/elements/1.1/"), NULL, reference_free_handler);
-       Put(KnownNameSpaces, HKEY("http://purl.org/rss/1.0/"), NULL, reference_free_handler);
-       Put(KnownNameSpaces, HKEY("http://purl.org/rss/1.0/modules/content/"), NULL, reference_free_handler);
-       Put(KnownNameSpaces, HKEY("http://purl.org/rss/1.0/modules/slash/"), NULL, reference_free_handler);
-       Put(KnownNameSpaces, HKEY("http://purl.org/rss/1.0/modules/syndication/"), NULL, reference_free_handler);
-       Put(KnownNameSpaces, HKEY("http://purl.org/rss/1.0/"), NULL, reference_free_handler);
-       Put(KnownNameSpaces, HKEY("http://purl.org/syndication/thread/1.0"), NULL, reference_free_handler);
-       Put(KnownNameSpaces, HKEY("http://rssnamespace.org/feedburner/ext/1.0"), NULL, reference_free_handler);
-       Put(KnownNameSpaces, HKEY("http://schemas.google.com/g/2005"), NULL, reference_free_handler);
-       Put(KnownNameSpaces, HKEY("http://webns.net/mvcb/"), NULL, reference_free_handler);
-       Put(KnownNameSpaces, HKEY("http://web.resource.org/cc/"), NULL, reference_free_handler);
-       Put(KnownNameSpaces, HKEY("http://wellformedweb.org/CommentAPI/"), NULL, reference_free_handler);
-       Put(KnownNameSpaces, HKEY("http://www.georss.org/georss"), NULL, reference_free_handler);
-       Put(KnownNameSpaces, HKEY("http://www.w3.org/1999/xhtml"), NULL, reference_free_handler);
-       Put(KnownNameSpaces, HKEY("http://www.w3.org/1999/02/22-rdf-syntax-ns#"), NULL, reference_free_handler);
-       Put(KnownNameSpaces, HKEY("http://www.w3.org/1999/02/22-rdf-syntax-ns#"), NULL, reference_free_handler);
-       Put(KnownNameSpaces, HKEY("http://www.w3.org/2003/01/geo/wgs84_pos#"), NULL, reference_free_handler);
-       Put(KnownNameSpaces, HKEY("http://www.w3.org/2005/Atom"), NULL, reference_free_handler);
-       Put(KnownNameSpaces, HKEY("urn:flickr:"), NULL, reference_free_handler);
+               AddRSSStartHandler(RSSATOM_item_ignore,      RSS_RSS|RSS_ATOM, HKEY("feedflare"));
+               AddRSSEndHandler  (RSSATOM_item_ignore,      RSS_RSS|RSS_ATOM, HKEY("feedflare"));
+               AddRSSStartHandler(RSSATOM_item_ignore,      RSS_RSS|RSS_ATOM, HKEY("browserfriendly"));
+               AddRSSEndHandler  (RSSATOM_item_ignore,      RSS_RSS|RSS_ATOM, HKEY("browserfriendly"));
+
+               KnownNameSpaces = NewHash(1, NULL);
+               Put(KnownNameSpaces, HKEY("http://a9.com/-/spec/opensearch/1.1/"), NULL, reference_free_handler);
+               Put(KnownNameSpaces, HKEY("http://a9.com/-/spec/opensearchrss/1.0/"), NULL, reference_free_handler);
+               Put(KnownNameSpaces, HKEY("http://backend.userland.com/creativeCommonsRssModule"), NULL, reference_free_handler);
+               Put(KnownNameSpaces, HKEY("http://purl.org/atom/ns#"), NULL, reference_free_handler);
+               Put(KnownNameSpaces, HKEY("http://purl.org/dc/elements/1.1/"), NULL, reference_free_handler);
+               Put(KnownNameSpaces, HKEY("http://purl.org/rss/1.0/"), NULL, reference_free_handler);
+               Put(KnownNameSpaces, HKEY("http://purl.org/rss/1.0/modules/content/"), NULL, reference_free_handler);
+               Put(KnownNameSpaces, HKEY("http://purl.org/rss/1.0/modules/slash/"), NULL, reference_free_handler);
+               Put(KnownNameSpaces, HKEY("http://purl.org/rss/1.0/modules/syndication/"), NULL, reference_free_handler);
+               Put(KnownNameSpaces, HKEY("http://purl.org/rss/1.0/"), NULL, reference_free_handler);
+               Put(KnownNameSpaces, HKEY("http://purl.org/syndication/thread/1.0"), NULL, reference_free_handler);
+               Put(KnownNameSpaces, HKEY("http://rssnamespace.org/feedburner/ext/1.0"), NULL, reference_free_handler);
+               Put(KnownNameSpaces, HKEY("http://schemas.google.com/g/2005"), NULL, reference_free_handler);
+               Put(KnownNameSpaces, HKEY("http://webns.net/mvcb/"), NULL, reference_free_handler);
+               Put(KnownNameSpaces, HKEY("http://web.resource.org/cc/"), NULL, reference_free_handler);
+               Put(KnownNameSpaces, HKEY("http://wellformedweb.org/CommentAPI/"), NULL, reference_free_handler);
+               Put(KnownNameSpaces, HKEY("http://www.georss.org/georss"), NULL, reference_free_handler);
+               Put(KnownNameSpaces, HKEY("http://www.w3.org/1999/xhtml"), NULL, reference_free_handler);
+               Put(KnownNameSpaces, HKEY("http://www.w3.org/1999/02/22-rdf-syntax-ns#"), NULL, reference_free_handler);
+               Put(KnownNameSpaces, HKEY("http://www.w3.org/1999/02/22-rdf-syntax-ns#"), NULL, reference_free_handler);
+               Put(KnownNameSpaces, HKEY("http://www.w3.org/2003/01/geo/wgs84_pos#"), NULL, reference_free_handler);
+               Put(KnownNameSpaces, HKEY("http://www.w3.org/2005/Atom"), NULL, reference_free_handler);
+               Put(KnownNameSpaces, HKEY("urn:flickr:"), NULL, reference_free_handler);
 #if 0
-       /* we don't like these namespaces because of they shadow our usefull parameters. */
-       Put(KnownNameSpaces, HKEY("http://search.yahoo.com/mrss/"), NULL, reference_free_handler);
+               /* we don't like these namespaces because of they shadow our usefull parameters. */
+               Put(KnownNameSpaces, HKEY("http://search.yahoo.com/mrss/"), NULL, reference_free_handler);
 #endif
+                CtdlRegisterCleanupHook(rss_cleanup);
+       }
        return "rssclient";
 }