]> code.citadel.org Git - citadel.git/blobdiff - citadel/modules/rssclient/serv_rssclient.c
finalize allocation & freeing of rss stuff
[citadel.git] / citadel / modules / rssclient / serv_rssclient.c
index a51cac413698e41d4cabc52989a9e3cf0b69d7f7..4383321097075cf1525ec85c6f40225c87524d49 100644 (file)
 #define TMP_SHORTER_URL_OFFSET 0xFE
 #define TMP_SHORTER_URLS 0xFD
 
+citthread_mutex_t RSSQueueMutex; /* locks the access to the following vars: */
+HashList *RSSQueueRooms = NULL; /* rss_room_counter */
+HashList *RSSFetchUrls = NULL; /* -> rss_aggregator; ->RefCount access to be locked too. */
+
+eNextState RSSAggregatorTerminate(AsyncIO *IO);
+
 
 struct rssnetcfg *rnclist = NULL;
 void AppendLink(StrBuf *Message, StrBuf *link, StrBuf *LinkTitle, const char *Title)
@@ -84,17 +90,90 @@ typedef struct __networker_save_message {
        AsyncIO IO;
        struct CtdlMessage *Msg;
        struct recptypes *recp;
+       rss_aggregator *Cfg;
        StrBuf *MsgGUID;
        StrBuf *Message;
        struct UseTable ut;
 } networker_save_message;
 
+
+void DeleteRoomReference(long QRnumber)
+{
+       HashPos *At;
+       long HKLen;
+       const char *HK;
+       void *vData = NULL;
+       rss_room_counter *pRoomC;
+
+       At = GetNewHashPos(RSSQueueRooms, 0);
+
+       GetHashPosFromKey(RSSQueueRooms, LKEY(QRnumber), At);
+       GetHashPos(RSSQueueRooms, At, &HKLen, &HK, &vData);
+       if (vData != NULL)
+       {
+               pRoomC = (rss_room_counter *) vData;
+               pRoomC->count --;
+               if (pRoomC->count == 0)
+                       DeleteEntryFromHash(RSSQueueRooms, At);
+       }
+       DeleteHashPos(&At);
+}
+
+void UnlinkRooms(rss_aggregator *Cfg)
+{
+       
+       DeleteRoomReference(Cfg->QRnumber);
+       if (Cfg->OtherQRnumbers != NULL)
+       {
+               long HKLen;
+               const char *HK;
+               HashPos *At;
+               void *vData;
+
+               At = GetNewHashPos(Cfg->OtherQRnumbers, 0);
+               while (GetNextHashPos(Cfg->OtherQRnumbers, At, &HKLen, &HK, &vData) && 
+                      (vData != NULL))
+               {
+                       long *lData = (long*) vData;
+                       DeleteRoomReference(*lData);
+               }
+
+               DeleteHashPos(&At);
+       }
+
+}
+
+void UnlinkAggregator(rss_aggregator *Cfg)
+{
+       HashPos *At;
+
+       UnlinkRooms(Cfg);
+
+       At = GetNewHashPos(RSSFetchUrls, 0);
+       if (GetHashPosFromKey(RSSFetchUrls, SKEY(Cfg->Url), At) == 0)
+       {
+               DeleteEntryFromHash(RSSFetchUrls, At);
+       }
+       DeleteHashPos(&At);
+}
+
 eNextState FreeNetworkSaveMessage (AsyncIO *IO)
 {
        networker_save_message *Ctx = (networker_save_message *) IO->Data;
 
+       citthread_mutex_lock(&RSSQueueMutex);
+       Ctx->Cfg->RefCount --;
+
+       if (Ctx->Cfg->RefCount == 0)
+       {
+               UnlinkAggregator(Ctx->Cfg);
+
+       }
+       citthread_mutex_unlock(&RSSQueueMutex);
+
        CtdlFreeMessage(Ctx->Msg);
        free_recipients(Ctx->recp);
+       FreeStrBuf(&Ctx->Message);
        FreeStrBuf(&Ctx->MsgGUID);
        free(Ctx);
        return eAbort;
@@ -102,7 +181,7 @@ eNextState FreeNetworkSaveMessage (AsyncIO *IO)
 
 eNextState AbortNetworkSaveMessage (AsyncIO *IO)
 {
-    return eAbort; ///TODO
+       return eAbort; ///TODO
 }
 
 eNextState RSSSaveMessage(AsyncIO *IO)
@@ -141,7 +220,7 @@ eNextState FetchNetworkUsetableEntry(AsyncIO *IO)
                cdb_store(CDB_USETABLE, 
                          SKEY(Ctx->MsgGUID), 
                          &Ctx->ut, sizeof(struct UseTable) );
-               return eTerminateConnection;
+               return eAbort;
        }
        else
 #endif
@@ -150,7 +229,7 @@ eNextState FetchNetworkUsetableEntry(AsyncIO *IO)
                return eSendMore;
        }
 }
-void RSSQueueSaveMessage(struct CtdlMessage *Msg, struct recptypes *recp, StrBuf *MsgGUID, StrBuf *MessageBody)
+void RSSQueueSaveMessage(struct CtdlMessage *Msg, struct recptypes *recp, StrBuf *MsgGUID, StrBuf *MessageBody, rss_aggregator *Cfg)
 {
        networker_save_message *Ctx;
 
@@ -160,6 +239,7 @@ void RSSQueueSaveMessage(struct CtdlMessage *Msg, struct recptypes *recp, StrBuf
        Ctx->MsgGUID = MsgGUID;
        Ctx->Message = MessageBody;
        Ctx->Msg = Msg;
+       Ctx->Cfg = Cfg;
        Ctx->recp = recp;
        Ctx->IO.Data = Ctx;
        Ctx->IO.CitContext = CloneContext(CC);
@@ -172,7 +252,7 @@ void RSSQueueSaveMessage(struct CtdlMessage *Msg, struct recptypes *recp, StrBuf
 /*
  * Commit a fetched and parsed RSS item to disk
  */
-void rss_save_item(rss_item *ri)
+void rss_save_item(rss_item *ri, rss_aggregator *Cfg)
 {
 
        struct MD5Context md5context;
@@ -187,11 +267,12 @@ void rss_save_item(rss_item *ri)
        recp = (struct recptypes *) malloc(sizeof(struct recptypes));
        if (recp == NULL) return;
        memset(recp, 0, sizeof(struct recptypes));
-       Buf = NewStrBufDup(ri->roomlist);
+       Buf = NewStrBufDup(Cfg->rooms);
        recp->recp_room = SmashStrBuf(&Buf);
-       recp->num_room = ri->roomlist_parts;
+       recp->num_room = Cfg->roomlist_parts;
        recp->recptypes_magic = RECPTYPES_MAGIC;
    
+       Cfg->RefCount ++;
        /* Construct a GUID to use in the S_USETABLE table.
         * If one is not present in the item itself, make one up.
         */
@@ -320,7 +401,7 @@ void rss_save_item(rss_item *ri)
        AppendLink(Message, ri->reLink, ri->reLinkTitle, "Reply to this");
        StrBufAppendBufPlain(Message, HKEY("</body></html>\n"), 0);
 
-       RSSQueueSaveMessage(msg, recp, guid, Message);
+       RSSQueueSaveMessage(msg, recp, guid, Message, Cfg);
 }
 
 
@@ -328,8 +409,8 @@ void rss_save_item(rss_item *ri)
 /*
  * Begin a feed parse
  */
-void rss_do_fetching(rssnetcfg *Cfg) {
-       rsscollection *rssc;
+int rss_do_fetching(rss_aggregator *Cfg)
+{
        rss_item *ri;
                
        time_t now;
@@ -338,19 +419,15 @@ void rss_do_fetching(rssnetcfg *Cfg) {
         now = time(NULL);
 
        if ((Cfg->next_poll != 0) && (now < Cfg->next_poll))
-               return;
-       Cfg->Attached = 1;
+               return 0;
+       Cfg->RefCount = 1;
 
        ri = (rss_item*) malloc(sizeof(rss_item));
-       rssc = (rsscollection*) malloc(sizeof(rsscollection));
        memset(ri, 0, sizeof(rss_item));
-       memset(rssc, 0, sizeof(rsscollection));
-       rssc->Item = ri;
-       rssc->Cfg = Cfg;
-       IO = &rssc->IO;
+       Cfg->Item = ri;
+       IO = &Cfg->IO;
        IO->CitContext = CloneContext(CC);
-       IO->Data = rssc;
-       ri->roomlist = Cfg->rooms;
+       IO->Data = Cfg;
 
 
        CtdlLogPrintf(CTDL_DEBUG, "Fetching RSS feed <%s>\n", ChrPtr(Cfg->Url));
@@ -361,89 +438,79 @@ void rss_do_fetching(rssnetcfg *Cfg) {
 //                       Ctx, 
                          NULL,
                          "Citadel RSS Client",
-                         ParseRSSReply))
+                         ParseRSSReply, 
+                         RSSAggregatorTerminate))
        {
                CtdlLogPrintf(CTDL_ALERT, "Unable to initialize libcurl.\n");
-//             goto abort;
+               return 0;
        }
 
        evcurl_handle_start(IO);
+       return 1;
 }
 
-citthread_mutex_t RSSQueueMutex; /* locks the access to the following vars: */
-HashList *RSSQueueRooms = NULL;
-HashList *RSSFetchUrls = NULL;
 
 
-/*
-       while (fgets(buf, sizeof buf, fp) != NULL && !CtdlThreadCheckStop()) {
-               buf[strlen(buf)-1] = 0;
-
-               extract_token(instr, buf, 0, '|', sizeof instr);
-               if (!strcasecmp(instr, "rssclient")) {
+void DeleteRssCfg(void *vptr)
+{
+       rss_aggregator *rncptr = (rss_aggregator *)vptr;
 
-                       use_this_rncptr = NULL;
+       FreeStrBuf(&rncptr->Url);
+       FreeStrBuf(&rncptr->rooms);
+       FreeStrBuf(&rncptr->CData);
+       FreeStrBuf(&rncptr->Key);
 
-                       extract_token(feedurl, buf, 1, '|', sizeof feedurl);
+       DeleteHash(&rncptr->OtherQRnumbers);
 
-                       /* If any other rooms have requested the same feed, then we will just add this
-                        * room to the target list for that client request.
-                        * / TODO: how do we do this best?
-                       for (rncptr=rnclist; rncptr!=NULL; rncptr=rncptr->next) {
-                               if (!strcmp(ChrPtr(rncptr->Url), feedurl)) {
-                                       use_this_rncptr = rncptr;
-                               }
-                       }
-                       * /
-                       /* Otherwise create a new client request * /
-                       if (use_this_rncptr == NULL) {
-                               rncptr = (rssnetcfg *) malloc(sizeof(rssnetcfg));
-                               memset(rncptr, 0, sizeof(rssnetcfg));
-                               rncptr->ItemType = RSS_UNSET;
-
-                               rncptr->Url = NewStrBufPlain(feedurl, -1);
-                               rncptr->rooms = NULL;
-                               rnclist = rncptr;
-                               use_this_rncptr = rncptr;
+       if (rncptr->Item != NULL)
+       {
+               FreeStrBuf(&rncptr->Item->guid);
+               FreeStrBuf(&rncptr->Item->title);
+               FreeStrBuf(&rncptr->Item->link);
+               FreeStrBuf(&rncptr->Item->linkTitle);
+               FreeStrBuf(&rncptr->Item->reLink);
+               FreeStrBuf(&rncptr->Item->reLinkTitle);
+               FreeStrBuf(&rncptr->Item->description);
+               FreeStrBuf(&rncptr->Item->channel_title);
+               FreeStrBuf(&rncptr->Item->author_or_creator);
+               FreeStrBuf(&rncptr->Item->author_url);
+               FreeStrBuf(&rncptr->Item->author_email);
+
+               free(rncptr->Item);
+       }
+       free(rncptr);
+}
 
-                       }
+eNextState RSSAggregatorTerminate(AsyncIO *IO)
+{
+       rss_aggregator *rncptr = (rss_aggregator *)IO->Data;
+       HashPos *At;
+       long HKLen;
+       const char *HK;
+       void *vData;
 
-                       /* Add the room name to the request * /
-                       if (use_this_rncptr != NULL) {
-                               if (use_this_rncptr->rooms == NULL) {
-                                       rncptr->rooms = strdup(qrbuf->QRname);
-                               }
-                               else {
-                                       len = strlen(use_this_rncptr->rooms) + strlen(qrbuf->QRname) + 5;
-                                       ptr = realloc(use_this_rncptr->rooms, len);
-                                       if (ptr != NULL) {
-                                               strcat(ptr, "|");
-                                               strcat(ptr, qrbuf->QRname);
-                                               use_this_rncptr->rooms = ptr;
-                                       }
-                               }
-                       }
-               }
+       citthread_mutex_lock(&RSSQueueMutex);
+       rncptr->RefCount --;
+       if (rncptr->RefCount == 0)
+       {
+               UnlinkAggregator(rncptr);
 
        }
-                       */
-typedef struct __RoomCounter {
-       int count;
-       long QRnumber;
-} RoomCounter;
-
-
+       citthread_mutex_unlock(&RSSQueueMutex);
+/*
+       At = GetNewHashPos(RSSFetchUrls, 0);
 
-void DeleteRssCfg(void *vptr)
-{
-       rssnetcfg *rncptr = (rssnetcfg *)vptr;
+       citthread_mutex_lock(&RSSQueueMutex);
+       GetHashPosFromKey(RSSFetchUrls, SKEY(rncptr->Url), At);
+       GetHashPos(RSSFetchUrls, At, &HKLen, &HK, &vData);
+       DeleteEntryFromHash(RSSFetchUrls, At);
+       citthread_mutex_unlock(&RSSQueueMutex);
 
-       FreeStrBuf(&rncptr->Url);
-       FreeStrBuf(&rncptr->rooms);
-       free(rncptr);
+       DeleteHashPos(&At);
+*/
+       return eAbort;
 }
 
-
 /*
  * Scan a room's netconfig to determine whether it is requesting any RSS feeds
  */
@@ -452,18 +519,13 @@ void rssclient_scan_room(struct ctdlroom *qrbuf, void *data)
        StrBuf *CfgData;
        StrBuf *CfgType;
        StrBuf *Line;
-       RoomCounter *Count = NULL;
+       rss_room_counter *Count = NULL;
        struct stat statbuf;
        char filename[PATH_MAX];
-       //char buf[1024];
-       //char instr[32];
        int  fd;
        int Done;
-       //char feedurl[256];
-       rssnetcfg *rncptr = NULL;
-       rssnetcfg *use_this_rncptr = NULL;
-       //int len = 0;
-       //char *ptr = NULL;
+       rss_aggregator *rncptr = NULL;
+       rss_aggregator *use_this_rncptr = NULL;
        void *vptr;
        const char *CfgPtr, *lPtr;
        const char *Err;
@@ -471,7 +533,10 @@ void rssclient_scan_room(struct ctdlroom *qrbuf, void *data)
        citthread_mutex_lock(&RSSQueueMutex);
        if (GetHash(RSSQueueRooms, LKEY(qrbuf->QRnumber), &vptr))
        {
-               //CtdlLogPrintf(CTDL_DEBUG, "rssclient: %s already in progress.\n", qrbuf->QRname);
+               CtdlLogPrintf(CTDL_DEBUG, 
+                             "rssclient: [%ld] %s already in progress.\n", 
+                             qrbuf->QRnumber, 
+                             qrbuf->QRname);
                citthread_mutex_unlock(&RSSQueueMutex);
                return;
        }
@@ -524,38 +589,46 @@ void rssclient_scan_room(struct ctdlroom *qrbuf, void *data)
                {
                    if (Count == NULL)
                    {
-                       Count = malloc(sizeof(RoomCounter));
+                       Count = malloc(sizeof(rss_room_counter));
                        Count->count = 0;
                    }
                    Count->count ++;
-                   rncptr = (rssnetcfg *) malloc(sizeof(rssnetcfg));
-                   memset (rncptr, 0, sizeof(rssnetcfg));
+                   rncptr = (rss_aggregator *) malloc(sizeof(rss_aggregator));
+                   memset (rncptr, 0, sizeof(rss_aggregator));
                    rncptr->roomlist_parts = 1;
                    rncptr->Url = NewStrBuf();
                    StrBufExtract_NextToken(rncptr->Url, Line, &lPtr, '|');
 
                    citthread_mutex_lock(&RSSQueueMutex);
                    GetHash(RSSFetchUrls, SKEY(rncptr->Url), &vptr);
-                   use_this_rncptr = (rssnetcfg *)vptr;
-                   citthread_mutex_unlock(&RSSQueueMutex);
-
+                   use_this_rncptr = (rss_aggregator *)vptr;
                    if (use_this_rncptr != NULL)
                    {
-                       /* mustn't attach to an active session */
-                       if (use_this_rncptr->Attached == 1)
-                       {
-                           DeleteRssCfg(rncptr);
-                       }
-                       else 
-                       {
-                               StrBufAppendBufPlain(use_this_rncptr->rooms, 
-                                                    qrbuf->QRname, 
-                                                    -1, 0);
-                               use_this_rncptr->roomlist_parts++;
-                       }
-
-                       continue;
+                           /* mustn't attach to an active session */
+                           if (use_this_rncptr->RefCount > 0)
+                           {
+                                   DeleteRssCfg(rncptr);
+                                   Count->count--;
+                           }
+                           else 
+                           {
+                                   long *QRnumber;
+                                   StrBufAppendBufPlain(use_this_rncptr->rooms, 
+                                                        qrbuf->QRname, 
+                                                        -1, 0);
+                                   if (use_this_rncptr->roomlist_parts == 1)
+                                   {
+                                           use_this_rncptr->OtherQRnumbers = NewHash(1, lFlathash);
+                                   }
+                                   QRnumber = (long*)malloc(sizeof(long));
+                                   *QRnumber = qrbuf->QRnumber;
+                                   Put(use_this_rncptr->OtherQRnumbers, LKEY(qrbuf->QRnumber), QRnumber, NULL);
+                                   use_this_rncptr->roomlist_parts++;
+                           }
+                           citthread_mutex_unlock(&RSSQueueMutex);
+                           continue;
                    }
+                   citthread_mutex_unlock(&RSSQueueMutex);
 
                    rncptr->ItemType = RSS_UNSET;
                                
@@ -571,6 +644,8 @@ void rssclient_scan_room(struct ctdlroom *qrbuf, void *data)
        {
                Count->QRnumber = qrbuf->QRnumber;
                citthread_mutex_lock(&RSSQueueMutex);
+               CtdlLogPrintf(CTDL_DEBUG, "rssclient: [%ld] %s now starting.\n", 
+                             qrbuf->QRnumber, qrbuf->QRname);
                Put(RSSQueueRooms, LKEY(qrbuf->QRnumber), Count, NULL);
                citthread_mutex_unlock(&RSSQueueMutex);
        }
@@ -584,7 +659,7 @@ void rssclient_scan_room(struct ctdlroom *qrbuf, void *data)
  */
 void rssclient_scan(void) {
        static int doing_rssclient = 0;
-       rssnetcfg *rptr = NULL;
+       rss_aggregator *rptr = NULL;
        void *vrptr = NULL;
        HashPos  *it;
        long len;
@@ -607,8 +682,10 @@ void rssclient_scan(void) {
        it = GetNewHashPos(RSSQueueRooms, 0);
        while (GetNextHashPos(RSSFetchUrls, it, &len, &Key, &vrptr) && 
               (vrptr != NULL)) {
-               rptr = (rssnetcfg *)vrptr;
-               if (!rptr->Attached) rss_do_fetching(rptr);
+               rptr = (rss_aggregator *)vrptr;
+               if (rptr->RefCount == 0) 
+                       if (!rss_do_fetching(rptr))
+                               UnlinkAggregator(rptr);
        }
        DeleteHashPos(&it);
        citthread_mutex_unlock(&RSSQueueMutex);
@@ -618,7 +695,7 @@ void rssclient_scan(void) {
        return;
 }
 
-void RSSCleanup(void)
+void rss_cleanup(void)
 {
        citthread_mutex_destroy(&RSSQueueMutex);
        DeleteHash(&RSSFetchUrls);
@@ -631,10 +708,11 @@ CTDL_MODULE_INIT(rssclient)
        if (threading)
        {
                citthread_mutex_init(&RSSQueueMutex, NULL);
-               RSSQueueRooms = NewHash(1, Flathash);
+               RSSQueueRooms = NewHash(1, lFlathash);
                RSSFetchUrls = NewHash(1, NULL);
                CtdlLogPrintf(CTDL_INFO, "%s\n", curl_version());
                CtdlRegisterSessionHook(rssclient_scan, EVT_TIMER);
+                CtdlRegisterCleanupHook(rss_cleanup);
        }
        return "rssclient";
 }