#include <errno.h>
#include <sys/types.h>
#include <sys/stat.h>
+#include <libcitadel.h>
#include "citadel.h"
#include "server.h"
#include "citserver.h"
#include "support.h"
#include "config.h"
-#include "tools.h"
#include "room_ops.h"
#include "ctdl_module.h"
#include "clientsocket.h"
char *link;
char *description;
time_t pubdate;
+ char channel_title[256];
+ int item_tag_nesting;
};
struct rssnetcfg *rnclist = NULL;
else {
/* Item has not been seen, so save it. */
+ if (ri->description == NULL) ri->description = strdup("");
for (i=strlen(ri->description); i>=0; --i) {
if (isspace(ri->description[i])) {
ri->description[i] = ' ';
msg->cm_fields['U'] = strdup(ri->title);
msg->cm_fields['T'] = malloc(64);
snprintf(msg->cm_fields['T'], 64, "%ld", ri->pubdate);
+ if (!IsEmptyStr(ri->channel_title)) {
+ msg->cm_fields['O'] = strdup(ri->channel_title);
+ }
msglen = 1024 + strlen(ri->link) + strlen(ri->description) ;
msg->cm_fields['M'] = malloc(msglen);
CtdlSubmitMsg(msg, recp, NULL);
CtdlFreeMessage(msg);
- free_recipients(recp);
/* write the uidl to the use table so we don't store this item again */
strcpy(ut.ut_msgid, utmsgid);
ut.ut_timestamp = time(NULL);
cdb_store(CDB_USETABLE, utmsgid, strlen(utmsgid), &ut, sizeof(struct UseTable) );
}
+ free_recipients(recp);
}
-void rss_xml_start(void *data, const char *el, const char **attr) {
+void rss_xml_start(void *data, const char *supplied_el, const char **attr) {
struct rss_item *ri = (struct rss_item *) data;
+ char el[256];
+ char *sep = NULL;
+
+ /* Axe the namespace, we don't care about it */
+ safestrncpy(el, supplied_el, sizeof el);
+ while (sep = strchr(el, ':'), sep) {
+ strcpy(el, ++sep);
+ }
if (!strcasecmp(el, "item")) {
+ ++ri->item_tag_nesting;
/* Initialize the feed item data structure */
if (ri->guid != NULL) free(ri->guid);
char el[256];
char *sep = NULL;
-
/* Axe the namespace, we don't care about it */
-
safestrncpy(el, supplied_el, sizeof el);
while (sep = strchr(el, ':'), sep) {
strcpy(el, ++sep);
}
- if (!strcasecmp(el, "guid")) {
+ if ( (!strcasecmp(el, "title")) && (ri->item_tag_nesting == 0) && (ri->chardata != NULL) ) {
+ safestrncpy(ri->channel_title, ri->chardata, sizeof ri->channel_title);
+ striplt(ri->channel_title);
+ }
+
+ if ( (!strcasecmp(el, "guid")) && (ri->chardata != NULL) ) {
if (ri->guid != NULL) free(ri->guid);
striplt(ri->chardata);
ri->guid = strdup(ri->chardata);
}
- if (!strcasecmp(el, "title")) {
+ if ( (!strcasecmp(el, "title")) && (ri->chardata != NULL) ) {
if (ri->title != NULL) free(ri->title);
striplt(ri->chardata);
ri->title = strdup(ri->chardata);
}
- if (!strcasecmp(el, "link")) {
+ if ( (!strcasecmp(el, "link")) && (ri->chardata != NULL) ) {
if (ri->link != NULL) free(ri->link);
striplt(ri->chardata);
ri->link = strdup(ri->chardata);
}
- if (!strcasecmp(el, "description")) {
+ if ( (!strcasecmp(el, "description")) && (ri->chardata != NULL) ) {
if (ri->description != NULL) free(ri->description);
ri->description = strdup(ri->chardata);
}
- if ( (!strcasecmp(el, "pubdate")) || (!strcasecmp(el, "date")) ) {
+ if ( ((!strcasecmp(el, "pubdate")) || (!strcasecmp(el, "date"))) && (ri->chardata != NULL) ) {
striplt(ri->chardata);
ri->pubdate = rdf_parsedate(ri->chardata);
}
if (!strcasecmp(el, "item")) {
+ --ri->item_tag_nesting;
rss_save_item(ri);
}
if ( (!strcasecmp(el, "rss")) || (!strcasecmp(el, "rdf")) ) {
- lprintf(CTDL_DEBUG, "KILL THE PARSER, KILL THE PARSER, KILL THE PARSER!\n");
+ lprintf(CTDL_DEBUG, "End of feed detected. Closing parser.\n");
ri->done_parsing = 1;
}
/*
- * Parses an url into hostname, port number and resource identifier.
+ * Parse a URL into host, port number, and resource identifier.
*/
int parse_url(char *url, char *hostname, int *port, char *identifier)
{
- char protocol[1024], scratch[1024];
+ char protocol[1024];
+ char scratch[1024];
char *ptr = NULL;
char *nptr = NULL;
if (!ptr) {
return(1); /* no protocol specified */
}
+
strcpy(ptr, "");
strcpy(protocol, scratch);
if (strcmp(protocol, "http")) {
}
-
-
-
-
/*
* Begin a feed parse
*/
XML_Parser xp;
int sock = (-1);
int got_bytes = (-1);
+ int redirect_count = 0;
+ /* Parse the URL */
+ if (parse_url(url, rsshost, &rssport, rssurl) != 0) {
+ lprintf(CTDL_ALERT, "Invalid URL: %s\n", url);
+ }
xp = XML_ParserCreateNS("UTF-8", ':');
if (!xp) {
XML_SetCharacterDataHandler(xp, rss_xml_chardata);
XML_SetUserData(xp, &ri);
- /* Parse the URL */
-
-retry: sock = (-1);
- if (parse_url(url, rsshost, &rssport, rssurl) != 0) {
- lprintf(CTDL_ALERT, "Invalid URL: %s\n", url);
- }
- else {
- lprintf(CTDL_NOTICE, "Connecting to <%s>\n", rsshost);
- sprintf(buf, "%d", rssport);
- sock = sock_connect(rsshost, buf, "tcp");
- }
-
+retry: lprintf(CTDL_NOTICE, "Connecting to <%s>\n", rsshost);
+ sprintf(buf, "%d", rssport);
+ sock = sock_connect(rsshost, buf, "tcp");
if (sock >= 0) {
lprintf(CTDL_DEBUG, "Connected!\n");
- snprintf(buf, sizeof buf, "GET %s HTTP/1.0\r", rssurl);
+ snprintf(buf, sizeof buf, "GET %s HTTP/1.0", rssurl);
lprintf(CTDL_DEBUG, "<%s\n", buf);
sock_puts(sock, buf);
- snprintf(buf, sizeof buf, "Server: %s\r", rsshost);
+ snprintf(buf, sizeof buf, "Host: %s", rsshost);
lprintf(CTDL_DEBUG, "<%s\n", buf);
sock_puts(sock, buf);
- sock_puts(sock, "\r");
+ snprintf(buf, sizeof buf, "User-Agent: %s", CITADEL);
+ lprintf(CTDL_DEBUG, "<%s\n", buf);
+ sock_puts(sock, buf);
+
+ snprintf(buf, sizeof buf, "Accept: */*");
+ lprintf(CTDL_DEBUG, "<%s\n", buf);
+ sock_puts(sock, buf);
+
+ sock_puts(sock, "");
if (sock_getln(sock, buf, sizeof buf) >= 0) {
lprintf(CTDL_DEBUG, ">%s\n", buf);
remove_token(buf, 0, ' ');
+
+ /* 200 OK */
if (buf[0] == '2') {
while (got_bytes = sock_getln(sock, buf, sizeof buf),
(got_bytes >= 0 && (strcmp(buf, "")) && (strcmp(buf, "\r"))) ) {
- /* FIXME handle 302 redirects!! */
+ /* discard headers */
}
-
while (got_bytes = sock_read(sock, buf, sizeof buf, 0),
((got_bytes>=0) && (ri.done_parsing == 0)) ) {
XML_Parse(xp, buf, got_bytes, 0);
}
if (ri.done_parsing == 0) XML_Parse(xp, "", 0, 1);
}
+
+ /* 30X redirect */
+ else if ( (!strncmp(buf, "30", 2)) && (redirect_count < 16) ) {
+ while (got_bytes = sock_getln(sock, buf, sizeof buf),
+ (got_bytes >= 0 && (strcmp(buf, "")) && (strcmp(buf, "\r"))) ) {
+ if (!strncasecmp(buf, "Location:", 9)) {
+ ++redirect_count;
+ strcpy(buf, &buf[9]);
+ striplt(buf);
+ if (parse_url(buf, rsshost, &rssport, rssurl) == 0) {
+ goto retry;
+ }
+ else {
+ lprintf(CTDL_ALERT, "Invalid URL: %s\n", buf);
+ }
+ }
+ }
+ }
+
}
sock_close(sock);
}
extract_token(instr, buf, 0, '|', sizeof instr);
if (!strcasecmp(instr, "rssclient")) {
+
+ use_this_rncptr = NULL;
+
extract_token(feedurl, buf, 1, '|', sizeof feedurl);
/* If any other rooms have requested the same feed, then we will just add this
/*
* Scan for rooms that have RSS client requests configured
*/
-void rssclient_scan(void) {
+void *rssclient_scan(void *args) {
static time_t last_run = 0L;
static int doing_rssclient = 0;
struct rssnetcfg *rptr = NULL;
+ CtdlThreadAllocTSD();
/*
* Run RSS client no more frequently than once every n seconds
*/
- if ( (time(NULL) - last_run) < config.c_net_freq ) {
- return;
- }
+// if ( (time(NULL) - last_run) < config.c_net_freq ) {
+// return;
+// }
/*
* This is a simple concurrency check to make sure only one rssclient run
* don't really require extremely fine granularity here, we'll do it
* with a static variable instead.
*/
- if (doing_rssclient) return;
+ if (doing_rssclient) return NULL;
doing_rssclient = 1;
lprintf(CTDL_DEBUG, "rssclient started\n");
lprintf(CTDL_DEBUG, "rssclient ended\n");
last_run = time(NULL);
doing_rssclient = 0;
+ CtdlThreadSchedule ("RSS Client", CTDLTHREAD_BIGSTACK, rssclient_scan, NULL, last_run + config.c_net_freq);
+ return NULL;
}
CTDL_MODULE_INIT(rssclient)
{
+ if (threading)
+ {
#ifdef HAVE_EXPAT
- CtdlRegisterSessionHook(rssclient_scan, EVT_TIMER);
+// CtdlRegisterSessionHook(rssclient_scan, EVT_TIMER);
+ CtdlThreadSchedule ("RSS Client", CTDLTHREAD_BIGSTACK, rssclient_scan, NULL, 0);
#else
- lprintf(CTDL_INFO, "This server is missing the Expat XML parser. RSS client will be disabled.\n");
+ lprintf(CTDL_INFO, "This server is missing the Expat XML parser. RSS client will be disabled.\n");
#endif
+ }
+
/* return our Subversion id for the Log */
return "$Id: serv_rssclient.c 5652 2007-10-29 20:14:48Z ajc $";
}