]> code.citadel.org Git - citadel.git/blobdiff - citadel/msgbase.c
* When submitting a message, harvest non-local addresses for potential
[citadel.git] / citadel / msgbase.c
index 941af80b4701ee72df29d73e42543e9cabf94feb..59c11abb8c330744587c22165d632f4b668c9910 100644 (file)
@@ -97,7 +97,7 @@ char *msgkeys[] = {
        NULL,
        NULL,
        NULL,
-       NULL,
+       "cccc",
        NULL
 };
 
@@ -174,7 +174,7 @@ int alias(char *name)
        fclose(fp);
 
        /* Hit the Global Address Book */
-       if (CtdlDirectoryLookup(aaa, name) == 0) {
+       if (CtdlDirectoryLookup(aaa, name, sizeof aaa) == 0) {
                strcpy(name, aaa);
        }
 
@@ -1429,6 +1429,9 @@ int CtdlOutputPreLoadedMsg(
                                        safestrncpy(luser, mptr, sizeof luser);
                                        safestrncpy(suser, mptr, sizeof suser);
                                }
+                               else if (i == 'Y') {
+                                       cprintf("CC: %s%s", mptr, nl);
+                               }
                                else if (i == 'U') {
                                        cprintf("Subject: %s%s", mptr, nl);
                                        subject_found = 1;
@@ -1476,19 +1479,15 @@ int CtdlOutputPreLoadedMsg(
                cprintf(">%s", nl);
 
                if (!is_room_aide() && (TheMessage->cm_anon_type == MES_ANONONLY)) {
-                       // cprintf("From: x@x.org (----)%s", nl);
                        cprintf("From: \"----\" <x@x.org>%s", nl);
                }
                else if (!is_room_aide() && (TheMessage->cm_anon_type == MES_ANONOPT)) {
-                       // cprintf("From: x@x.org (anonymous)%s", nl);
                        cprintf("From: \"anonymous\" <x@x.org>%s", nl);
                }
                else if (strlen(fuser) > 0) {
-                       // cprintf("From: %s (%s)%s", fuser, luser, nl);
                        cprintf("From: \"%s\" <%s>%s", luser, fuser, nl);
                }
                else {
-                       // cprintf("From: %s@%s (%s)%s", suser, snode, luser, nl);
                        cprintf("From: \"%s\" <%s@%s>%s", luser, suser, snode, nl);
                }
 
@@ -2030,7 +2029,6 @@ int ReplicationChecks(struct CtdlMessage *msg) {
 
 
 
-
 /*
  * Save a message to disk and submit it into the delivery system.
  */
@@ -2056,6 +2054,7 @@ long CtdlSubmitMsg(struct CtdlMessage *msg,       /* message to save */
        char *instr;
        struct ser_ret smr;
        char *hold_R, *hold_D;
+       char *collected_addresses = NULL;
 
        lprintf(CTDL_DEBUG, "CtdlSubmitMsg() called\n");
        if (is_valid_message(msg) == 0) return(-1);     /* self check */
@@ -2109,8 +2108,7 @@ long CtdlSubmitMsg(struct CtdlMessage *msg,       /* message to save */
                break;
        case 4:
                strcpy(content_type, "text/plain");
-               mptr = bmstrstr(msg->cm_fields['M'],
-                               "Content-type: ", strncasecmp);
+               mptr = bmstrcasestr(msg->cm_fields['M'], "Content-type: ");
                if (mptr != NULL) {
                        safestrncpy(content_type, &mptr[14], 
                                        sizeof content_type);
@@ -2358,11 +2356,25 @@ long CtdlSubmitMsg(struct CtdlMessage *msg,     /* message to save */
                CtdlFreeMessage(imsg);
        }
 
+       /*
+        * Any addresses to collect?  (FIXME do something with them!!)
+        */
+       collected_addresses = harvest_collected_addresses(msg);
+       if (collected_addresses != NULL) {
+               lprintf(CTDL_DEBUG, "FIXME collected addresses: %s\n", collected_addresses);
+               free(collected_addresses);
+       }
+
        return(newmsgid);
 }
 
 
 
+
+
+
+
+
 /*
  * Convenience function for generating small administrative messages.
  */
@@ -2492,6 +2504,7 @@ char *CtdlReadMessageBody(char *terminator,       /* token signalling EOT */
 struct CtdlMessage *CtdlMakeMessage(
        struct ctdluser *author,        /* author's user structure */
        char *recipient,                /* NULL if it's not mail */
+       char *recp_cc,                  /* NULL if it's not mail */
        char *room,                     /* room where it's going */
        int type,                       /* see MES_ types in header file */
        int format_type,                /* variformat, plain text, MIME... */
@@ -2513,6 +2526,7 @@ struct CtdlMessage *CtdlMakeMessage(
        strcpy(dest_node, "");
 
        striplt(recipient);
+       striplt(recp_cc);
 
        snprintf(buf, sizeof buf, "cit%ld", author->usernum);   /* Path */
        msg->cm_fields['P'] = strdup(buf);
@@ -2538,6 +2552,9 @@ struct CtdlMessage *CtdlMakeMessage(
        if (recipient[0] != 0) {
                msg->cm_fields['R'] = strdup(recipient);
        }
+       if (recp_cc[0] != 0) {
+               msg->cm_fields['Y'] = strdup(recp_cc);
+       }
        if (dest_node[0] != 0) {
                msg->cm_fields['D'] = strdup(dest_node);
        }
@@ -2624,10 +2641,11 @@ int CtdlCheckInternetMailPermission(struct ctdluser *who) {
 }
 
 
-
 /*
  * Validate recipients, count delivery types and errors, and handle aliasing
  * FIXME check for dupes!!!!!
+ * Returns 0 if all addresses are ok, -1 if no addresses were specified,
+ * or the number of addresses found invalid.
  */
 struct recptypes *validate_recipients(char *recipients) {
        struct recptypes *ret;
@@ -2786,7 +2804,7 @@ struct recptypes *validate_recipients(char *recipients) {
 
        if ((ret->num_local + ret->num_internet + ret->num_ignet +
           ret->num_room + ret->num_error) == 0) {
-               ++ret->num_error;
+               ret->num_error = (-1);
                strcpy(ret->errormsg, "No recipients specified.");
        }
 
@@ -2809,6 +2827,8 @@ void cmd_ent0(char *entargs)
 {
        int post = 0;
        char recp[SIZ];
+       char cc[SIZ];
+       char bcc[SIZ];
        char masquerade_as[SIZ];
        int anon_flag = 0;
        int format_type = 0;
@@ -2818,6 +2838,9 @@ void cmd_ent0(char *entargs)
        char errmsg[SIZ];
        int err = 0;
        struct recptypes *valid = NULL;
+       struct recptypes *valid_to = NULL;
+       struct recptypes *valid_cc = NULL;
+       struct recptypes *valid_bcc = NULL;
        char subject[SIZ];
        int do_confirm = 0;
        long msgnum;
@@ -2830,6 +2853,8 @@ void cmd_ent0(char *entargs)
        format_type = extract_int(entargs, 3);
        extract_token(subject, entargs, 4, '|', sizeof subject);
        do_confirm = extract_int(entargs, 6);
+       extract_token(cc, entargs, 7, '|', sizeof cc);
+       extract_token(bcc, entargs, 8, '|', sizeof bcc);
 
        /* first check to make sure the request is valid. */
 
@@ -2865,39 +2890,74 @@ void cmd_ent0(char *entargs)
 
                if (CC->user.axlevel < 2) {
                        strcpy(recp, "sysop");
+                       strcpy(cc, "");
+                       strcpy(bcc, "");
+               }
+
+               valid_to = validate_recipients(recp);
+               if (valid_to->num_error > 0) {
+                       cprintf("%d Invalid recipient (To)\n", ERROR + NO_SUCH_USER);
+                       free(valid_to);
+                       return;
+               }
+
+               valid_cc = validate_recipients(cc);
+               if (valid_cc->num_error > 0) {
+                       cprintf("%d Invalid recipient (CC)\n", ERROR + NO_SUCH_USER);
+                       free(valid_to);
+                       free(valid_cc);
+                       return;
                }
 
-               valid = validate_recipients(recp);
-               if (valid->num_error > 0) {
-                       cprintf("%d %s\n",
-                               ERROR + NO_SUCH_USER, valid->errormsg);
-                       free(valid);
+               valid_bcc = validate_recipients(bcc);
+               if (valid_bcc->num_error > 0) {
+                       cprintf("%d Invalid recipient (BCC)\n", ERROR + NO_SUCH_USER);
+                       free(valid_to);
+                       free(valid_cc);
+                       free(valid_bcc);
                        return;
                }
-               if (valid->num_internet > 0) {
+
+               /* Recipient required, but none were specified */
+               if ( (valid_to->num_error < 0) && (valid_cc->num_error < 0) && (valid_bcc->num_error < 0) ) {
+                       free(valid_to);
+                       free(valid_cc);
+                       free(valid_bcc);
+                       cprintf("%d At least one recipient is required.\n", ERROR + NO_SUCH_USER);
+                       return;
+               }
+
+               if (valid_to->num_internet + valid_cc->num_internet + valid_bcc->num_internet > 0) {
                        if (CtdlCheckInternetMailPermission(&CC->user)==0) {
                                cprintf("%d You do not have permission "
                                        "to send Internet mail.\n",
                                        ERROR + HIGHER_ACCESS_REQUIRED);
-                               free(valid);
+                               free(valid_to);
+                               free(valid_cc);
+                               free(valid_bcc);
                                return;
                        }
                }
 
-               if ( ( (valid->num_internet + valid->num_ignet) > 0)
+               if ( ( (valid_to->num_internet + valid_to->num_ignet + valid_cc->num_internet + valid_cc->num_ignet + valid_bcc->num_internet + valid_bcc->num_ignet) > 0)
                   && (CC->user.axlevel < 4) ) {
                        cprintf("%d Higher access required for network mail.\n",
                                ERROR + HIGHER_ACCESS_REQUIRED);
-                       free(valid);
+                       free(valid_to);
+                       free(valid_cc);
+                       free(valid_bcc);
                        return;
                }
        
-               if ((RESTRICT_INTERNET == 1) && (valid->num_internet > 0)
+               if ((RESTRICT_INTERNET == 1)
+                   && (valid_to->num_internet + valid_cc->num_internet + valid_bcc->num_internet > 0)
                    && ((CC->user.flags & US_INTERNET) == 0)
                    && (!CC->internal_pgm)) {
                        cprintf("%d You don't have access to Internet mail.\n",
                                ERROR + HIGHER_ACCESS_REQUIRED);
-                       free(valid);
+                       free(valid_to);
+                       free(valid_cc);
+                       free(valid_bcc);
                        return;
                }
 
@@ -2923,11 +2983,18 @@ void cmd_ent0(char *entargs)
         */
        if (post == 0) {
                cprintf("%d %s\n", CIT_OK,
-                       ((valid != NULL) ? valid->display_recp : "") );
-               free(valid);
+                       ((valid_to != NULL) ? valid_to->display_recp : "") );
+               free(valid_to);
+               free(valid_cc);
+               free(valid_bcc);
                return;
        }
 
+       /* We don't need these anymore because we'll do it differently below */
+       free(valid_to);
+       free(valid_cc);
+       free(valid_bcc);
+
        /* Handle author masquerading */
        if (CC->fake_postname[0]) {
                strcpy(masquerade_as, CC->fake_postname);
@@ -2945,10 +3012,36 @@ void cmd_ent0(char *entargs)
        } else {
                cprintf("%d send message\n", SEND_LISTING);
        }
-       msg = CtdlMakeMessage(&CC->user, recp,
+
+       msg = CtdlMakeMessage(&CC->user, recp, cc,
                CC->room.QRname, anonymous, format_type,
                masquerade_as, subject, NULL);
 
+       /* Put together one big recipients struct containing to/cc/bcc all in
+        * one.  This is for the envelope.
+        */
+       char *all_recps = malloc(SIZ * 3);
+       strcpy(all_recps, recp);
+       if (strlen(cc) > 0) {
+               if (strlen(all_recps) > 0) {
+                       strcat(all_recps, ",");
+               }
+               strcat(all_recps, cc);
+       }
+       if (strlen(bcc) > 0) {
+               if (strlen(all_recps) > 0) {
+                       strcat(all_recps, ",");
+               }
+               strcat(all_recps, bcc);
+       }
+       if (strlen(all_recps) > 0) {
+               valid = validate_recipients(all_recps);
+       }
+       else {
+               valid = NULL;
+       }
+       free(all_recps);
+
        if (msg != NULL) {
                msgnum = CtdlSubmitMsg(msg, valid, "");
 
@@ -2971,7 +3064,9 @@ void cmd_ent0(char *entargs)
                CtdlFreeMessage(msg);
        }
        CC->fake_postname[0] = '\0';
-       free(valid);
+       if (valid != NULL) {
+               free(valid);
+       }
        return;
 }